April 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: e1d: clean up error logging in handle_ts_sign_read
by pespin 17 Apr '23

17 Apr '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32337 ) Change subject: e1d: clean up error logging in handle_ts_sign_read ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ife3bb07fb4180dbd73d0efdc5acade8b20e8a5da Gerrit-Change-Number: 32337 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Apr 2023 12:30:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-e1d[master]: proto_clnt: fix function prototype
by pespin 17 Apr '23

17 Apr '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/32335 ) Change subject: proto_clnt: fix function prototype ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/32335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I8bd4fbdf2bda332870da1b915a7898c396a85b0f Gerrit-Change-Number: 32335 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Apr 2023 12:30:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: Fix DL_TBF PACCH ass done on UL_TBF already scheduled to tx last PKT ...
by pespin 17 Apr '23

17 Apr '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32339 ) Change subject: Fix DL_TBF PACCH ass done on UL_TBF already scheduled to tx last PKT CTRL ACK ...................................................................... Fix DL_TBF PACCH ass done on UL_TBF already scheduled to tx last PKT CTRL ACK Change-Id: I62ae91b494e4fd0ade3f4a3ba3817bcaedbdebf5 --- M src/tbf_ul_ack_fsm.c M tests/tbf/TbfTest.err 2 files changed, 34 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/39/32339/1 diff --git a/src/tbf_ul_ack_fsm.c b/src/tbf_ul_ack_fsm.c index 5e5586b..76a1cad 100644 --- a/src/tbf_ul_ack_fsm.c +++ b/src/tbf_ul_ack_fsm.c @@ -65,7 +65,6 @@ unsigned int rrbp = 0; uint32_t new_poll_fn = 0; struct gprs_rlcmac_ul_tbf *tbf = ctx->tbf; - struct GprsMs *ms = tbf_ms(ul_tbf_as_tbf(tbf)); if (final) { rc = tbf_check_polling(ul_tbf_as_tbf(tbf), d->pdch, d->fn, &new_poll_fn, &rrbp); @@ -86,21 +85,6 @@ bitvec_pack(ack_vec, msgb_put(msg, 23)); bitvec_free(ack_vec); - /* TS 44.060 7a.2.1.1: "The contention resolution is completed on - * the network side when the network receives an RLC data block that - * comprises the TLLI value that identifies the mobile station and the - * TFI value associated with the TBF." (see TBF_EV_FIRST_UL_DATA_RECVD). - * - * However, it's handier for us to mark contention resolution success here - * since upon rx UL ACK is the time at which MS realizes contention resolution - * succeeds: - * TS 44.060 7.1.2.3: "The contention resolution is successfully completed - * on the mobile station side when the mobile station receives a - * PACKET UPLINK ACK/NACK" - */ - if (ms_tlli(ms) != GSM_RESERVED_TMSI && !ul_tbf_contention_resolution_done(ctx->tbf)) - osmo_fsm_inst_dispatch(tbf_state_fi(ul_tbf_as_tbf(ctx->tbf)), TBF_EV_CONTENTION_RESOLUTION_MS_SUCCESS, NULL); - if (final) { tbf_set_polling(ul_tbf_as_tbf(tbf), d->pdch, new_poll_fn, PDCH_ULC_POLL_UL_ACK); LOGPTBFUL(tbf, LOGL_DEBUG, @@ -126,6 +110,7 @@ { struct tbf_ul_ack_fsm_ctx *ctx = (struct tbf_ul_ack_fsm_ctx *)fi->priv; struct gprs_rlcmac_ul_tbf *tbf = ctx->tbf; + struct GprsMs *ms = tbf_ms(ul_tbf_as_tbf(tbf)); struct tbf_ul_ack_ev_create_rlcmac_msg_ctx *data_ctx; bool final; @@ -144,6 +129,28 @@ tbf_ul_ack_fsm_state_chg(fi, TBF_UL_ACK_ST_WAIT_ACK); else tbf_ul_ack_fsm_state_chg(fi, TBF_UL_ACK_ST_NONE); + + /* TS 44.060 7a.2.1.1: "The contention resolution is completed on + * the network side when the network receives an RLC data block that + * comprises the TLLI value that identifies the mobile station and the + * TFI value associated with the TBF." (see TBF_EV_FIRST_UL_DATA_RECVD). + * + * However, it's handier for us to mark contention resolution success here + * since upon rx UL ACK is the time at which MS realizes contention resolution + * succeeds: + * TS 44.060 7.1.2.3: "The contention resolution is successfully completed + * on the mobile station side when the mobile station receives a + * PACKET UPLINK ACK/NACK" + * + * This event must be triggered here *after* potentially transitioning + * to ST_WAIT_ACK above, so that gprs_ms knows whether it can create a + * DL TBF on PACCH of the UL_TBF or not (not possible if we are in + * ST_WAIT_ACK, since UL TBF is terminating sending the final PKT CTRL + * ACK). + */ + if (ms_tlli(ms) != GSM_RESERVED_TMSI && !ul_tbf_contention_resolution_done(ctx->tbf)) + osmo_fsm_inst_dispatch(tbf_state_fi(ul_tbf_as_tbf(ctx->tbf)), TBF_EV_CONTENTION_RESOLUTION_MS_SUCCESS, NULL); + break; default: OSMO_ASSERT(0); diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 2598cdf..9410fd4 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -1921,11 +1921,11 @@ Got MS: TLLI = 0xf1223344, TA = 7 UL_ACK_TBF(UL:TFI-0-0-0:STATE-NEW:GPRS){SCHED_UL_ACK}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654167 + 17 = 2654184 -UL_TBF(UL:TFI-0-0-0:STATE-NEW:GPRS){FINISHED}: Received Event CONTENTION_RESOLUTION_MS_SUCCESS -TBF(UL:TFI-0-0-0:STATE-FINISHED:GPRS:TLLI-0xf1223344) stopping timer T3141 [Contention resolution success (UL-TBF, CCCH)] PDCH(bts=0,trx=0,ts=7) Reserving FN 2654184 for type POLL TBF(UL:TFI-0-0-0:STATE-FINISHED:GPRS:TLLI-0xf1223344) Scheduled UL Acknowledgement polling on PACCH (FN=2654184, TS=7) UL_ACK_TBF(UL:TFI-0-0-0:STATE-NEW:GPRS){SCHED_UL_ACK}: state_chg to WAIT_ACK +UL_TBF(UL:TFI-0-0-0:STATE-NEW:GPRS){FINISHED}: Received Event CONTENTION_RESOLUTION_MS_SUCCESS +TBF(UL:TFI-0-0-0:STATE-FINISHED:GPRS:TLLI-0xf1223344) stopping timer T3141 [Contention resolution success (UL-TBF, CCCH)] PDCH(bts=0,trx=0,ts=7) FN=2654167 Scheduling control message at RTS for TBF(UL:TFI-0-0-0:STATE-FINISHED:GPRS:TLLI-0xf1223344) Modifying MS object, TLLI = 0xf1223344, IMSI '' -> '0011223344' Modifying MS object, TLLI: 0xf1223344 confirmed -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I62ae91b494e4fd0ade3f4a3ba3817bcaedbdebf5 Gerrit-Change-Number: 32339 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in osmo-pcu[master]: ms: Drop setting tlli during ms_alloc()
by pespin 17 Apr '23

17 Apr '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32340 ) Change subject: ms: Drop setting tlli during ms_alloc() ...................................................................... ms: Drop setting tlli during ms_alloc() Inside osmo-pcu code, the code path is to always call ms_alloc with tlli=GSM_RESERVED_TMSI; a different value is only passed during unit tests. It makes no sense to have unit tests using differnet code paths than ther app itself, since in the app it always desired to go through the ms_set_tlli() and ms_confirm_tlli() which does more stuff. Hence, drop the tlli param in ms_alloc and change the unit tests to use the available APIs used by the application. Change-Id: I730ec911a43b0f4e78faee4eeffb3ca8601564f8 --- M src/gprs_ms.c M src/gprs_ms.h M src/gprs_ms_storage.cpp M tests/app_info/AppInfoTest.err M tests/ms/MsTest.cpp M tests/ms/MsTest.err M tests/tbf/TbfTest.err M tests/ulc/PdchUlcTest.cpp M tests/ulc/PdchUlcTest.err 9 files changed, 161 insertions(+), 129 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/40/32340/1 diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 7ecaae4..0a9d026 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -104,7 +104,7 @@ } static int ms_talloc_destructor(struct GprsMs *ms); -struct GprsMs *ms_alloc(struct gprs_rlcmac_bts *bts, uint32_t tlli) +struct GprsMs *ms_alloc(struct gprs_rlcmac_bts *bts) { struct GprsMs *ms = talloc_zero(tall_pcu_ctx, struct GprsMs); OSMO_ASSERT(bts); @@ -113,7 +113,7 @@ ms->bts = bts; ms->cb = gprs_default_cb; - ms->tlli = tlli; + ms->tlli = GSM_RESERVED_TMSI; ms->new_ul_tlli = GSM_RESERVED_TMSI; ms->new_dl_tlli = GSM_RESERVED_TMSI; ms->ta = GSM48_TA_INVALID; @@ -125,7 +125,7 @@ int codel_interval = LLC_CODEL_USE_DEFAULT; - LOGP(DRLCMAC, LOGL_INFO, "Creating MS object, TLLI = 0x%08x\n", tlli); + LOGP(DRLCMAC, LOGL_INFO, "Creating MS object\n"); ms->imsi[0] = '\0'; osmo_timer_setup(&ms->timer, ms_release_timer_cb, NULL); diff --git a/src/gprs_ms.h b/src/gprs_ms.h index 9b957ac..d976235 100644 --- a/src/gprs_ms.h +++ b/src/gprs_ms.h @@ -101,7 +101,7 @@ struct nacc_fsm_ctx *nacc; }; -struct GprsMs *ms_alloc(struct gprs_rlcmac_bts *bts, uint32_t tlli); +struct GprsMs *ms_alloc(struct gprs_rlcmac_bts *bts); struct gprs_rlcmac_pdch *ms_first_common_ts(const struct GprsMs *ms); void ms_set_first_common_ts(struct GprsMs *ms, struct gprs_rlcmac_pdch *pdch); diff --git a/src/gprs_ms_storage.cpp b/src/gprs_ms_storage.cpp index e49474f..4741a2d 100644 --- a/src/gprs_ms_storage.cpp +++ b/src/gprs_ms_storage.cpp @@ -100,7 +100,7 @@ { GprsMs *ms; - ms = ms_alloc(m_bts, GSM_RESERVED_TMSI); + ms = ms_alloc(m_bts); ms_set_callback(ms, &ms_storage_ms_cb); llist_add(&ms->list, &m_list); diff --git a/tests/app_info/AppInfoTest.err b/tests/app_info/AppInfoTest.err index 3624250..5300b7b 100644 --- a/tests/app_info/AppInfoTest.err +++ b/tests/app_info/AppInfoTest.err @@ -14,7 +14,7 @@ PDCH(bts=0,trx=0,ts=5) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=6) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 10 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-10-11) Enabled EGPRS, mode EGPRS @@ -25,7 +25,7 @@ PDCH(bts=0,trx=0,ts=7) Attaching TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS), 1 TBFs, USFs = 00, TFIs = 00000001. MS(TA-220:MSCLS-10-11) Attaching DL TBF: TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS) ws(64) -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 12 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 13 MS(TA-220:MSCLS-12-13) Enabled EGPRS, mode EGPRS diff --git a/tests/ms/MsTest.cpp b/tests/ms/MsTest.cpp index 6a770c9..ec1672a 100644 --- a/tests/ms/MsTest.cpp +++ b/tests/ms/MsTest.cpp @@ -86,7 +86,8 @@ printf("=== start %s ===\n", __func__); - ms = ms_alloc(bts, tlli); + ms = ms_alloc(bts); + ms_set_tlli(ms, tlli); OSMO_ASSERT(ms_is_idle(ms)); dl_tbf = alloc_dl_tbf(bts, ms); @@ -148,7 +149,8 @@ printf("=== start %s ===\n", __func__); - ms = ms_alloc(bts, tlli); + ms = ms_alloc(bts); + ms_set_tlli(ms, tlli); ms_set_callback(ms, &ms_cb); OSMO_ASSERT(ms_is_idle(ms)); @@ -219,7 +221,8 @@ printf("=== start %s ===\n", __func__); - ms = ms_alloc(bts, tlli); + ms = ms_alloc(bts); + ms_confirm_tlli(ms, tlli); ms_set_callback(ms, &ms_replace_tbf_cb); OSMO_ASSERT(ms_is_idle(ms)); @@ -290,7 +293,7 @@ printf("=== start %s ===\n", __func__); - ms = ms_alloc(bts, start_tlli); + ms = ms_alloc(bts); OSMO_ASSERT(ms_is_idle(ms)); @@ -298,12 +301,10 @@ ms_set_tlli(ms, new_ms_tlli); OSMO_ASSERT(ms_tlli(ms) == new_ms_tlli); OSMO_ASSERT(ms_check_tlli(ms, new_ms_tlli)); - OSMO_ASSERT(ms_check_tlli(ms, start_tlli)); ms_confirm_tlli(ms, new_ms_tlli); OSMO_ASSERT(ms_tlli(ms) == new_ms_tlli); OSMO_ASSERT(ms_check_tlli(ms, new_ms_tlli)); - OSMO_ASSERT(!ms_check_tlli(ms, start_tlli)); /* MS announces TLLI, SGSN uses it later */ ms_set_tlli(ms, start_tlli); @@ -474,7 +475,8 @@ printf("=== start %s ===\n", __func__); - ms = ms_alloc(bts, tlli); + ms = ms_alloc(bts); + ms_set_tlli(ms, tlli); ms_set_callback(ms, &ms_cb); ms_set_timeout(ms, 1); @@ -532,7 +534,8 @@ the_pcu->vty.cs_downgrade_threshold = 0; the_pcu->vty.cs_adj_lower_limit = 0; - ms = ms_alloc(bts, tlli); + ms = ms_alloc(bts); + ms_confirm_tlli(ms, tlli); OSMO_ASSERT(ms_is_idle(ms)); @@ -571,14 +574,16 @@ printf("=== start %s ===\n", __func__); - ms1 = ms_alloc(bts, tlli); + ms1 = ms_alloc(bts); + ms_confirm_tlli(ms1, tlli); dump_ms(ms1, "1: no BTS defaults "); bts->initial_cs_dl = 4; bts->initial_cs_ul = 1; the_pcu->vty.cs_downgrade_threshold = 0; - ms2 = ms_alloc(bts, tlli + 1); + ms2 = ms_alloc(bts); + ms_confirm_tlli(ms2, tlli + 1); dump_ms(ms2, "2: with BTS defaults"); dl_tbf = alloc_dl_tbf(bts, ms2); diff --git a/tests/ms/MsTest.err b/tests/ms/MsTest.err index 7fdf284..218ae59 100644 --- a/tests/ms/MsTest.err +++ b/tests/ms/MsTest.err @@ -1,16 +1,19 @@ -Creating MS object, TLLI = 0xffeeddbb +Creating MS object +Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddbb, not yet confirmed MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Attaching UL TBF: TBF(UL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0:UL) Attaching DL TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0:DL) Detaching TBF: TBF(UL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Detaching TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Destroying MS object -Creating MS object, TLLI = 0xffeeddbb +Creating MS object +Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddbb, not yet confirmed MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Attaching UL TBF: TBF(UL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0:UL) Attaching DL TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0:DL) Detaching TBF: TBF(UL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Detaching TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Destroying MS object -Creating MS object, TLLI = 0xffeeddbb +Creating MS object +The MS object cannot fully confirm an unexpected TLLI: 0xffeeddbb, partly confirmed MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Attaching DL TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0:DL) Attaching DL TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0:DL) Attaching UL TBF: TBF(UL:STATE-NEW:GPRS:TLLI-0xffeeddbb) @@ -18,8 +21,8 @@ MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0:DL) Detaching TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Detaching TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Destroying MS object -Creating MS object, TLLI = 0xaa000000 -Modifying MS object, UL TLLI: 0xaa000000 -> 0xff001111, not yet confirmed +Creating MS object +Modifying MS object, UL TLLI: 0xffffffff -> 0xff001111, not yet confirmed Modifying MS object, TLLI: 0xff001111 confirmed Modifying MS object, UL TLLI: 0xff001111 -> 0xaa000000, not yet confirmed Modifying MS object, TLLI: 0xaa000000 confirmed @@ -35,10 +38,10 @@ The MS object cannot fully confirm an unexpected TLLI: 0xff001111, partly confirmed Modifying MS object, TLLI: 0xaa000000 -> 0xff001111, already confirmed partly MS(TLLI-0xff001111:TA-220:MSCLS-0-0) Destroying MS object -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddbb, not yet confirmed Modifying MS object, TLLI = 0xffeeddbb, IMSI '' -> '001001987654321' -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddbc, not yet confirmed Modifying MS object, TLLI = 0xffeeddbc, IMSI '' -> '001001987654322' MS(IMSI-001001987654321:TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Attaching UL TBF: TBF(UL:STATE-NEW:GPRS:IMSI-001001987654321:TLLI-0xffeeddbb) @@ -47,15 +50,19 @@ MS(IMSI-001001987654322:TLLI-0xffeeddbc:TA-220:MSCLS-0-0) Attaching UL TBF: TBF(UL:STATE-NEW:GPRS) MS(IMSI-001001987654322:TLLI-0xffeeddbc:TA-220:MSCLS-0-0) Detaching TBF: TBF(UL:STATE-NEW:GPRS) MS(IMSI-001001987654322:TLLI-0xffeeddbc:TA-220:MSCLS-0-0) Destroying MS object -Creating MS object, TLLI = 0xffeeddbb +Creating MS object +Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddbb, not yet confirmed MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Attaching UL TBF: TBF(UL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0:UL) Attaching DL TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0:DL) Detaching TBF: TBF(UL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Detaching TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Release timer expired MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Destroying MS object -Creating MS object, TLLI = 0xffeeddbb +Creating MS object +The MS object cannot fully confirm an unexpected TLLI: 0xffeeddbb, partly confirmed MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Attaching DL TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) -Creating MS object, TLLI = 0xdeadbeef -Creating MS object, TLLI = 0xdeadbef0 +Creating MS object +The MS object cannot fully confirm an unexpected TLLI: 0xdeadbeef, partly confirmed +Creating MS object +The MS object cannot fully confirm an unexpected TLLI: 0xdeadbef0, partly confirmed MS(TLLI-0xdeadbef0:TA-220:MSCLS-0-0) Attaching DL TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xdeadbef0) diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 9410fd4..46e777a 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -3,7 +3,7 @@ === start test_tbf_tlli_update === PDCH(bts=0,trx=0,ts=2) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=3) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** DL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating DL TBF UL_ASS_TBF{NONE}: Allocated @@ -53,7 +53,7 @@ MS(TLLI-0x00004232:TA-6:MSCLS-0-0) Detaching TBF: TBF(DL:TFI-0-0-0:STATE-NEW:GPRS:TLLI-0x00004232) === start test_tbf_final_ack === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 MS(TA-220:MSCLS-45-0) ********** DL-TBF starts here ********** @@ -167,7 +167,7 @@ === end test_tbf_final_ack === === start test_tbf_final_ack === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 MS(TA-220:MSCLS-45-0) ********** DL-TBF starts here ********** @@ -281,7 +281,7 @@ === end test_tbf_final_ack === === start test_tbf_delayed_release === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 MS(TA-220:MSCLS-45-0) ********** DL-TBF starts here ********** @@ -552,7 +552,7 @@ === end test_tbf_delayed_release === === start test_tbf_imsi === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=0 MS(TA-220:MSCLS-45-0) ********** DL-TBF starts here ********** @@ -584,7 +584,7 @@ TBF(DL:TFI-0-0-0:STATE-ASSIGN:GPRS) unset ass. type CCCH [prev CCCH:1, PACCH:0] TBF(DL:TFI-0-0-0:STATE-ASSIGN:GPRS) set ass. type PACCH [prev CCCH:0, PACCH:0] DL_TBF(DL:TFI-0-0-0:STATE-NEW:GPRS){ASSIGN}: state_chg to FLOW -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Found first unallocated TRX=0 TFI=1 MS(TA-220:MSCLS-45-0) ********** DL-TBF starts here ********** @@ -643,7 +643,7 @@ === end test_tbf_imsi === === start test_tbf_exhaustion === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000000' The MS object cannot fully confirm an unexpected TLLI: 0xc0000000, partly confirmed @@ -673,7 +673,7 @@ DL_TBF(DL:TFI-0-0-0:STATE-NEW:GPRS:IMSI-001001000000000:TLLI-0xc0000000){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-0:STATE-ASSIGN:GPRS:IMSI-001001000000000:TLLI-0xc0000000) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000001' The MS object cannot fully confirm an unexpected TLLI: 0xc0000001, partly confirmed @@ -703,7 +703,7 @@ DL_TBF(DL:TFI-0-0-1:STATE-NEW:GPRS:IMSI-001001000000001:TLLI-0xc0000001){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-1:STATE-ASSIGN:GPRS:IMSI-001001000000001:TLLI-0xc0000001) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000002' The MS object cannot fully confirm an unexpected TLLI: 0xc0000002, partly confirmed @@ -733,7 +733,7 @@ DL_TBF(DL:TFI-0-0-2:STATE-NEW:GPRS:IMSI-001001000000002:TLLI-0xc0000002){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-2:STATE-ASSIGN:GPRS:IMSI-001001000000002:TLLI-0xc0000002) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000003' The MS object cannot fully confirm an unexpected TLLI: 0xc0000003, partly confirmed @@ -763,7 +763,7 @@ DL_TBF(DL:TFI-0-0-3:STATE-NEW:GPRS:IMSI-001001000000003:TLLI-0xc0000003){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-3:STATE-ASSIGN:GPRS:IMSI-001001000000003:TLLI-0xc0000003) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000004' The MS object cannot fully confirm an unexpected TLLI: 0xc0000004, partly confirmed @@ -793,7 +793,7 @@ DL_TBF(DL:TFI-0-0-4:STATE-NEW:GPRS:IMSI-001001000000004:TLLI-0xc0000004){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-4:STATE-ASSIGN:GPRS:IMSI-001001000000004:TLLI-0xc0000004) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000005' The MS object cannot fully confirm an unexpected TLLI: 0xc0000005, partly confirmed @@ -823,7 +823,7 @@ DL_TBF(DL:TFI-0-0-5:STATE-NEW:GPRS:IMSI-001001000000005:TLLI-0xc0000005){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-5:STATE-ASSIGN:GPRS:IMSI-001001000000005:TLLI-0xc0000005) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000006' The MS object cannot fully confirm an unexpected TLLI: 0xc0000006, partly confirmed @@ -853,7 +853,7 @@ DL_TBF(DL:TFI-0-0-6:STATE-NEW:GPRS:IMSI-001001000000006:TLLI-0xc0000006){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-6:STATE-ASSIGN:GPRS:IMSI-001001000000006:TLLI-0xc0000006) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000007' The MS object cannot fully confirm an unexpected TLLI: 0xc0000007, partly confirmed @@ -883,7 +883,7 @@ DL_TBF(DL:TFI-0-0-7:STATE-NEW:GPRS:IMSI-001001000000007:TLLI-0xc0000007){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-7:STATE-ASSIGN:GPRS:IMSI-001001000000007:TLLI-0xc0000007) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000008' The MS object cannot fully confirm an unexpected TLLI: 0xc0000008, partly confirmed @@ -913,7 +913,7 @@ DL_TBF(DL:TFI-0-0-8:STATE-NEW:GPRS:IMSI-001001000000008:TLLI-0xc0000008){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-8:STATE-ASSIGN:GPRS:IMSI-001001000000008:TLLI-0xc0000008) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000009' The MS object cannot fully confirm an unexpected TLLI: 0xc0000009, partly confirmed @@ -943,7 +943,7 @@ DL_TBF(DL:TFI-0-0-9:STATE-NEW:GPRS:IMSI-001001000000009:TLLI-0xc0000009){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-9:STATE-ASSIGN:GPRS:IMSI-001001000000009:TLLI-0xc0000009) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000010' The MS object cannot fully confirm an unexpected TLLI: 0xc000000a, partly confirmed @@ -973,7 +973,7 @@ DL_TBF(DL:TFI-0-0-10:STATE-NEW:GPRS:IMSI-001001000000010:TLLI-0xc000000a){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-10:STATE-ASSIGN:GPRS:IMSI-001001000000010:TLLI-0xc000000a) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000011' The MS object cannot fully confirm an unexpected TLLI: 0xc000000b, partly confirmed @@ -1003,7 +1003,7 @@ DL_TBF(DL:TFI-0-0-11:STATE-NEW:GPRS:IMSI-001001000000011:TLLI-0xc000000b){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-11:STATE-ASSIGN:GPRS:IMSI-001001000000011:TLLI-0xc000000b) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000012' The MS object cannot fully confirm an unexpected TLLI: 0xc000000c, partly confirmed @@ -1033,7 +1033,7 @@ DL_TBF(DL:TFI-0-0-12:STATE-NEW:GPRS:IMSI-001001000000012:TLLI-0xc000000c){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-12:STATE-ASSIGN:GPRS:IMSI-001001000000012:TLLI-0xc000000c) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000013' The MS object cannot fully confirm an unexpected TLLI: 0xc000000d, partly confirmed @@ -1063,7 +1063,7 @@ DL_TBF(DL:TFI-0-0-13:STATE-NEW:GPRS:IMSI-001001000000013:TLLI-0xc000000d){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-13:STATE-ASSIGN:GPRS:IMSI-001001000000013:TLLI-0xc000000d) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000014' The MS object cannot fully confirm an unexpected TLLI: 0xc000000e, partly confirmed @@ -1093,7 +1093,7 @@ DL_TBF(DL:TFI-0-0-14:STATE-NEW:GPRS:IMSI-001001000000014:TLLI-0xc000000e){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-14:STATE-ASSIGN:GPRS:IMSI-001001000000014:TLLI-0xc000000e) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000015' The MS object cannot fully confirm an unexpected TLLI: 0xc000000f, partly confirmed @@ -1123,7 +1123,7 @@ DL_TBF(DL:TFI-0-0-15:STATE-NEW:GPRS:IMSI-001001000000015:TLLI-0xc000000f){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-15:STATE-ASSIGN:GPRS:IMSI-001001000000015:TLLI-0xc000000f) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000016' The MS object cannot fully confirm an unexpected TLLI: 0xc0000010, partly confirmed @@ -1153,7 +1153,7 @@ DL_TBF(DL:TFI-0-0-16:STATE-NEW:GPRS:IMSI-001001000000016:TLLI-0xc0000010){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-16:STATE-ASSIGN:GPRS:IMSI-001001000000016:TLLI-0xc0000010) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000017' The MS object cannot fully confirm an unexpected TLLI: 0xc0000011, partly confirmed @@ -1183,7 +1183,7 @@ DL_TBF(DL:TFI-0-0-17:STATE-NEW:GPRS:IMSI-001001000000017:TLLI-0xc0000011){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-17:STATE-ASSIGN:GPRS:IMSI-001001000000017:TLLI-0xc0000011) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000018' The MS object cannot fully confirm an unexpected TLLI: 0xc0000012, partly confirmed @@ -1213,7 +1213,7 @@ DL_TBF(DL:TFI-0-0-18:STATE-NEW:GPRS:IMSI-001001000000018:TLLI-0xc0000012){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-18:STATE-ASSIGN:GPRS:IMSI-001001000000018:TLLI-0xc0000012) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000019' The MS object cannot fully confirm an unexpected TLLI: 0xc0000013, partly confirmed @@ -1243,7 +1243,7 @@ DL_TBF(DL:TFI-0-0-19:STATE-NEW:GPRS:IMSI-001001000000019:TLLI-0xc0000013){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-19:STATE-ASSIGN:GPRS:IMSI-001001000000019:TLLI-0xc0000013) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000020' The MS object cannot fully confirm an unexpected TLLI: 0xc0000014, partly confirmed @@ -1273,7 +1273,7 @@ DL_TBF(DL:TFI-0-0-20:STATE-NEW:GPRS:IMSI-001001000000020:TLLI-0xc0000014){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-20:STATE-ASSIGN:GPRS:IMSI-001001000000020:TLLI-0xc0000014) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000021' The MS object cannot fully confirm an unexpected TLLI: 0xc0000015, partly confirmed @@ -1303,7 +1303,7 @@ DL_TBF(DL:TFI-0-0-21:STATE-NEW:GPRS:IMSI-001001000000021:TLLI-0xc0000015){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-21:STATE-ASSIGN:GPRS:IMSI-001001000000021:TLLI-0xc0000015) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000022' The MS object cannot fully confirm an unexpected TLLI: 0xc0000016, partly confirmed @@ -1333,7 +1333,7 @@ DL_TBF(DL:TFI-0-0-22:STATE-NEW:GPRS:IMSI-001001000000022:TLLI-0xc0000016){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-22:STATE-ASSIGN:GPRS:IMSI-001001000000022:TLLI-0xc0000016) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000023' The MS object cannot fully confirm an unexpected TLLI: 0xc0000017, partly confirmed @@ -1363,7 +1363,7 @@ DL_TBF(DL:TFI-0-0-23:STATE-NEW:GPRS:IMSI-001001000000023:TLLI-0xc0000017){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-23:STATE-ASSIGN:GPRS:IMSI-001001000000023:TLLI-0xc0000017) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000024' The MS object cannot fully confirm an unexpected TLLI: 0xc0000018, partly confirmed @@ -1393,7 +1393,7 @@ DL_TBF(DL:TFI-0-0-24:STATE-NEW:GPRS:IMSI-001001000000024:TLLI-0xc0000018){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-24:STATE-ASSIGN:GPRS:IMSI-001001000000024:TLLI-0xc0000018) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000025' The MS object cannot fully confirm an unexpected TLLI: 0xc0000019, partly confirmed @@ -1423,7 +1423,7 @@ DL_TBF(DL:TFI-0-0-25:STATE-NEW:GPRS:IMSI-001001000000025:TLLI-0xc0000019){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-25:STATE-ASSIGN:GPRS:IMSI-001001000000025:TLLI-0xc0000019) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000026' The MS object cannot fully confirm an unexpected TLLI: 0xc000001a, partly confirmed @@ -1453,7 +1453,7 @@ DL_TBF(DL:TFI-0-0-26:STATE-NEW:GPRS:IMSI-001001000000026:TLLI-0xc000001a){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-26:STATE-ASSIGN:GPRS:IMSI-001001000000026:TLLI-0xc000001a) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000027' The MS object cannot fully confirm an unexpected TLLI: 0xc000001b, partly confirmed @@ -1483,7 +1483,7 @@ DL_TBF(DL:TFI-0-0-27:STATE-NEW:GPRS:IMSI-001001000000027:TLLI-0xc000001b){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-27:STATE-ASSIGN:GPRS:IMSI-001001000000027:TLLI-0xc000001b) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000028' The MS object cannot fully confirm an unexpected TLLI: 0xc000001c, partly confirmed @@ -1513,7 +1513,7 @@ DL_TBF(DL:TFI-0-0-28:STATE-NEW:GPRS:IMSI-001001000000028:TLLI-0xc000001c){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-28:STATE-ASSIGN:GPRS:IMSI-001001000000028:TLLI-0xc000001c) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000029' The MS object cannot fully confirm an unexpected TLLI: 0xc000001d, partly confirmed @@ -1543,7 +1543,7 @@ DL_TBF(DL:TFI-0-0-29:STATE-NEW:GPRS:IMSI-001001000000029:TLLI-0xc000001d){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-29:STATE-ASSIGN:GPRS:IMSI-001001000000029:TLLI-0xc000001d) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000030' The MS object cannot fully confirm an unexpected TLLI: 0xc000001e, partly confirmed @@ -1573,7 +1573,7 @@ DL_TBF(DL:TFI-0-0-30:STATE-NEW:GPRS:IMSI-001001000000030:TLLI-0xc000001e){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-30:STATE-ASSIGN:GPRS:IMSI-001001000000030:TLLI-0xc000001e) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000031' The MS object cannot fully confirm an unexpected TLLI: 0xc000001f, partly confirmed @@ -1603,7 +1603,7 @@ DL_TBF(DL:TFI-0-0-31:STATE-NEW:GPRS:IMSI-001001000000031:TLLI-0xc000001f){NEW}: state_chg to ASSIGN TBF(DL:TFI-0-0-31:STATE-ASSIGN:GPRS:IMSI-001001000000031:TLLI-0xc000001f) TX: START Immediate Assignment Downlink (PCH) - TRX=0 (0) TS=4 TA=220 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000032' The MS object cannot fully confirm an unexpected TLLI: 0xc0000020, partly confirmed @@ -1688,7 +1688,7 @@ MS(IMSI-001001000000000:TLLI-0xc0000000:TA-220:MSCLS-45-0) Detaching TBF: TBF(DL:TFI-0-0-0:STATE-ASSIGN:GPRS:IMSI-001001000000000:TLLI-0xc0000000) === start test_tbf_dl_llc_loss === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000123456' The MS object cannot fully confirm an unexpected TLLI: 0xc0123456, partly confirmed @@ -1806,7 +1806,7 @@ Found first unallocated TRX=0 TFI=0 MS requests Uplink resource on CCCH/RACH: ra=0x03 (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating UL TBF UL_ASS_TBF{NONE}: Allocated @@ -1868,7 +1868,7 @@ Found first unallocated TRX=0 TFI=0 MS requests Uplink resource on CCCH/RACH: ra=0x03 (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating UL TBF UL_ASS_TBF{NONE}: Allocated @@ -1985,7 +1985,7 @@ Detected FN jump! 2654167 -> 2654270 (expected 2654171, delta 103) PDCH(bts=0,trx=0,ts=7) FN=2654270 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654270 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xf1223344, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 @@ -2090,7 +2090,7 @@ Detected FN jump! 2654167 -> 2654270 (expected 2654171, delta 103) PDCH(bts=0,trx=0,ts=7) FN=2654270 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654270 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xf1223344, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 @@ -2263,7 +2263,7 @@ Detected FN jump! 2654292 -> 2654348 (expected 2654296, delta 56) PDCH(bts=0,trx=0,ts=7) FN=2654348 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654348 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xf5667788, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=2654348 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf5667788, TA 220 -> 7 @@ -2394,7 +2394,7 @@ Detected FN jump! 2654167 -> 2654270 (expected 2654171, delta 103) PDCH(bts=0,trx=0,ts=7) FN=2654270 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654270 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xf1223344, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 @@ -2609,7 +2609,7 @@ Detected FN jump! 2654167 -> 2654270 (expected 2654171, delta 103) PDCH(bts=0,trx=0,ts=7) FN=2654270 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654270 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xf1223344, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 @@ -2713,7 +2713,7 @@ Found first unallocated TRX=0 TFI=0 MS requests Uplink resource on CCCH/RACH: ra=0x03 (8 bit) Fn=2654275 qta=31 MS requests single TS uplink transmission (one phase packet access) -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating UL TBF UL_ASS_TBF{NONE}: Allocated @@ -2788,7 +2788,7 @@ Detected FN jump! 2654167 -> 2654270 (expected 2654171, delta 103) PDCH(bts=0,trx=0,ts=7) FN=2654270 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654270 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xf1223344, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 @@ -3873,7 +3873,7 @@ === end test_tbf_dl_reuse === === start test_tbf_gprs_egprs === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 45 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001123456789' The MS object cannot fully confirm an unexpected TLLI: 0xc0006789, partly confirmed @@ -3911,7 +3911,7 @@ PDCH(bts=0,trx=0,ts=2) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=3) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=5) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 12 MS(TA-220:MSCLS-12-0) ********** DL-TBF starts here ********** MS(TA-220:MSCLS-12-0) Allocating DL TBF @@ -3953,7 +3953,7 @@ DL_TBF(DL:TFI-0-0-0:STATE-NEW:GPRS){NEW}: Deallocated UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:GPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:GPRS){NONE}: Deallocated -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 12 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 12 MS(TA-220:MSCLS-12-12) Enabled EGPRS, mode EGPRS @@ -4011,7 +4011,7 @@ Detected FN jump! 2654167 -> 2654270 (expected 2654171, delta 103) PDCH(bts=0,trx=0,ts=7) FN=2654270 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654270 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xf1223344, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 @@ -4124,7 +4124,7 @@ Detected FN jump! 2654167 -> 2654270 (expected 2654171, delta 103) PDCH(bts=0,trx=0,ts=7) FN=2654270 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654270 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xf1223344, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 @@ -4352,7 +4352,7 @@ === start test_tbf_egprs_dl === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Testing MCS-1 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -4663,7 +4663,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing MCS-2 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -4923,7 +4923,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing MCS-3 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -5143,7 +5143,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing MCS-4 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -5347,7 +5347,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing MCS-5 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -5535,7 +5535,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing MCS-6 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -5699,7 +5699,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing MCS-7 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -5872,7 +5872,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing MCS-8 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -6036,7 +6036,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing MCS-9 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -6192,7 +6192,7 @@ === start test_tbf_egprs_retx_dl === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Testing retx for MCS 6 - 6 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -6263,7 +6263,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing retx for MCS 1 - 9 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -6333,7 +6333,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing retx for MCS 2 - 8 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -6403,7 +6403,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing retx for MCS 5 - 7 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -6498,7 +6498,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing retx for MCS 6 - 9 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -6592,7 +6592,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing retx for MCS 7 - 5 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -6686,7 +6686,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing retx for MCS 9 - 6 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -6783,7 +6783,7 @@ === start test_tbf_egprs_spb_dl === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled Testing retx for MCS 6 to reseg_mcs 3 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -6860,7 +6860,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing retx for MCS 5 to reseg_mcs 2 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -6937,7 +6937,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing retx for MCS 4 to reseg_mcs 1 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -7014,7 +7014,7 @@ UL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){NONE}: Deallocated DL_ASS_TBF(DL:TFI-0-0-0:STATE-NEW:EGPRS){SEND_ASS}: Deallocated Testing retx for MCS 6 to reseg_mcs 3 -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -7109,7 +7109,7 @@ Detected FN jump! 2654167 -> 2654270 (expected 2654171, delta 103) PDCH(bts=0,trx=0,ts=7) FN=2654270 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654270 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xf1223344, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 @@ -7239,7 +7239,7 @@ PDCH(bts=0,trx=0,ts=2) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=3) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=5) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -7315,7 +7315,7 @@ Detected FN jump! 2654167 -> 2654270 (expected 2654171, delta 103) PDCH(bts=0,trx=0,ts=7) FN=2654270 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654270 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xf1223344, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 @@ -7431,7 +7431,7 @@ === end test_tbf_li_decoding === === start test_tbf_epdan_out_of_rx_window === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -7486,7 +7486,7 @@ PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled MS requests Uplink resource on CCCH/RACH: ra=0x78 (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating UL TBF UL_ASS_TBF{NONE}: Allocated @@ -7514,7 +7514,7 @@ Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=0 USF=0 MS requests Uplink resource on CCCH/RACH: ra=0x79 (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating UL TBF UL_ASS_TBF{NONE}: Allocated @@ -7542,7 +7542,7 @@ Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=1 USF=1 MS requests Uplink resource on CCCH/RACH: ra=0x7a (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating UL TBF UL_ASS_TBF{NONE}: Allocated @@ -7570,7 +7570,7 @@ Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=2 USF=2 MS requests Uplink resource on CCCH/RACH: ra=0x7b (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating UL TBF UL_ASS_TBF{NONE}: Allocated @@ -7598,7 +7598,7 @@ Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=3 USF=3 MS requests Uplink resource on CCCH/RACH: ra=0x7c (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating UL TBF UL_ASS_TBF{NONE}: Allocated @@ -7626,7 +7626,7 @@ Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=4 USF=4 MS requests Uplink resource on CCCH/RACH: ra=0x7d (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating UL TBF UL_ASS_TBF{NONE}: Allocated @@ -7654,7 +7654,7 @@ Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=5 USF=5 MS requests Uplink resource on CCCH/RACH: ra=0x7e (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating UL TBF UL_ASS_TBF{NONE}: Allocated @@ -7682,7 +7682,7 @@ Tx Immediate Assignment on AGCH: TRX=0 (ARFCN 0) TS=7 TA=7 TSC=0 TFI=6 USF=6 MS requests Uplink resource on CCCH/RACH: ra=0x7f (8 bit) Fn=2654167 qta=31 MS requests single TS uplink transmission (one phase packet access) -Creating MS object, TLLI = 0xffffffff +Creating MS object MS(TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TA-220:MSCLS-0-0) Allocating UL TBF UL_ASS_TBF{NONE}: Allocated @@ -7742,7 +7742,7 @@ Detected FN jump! 2654167 -> 2654270 (expected 2654171, delta 103) PDCH(bts=0,trx=0,ts=7) FN=2654270 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=2654270 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xf1223344, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 @@ -9005,7 +9005,7 @@ === end test_tbf_egprs_two_phase_puan === === start test_packet_access_rej_epdan === PDCH(bts=0,trx=0,ts=4) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, EGPRS MS class 0 -> 11 MS(TA-220:MSCLS-11-11) Enabled EGPRS, mode EGPRS @@ -9096,7 +9096,7 @@ Detected FN jump! 2654167 -> 52 (expected 2654171, delta 61533) PDCH(bts=0,trx=0,ts=7) FN=52 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=52 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddcc, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=52 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xffeeddcc, TA 220 -> 7 @@ -9143,7 +9143,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(UL:TFI-0-0-0:STATE-ASSIGN:EGPRS:TLLI-0xffeeddcc) PDCH(bts=0,trx=0,ts=7) FN=56 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=56 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddcd, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=56 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xffeeddcd, TA 220 -> 7 @@ -9197,7 +9197,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(UL:TFI-0-0-1:STATE-ASSIGN:EGPRS:TLLI-0xffeeddcd) PDCH(bts=0,trx=0,ts=7) FN=60 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=60 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddce, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=60 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xffeeddce, TA 220 -> 7 @@ -9251,7 +9251,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(UL:TFI-0-0-2:STATE-ASSIGN:EGPRS:TLLI-0xffeeddce) PDCH(bts=0,trx=0,ts=7) FN=65 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=65 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddcf, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=65 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xffeeddcf, TA 220 -> 7 @@ -9305,7 +9305,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(UL:TFI-0-0-3:STATE-ASSIGN:EGPRS:TLLI-0xffeeddcf) PDCH(bts=0,trx=0,ts=7) FN=69 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=69 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddd0, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=69 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xffeeddd0, TA 220 -> 7 @@ -9359,7 +9359,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(UL:TFI-0-0-4:STATE-ASSIGN:EGPRS:TLLI-0xffeeddd0) PDCH(bts=0,trx=0,ts=7) FN=73 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=73 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddd1, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=73 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xffeeddd1, TA 220 -> 7 @@ -9413,7 +9413,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(UL:TFI-0-0-5:STATE-ASSIGN:EGPRS:TLLI-0xffeeddd1) PDCH(bts=0,trx=0,ts=7) FN=78 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=78 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddd2, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=78 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xffeeddd2, TA 220 -> 7 @@ -9467,7 +9467,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654218 Scheduling control message at RTS for TBF(UL:TFI-0-0-6:STATE-ASSIGN:EGPRS:TLLI-0xffeeddd2) PDCH(bts=0,trx=0,ts=7) FN=82 +++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++ PDCH(bts=0,trx=0,ts=7) FN=82 ------------------------- RX : Uplink Control Block ------------------------- -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddd3, not yet confirmed PDCH(bts=0,trx=0,ts=7) FN=82 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xffeeddd3, TA 220 -> 7 @@ -9544,7 +9544,7 @@ === end test_packet_access_rej_prr === === start test_packet_access_rej_prr_no_other_tbfs === PDCH(bts=0,trx=0,ts=7) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xffeeddcc, not yet confirmed UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated @@ -9578,7 +9578,7 @@ PDCH(bts=0,trx=1,ts=4) PDCH state: disabled => enabled PDCH(bts=0,trx=1,ts=5) PDCH state: disabled => enabled PDCH(bts=0,trx=1,ts=6) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, TLLI = 0xffffffff, MS class 0 -> 11 Modifying MS object, TLLI = 0xffffffff, IMSI '' -> '001001000000001' The MS object cannot fully confirm an unexpected TLLI: 0xa3c2f953, partly confirmed @@ -9617,7 +9617,7 @@ PDCH(bts=0,trx=0,ts=1) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=2) PDCH state: disabled => enabled PDCH(bts=0,trx=0,ts=3) PDCH state: disabled => enabled -Creating MS object, TLLI = 0xffffffff +Creating MS object Modifying MS object, UL TLLI: 0xffffffff -> 0xecc1f953, not yet confirmed MS(TLLI-0xecc1f953:TA-220:MSCLS-0-0) ********** UL-TBF starts here ********** MS(TLLI-0xecc1f953:TA-220:MSCLS-0-0) Allocating UL TBF diff --git a/tests/ulc/PdchUlcTest.cpp b/tests/ulc/PdchUlcTest.cpp index 44aef34..b77f1d4 100644 --- a/tests/ulc/PdchUlcTest.cpp +++ b/tests/ulc/PdchUlcTest.cpp @@ -182,7 +182,8 @@ the_pcu->alloc_algorithm = _alloc_algorithm_dummy; struct gprs_rlcmac_bts *bts = setup_new_bts(); - struct GprsMs *ms = ms_alloc(bts, 0x12345678); + struct GprsMs *ms = ms_alloc(bts); + ms_confirm_tlli(ms, 0x12345678); struct gprs_rlcmac_tbf *tbf1 = dl_tbf_alloc(bts, ms, 0, true); struct gprs_rlcmac_pdch *pdch = &tbf1->trx->pdch[0]; int rc; diff --git a/tests/ulc/PdchUlcTest.err b/tests/ulc/PdchUlcTest.err index 80cb9f3..a2ec373 100644 --- a/tests/ulc/PdchUlcTest.err +++ b/tests/ulc/PdchUlcTest.err @@ -15,7 +15,8 @@ PDCH(bts=0,trx=0,ts=0) Trying to release unregistered SBA (FN=78, TA=0) PDCH(bts=0,trx=0,ts=0) Timeout for registered SBA (FN=72, TA=0) PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => enabled -Creating MS object, TLLI = 0x12345678 +Creating MS object +The MS object cannot fully confirm an unexpected TLLI: 0x12345678, partly confirmed MS(TLLI-0x12345678:TA-220:MSCLS-0-0) Attaching DL TBF: TBF(DL:TFI-0-0--1:STATE-NEW:GPRS:TLLI-0x12345678) PDCH(bts=0,trx=0,ts=0) Reserving FN 2715608 for type POLL PDCH(bts=0,trx=0,ts=0) Reserving FN 2715613 for type POLL -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I730ec911a43b0f4e78faee4eeffb3ca8601564f8 Gerrit-Change-Number: 32340 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: e1d: fix log output
by dexter 17 Apr '23

17 Apr '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/32336 to look at the new patch set (#3). Change subject: e1d: fix log output ...................................................................... e1d: fix log output When a read access to the osmo-e1d fd fails we just prind the error to LOGL_DEBUG but an error like this should be logged to LOGL_ERROR. Also the line might print "read error 0 Success", which is a bit misleading, so let's fix this as well. Change-Id: I3a0500f083cbe8cc162826e2ec974875bafcaba9 --- M src/input/e1d.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/36/32336/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3a0500f083cbe8cc162826e2ec974875bafcaba9 Gerrit-Change-Number: 32336 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-abis[master]: e1d: clean up error logging in handle_ts_sign_read
by dexter 17 Apr '23

17 Apr '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32337 ) Change subject: e1d: clean up error logging in handle_ts_sign_read ...................................................................... e1d: clean up error logging in handle_ts_sign_read The error logging in handle_ts_sign_read can be organized the same way as in handle_ts_raw_read, then we do not need to check the return code twice. Change-Id: Ife3bb07fb4180dbd73d0efdc5acade8b20e8a5da --- M src/input/e1d.c 1 file changed, 16 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/37/32337/1 diff --git a/src/input/e1d.c b/src/input/e1d.c index a42c87d..289e693 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -64,16 +64,13 @@ return -ENOMEM; ret = read(bfd->fd, msg->data, TS_SIGN_ALLOC_SIZE - 16); - if (ret < 0) { - LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); + if (ret < 1) { + LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "%s read error: %d %s\n", __func__, ret, + ret < 0 ? strerror(errno) : "bytes read"); return ret; } msgb_put(msg, ret); - if (ret <= 1) { - LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); - return ret; - } return e1inp_rx_ts_lapd(e1i_ts, msg); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ife3bb07fb4180dbd73d0efdc5acade8b20e8a5da Gerrit-Change-Number: 32337 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: e1d: maintain error log consistency in handle_ts_hdlc_read
by dexter 17 Apr '23

17 Apr '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32338 ) Change subject: e1d: maintain error log consistency in handle_ts_hdlc_read ...................................................................... e1d: maintain error log consistency in handle_ts_hdlc_read The function handle_ts_hdlc_read() should log read errors in the same way as the other functions do Change-Id: I0af06d6adcbf61e0996d9888feb70b74f0c9c0ef --- M src/input/e1d.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/38/32338/1 diff --git a/src/input/e1d.c b/src/input/e1d.c index 289e693..56fb5e5 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -291,7 +291,7 @@ ret = read(bfd->fd, msg->data, TSX_ALLOC_SIZE); if (ret < 0) { - LOGPITS(e1i_ts, DLINP, LOGL_NOTICE, "read error %d %s\n", ret, strerror(errno)); + LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "%s read error: %d %s\n", __func__, ret, strerror(errno)); msgb_free(msg); return ret; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0af06d6adcbf61e0996d9888feb70b74f0c9c0ef Gerrit-Change-Number: 32338 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: e1d: fix log output
by dexter 17 Apr '23

17 Apr '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/32336 to look at the new patch set (#2). Change subject: e1d: fix log output ...................................................................... e1d: fix log output When a read access to the osmo-e1d fd fails we just prind the error to LOGL_DEBUG but an error like this should be logged to LOGL_ERROR. Also the line might print "read error 0 Success", which is a bit misleading, so let's fix this as well. Change-Id: I3a0500f083cbe8cc162826e2ec974875bafcaba9 --- M src/input/e1d.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/36/32336/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3a0500f083cbe8cc162826e2ec974875bafcaba9 Gerrit-Change-Number: 32336 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-abis[master]: e1d: fix log output
by dexter 17 Apr '23

17 Apr '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32336 ) Change subject: e1d: fix log output ...................................................................... e1d: fix log output When a read access to the osmo-e1d fd fails we just prind the error to LOGL_DEBUG but an error like this should be logged to LOGL_ERROR. Also the line might print "read error 0 Success", which is a bit misleading, so let's fix this as well. Change-Id: I3a0500f083cbe8cc162826e2ec974875bafcaba9 --- M src/input/e1d.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/36/32336/1 diff --git a/src/input/e1d.c b/src/input/e1d.c index 6392b4f..098e488 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -233,7 +233,7 @@ ret = read(bfd->fd, msg->data, D_TSX_ALLOC_SIZE); if (ret < 0 || ret != D_TSX_ALLOC_SIZE) { - LOGPITS(e1i_ts, DLINP, LOGL_DEBUG, "read error %d %s\n", ret, strerror(errno)); + LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "read error: %d %s\n", ret, ret < 0 ? strerror(errno) : "bytes read"); msgb_free(msg); return ret; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3a0500f083cbe8cc162826e2ec974875bafcaba9 Gerrit-Change-Number: 32336 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-e1d[master]: proto_clnt: fix function prototype
by tnt 17 Apr '23

17 Apr '23

Attention is currently required from: dexter. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/32335 ) Change subject: proto_clnt: fix function prototype ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/32335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I8bd4fbdf2bda332870da1b915a7898c396a85b0f Gerrit-Change-Number: 32335 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Apr 2023 10:44:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0