Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32360 )
Change subject: ms: Rewrite MS release lifecycle
......................................................................
Patch Set 5:
(1 comment)
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/32360/comment/c7791686_b11d6225
PS5, Line 218: ms_becomes_idle
> these ms_becomes_ function names sound a bit strange to me, as the other functions are in imperative […]
They are not imperative because well, the idea is that they are not doing something sepcific, they are rather an entry point. The idea is that the dev usually wants to find out where that specific event/change happens.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32360
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839
Gerrit-Change-Number: 32360
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Apr 2023 12:29:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: jolly, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/32393 )
Change subject: proto_clnt: use osmo_fd_close to close the socket on connection loss
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/32393
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I702b944baf2ebbcc84b6a211e245a4a41627bde6
Gerrit-Change-Number: 32393
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Apr 2023 12:28:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32321 )
Change subject: add public API: osmo_sccp_instance_next_conn_id()
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> AFAIU, when using this function instead of each's app function, you'll then be iterating over a diff […]
I saw not yet any reply regarding my concerns here.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32321
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: If59d524fbe1088a59ae1b69908e2d4bf67113439
Gerrit-Change-Number: 32321
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Apr 2023 12:27:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32320 )
Change subject: sccp_scoc.c: fix infinite loop on conn ID exhaustion
......................................................................
Patch Set 2:
(1 comment)
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/43e5221c_75a0356a
PS1, Line 589: 0
> are you really ever going to pass something other than 0 here?
You forgot to update this call to pass only 1 param.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32320
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ib64e0cb1ae0cc8b7bebcb2a352d4068b496b304a
Gerrit-Change-Number: 32320
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Apr 2023 12:26:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment