April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: tbf: Move m_ctrs alloc to constructor

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32377 to look at the new patch set (#7). Change subject: tbf: Move m_ctrs alloc to constructor ...................................................................... tbf: Move m_ctrs alloc to constructor Move rate_ctr allocation to the constructor since it's expected not to fail. This simplifies further tbf::setup() function. Change-Id: If64443c38624d159e68eec3a07d8e8caf369467b --- M src/tbf.cpp M src/tbf_ul.cpp 2 files changed, 16 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/77/32377/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If64443c38624d159e68eec3a07d8e8caf369467b Gerrit-Change-Number: 32377 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf: Move enable_egprs() to constructor

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32379 to look at the new patch set (#7). Change subject: tbf: Move enable_egprs() to constructor ...................................................................... tbf: Move enable_egprs() to constructor Whether the TBF is GPRS or EGPRS is known at allocation time since it comes from the information known in the MS object used to create it. Hence, no need to delay calling it to later steps such as setup(). So far it was probably left in setup() due to the constrains about requiring the subclass to be constructed (use of window() virtual API). Change-Id: I2e9d2a98c666a930333d52fb6c0463d7593c2615 --- M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_ul.cpp M tests/tbf/TbfTest.err 5 files changed, 36 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/79/32379/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2e9d2a98c666a930333d52fb6c0463d7593c2615 Gerrit-Change-Number: 32379 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_ul: Move rate_ctr allocation to constructor

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32378 to look at the new patch set (#7). Change subject: tbf_ul: Move rate_ctr allocation to constructor ...................................................................... tbf_ul: Move rate_ctr allocation to constructor Change-Id: I818eb05fe062e0610e86cb34273bde99b379aa3f --- M src/tbf_ul.cpp 1 file changed, 14 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/78/32378/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I818eb05fe062e0610e86cb34273bde99b379aa3f Gerrit-Change-Number: 32378 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: cosmetic: Fix indentation in comment

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32380 to look at the new patch set (#6). Change subject: cosmetic: Fix indentation in comment ...................................................................... cosmetic: Fix indentation in comment Change-Id: I15063346e4ff0367c0bf04f6b48ac62b9bdf2929 --- M src/gprs_ms.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/32380/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32380 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I15063346e4ff0367c0bf04f6b48ac62b9bdf2929 Gerrit-Change-Number: 32380 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: dl_tbf: Set BandWidth timestamps to current time directly

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32382 to look at the new patch set (#6). Change subject: dl_tbf: Set BandWidth timestamps to current time directly ...................................................................... dl_tbf: Set BandWidth timestamps to current time directly Change-Id: I01654534aef5255c6d1c3ba0c553190a0319e8e1 --- M src/tbf_dl.cpp 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/32382/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I01654534aef5255c6d1c3ba0c553190a0319e8e1 Gerrit-Change-Number: 32382 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: meas: Improve logging formatting

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32389 to look at the new patch set (#4). Change subject: meas: Improve logging formatting ...................................................................... meas: Improve logging formatting Change-Id: I15d66da3f41a9f14a542b96436d65a0581bbb45a --- M src/gprs_rlcmac_meas.cpp 1 file changed, 15 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/89/32389/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I15d66da3f41a9f14a542b96436d65a0581bbb45a Gerrit-Change-Number: 32389 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: Add new log category 'ms'

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32383 to look at the new patch set (#7). Change subject: Add new log category 'ms' ...................................................................... Add new log category 'ms' This is useful to track the lifecycle of MS objects. The RLCMAC cateogry used so far in those log messages is too broad. Change-Id: Ib4ce88d0f7309ac77c064a94bb0d667e8dbc33dd --- M src/gprs_debug.c M src/gprs_debug.h M src/gprs_ms.c M tests/app_info/AppInfoTest.cpp M tests/ms/MsTest.cpp M tests/tbf/TbfTest.cpp M tests/ulc/PdchUlcTest.cpp 7 files changed, 50 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/83/32383/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib4ce88d0f7309ac77c064a94bb0d667e8dbc33dd Gerrit-Change-Number: 32383 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: ms: Increase log level when scheduling release timer

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32384 to look at the new patch set (#5). Change subject: ms: Increase log level when scheduling release timer ...................................................................... ms: Increase log level when scheduling release timer Change-Id: Ie470b5b0c7b01d91f4ad693e52afd51860d6da2d --- M src/gprs_ms.c M tests/ms/MsTest.err 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/84/32384/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie470b5b0c7b01d91f4ad693e52afd51860d6da2d Gerrit-Change-Number: 32384 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: ms: Hold a reference during ms_alloc

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32375 to look at the new patch set (#8). Change subject: ms: Hold a reference during ms_alloc ...................................................................... ms: Hold a reference during ms_alloc Make the caller hold a reference to the MS object just allocated, so that it hs to explicitly unref it and, in turn, if no new references were added during its use, trigger release of the MS object. This is useful to avoid leaking MS object if it was allocated and then no TBF is attached to it because allocation of TBF failed. Related: OS#6002 Change-Id: I2088a7ddd76fe9157b6626ef96ae4315e88779ea --- M src/bts.cpp M src/gprs_ms.c M src/gprs_ms.h M src/pdch.cpp M src/tbf_dl.cpp M tests/alloc/AllocTest.cpp M tests/app_info/AppInfoTest.cpp M tests/llc/LlcTest.cpp M tests/ms/MsTest.cpp M tests/ms/MsTest.err M tests/tbf/TbfTest.cpp M tests/tbf/TbfTest.err M tests/types/TypesTest.cpp M tests/ulc/PdchUlcTest.cpp 14 files changed, 274 insertions(+), 114 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/75/32375/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2088a7ddd76fe9157b6626ef96ae4315e88779ea Gerrit-Change-Number: 32375 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: ms: Get rid of ms->delay field

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32390 to look at the new patch set (#3). Change subject: ms: Get rid of ms->delay field ...................................................................... ms: Get rid of ms->delay field Simply apply the content of the configured timer when the MS goes idle. Having that field is convenient to do tricky stuff in unit tests, but makes the main osmo-pcu app more complex for no good enough reason. Change-Id: I8d44318b37b6605afd84db8ccec0d75e6db293b9 --- M src/bts.cpp M src/gprs_ms.c M src/gprs_ms.h M tests/alloc/AllocTest.cpp M tests/ms/MsTest.cpp M tests/tbf/TbfTest.cpp M tests/ulc/PdchUlcTest.cpp 7 files changed, 30 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/90/32390/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8d44318b37b6605afd84db8ccec0d75e6db293b9 Gerrit-Change-Number: 32390 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023