Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32391
to look at the new patch set (#3).
Change subject: ms: Rename field timer -> release_timer
......................................................................
ms: Rename field timer -> release_timer
Rename it so that it becomes clear what the timer is used for.
Change-Id: Id4738ea196b232858e1ec9cdc439f9b81839058f
---
M src/gprs_ms.c
M src/gprs_ms.h
M tests/ms/MsTest.cpp
3 files changed, 18 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/91/32391/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32391
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id4738ea196b232858e1ec9cdc439f9b81839058f
Gerrit-Change-Number: 32391
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello osmith, Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32394
to look at the new patch set (#3).
Change subject: ms: Log MS active/idle state in 'show ms' VTY commands
......................................................................
ms: Log MS active/idle state in 'show ms' VTY commands
Change-Id: Ibcd34055c9ae390510c5c3ba26621fd96d2368fd
---
M src/gprs_ms.c
M src/gprs_ms.h
M src/pcu_vty_functions.cpp
3 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/94/32394/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32394
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibcd34055c9ae390510c5c3ba26621fd96d2368fd
Gerrit-Change-Number: 32394
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32396
to look at the new patch set (#3).
Change subject: vty: Several improvements to 'show ms' output format
......................................................................
vty: Several improvements to 'show ms' output format
* Use UL/DL acronyms to decrease output verbosity
* Keep more stable MS properties at the top, move link quality changing
entries to the bottom putting them together.
Change-Id: If9f4c6ba1a4a6f9060222cc04254054ad03d7a96
---
M src/pcu_vty_functions.cpp
1 file changed, 27 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/96/32396/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32396
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If9f4c6ba1a4a6f9060222cc04254054ad03d7a96
Gerrit-Change-Number: 32396
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newpatchset
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32396 )
Change subject: vty: Several improvements to 'show ms' output format
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Good catch, thanks, fixing in next version I'm submitting now.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32396
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If9f4c6ba1a4a6f9060222cc04254054ad03d7a96
Gerrit-Change-Number: 32396
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Apr 2023 12:45:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32357 )
Change subject: ms: Make sure tbf!=NULL in ms_attach_{ul,dl}_tbf()
......................................................................
ms: Make sure tbf!=NULL in ms_attach_{ul,dl}_tbf()
It makes no sense to pass "NULL" to attach function. There's a detach
function to be used if a given TBF has to be detached.
Change-Id: I0c5df195c080b21e5516aebfb46db22bdc55f2a2
---
M src/gprs_ms.c
1 file changed, 17 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/gprs_ms.c b/src/gprs_ms.c
index f65ffb8..357470b 100644
--- a/src/gprs_ms.c
+++ b/src/gprs_ms.c
@@ -362,8 +362,7 @@
ms->ul_tbf = tbf;
- if (tbf)
- ms_release_timer_stop(ms);
+ ms_release_timer_stop(ms);
ms_unref(ms, __func__);
}
@@ -382,14 +381,16 @@
ms->dl_tbf = tbf;
- if (tbf)
- ms_release_timer_stop(ms);
+ ms_release_timer_stop(ms);
ms_unref(ms, __func__);
}
void ms_attach_tbf(struct GprsMs *ms, struct gprs_rlcmac_tbf *tbf)
{
+ OSMO_ASSERT(ms);
+ OSMO_ASSERT(tbf);
+
if (tbf_direction(tbf) == GPRS_RLCMAC_DL_TBF)
ms_attach_dl_tbf(ms, tbf_as_dl_tbf(tbf));
else
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32357
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0c5df195c080b21e5516aebfb46db22bdc55f2a2
Gerrit-Change-Number: 32357
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged