February 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx

by daniel

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31586 ) Change subject: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f Gerrit-Change-Number: 31586 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:22:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... osmo_{client,server}_main: Remove is_config_node in vty_app_info This member is deprcated/unused so simply remove it: > 'is_config_node' is deprecated: Implicit parent node tracking has > replaced the use of this callback. This callback is no longer called, > ever, and can be left NULL. Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 --- M src/osmo_client_main.c M src/osmo_server_main.c 2 files changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/88/31588/1 diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c index 8ca2df3..818a2f1 100644 --- a/src/osmo_client_main.c +++ b/src/osmo_client_main.c @@ -79,7 +79,6 @@ .name = "OsmoPCAPClient", .version = PACKAGE_VERSION, .go_parent_cb = osmopcap_go_parent, - .is_config_node = osmopcap_is_config_node, }; static void print_usage() diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 8ad89ba..4633888 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -89,7 +89,6 @@ .name = "OsmoPCAPServer", .version = PACKAGE_VERSION, .go_parent_cb = osmopcap_go_parent, - .is_config_node = osmopcap_is_config_node, }; static void print_usage() -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: cosmetic: Remove trailing whitespace

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31589 ) Change subject: cosmetic: Remove trailing whitespace ...................................................................... cosmetic: Remove trailing whitespace Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 --- M src/osmo_common.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/89/31589/1 diff --git a/src/osmo_common.c b/src/osmo_common.c index 39f448a..6a12728 100644 --- a/src/osmo_common.c +++ b/src/osmo_common.c @@ -62,7 +62,7 @@ .num_cat = ARRAY_SIZE(default_categories), }; -const char *osmopcap_copyright = +const char *osmopcap_copyright = "Copyright (C) 2011-2017 Holger Freyther and contributors\r\n" "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" "This is free software: you are free to change and redistribute it.\r\n" @@ -86,7 +86,7 @@ break; } - return vty->node; + return vty->node; } int osmopcap_is_config_node(struct vty *vty, int node) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 Gerrit-Change-Number: 31589 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

[S] Change in osmo-iuh[master]: test-ranap: don't use libosmocore's tall_msgb_ctx

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31587 ) Change subject: test-ranap: don't use libosmocore's tall_msgb_ctx ...................................................................... test-ranap: don't use libosmocore's tall_msgb_ctx Use msgb_ctx from test_common.c instead, which is the same pointer after test_common_init() ran. tall_msgb_ctx from libosmocore is no longer getting exported since I13169c00a59fb59513dfc598de5a71d094492422. Fix for: /usr/bin/ld: test-ranap.o: in function `main': /build/src/tests/test-ranap.c:201: undefined reference to `tall_msgb_ctx' /usr/bin/ld: /build/src/tests/test-ranap.c:201: undefined reference to `tall_msgb_ctx' Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb --- M src/tests/test-ranap.c M src/tests/test_common.c 2 files changed, 21 insertions(+), 3 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tests/test-ranap.c b/src/tests/test-ranap.c index 633bb2b..e593bd9 100644 --- a/src/tests/test-ranap.c +++ b/src/tests/test-ranap.c @@ -32,7 +32,7 @@ #include "test_common.h" -extern void *tall_msgb_ctx; +extern void *msgb_ctx; static void test_aper_int(uint32_t inp) { @@ -198,7 +198,7 @@ printf("report\n"); talloc_report(talloc_asn1_ctx, stdout); - talloc_report(tall_msgb_ctx, stdout); + talloc_report(msgb_ctx, stdout); //talloc_report(NULL, stdout); test_common_cleanup(); diff --git a/src/tests/test_common.c b/src/tests/test_common.c index 187a269..36d9954 100644 --- a/src/tests/test_common.c +++ b/src/tests/test_common.c @@ -71,7 +71,7 @@ }; static void *tall_hnb_ctx; -static void *msgb_ctx; +void *msgb_ctx; int test_common_init(void) { -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb Gerrit-Change-Number: 31587 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-iuh[master]: test-ranap: don't use libosmocore's tall_msgb_ctx

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31587 ) Change subject: test-ranap: don't use libosmocore's tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb Gerrit-Change-Number: 31587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:19:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-iuh[master]: test-ranap: don't use libosmocore's tall_msgb_ctx

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31587 ) Change subject: test-ranap: don't use libosmocore's tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb Gerrit-Change-Number: 31587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:19:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31586 ) Change subject: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f Gerrit-Change-Number: 31586 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:18:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-iuh[master]: test-ranap: don't use libosmocore's tall_msgb_ctx

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31587 ) Change subject: test-ranap: don't use libosmocore's tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb Gerrit-Change-Number: 31587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:17:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[M] Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

by pespin

Attention is currently required from: neels, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 17: Code-Review-1 (6 comments) File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/de5fe3fe_854658d9 PS17, Line 48: #define PCU_IF_FLAG_DT (1 << 2)/* use TLLI for confirmation directly */ I think we agreed in the call this flag was not needed. https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/669099fc_aa3e5889 PS17, Line 280: uint8_t pgroup[3]; This can be a int16_t containing a number 0-999. https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/f86341bf_e27d3f4d PS17, Line 294: struct gsm_pcu_if_data_cnf_dt data_cnf_dt; isn't it a bit weird that we have a cnf_dt but no data_dt? File src/bts.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/3c1259d6_37a48a0b PS17, Line 282: /* Use the TLLI directly to handle IMMEDIATE ASSIGNMENT confirmation, otherwise the TLLI is extracted This is most probably not needed anymore and can be dropped. File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/5d34526d_f3a0f307 PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf))); I thought we agreed on dropping the previous message? File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/eaf4a5b4_12c55936 PS17, Line 769: this can be dropped. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 17 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:16:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx

by osmith

Attention is currently required from: daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31586 ) Change subject: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f Gerrit-Change-Number: 31586 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:14:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023