February 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD
by osmith 28 Feb '23

28 Feb '23

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31549 to look at the new patch set (#2). Change subject: rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD ...................................................................... rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD Omit the A-bis/IP specific RSL_IE_IPAC_SPEECH_MODE, as it doesn't make sense for circuit switched data. Related: OS#4393 Change-Id: I6641b713177276bcf798f08123e1dd2e88ffdce6 --- M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/lchan_rtp_fsm.c 2 files changed, 58 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/31549/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6641b713177276bcf798f08123e1dd2e88ffdce6 Gerrit-Change-Number: 31549 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: bssmap_handle_ass_req_tp_codec_list: tweak log msg
by osmith 28 Feb '23

28 Feb '23

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31550 to look at the new patch set (#2). Change subject: bssmap_handle_ass_req_tp_codec_list: tweak log msg ...................................................................... bssmap_handle_ass_req_tp_codec_list: tweak log msg Remove "speech mode" from the log message, as the log message is relevant for CSD too. According to 3GPP TS 48.008 § 3.2.1.1 note 13 the IE shall be included for AoIP unless channel type is signalling. Related: OS#4393 Change-Id: Idfab0b7f6e97a6b67d140f967ddfe9b29818586e --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/31550/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfab0b7f6e97a6b67d140f967ddfe9b29818586e Gerrit-Change-Number: 31550 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: pgw: Avoid access to unbound global variable
by pespin 28 Feb '23

28 Feb '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31592 ) Change subject: pgw: Avoid access to unbound global variable ...................................................................... pgw: Avoid access to unbound global variable This happens if GTv2C failed prior: """ 11:30:17.577738 15 PGW_Tests.ttcn:645 setverdict(fail): none -> fail reason: "Unexpected GTPv2 while waiting for CreateSessionResp", new component reason: "Une xpected GTPv2 while waiting for CreateSessionResp" 11:30:17.578004 15 PGW_Tests.ttcn:756 Dynamic test case error: Initializing a TTCN_Buffer with an unbound octetstring value. """ Change-Id: I9731b755ddc7bb3ebd56bdec550961cc36f2e2c6 --- M pgw/PGW_Tests.ttcn 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/31592/1 diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index b8c363b..8a25ebf 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -753,6 +753,10 @@ private function f_ping4(charstring host, integer interval := 1, integer count := 10) runs on PGW_Session_CT { var charstring ping :="ping -c " & int2str(count) & " -i " & int2str(interval); + + if (not isbound(g_ip4_addr)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_ping4(): g_ip4_addr is unset!"); + } ping := ping & " -I " & f_inet_ntoa(g_ip4_addr); ping := ping & " " & host; f_start_prog_wait(ping, tout := int2float(5 + interval*count)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9731b755ddc7bb3ebd56bdec550961cc36f2e2c6 Gerrit-Change-Number: 31592 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: osmo_wqueue_enqueue(): Avoid redundant if-check
by arehbein 28 Feb '23

28 Feb '23

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31591 ) Change subject: osmo_wqueue_enqueue(): Avoid redundant if-check ...................................................................... osmo_wqueue_enqueue(): Avoid redundant if-check Remove call to osmo_wqueue_enqueue_quiet(), which checks the same condition as osmo_wqueue_enqueue. The result is basically one function less on the call stack and one if-check less; while having one more statement in osmo_wqueue_enqueue() itself compared to before. Change-Id: I3ecc1698e836ca40e178a5b84c2946ae0e6bbfc9 --- M src/core/write_queue.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/31591/1 diff --git a/src/core/write_queue.c b/src/core/write_queue.c index 884cebd..b5cbe6d 100644 --- a/src/core/write_queue.c +++ b/src/core/write_queue.c @@ -128,7 +128,10 @@ return -ENOSPC; } - return osmo_wqueue_enqueue_quiet(queue, data); + msgb_enqueue_count(&queue->msg_queue, data, &queue->current_length); + queue->bfd.when |= OSMO_FD_WRITE; + + return 0; } /*! Clear a \ref osmo_wqueue -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3ecc1698e836ca40e178a5b84c2946ae0e6bbfc9 Gerrit-Change-Number: 31591 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: Cosmetic: fix various typos
by osmith 28 Feb '23

28 Feb '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31539 ) Change subject: Cosmetic: fix various typos ...................................................................... Cosmetic: fix various typos Change-Id: I9225e733e3afa8171f24253e21eaffc654f689af --- M src/osmo-bsc/assignment_fsm.c M src/osmo-bsc/codec_pref.c 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index e2213d4..d382f10 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -389,7 +389,7 @@ return 0; } -/* Check if the incoming assignment requests requires a voice stream or not, +/* Check if the incoming assignment request requires a voice stream or not, * we will look at the preferred and the alternate channel mode and also make * sure that both are consistent. */ static int check_requires_voice_stream(struct gsm_subscriber_connection *conn) diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c index 9b4b37f..3824e14 100644 --- a/src/osmo-bsc/codec_pref.c +++ b/src/osmo-bsc/codec_pref.c @@ -376,7 +376,7 @@ break; } - /* Exit without result, in case no match can be deteched */ + /* Exit without result, in case no match can be detected */ if (!match) { ch_mode_rate->chan_mode = GSM48_CMODE_SIGN; ch_mode_rate->chan_rate = CH_RATE_SDCCH; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9225e733e3afa8171f24253e21eaffc654f689af Gerrit-Change-Number: 31539 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: Cosmetic: codec_pref: tweak comments
by osmith 28 Feb '23

28 Feb '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31540 ) Change subject: Cosmetic: codec_pref: tweak comments ...................................................................... Cosmetic: codec_pref: tweak comments Remove "Helper function for match_codec_pref()" at the beginning of the descriptions of these functions, looks like a leftover from before this was moved to its own c file. Remove a duplicated "received" in a comment. Change-Id: I30f0744db9aebf2f05077fef840097c332b9dafd --- M src/osmo-bsc/codec_pref.c 1 file changed, 23 insertions(+), 12 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c index 3824e14..a64425a 100644 --- a/src/osmo-bsc/codec_pref.c +++ b/src/osmo-bsc/codec_pref.c @@ -61,8 +61,7 @@ return 0; } -/* Helper function for match_codec_pref(), looks up a matching chan mode for - * a given permitted speech value */ +/* Look up a matching chan mode for a given permitted speech value */ static enum gsm48_chan_mode gsm88_to_chan_mode(enum gsm0808_permitted_speech speech) { switch (speech) { @@ -88,8 +87,7 @@ } } -/* Helper function for match_codec_pref(), looks up a matching permitted speech - * value for a given msc audio codec pref */ +/* Look up a matching permitted speech value for a given msc audio codec pref */ static enum gsm0808_permitted_speech audio_support_to_gsm88(const struct gsm_audio_support *audio) { if (audio->hr) { @@ -125,10 +123,9 @@ } } -/* Helper function for match_codec_pref(), tests if a given audio support - * matches one of the permitted speech settings of the channel type element. - * The matched permitted speech value is then also compared against the - * speech codec list. (optional, only relevant for AoIP) */ +/* Test if a given audio support matches one of the permitted speech settings + * of the channel type element. The matched permitted speech value is then also + * compared against the speech codec list. (optional, only relevant for AoIP) */ static bool test_codec_pref(const struct gsm0808_speech_codec **sc_match, const struct gsm0808_speech_codec_list *scl, const struct gsm0808_channel_type *ct, @@ -177,8 +174,8 @@ return false; } -/* Helper function to check if the given permitted speech value is supported - * by the BTS. (vty option bts->codec-support). */ +/* Check if the given permitted speech value is supported by the BTS + * (vty option bts->codec-support). */ static bool test_codec_support_bts(const struct gsm_bts *bts, uint8_t perm_spch) { struct gsm_bts_trx *trx; @@ -308,8 +305,8 @@ return 0; } -/*! Match the codec preferences from local config with a received codec preferences IEs received from the - * MSC and the BTS' codec configuration. +/*! Match the codec preferences from local config with codec preference IEs + * received from the MSC and the BTS' codec configuration. * \param[out] ch_mode_rate resulting codec and rate information * \param[in] ct GSM 08.08 channel type received from MSC. * \param[in] scl GSM 08.08 speech codec list received from MSC (optional). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I30f0744db9aebf2f05077fef840097c332b9dafd Gerrit-Change-Number: 31540 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: Cosmetic: codec_pref: tweak comments
by osmith 28 Feb '23

28 Feb '23

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31540 ) Change subject: Cosmetic: codec_pref: tweak comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I30f0744db9aebf2f05077fef840097c332b9dafd Gerrit-Change-Number: 31540 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 11:06:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info
by daniel 28 Feb '23

28 Feb '23

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... osmo_{client,server}_main: Remove is_config_node in vty_app_info This member is deprcated/unused so simply remove it: > 'is_config_node' is deprecated: Implicit parent node tracking has > replaced the use of this callback. This callback is no longer called, > ever, and can be left NULL. Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 --- M src/osmo_client_main.c M src/osmo_common.c M src/osmo_server_main.c 3 files changed, 15 insertions(+), 12 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c index 8ca2df3..818a2f1 100644 --- a/src/osmo_client_main.c +++ b/src/osmo_client_main.c @@ -79,7 +79,6 @@ .name = "OsmoPCAPClient", .version = PACKAGE_VERSION, .go_parent_cb = osmopcap_go_parent, - .is_config_node = osmopcap_is_config_node, }; static void print_usage() diff --git a/src/osmo_common.c b/src/osmo_common.c index 39f448a..7c641e6 100644 --- a/src/osmo_common.c +++ b/src/osmo_common.c @@ -88,13 +88,3 @@ return vty->node; } - -int osmopcap_is_config_node(struct vty *vty, int node) -{ - switch (node) { - case CONFIG_NODE: - return 0; - default: - return 1; - } -} diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 8ad89ba..4633888 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -89,7 +89,6 @@ .name = "OsmoPCAPServer", .version = PACKAGE_VERSION, .go_parent_cb = osmopcap_go_parent, - .is_config_node = osmopcap_is_config_node, }; static void print_usage() -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-pcap[master]: cosmetic: Remove trailing whitespace
by daniel 28 Feb '23

28 Feb '23

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31589 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cosmetic: Remove trailing whitespace ...................................................................... cosmetic: Remove trailing whitespace Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 --- M src/osmo_common.c 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: daniel: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_common.c b/src/osmo_common.c index 7c641e6..b90d339 100644 --- a/src/osmo_common.c +++ b/src/osmo_common.c @@ -62,7 +62,7 @@ .num_cat = ARRAY_SIZE(default_categories), }; -const char *osmopcap_copyright = +const char *osmopcap_copyright = "Copyright (C) 2011-2017 Holger Freyther and contributors\r\n" "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" "This is free software: you are free to change and redistribute it.\r\n" @@ -86,5 +86,5 @@ break; } - return vty->node; + return vty->node; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 Gerrit-Change-Number: 31589 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx
by osmith 28 Feb '23

28 Feb '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... libosmocore.map: add tall_{ctr/msgb}_ctx These should not be used, but add them for backwards compatibility with building older versions of osmo-bsc, osmo-iuh, osmo-pcap against current libosmocore. Fixes: 213fc420 ("Add libosmocore.map") Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d --- M src/core/libosmocore.map 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 16b7261..984046b 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -559,7 +559,9 @@ rb_replace_node; sercomm_drv_lock; sercomm_drv_unlock; +tall_ctr_ctx; /* deprecated */ tall_log_ctx; +tall_msgb_ctx; /* deprecated */ local: *; }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2025

2024

2023

2022

gerrit-log February 2023