February 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by pespin

Attention is currently required from: osmith, pespin. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/core/libosmocore.map: https://gerrit.osmocom.org/c/libosmocore/+/31590/comment/54238fd9_880ea58e PS2, Line 562: tall_ctr_ctx; Maybe add comments in here regarding only exported due to historical reasons and are actually deprecated. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:30:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by osmith

osmith has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... libosmocore.map: add tall_{ctr/msgb}_ctx These should not be used, but add them for backwards compatibility with building older versions of osmo-bsc, osmo-iuh, osmo-pcap against current libosmocore. Fixes: 213fc420 ("Add libosmocore.map") Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d --- M src/core/libosmocore.map 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/31590/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... Patch Set 1: -Code-Review (1 comment) Patchset: PS1: Don't you need to remove the symbol too? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:29:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by osmith

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... libosmocore.map: add tall_{ctr/msgb}_ctx These should not be used, but add them for backwards compatibility with building older versions of osmo-bsc, osmo-iuh, osmo-pcap against current libosmocore. Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d --- M src/core/libosmocore.map 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/31590/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:29:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: cosmetic: Remove trailing whitespace

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31589 ) Change subject: cosmetic: Remove trailing whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 Gerrit-Change-Number: 31589 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:28:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgbx}_ctx

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgbx}_ctx ...................................................................... libosmocore.map: add tall_{ctr/msgbx}_ctx These should not be used, but add them for backwards compatibility with building older versions of osmo-bsc, osmo-iuh, osmo-pcap against current libosmocore. Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d --- M src/core/libosmocore.map 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/31590/1 diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 16b7261..b204651 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -559,7 +559,9 @@ rb_replace_node; sercomm_drv_lock; sercomm_drv_unlock; +tall_ctr_ctx; tall_log_ctx; +tall_msgb_ctx; local: *; }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by osmith

Attention is currently required from: pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:24:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: cosmetic: Remove trailing whitespace

by daniel

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31589 ) Change subject: cosmetic: Remove trailing whitespace ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: whitespace change -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 Gerrit-Change-Number: 31589 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 28 Feb 2023 10:23:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31586 ) Change subject: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx ...................................................................... osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx tall_ctr_ctx is only used by the obsolete osmo_counters which are not used anymore. tall_msgb_ctx is now set through msgb_tallox_ctx_init(). Fixes undefined reference errors since libosmocore.map was introduced in I13169c00a59fb59513dfc598de5a71d094492422: ``` osmo-pcap/src/osmo_client_main.c:226: undefined reference to `tall_msgb_ctx' /usr/bin/ld: osmo-pcap/src/osmo_client_main.c:226: undefined reference to `tall_msgb_ctx' /usr/bin/ld: osmo-pcap/src/osmo_client_main.c:227: undefined reference to `tall_ctr_ctx' /usr/bin/ld: osmo-pcap/src/osmo_client_main.c:227: undefined reference to `tall_ctr_ctx' ``` Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f --- M src/osmo_client_main.c M src/osmo_server_main.c 2 files changed, 25 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c index 3033b15..8ca2df3 100644 --- a/src/osmo_client_main.c +++ b/src/osmo_client_main.c @@ -51,8 +51,6 @@ void *tall_cli_ctx; struct osmo_pcap_client *pcap_client; -extern void *tall_msgb_ctx; -extern void *tall_ctr_ctx; static const struct rate_ctr_desc pcap_client_ctr_desc[] = { @@ -223,8 +221,7 @@ static void talloc_init_ctx() { tall_cli_ctx = talloc_named_const(NULL, 0, "client"); - tall_msgb_ctx = talloc_named_const(tall_cli_ctx, 0, "msgb"); - tall_ctr_ctx = talloc_named_const(tall_cli_ctx, 0, "counter"); + msgb_talloc_ctx_init(tall_cli_ctx, 0); } int main(int argc, char **argv) diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 484b51d..8ad89ba 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -52,8 +52,6 @@ void *tall_srv_ctx; struct osmo_pcap_server *pcap_server; -extern void *tall_msgb_ctx; -extern void *tall_ctr_ctx; static const struct rate_ctr_desc pcap_peer_ctr_desc[] = { @@ -235,8 +233,7 @@ static void talloc_init_ctx() { tall_srv_ctx = talloc_named_const(NULL, 0, "server"); - tall_msgb_ctx = talloc_named_const(tall_srv_ctx, 0, "msgb"); - tall_ctr_ctx = talloc_named_const(tall_srv_ctx, 0, "counter"); + msgb_talloc_ctx_init(tall_srv_ctx, 0); } int main(int argc, char **argv) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f Gerrit-Change-Number: 31586 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023