February 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-iuh[master]: test-ranap: don't use libosmocore's tall_msgb_ctx

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31587 ) Change subject: test-ranap: don't use libosmocore's tall_msgb_ctx ...................................................................... test-ranap: don't use libosmocore's tall_msgb_ctx Use msgb_ctx from test_common.c instead, which is the same pointer after test_common_init() ran. tall_msgb_ctx from libosmocore is no longer getting exported since I13169c00a59fb59513dfc598de5a71d094492422. Fix for: /usr/bin/ld: test-ranap.o: in function `main': /build/src/tests/test-ranap.c:201: undefined reference to `tall_msgb_ctx' /usr/bin/ld: /build/src/tests/test-ranap.c:201: undefined reference to `tall_msgb_ctx' Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb --- M src/tests/test-ranap.c M src/tests/test_common.c 2 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/87/31587/1 diff --git a/src/tests/test-ranap.c b/src/tests/test-ranap.c index 633bb2b..e593bd9 100644 --- a/src/tests/test-ranap.c +++ b/src/tests/test-ranap.c @@ -32,7 +32,7 @@ #include "test_common.h" -extern void *tall_msgb_ctx; +extern void *msgb_ctx; static void test_aper_int(uint32_t inp) { @@ -198,7 +198,7 @@ printf("report\n"); talloc_report(talloc_asn1_ctx, stdout); - talloc_report(tall_msgb_ctx, stdout); + talloc_report(msgb_ctx, stdout); //talloc_report(NULL, stdout); test_common_cleanup(); diff --git a/src/tests/test_common.c b/src/tests/test_common.c index 187a269..36d9954 100644 --- a/src/tests/test_common.c +++ b/src/tests/test_common.c @@ -71,7 +71,7 @@ }; static void *tall_hnb_ctx; -static void *msgb_ctx; +void *msgb_ctx; int test_common_init(void) { -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb Gerrit-Change-Number: 31587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31586 ) Change subject: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx ...................................................................... osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx tall_ctr_ctx is only used by the obsolete osmo_counters which are not used anymore. tall_msgb_ctx is now set through msgb_tallox_ctx_init(). Fixes undefined reference errors since libosmocore.map was introduced in I13169c00a59fb59513dfc598de5a71d094492422: ``` osmo-pcap/src/osmo_client_main.c:226: undefined reference to `tall_msgb_ctx' /usr/bin/ld: osmo-pcap/src/osmo_client_main.c:226: undefined reference to `tall_msgb_ctx' /usr/bin/ld: osmo-pcap/src/osmo_client_main.c:227: undefined reference to `tall_ctr_ctx' /usr/bin/ld: osmo-pcap/src/osmo_client_main.c:227: undefined reference to `tall_ctr_ctx' ``` Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f --- M src/osmo_client_main.c M src/osmo_server_main.c 2 files changed, 25 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/86/31586/1 diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c index 3033b15..8ca2df3 100644 --- a/src/osmo_client_main.c +++ b/src/osmo_client_main.c @@ -51,8 +51,6 @@ void *tall_cli_ctx; struct osmo_pcap_client *pcap_client; -extern void *tall_msgb_ctx; -extern void *tall_ctr_ctx; static const struct rate_ctr_desc pcap_client_ctr_desc[] = { @@ -223,8 +221,7 @@ static void talloc_init_ctx() { tall_cli_ctx = talloc_named_const(NULL, 0, "client"); - tall_msgb_ctx = talloc_named_const(tall_cli_ctx, 0, "msgb"); - tall_ctr_ctx = talloc_named_const(tall_cli_ctx, 0, "counter"); + msgb_talloc_ctx_init(tall_cli_ctx, 0); } int main(int argc, char **argv) diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 484b51d..8ad89ba 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -52,8 +52,6 @@ void *tall_srv_ctx; struct osmo_pcap_server *pcap_server; -extern void *tall_msgb_ctx; -extern void *tall_ctr_ctx; static const struct rate_ctr_desc pcap_peer_ctr_desc[] = { @@ -235,8 +233,7 @@ static void talloc_init_ctx() { tall_srv_ctx = talloc_named_const(NULL, 0, "server"); - tall_msgb_ctx = talloc_named_const(tall_srv_ctx, 0, "msgb"); - tall_ctr_ctx = talloc_named_const(tall_srv_ctx, 0, "counter"); + msgb_talloc_ctx_init(tall_srv_ctx, 0); } int main(int argc, char **argv) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f Gerrit-Change-Number: 31586 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

[M] Change in osmo-bsc[master]: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH

by Jenkins Builder

Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31578 ) Change subject: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/pcu_sock.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4139): https://gerrit.osmocom.org/c/osmo-bsc/+/31578/comment/358d89b3_0bdd470a PS2, Line 575: pch_dt = (struct gsm_pcu_if_pch_dt*)data_req->data; "(foo*)" should be "(foo *)" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id6acbd243adf26169e5e8319dd66bb68dd6a3c22 Gerrit-Change-Number: 31578 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:06:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[M] Change in osmo-bsc[master]: pcu_sock: activate/deactivate PDCH on pcu reconnect

by Jenkins Builder

Attention is currently required from: neels, fixeria, dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31497 ) Change subject: pcu_sock: activate/deactivate PDCH on pcu reconnect ...................................................................... Patch Set 4: (3 comments) File doc/timeslot.msc: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4137): https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/33b1fa51_708044fc PS4, Line 96: ...; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4137): https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/195d4657_1656cc64 PS4, Line 105: ...; trailing whitespace File include/osmocom/bsc/timeslot_fsm.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4137): https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/fbffbe7c_ccd5825b PS4, Line 46: /* BSC co-located PCU disconnects from PCU socket, deactive PDCH */ 'deactive' may be misspelled - perhaps 'deactivate'? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ea0c53a5e68a51c781ef43bae71f947cdb95678 Gerrit-Change-Number: 31497 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:06:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-bsc[master]: timeslot_fsm: fix sourcecode indenting

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31498 ) Change subject: timeslot_fsm: fix sourcecode indenting ...................................................................... timeslot_fsm: fix sourcecode indenting Change-Id: I1cfd377cd8014e42aa45f9f0da664598ee88e02d --- M include/osmocom/bsc/timeslot_fsm.h 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved dexter: Verified diff --git a/include/osmocom/bsc/timeslot_fsm.h b/include/osmocom/bsc/timeslot_fsm.h index 526f3cf..cea1e4c 100644 --- a/include/osmocom/bsc/timeslot_fsm.h +++ b/include/osmocom/bsc/timeslot_fsm.h @@ -37,9 +37,9 @@ TS_EV_LCHAN_REQUESTED, TS_EV_LCHAN_UNUSED, TS_EV_PDCH_ACT_ACK, - TS_EV_PDCH_ACT_NACK, - TS_EV_PDCH_DEACT_ACK, - TS_EV_PDCH_DEACT_NACK, + TS_EV_PDCH_ACT_NACK, + TS_EV_PDCH_DEACT_ACK, + TS_EV_PDCH_DEACT_NACK, }; void ts_fsm_alloc(struct gsm_bts_trx_ts *ts); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1cfd377cd8014e42aa45f9f0da664598ee88e02d Gerrit-Change-Number: 31498 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-bsc[master]: timeslot_fsm: fix sourcecode indenting

by dexter

Attention is currently required from: neels. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31498 ) Change subject: timeslot_fsm: fix sourcecode indenting ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1cfd377cd8014e42aa45f9f0da664598ee88e02d Gerrit-Change-Number: 31498 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:01:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[XL] Change in osmo-pcu[master]: support for Ericsson RBS E1 CCU

by dexter

Attention is currently required from: neels. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31176 ) Change subject: support for Ericsson RBS E1 CCU ...................................................................... Patch Set 15: (10 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/60a6536f_51baf6aa PS13, Line 10: BTS > BSC ? Done https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/30fc01fb_3adf33fd PS13, Line 15: fun > fun?? =) Done File src/ericsson-rbs/er_ccu_if.c: https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/fcf7ca0a_f683c037 PS13, Line 62: /* called by trau frame synchronizer: feed received MAC blocks into PCU */ > does it make sense to document who calls the function? usually we just describe what it does? There are multiple callbacks in this c file used by different entities (->demux->synchronizer->) I think the comment helps to make sense since it helps to follow the path better. https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/f7899371_902a94cd PS13, Line 76: multeiplexer > multiplexer Done https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/e7cb34e8_267457ec PS13, Line 90: multeiplexer > i Done https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/efa69b66_b4c70a28 PS13, Line 99: Function to > (drop the first two words) Done https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/7eacc5f3_850e9866 PS13, Line 122: , > (nicer to start a new line for osmo_hexdump) I think its better to have it in one line. I agree its a bit long but too many lines also make the log more difficult to read. Especially when grepping for things. https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/eed0b53e_ffe2f48a PS13, Line 143: (line=%u,ts=%u) > seems this log context occurs in several places, welcome a LOG_FOO() macro instead of code dup. […] There is already a LOGPCCU. (line=%u,ts=%u) is only used three times where I couln'd use LOGPCCU. https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/0a5a2e99_e0674cc1 PS13, Line 146: Note > "Note"? =) Done https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/01dd58cb_73f7fad0 PS13, Line 184: /* NOTE: This is a serious error: subslots should be removed when l1if_close_pdch() is called by the PCU. This > (seems this comment wants to be inside the if { .. } body.) […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5c0a76667339ca984a12cbd2052f5d9e5b0f9c4d Gerrit-Change-Number: 31176 Gerrit-PatchSet: 15 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:00:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[XL] Change in osmo-pcu[master]: support for Ericsson RBS E1 CCU

by dexter

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31176 to look at the new patch set (#15). Change subject: support for Ericsson RBS E1 CCU ...................................................................... support for Ericsson RBS E1 CCU Ericsson RBS series BTSs do not have a built in PCU. Rather than having the PCU on board the PCU is co-located to the BSC in those cases. Just like the MGW the PCU would connect to the CCU (Channel Coding Unit) via E1 line. The PCU is connected via an unix domain socket (pcu_sock) to the BSC to receive RACH requests and to control Paging and TBF assignment. This patch adds all the required functionality to run an Ercisson RBS in GPRS/EGPRS mode. It supports 16k I.460 E1 subslots and full 64k E1 timeslots (recommended) Change-Id: I5c0a76667339ca984a12cbd2052f5d9e5b0f9c4d Related: OS#5198 --- M configure.ac M src/Makefile.am A src/ericsson-rbs/er_ccu_descr.h A src/ericsson-rbs/er_ccu_if.c A src/ericsson-rbs/er_ccu_if.h A src/ericsson-rbs/er_ccu_l1_if.c A src/ericsson-rbs/er_ccu_l1_if.h M src/gprs_debug.c M src/gprs_debug.h M src/pcu_l1_if.cpp M src/pcu_l1_if.h 11 files changed, 1,142 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/31176/15 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5c0a76667339ca984a12cbd2052f5d9e5b0f9c4d Gerrit-Change-Number: 31176 Gerrit-PatchSet: 15 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[S] Change in osmo-bsc[master]: osmo_bsc_main: don't allocate talloc_ctr_ctx

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31583 ) Change subject: osmo_bsc_main: don't allocate talloc_ctr_ctx ...................................................................... osmo_bsc_main: don't allocate talloc_ctr_ctx tall_ctr_ctx is not defined or used in osmo-bsc and apparently was only exported by accident from libosmocore. It's not exported anymore since libosmocore.map was introduced in I13169c00a59fb59513dfc598de5a71d094492422. Fix for: /usr/bin/ld: osmo_bsc_main.o: in function `main': osmo_bsc_main.c:(.text+0x830d): undefined reference to `tall_ctr_ctx' /usr/bin/ld: osmo_bsc_main.c:(.text+0x8331): undefined reference to `tall_ctr_ctx' Change-Id: I558e1ec722f3b1ff1f2e89b3cb97ed1dba9063e3 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index d33cbc0..5ad13ca 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -830,7 +830,6 @@ extern void *tall_paging_ctx; extern void *tall_fle_ctx; extern void *tall_tqe_ctx; -extern void *tall_ctr_ctx; static int bsc_mgw_setup(void) { @@ -881,7 +880,6 @@ tall_paging_ctx = talloc_named_const(tall_bsc_ctx, 0, "paging_request"); tall_fle_ctx = talloc_named_const(tall_bsc_ctx, 0, "bs11_file_list_entry"); tall_tqe_ctx = talloc_named_const(tall_bsc_ctx, 0, "subch_txq_entry"); - tall_ctr_ctx = talloc_named_const(tall_bsc_ctx, 0, "counter"); osmo_init_logging2(tall_bsc_ctx, &log_info); osmo_stats_init(tall_bsc_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31583 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I558e1ec722f3b1ff1f2e89b3cb97ed1dba9063e3 Gerrit-Change-Number: 31583 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-bsc[master]: osmo_bsc_main: don't allocate talloc_ctr_ctx

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31583 ) Change subject: osmo_bsc_main: don't allocate talloc_ctr_ctx ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31583 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I558e1ec722f3b1ff1f2e89b3cb97ed1dba9063e3 Gerrit-Change-Number: 31583 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 09:58:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023