February 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:43:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Don't you need to remove the symbol too? I should, yeah.. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:41:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by daniel

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 to look at the new patch set (#2). Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... osmo_{client,server}_main: Remove is_config_node in vty_app_info This member is deprcated/unused so simply remove it: > 'is_config_node' is deprecated: Implicit parent node tracking has > replaced the use of this callback. This callback is no longer called, > ever, and can be left NULL. Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 --- M src/osmo_client_main.c M src/osmo_common.c M src/osmo_server_main.c 3 files changed, 15 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/88/31588/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:37:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:33:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... Patch Set 3: (1 comment) File src/core/libosmocore.map: https://gerrit.osmocom.org/c/libosmocore/+/31590/comment/f13c0d67_9e33e6b7 PS2, Line 562: tall_ctr_ctx; > Maybe add comments in here regarding only exported due to historical reasons and are actually deprec […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:33:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31590 to look at the new patch set (#4). Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... libosmocore.map: add tall_{ctr/msgb}_ctx These should not be used, but add them for backwards compatibility with building older versions of osmo-bsc, osmo-iuh, osmo-pcap against current libosmocore. Fixes: 213fc420 ("Add libosmocore.map") Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d --- M src/core/libosmocore.map 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/31590/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[S] Change in libosmo-sccp[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M examples/sccp_demo_user.c M stp/stp_main.c M tests/vty/ss7_asp_vty_test.c 3 files changed, 13 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index df6c9af..a88dd69 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -285,8 +285,7 @@ } } - rc = telnet_init_dynif(NULL, NULL, config_file ? vty_get_bind_addr() : local_address, - 2324+client); + rc = telnet_init_default(NULL, NULL, 2324 + client); if (rc < 0) { perror("Error binding VTY port"); exit(1); diff --git a/stp/stp_main.c b/stp/stp_main.c index 569cf8e..01d1865 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -243,7 +243,7 @@ exit(1); } - rc = telnet_init_dynif(tall_stp_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_STP); + rc = telnet_init_default(tall_stp_ctx, NULL, OSMO_VTY_PORT_STP); if (rc < 0) { perror("Error binding VTY port\n"); exit(1); diff --git a/tests/vty/ss7_asp_vty_test.c b/tests/vty/ss7_asp_vty_test.c index 80ce3ec..5423f6f 100644 --- a/tests/vty/ss7_asp_vty_test.c +++ b/tests/vty/ss7_asp_vty_test.c @@ -182,7 +182,7 @@ } } - rc = telnet_init_dynif(root_ctx, NULL, vty_get_bind_addr(), 42043); + rc = telnet_init_default(root_ctx, NULL, 42043); if (rc < 0) return 2; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31516 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-sgsn[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M src/gtphub/gtphub_main.c M src/sgsn/sgsn_main.c 2 files changed, 12 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/gtphub/gtphub_main.c b/src/gtphub/gtphub_main.c index d25123e..9b0532b 100644 --- a/src/gtphub/gtphub_main.c +++ b/src/gtphub/gtphub_main.c @@ -354,8 +354,7 @@ } /* start telnet after reading config for vty_get_bind_addr() */ - rc = telnet_init_dynif(osmo_gtphub_ctx, 0, vty_get_bind_addr(), - OSMO_VTY_PORT_GTPHUB); + rc = telnet_init_default(osmo_gtphub_ctx, NULL, OSMO_VTY_PORT_GTPHUB); if (rc < 0) exit(1); diff --git a/src/sgsn/sgsn_main.c b/src/sgsn/sgsn_main.c index 04de6a2..d6afdef 100644 --- a/src/sgsn/sgsn_main.c +++ b/src/sgsn/sgsn_main.c @@ -442,8 +442,7 @@ } /* start telnet after reading config for vty_get_bind_addr() */ - rc = telnet_init_dynif(tall_sgsn_ctx, NULL, - vty_get_bind_addr(), OSMO_VTY_PORT_SGSN); + rc = telnet_init_default(tall_sgsn_ctx, NULL, OSMO_VTY_PORT_SGSN); if (rc < 0) exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31523 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:31:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023