Attention is currently required from: neels, fixeria, dexter.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31497 )
Change subject: pcu_sock: activate/deactivate PDCH on pcu reconnect
......................................................................
Patch Set 4:
(3 comments)
File doc/timeslot.msc:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4137):
https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/33b1fa51_708044fc
PS4, Line 96: ...;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4137):
https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/195d4657_1656cc64
PS4, Line 105: ...;
trailing whitespace
File include/osmocom/bsc/timeslot_fsm.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4137):
https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/fbffbe7c_ccd5825b
PS4, Line 46: /* BSC co-located PCU disconnects from PCU socket, deactive PDCH */
'deactive' may be misspelled - perhaps 'deactivate'?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31497
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9ea0c53a5e68a51c781ef43bae71f947cdb95678
Gerrit-Change-Number: 31497
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 10:06:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment