lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

February 2023

  • 1 participants
  • 2601 discussions
[S] Change in osmo-ttcn3-hacks[master]: pgw: stop components early if test fails
by pespin 28 Feb '23

28 Feb '23
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31596 ) Change subject: pgw: stop components early if test fails ...................................................................... pgw: stop components early if test fails Change-Id: I3465a421a4b2a3fce72a1c54037d8dc2b4e3a0fe --- M pgw/PGW_Tests.ttcn 1 file changed, 27 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/31596/1 diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 8a25ebf..adae0a4 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -632,17 +632,20 @@ process_bctx_create(bctx); } case ('0001'B) { // removed - setverdict(fail, "We don't expect removed bearer contexts yet"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "We don't expect removed bearer contexts yet"); } } } } [] GTP2.receive(tr_GTP2C_CreateSessionResp(d_teid:=g_teic, cause:=?)) -> value rx { - setverdict(fail, "Unexpected CreateSessionResp(cause=", - rx.gtpcv2_pdu.createSessionResponse.cause.causeValue, ")"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Unexpected CreateSessionResp(cause=", + rx.gtpcv2_pdu.createSessionResponse.cause.causeValue, ")")); } [] GTP2.receive { - setverdict(fail, "Unexpected GTPv2 while waiting for CreateSessionResp"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Unexpected GTPv2 while waiting for CreateSessionResp"); } } @@ -673,10 +676,12 @@ setverdict(pass); } [] GTP2.receive(tr_GTP2C_DeleteSessionResp(?, ?)) { - setverdict(fail, "Unexpected DeleteSessionResp"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Unexpected DeleteSessionResp"); } [] GTP2.receive { - setverdict(fail, "Unexpected GTPv2 while waiting for DeleteSessionResp"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Unexpected GTPv2 while waiting for DeleteSessionResp"); } } @@ -712,7 +717,8 @@ log("Starting a program: ", command); var UECUPS_StartProgramRes res := f_gtp2_start_program(sprog); if (res.result != OK) { - setverdict(fail, "Unable to start program '", command, "'"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Unable to start program '", command, "'")); } return res.pid; } @@ -730,10 +736,12 @@ setverdict(pass); } [] GTP2.receive(UECUPS_ProgramTermInd:?) -> value pti { - setverdict(fail, "Received unexpected ProgramTermInd := ", pti); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received unexpected ProgramTermInd := ", pti)); } [] T.timeout { - setverdict(fail, "timeout waiting for user-plane program termination"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "timeout waiting for user-plane program termination"); } } } @@ -778,7 +786,7 @@ setverdict(pass); } [] T.timeout { - setverdict(fail, "timeout waiting for Echo Response"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "timeout waiting for Echo Response"); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3465a421a4b2a3fce72a1c54037d8dc2b4e3a0fe Gerrit-Change-Number: 31596 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[M] Change in osmo-bsc[master]: pcu_sock: activate/deactivate PDCH on pcu reconnect
by dexter 28 Feb '23

28 Feb '23
Attention is currently required from: neels, fixeria, dexter. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31497 to look at the new patch set (#5). Change subject: pcu_sock: activate/deactivate PDCH on pcu reconnect ...................................................................... pcu_sock: activate/deactivate PDCH on pcu reconnect When the PCU is disconnected while the BSC keeps running the PDCH should be closed. Also the PDCH should be reopened when the PCU is reconnected. Change-Id: I9ea0c53a5e68a51c781ef43bae71f947cdb95678 Related: OS#5198 --- M doc/timeslot.msc M include/osmocom/bsc/timeslot_fsm.h M src/osmo-bsc/pcu_sock.c M src/osmo-bsc/timeslot_fsm.c 4 files changed, 112 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/31497/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ea0c53a5e68a51c781ef43bae71f947cdb95678 Gerrit-Change-Number: 31497 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
[M] Change in osmo-mgw[master]: mgcp_sdp: add fmtp string to define HR GSM RTP format
by pespin 28 Feb '23

28 Feb '23
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 ) Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ...................................................................... Patch Set 10: (4 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/b7f7d957_a0203c85 PS10, Line 705: case GSM_HR_BYTES + sizeof(struct rtp_hdr): if possible order the fields left to right based on the order you encounter them in the pkt. https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/94877e38_ee6f532d PS10, Line 741: bool convert = false; can be dropped. https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/59257e91_d17bf92c PS10, Line 746: convert = true; return true; https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/8fa69cd4_49258296 PS10, Line 750: convert = true; return true; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 13:36:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
[S] Change in osmo-mgw[master]: mgcp_client: fix sourcecode formatting
by dexter 28 Feb '23

28 Feb '23
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31406 ) ( 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mgcp_client: fix sourcecode formatting ...................................................................... mgcp_client: fix sourcecode formatting Change-Id: I55f98379ea48ffddc25186c15e4dd40762e818b6 --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 0434e70..81847ee 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -1006,11 +1006,8 @@ return epname; } -struct mgcp_response_pending * mgcp_client_pending_add( - struct mgcp_client *mgcp, - mgcp_trans_id_t trans_id, - mgcp_response_cb_t response_cb, - void *priv) +struct mgcp_response_pending *mgcp_client_pending_add(struct mgcp_client *mgcp, mgcp_trans_id_t trans_id, + mgcp_response_cb_t response_cb, void *priv) { struct mgcp_response_pending *pending; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I55f98379ea48ffddc25186c15e4dd40762e818b6 Gerrit-Change-Number: 31406 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[S] Change in libosmocore[master]: bts_features: Add features for HR formats (TS 101813 vs. RFC5993)
by pespin 28 Feb '23

28 Feb '23
Attention is currently required from: neels, fixeria, msuraev, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31415 ) Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ...................................................................... Patch Set 8: (1 comment) File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/dfc81cd8_142911f5 PS7, Line 39: _TX > In a correctly configured setup we should always see the same format in both directions. If you say so... I don't think that's really stated anywhere in the spec, and sounds like a personal expectancy of what a "correctly configured setup" is imho 😊 > I thought the OML feature flags were introduced for things like this Yes, to know that a BTS supports a given feature. Not to indicate which of the several supported is to be used. > BTS model is a PHY based model with TS 101318 support or an osmo-trx based model with RFC 5993 support. So our osmo-bts-sysmo is transmitting different RTP type than our osmo-bts-trx? what a mess! 😮 > The BSC knows that it talks to an osmo-bts, but it does not know if this BTS model My point is only that you still need to store that in osmo-bsc hardcoded somehow for other types of BTS, like nanobts, etc. so you could simply do the same for osmobts (you will need this for older versions of osmo-bts anyway). Maybe that's actually done using this set of features? > BTS model is a PHY based model with TS 101318 support or an osmo-trx based model with RFC 5993 support. So our osmo-bts-sysmo is transmitting different RTP type than our osmo-bts-trx? what a mess! :O > Extending IPACC can be also a way, here we can at least be sure that osmo-bts type BTSs will support the extension but we will have to make sure that older osmo-bts versions will tolerate/ignore the extensions. Yes, have a look if adding the new IE is really a problem for old versions (I think it won't be an issue). If it was, then you could add a new BTS feature stating whether the BTS supports this new IE and then only send it based on it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 Gerrit-Change-Number: 31415 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 13:33:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-mgw[master]: mgcp_sdp: add fmtp string to define HR GSM RTP format
by dexter 28 Feb '23

28 Feb '23
Attention is currently required from: pespin, dexter. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 to look at the new patch set (#10). Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ...................................................................... mgcp_sdp: add fmtp string to define HR GSM RTP format There are two different RTP HR GSM formats defined (TS 101.318 and RFC5993). Lets add an fmtp parameter In order to select between the two formats (and convert if necessary) via MGCP/SDP. Unfortunately there is no official fmtp string defined, so we have to define an osmocom specific string. Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Related: OS#5688 --- M include/osmocom/mgcp/mgcp_common.h M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_sdp.c 4 files changed, 102 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/14/31214/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
[S] Change in libosmocore[master]: osmo_wqueue_enqueue(): Avoid redundant if-check
by pespin 28 Feb '23

28 Feb '23
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31591 ) Change subject: osmo_wqueue_enqueue(): Avoid redundant if-check ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'm not sure it's really worth it and it's clearer the way it is now. So I vote for not merging this. If enough think differently then I won't block. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3ecc1698e836ca40e178a5b84c2946ae0e6bbfc9 Gerrit-Change-Number: 31591 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 13:23:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-mgw[master]: mgcp_sdp: add fmtp string to define HR GSM RTP format
by Jenkins Builder 28 Feb '23

28 Feb '23
Attention is currently required from: pespin, dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 ) Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ...................................................................... Patch Set 9: (4 comments) File src/libosmo-mgcp/mgcp_network.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/00e89359_c2fc46e4 PS9, Line 704: switch(msgb_length(msg)) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/dc1b001a_398a1359 PS9, Line 704: switch(msgb_length(msg)) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/cb2a49a9_6640a804 PS9, Line 706: case GSM_HR_BYTES + sizeof(struct rtp_hdr): code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/89d6e140_9512b368 PS9, Line 706: case GSM_HR_BYTES + sizeof(struct rtp_hdr): please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 13:21:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by pespin 28 Feb '23

28 Feb '23
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 ) Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 3: Code-Review-1 (3 comments) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/71841978_da3ed4aa PS2, Line 1092: return -1; > It doesn't change the control flow afaik (I looked at `osmo_wqueue_bfd_cb()`). […] osmo_wqueue_bfd_cb: if (rc == -EBADF) goto err_badfd; You have to return -EBADF while handling the socket fd if you close/free it, otherwise osmo_wqueue_bfd_cb() continues using it and potentially calling the write_cb for a fd/mem which is no longer existing which can cause problems. https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/1c4ccd75_92870a87 PS2, Line 1102: osmo_fd_write_disable(&state->upqueue.bfd); > From my understanding/by looking at this code, it looks like `osmo_fd_write_disable()` is meant to p […] that's not to prevent concurrent write-access. It's to manage the main loop poll() to tell the kernel to trigger us when the socket is available for writing again. https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/be99ebb8_52a56719 PS2, Line 1181: osmo_wqueue_init(&state->upqueue, PCU_SOCK_QLENGTH_MAX_DEFAULT); > No it's not possible, with the current code the current length of the wqueue is always incremented/t […] I'm fine with whatever but use WQUEUE instead of the QLENGTH stuff :) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 13:21:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by pespin 28 Feb '23

28 Feb '23
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 ) Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 3: (1 comment) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/10227697_0c0939c4 PS3, Line 993: LOGP(DLGLOBAL, LOGL_NOTICE, "PCU not reacting (more thatn %u messages waiting). Closing connection\n", typo: than -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 13:17:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 6
  • 7
  • 8
  • 9
  • 10
  • 11
  • 12
  • ...
  • 261
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.