Attention is currently required from: pespin, dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 ) Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ...................................................................... Patch Set 9: (4 comments) File src/libosmo-mgcp/mgcp_network.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/00e89359_c2fc46e4 PS9, Line 704: switch(msgb_length(msg)) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/dc1b001a_398a1359 PS9, Line 704: switch(msgb_length(msg)) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/cb2a49a9_6640a804 PS9, Line 706: case GSM_HR_BYTES + sizeof(struct rtp_hdr): code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4169): https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/89d6e140_9512b368 PS9, Line 706: case GSM_HR_BYTES + sizeof(struct rtp_hdr): please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 13:21:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment