February 2023 - gerrit-log - lists.osmocom.org

[M] Change in docker-playground[master]: docker kill: wait until containers are stopped

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31598 ) Change subject: docker kill: wait until containers are stopped ...................................................................... docker kill: wait until containers are stopped As "docker kill" / "docker container kill" (alias) doesn't block until the given container stops, make sure to always run "docker wait" afterwards. Closes: OS#5928 Change-Id: I0242ece96541d8036ebbf8b0f498ebf231db26b5 --- M jenkins-common.sh M osmo-cn-latest/run.sh M osmo-ran/split/jenkins-split.sh M scripts/regen_doc.sh M ttcn3-bts-test/jenkins.sh M ttcn3-fr-test/jenkins.sh M ttcn3-hnbgw-test/jenkins.sh M ttcn3-hnodeb-test/jenkins.sh M ttcn3-remsim-test/jenkins.sh 9 files changed, 46 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/98/31598/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index b09db58..ec91b3f 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -190,9 +190,24 @@ done } +# Kill a docker container and ensure it doesn't exist anymore (OS#5928) +docker_kill_wait() { + docker kill "$1" + docker wait "$1" || true +} + #kills all containers attached to network network_clean() { - docker network inspect $NET_NAME | grep Name | cut -d : -f2 | awk -F\" 'NR>1{print $2}' | xargs -rn1 docker kill + local containers="$(docker network inspect $NET_NAME | grep Name | cut -d : -f2 | awk -F\" 'NR>1{print $2}')" + local container + + if [ -z "$containers" ]; then + return + fi + + for container in $containers; do + docker_kill_wait "$container" + done } # Create network and find a free subnet automatically. The global variables diff --git a/osmo-cn-latest/run.sh b/osmo-cn-latest/run.sh index d7bba95..4745ee3 100755 --- a/osmo-cn-latest/run.sh +++ b/osmo-cn-latest/run.sh @@ -28,6 +28,6 @@ echo Stopping containers -docker container kill osmo-cn +docker_kill_wait osmo-cn network_remove diff --git a/osmo-ran/split/jenkins-split.sh b/osmo-ran/split/jenkins-split.sh index 5cecf4a..58c1aea 100755 --- a/osmo-ran/split/jenkins-split.sh +++ b/osmo-ran/split/jenkins-split.sh @@ -69,7 +69,7 @@ kill_containers() { for i in "${docker_names[@]}"; do - docker kill $i + docker_kill_wait $i done } diff --git a/scripts/regen_doc.sh b/scripts/regen_doc.sh index 27c3138..fdc9da2 100755 --- a/scripts/regen_doc.sh +++ b/scripts/regen_doc.sh @@ -51,6 +51,6 @@ -H "172.18.$SUBNET.23" \ -O "$VTYFILE" -docker container kill "${BUILD_TAG}-$NAME-$IMAGE_SUFFIX" +docker_kill_wait "${BUILD_TAG}-$NAME-$IMAGE_SUFFIX" network_remove diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 0c1cbb0..ed1e095 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -168,9 +168,9 @@ # 2) some GPRS tests require virt_phy echo "Changing to virtphy configuration" # switch from osmo-bts-trx + trxcon + faketrx to virtphy + osmo-bts-virtual -docker container kill ${BUILD_TAG}-trxcon -docker container kill ${BUILD_TAG}-fake_trx -docker container kill ${BUILD_TAG}-bts +docker_kill_wait ${BUILD_TAG}-trxcon +docker_kill_wait ${BUILD_TAG}-fake_trx +docker_kill_wait ${BUILD_TAG}-bts cp virtphy/osmo-bts.gen.cfg $VOL_BASE_DIR/bts/ network_replace_subnet_in_configs start_bts virtual 0 @@ -179,10 +179,10 @@ #start_testsuite virtphy # 3) OML tests require us to run without BSC -docker container kill ${BUILD_TAG}-bsc +docker_kill_wait ${BUILD_TAG}-bsc # switch back from virtphy + osmo-bts-virtual to osmo-bts-trx -docker container kill ${BUILD_TAG}-virtphy -docker container kill ${BUILD_TAG}-bts +docker_kill_wait ${BUILD_TAG}-virtphy +docker_kill_wait ${BUILD_TAG}-bts cp oml/osmo-bts.gen.cfg $VOL_BASE_DIR/bts/ network_replace_subnet_in_configs @@ -196,7 +196,7 @@ cp fh/osmo-bsc.gen.cfg $VOL_BASE_DIR/bsc/ cp generic/osmo-bts.gen.cfg $VOL_BASE_DIR/bts/ # restart the BSC/BTS and run the testsuite again -docker container kill ${BUILD_TAG}-bts +docker_kill_wait ${BUILD_TAG}-bts network_replace_subnet_in_configs start_bsc start_bts trx 1 diff --git a/ttcn3-fr-test/jenkins.sh b/ttcn3-fr-test/jenkins.sh index 12e14a5..36bb77b 100755 --- a/ttcn3-fr-test/jenkins.sh +++ b/ttcn3-fr-test/jenkins.sh @@ -10,7 +10,7 @@ clean_up() { # kill the frnet container to avoid "You cannot remove a running container " below in 'rm' - docker kill ${BUILD_TAG}-frnet || true + docker_kill_wait ${BUILD_TAG}-frnet || true # store execution logs for both containers docker logs --timestamps ${BUILD_TAG}-ttcn3-fr-test > $VOL_BASE_DIR/fr-tester/exec.log || true diff --git a/ttcn3-hnbgw-test/jenkins.sh b/ttcn3-hnbgw-test/jenkins.sh index f3c5694..e93c8af 100755 --- a/ttcn3-hnbgw-test/jenkins.sh +++ b/ttcn3-hnbgw-test/jenkins.sh @@ -74,8 +74,8 @@ $REPO_USER/ttcn3-hnbgw-test echo Stopping containers - docker container kill ${BUILD_TAG}-hnbgw - docker container kill ${BUILD_TAG}-stp + docker_kill_wait ${BUILD_TAG}-hnbgw + docker_kill_wait ${BUILD_TAG}-stp } echo Testing without PFCP diff --git a/ttcn3-hnodeb-test/jenkins.sh b/ttcn3-hnodeb-test/jenkins.sh index 21e72c0..3b57fd8 100755 --- a/ttcn3-hnodeb-test/jenkins.sh +++ b/ttcn3-hnodeb-test/jenkins.sh @@ -45,4 +45,4 @@ $REPO_USER/ttcn3-hnodeb-test echo Stopping containers -docker container kill ${BUILD_TAG}-hnodeb +docker_kill_wait ${BUILD_TAG}-hnodeb diff --git a/ttcn3-remsim-test/jenkins.sh b/ttcn3-remsim-test/jenkins.sh index a7325e7..158a352 100755 --- a/ttcn3-remsim-test/jenkins.sh +++ b/ttcn3-remsim-test/jenkins.sh @@ -80,7 +80,7 @@ network_replace_subnet_in_configs start_server start_testsuite -docker container kill ${BUILD_TAG}-server +docker_kill_wait ${BUILD_TAG}-server # 2) bankd test suite echo "Changing to bankd configuration" @@ -89,7 +89,7 @@ network_replace_subnet_in_configs start_bankd start_testsuite -docker container kill ${BUILD_TAG}-bankd +docker_kill_wait ${BUILD_TAG}-bankd # 3) client test suite echo "Changing to client configuration" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0242ece96541d8036ebbf8b0f498ebf231db26b5 Gerrit-Change-Number: 31598 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

[S] Change in libosmocore[master]: Add osmo_sockaddr_size() to return the size of the variant used

by daniel

Attention is currently required from: pespin, msuraev. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31172 ) Change subject: Add osmo_sockaddr_size() to return the size of the variant used ...................................................................... Patch Set 3: (1 comment) File include/osmocom/core/socket.h: https://gerrit.osmocom.org/c/libosmocore/+/31172/comment/4d3adf3c_a252f0aa PS1, Line 42: { > Ok, maybe add a comment in the code about this when handling this case, because it's really not intu […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I952b6bb752441fe019fc18f89bce4bbfbe58994a Gerrit-Change-Number: 31172 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 17:13:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in libosmocore[master]: Add osmo_sockaddr_size() to return the size of the variant used

by daniel

Attention is currently required from: daniel, msuraev. Hello Jenkins Builder, pespin, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31172 to look at the new patch set (#3). Change subject: Add osmo_sockaddr_size() to return the size of the variant used ...................................................................... Add osmo_sockaddr_size() to return the size of the variant used Change-Id: I952b6bb752441fe019fc18f89bce4bbfbe58994a --- M include/osmocom/core/socket.h 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/72/31172/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I952b6bb752441fe019fc18f89bce4bbfbe58994a Gerrit-Change-Number: 31172 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[M] Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

by dexter

Attention is currently required from: neels, pespin, fixeria. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 to look at the new patch set (#18). Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... bts: add IMMEDIATE ASSIGNMENT via PCH transmission In situations where the PCU is co-located to the BSC, the IMMEDIATE ASSIGNMENT for downlink TBFs must be sent via RSL and the BSC also must instruct the BTS to transmit the IMMEDIATE ASSIGNMENT via PCH instead of AGCH. Eventually the BSC must sent a confirmation message (follow-up patch) where the TLLI is used as an identifer. Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Related: OS#5198 --- M include/osmocom/pcu/pcuif_proto.h M src/bts.cpp M src/bts.h M src/pcu_l1_if.cpp M src/pcu_l1_if.h 5 files changed, 80 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/45/31145/18 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 18 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[M] Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

by dexter

Attention is currently required from: neels, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 18: (6 comments) File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/5510a419_bd202104 PS17, Line 48: #define PCU_IF_FLAG_DT (1 << 2)/* use TLLI for confirmation directly */ > I think we agreed in the call this flag was not needed. Thanks for reminding me. I wasn't sure anymore but it certainly makes sense to drop the flag and look at the PCUIIF version number instead. https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/e20bdc85_35de6adb PS17, Line 280: uint8_t pgroup[3]; > This can be a int16_t containing a number 0-999. I think this would then make using the struct at the BSC side more complicated, but I am not entirely sure. The thing is that this value ends up at extract_paging_group and this function does a str_to_imsi(imsi_digit_buf) with the value, which then ends up at libosmocore:gsm0502_calc_paging_group, which gets the IMSI as an uint64_t. If we can feed gsm0502_calc_paging_group() the pgroup value from here directly then we can use an uint16_t. (what makes me wonder a bit is that gsm0502_calc_paging_group() returns an unsigned int but we store the returned paging group in an uint8_t.) https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/851ea54f_2dfab0f6 PS17, Line 294: struct gsm_pcu_if_data_cnf_dt data_cnf_dt; > isn't it a bit weird that we have a cnf_dt but no data_dt? The message in the direction towards the BSC is sent as data_req under the SAPI PCU_IF_SAPI_PCH_DT. For the confirmation we have specific message types. That is the reason why there is no data_dt. File src/bts.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/d48a6ed7_c5eeb3ef PS17, Line 282: /* Use the TLLI directly to handle IMMEDIATE ASSIGNMENT confirmation, otherwise the TLLI is extracted > This is most probably not needed anymore and can be dropped. (see above, we still needed it, but hopefully not very long.) File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/63442e9d_6731f25d PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf))); > I thought we agreed on dropping the previous message? If we drop it now, then the PCU will become incompatible with osmo-bts. As far as I remember we decided to add a deprecation warning and upgrade osmo-bts later. Its easy to remove the code pathes later so lets not get blocked by the BTS part and keep compatibility for now. File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/d78cf3c1_09a75e9d PS17, Line 769: > this can be dropped. I have reworked this part and added the deprecation note. I also have created a ticket for the BTS part now. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 18 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 15:47:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-bsc[master]: pcuif_proto: increment version number

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31597 ) Change subject: pcuif_proto: increment version number ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8315bd67c7f3eb0d7ee71b64cd4dff889a84fcf1 Gerrit-Change-Number: 31597 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 15:01:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_sdp: add fmtp string to define HR GSM RTP format

by neels

Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 ) Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ...................................................................... Patch Set 10: (1 comment) File include/osmocom/mgcp/mgcp_common.h: https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/d64b4f29_c9638175 PS10, Line 71: enum mgcp_gsm_hr_fmt gsm_hr_format; > struct mgcp_codec_param has a fundamental problem: […] https://osmocom.org/issues/5723 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 14:03:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_sdp: add fmtp string to define HR GSM RTP format

by neels

Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 ) Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ...................................................................... Patch Set 10: Code-Review-1 (1 comment) File include/osmocom/mgcp/mgcp_common.h: https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/1701ba1a_21068860 PS10, Line 71: enum mgcp_gsm_hr_fmt gsm_hr_format; struct mgcp_codec_param has a fundamental problem: it lives in struct mgcp_msg, i.e. there can *only be one* in an entire SDP message in the osmo_mgcp_client API. However, "a=fmtp:<pt-nr>" are scoped *per payload type nr*, i.e. there should be one for every codec, not only one per SDP message. amr_octet_aligned has this problem, meaning that our MGCP client cannot offer two distinct payload types for AMR octet-aligned and AMR bandwidth-efficient. This recently bit me while working on codec resolution in osmo-msc and osmo-bsc. So far I have to decide for OA or not for *all* AMR codecs represented in our mgcp_client SDP. Let's not proliferate this problem. This probably means we first need to fix this scoping problem before adding new fmtp -- because when you make room for per-pt fmtp, might as well move the OA flag there. (If you instead would want one global flag, it would be a new X-Osmo header; but I think per pt fmtp is the right choice here) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 14:02:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[M] Change in osmo-bsc[master]: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH

by Jenkins Builder

Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31578 ) Change subject: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/pcu_sock.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4178): https://gerrit.osmocom.org/c/osmo-bsc/+/31578/comment/2804b4b8_1cc7ba13 PS3, Line 575: pch_dt = (struct gsm_pcu_if_pch_dt*)data_req->data; "(foo*)" should be "(foo *)" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id6acbd243adf26169e5e8319dd66bb68dd6a3c22 Gerrit-Change-Number: 31578 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 13:58:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-bsc[master]: pcuif_proto: increment version number

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31597 ) Change subject: pcuif_proto: increment version number ...................................................................... pcuif_proto: increment version number The co-located PCU support for Ericsson RBS E1 CCU made it necessary to add new features to the PCU socket interface, so lets increase the version number. Change-Id: I8315bd67c7f3eb0d7ee71b64cd4dff889a84fcf1 Related: OS#5198 --- M include/osmocom/bsc/pcuif_proto.h 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/31597/1 diff --git a/include/osmocom/bsc/pcuif_proto.h b/include/osmocom/bsc/pcuif_proto.h index 1d12f50..3265dfa 100644 --- a/include/osmocom/bsc/pcuif_proto.h +++ b/include/osmocom/bsc/pcuif_proto.h @@ -7,7 +7,7 @@ #define PCU_SOCK_DEFAULT "/tmp/pcu_bts" -#define PCU_IF_VERSION 0x0a +#define PCU_IF_VERSION 0x0b #define TXT_MAX_LEN 128 /* msg_type */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8315bd67c7f3eb0d7ee71b64cd4dff889a84fcf1 Gerrit-Change-Number: 31597 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023