October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: ASCI: Fix false return value checks, discovered by Coverity Scan
by fixeria 05 Oct '23

05 Oct '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34646?usp=email ) Change subject: ASCI: Fix false return value checks, discovered by Coverity Scan ...................................................................... ASCI: Fix false return value checks, discovered by Coverity Scan See: CID 32637 - 323644 Related: OS#5364 Change-Id: If72590bb94597e434386bbcd312919a71abf0aae --- M src/host/layer23/src/mobile/gsm44068_gcc_bcc.c 1 file changed, 19 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c b/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c index fa0e7bd..7bb8b29 100644 --- a/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c +++ b/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c @@ -622,7 +622,7 @@ { struct gsm_trans *trans = fi->priv; uint8_t *cause = data; - uint8_t transaction_id; + int rc; switch (event) { case VGCS_GCC_EV_TERM_REQ: @@ -649,13 +649,13 @@ /* Change to GROUP CALL INITIATED state. */ osmo_fsm_inst_state_chg(fi, VGCS_GCC_ST_U1_GROUP_CALL_INITIATED, 0, 0); /* Choose transaction ID. */ - transaction_id = trans_assign_trans_id(trans->ms, trans->protocol, 0); - if (transaction_id < 0) { + rc = trans_assign_trans_id(trans->ms, trans->protocol, 0); + if (rc < 0) { /* No free transaction ID. */ trans_free(trans); return; } - trans->transaction_id = transaction_id; + trans->transaction_id = rc; /* Send SETUP towards network. */ gsm44068_tx_setup(trans, trans->callref, false, 0, false, NULL, 0, false, 0); break; @@ -1500,7 +1500,7 @@ struct gsm_trans *trans; trans = trans_alloc(ms, pdisc, 0xff, callref); - if (trans < 0) + if (!trans) return NULL; trans->gcc.fi = osmo_fsm_inst_alloc((pdisc == GSM48_PDISC_GROUP_CC) ? &vgcs_gcc_fsm : &vgcs_bcc_fsm, trans, trans, LOGL_DEBUG, NULL); @@ -1664,7 +1664,7 @@ return 0; /* Incoming notification, creation transaction. */ trans = trans_alloc_vgcs(ms, pdisc, 0xff, mmh->ref); - if (trans < 0) + if (!trans) return -ENOMEM; } else { LOG_GCC_PR(pdisc, mmh->ref, LOGL_ERROR, "Received GCC/BCC message for unknown transaction.\n"); @@ -1816,7 +1816,7 @@ /* Create new transaction. ORIG will be set when entering U2sl state. */ trans = trans_alloc_vgcs(ms, protocol, 0xff, callref); - if (trans < 0) + if (!trans) return -ENOMEM; /* Setup new call. */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If72590bb94597e434386bbcd312919a71abf0aae Gerrit-Change-Number: 34646 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: ASCI: Fix false return value checks, discovered by Coverity Scan
by fixeria 05 Oct '23

05 Oct '23

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34646?usp=email ) Change subject: ASCI: Fix false return value checks, discovered by Coverity Scan ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If72590bb94597e434386bbcd312919a71abf0aae Gerrit-Change-Number: 34646 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 05 Oct 2023 13:41:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: Fix osmo_dia2gsup-master not pulling in debian-bookworm-erlang dep image
by osmith 05 Oct '23

05 Oct '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34652?usp=email ) Change subject: Fix osmo_dia2gsup-master not pulling in debian-bookworm-erlang dep image ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8d9bd77bbfac14a9951a549a21ee6bc4ea7b267a Gerrit-Change-Number: 34652 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 13:32:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: Fix osmo_dia2gsup-master not pulling in debian-bookworm-erlang dep image
by pespin 05 Oct '23

05 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34652?usp=email ) Change subject: Fix osmo_dia2gsup-master not pulling in debian-bookworm-erlang dep image ...................................................................... Fix osmo_dia2gsup-master not pulling in debian-bookworm-erlang dep image Change-Id: I8d9bd77bbfac14a9951a549a21ee6bc4ea7b267a --- M jenkins-common.sh 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/52/34652/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 72eaec2..e72a28d 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -21,6 +21,7 @@ osmo-*-centos7) echo "centos7-build" ;; osmo-*-centos8) echo "centos8-build" ;; osmo-*-latest) echo "debian-$DEBIAN_DEFAULT-obs-latest" ;; + osmo_dia2gsup-*) echo "debian-$DEBIAN_DEFAULT-erlang" ;; osmo-*) echo "debian-$DEBIAN_DEFAULT-build" ;; open5gs-master) echo "debian-$DEBIAN_DEFAULT-build" ;; ttcn3-*) echo "debian-bookworm-titan" ;; -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8d9bd77bbfac14a9951a549a21ee6bc4ea7b267a Gerrit-Change-Number: 34652 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: modem: grr_fsm: permit loop transition for GRR_ST_PACKET_ACCESS
by fixeria 05 Oct '23

05 Oct '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34651?usp=email ) Change subject: modem: grr_fsm: permit loop transition for GRR_ST_PACKET_ACCESS ...................................................................... modem: grr_fsm: permit loop transition for GRR_ST_PACKET_ACCESS I forgot to permit the loop state transmission, so the modem app gets stuck in GRR_ST_PACKET_ACCESS is no IMM ASS is received... Change-Id: I059d2929f7f724cfe26935bf35c167e60157451f Fixes: 9978b00e "modem: grr: implement RACH.req retransmission" --- M src/host/layer23/src/modem/grr.c 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/layer23/src/modem/grr.c b/src/host/layer23/src/modem/grr.c index 1bb172e..cbabdc9 100644 --- a/src/host/layer23/src/modem/grr.c +++ b/src/host/layer23/src/modem/grr.c @@ -804,6 +804,7 @@ [GRR_ST_PACKET_ACCESS] = { .name = "PACKET_ACCESS", .out_state_mask = S(GRR_ST_PACKET_NOT_READY) + | S(GRR_ST_PACKET_ACCESS) | S(GRR_ST_PACKET_TRANSFER), .in_event_mask = S(GRR_EV_BCCH_BLOCK_IND) | S(GRR_EV_PCH_AGCH_BLOCK_IND) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I059d2929f7f724cfe26935bf35c167e60157451f Gerrit-Change-Number: 34651 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: modem: grr_fsm: permit loop transition for GRR_ST_PACKET_ACCESS
by pespin 05 Oct '23

05 Oct '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34651?usp=email ) Change subject: modem: grr_fsm: permit loop transition for GRR_ST_PACKET_ACCESS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I059d2929f7f724cfe26935bf35c167e60157451f Gerrit-Change-Number: 34651 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 13:18:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: modem: grr_fsm: permit loop transition for GRR_ST_PACKET_ACCESS
by fixeria 05 Oct '23

05 Oct '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34651?usp=email ) Change subject: modem: grr_fsm: permit loop transition for GRR_ST_PACKET_ACCESS ...................................................................... modem: grr_fsm: permit loop transition for GRR_ST_PACKET_ACCESS I forgot to permit the loop state transmission, so the modem app gets stuck in GRR_ST_PACKET_ACCESS is no IMM ASS is received... Change-Id: I059d2929f7f724cfe26935bf35c167e60157451f Fixes: 9978b00e "modem: grr: implement RACH.req retransmission" --- M src/host/layer23/src/modem/grr.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/51/34651/1 diff --git a/src/host/layer23/src/modem/grr.c b/src/host/layer23/src/modem/grr.c index 1bb172e..cbabdc9 100644 --- a/src/host/layer23/src/modem/grr.c +++ b/src/host/layer23/src/modem/grr.c @@ -804,6 +804,7 @@ [GRR_ST_PACKET_ACCESS] = { .name = "PACKET_ACCESS", .out_state_mask = S(GRR_ST_PACKET_NOT_READY) + | S(GRR_ST_PACKET_ACCESS) | S(GRR_ST_PACKET_TRANSFER), .in_event_mask = S(GRR_EV_BCCH_BLOCK_IND) | S(GRR_EV_PCH_AGCH_BLOCK_IND) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I059d2929f7f724cfe26935bf35c167e60157451f Gerrit-Change-Number: 34651 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul_ass_fsm: Fix 'sba' field wrongly reset to true
by pespin 05 Oct '23

05 Oct '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34650?usp=email ) Change subject: rlcmac: tbf_ul_ass_fsm: Fix 'sba' field wrongly reset to true ...................................................................... rlcmac: tbf_ul_ass_fsm: Fix 'sba' field wrongly reset to true Change-Id: Ibf0c60516c337f4428ff33afbfb65a39a37a3719 --- M src/rlcmac/tbf_ul_ass_fsm.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/rlcmac/tbf_ul_ass_fsm.c b/src/rlcmac/tbf_ul_ass_fsm.c index e577313..1783d5b 100644 --- a/src/rlcmac/tbf_ul_ass_fsm.c +++ b/src/rlcmac/tbf_ul_ass_fsm.c @@ -130,7 +130,7 @@ { /* reset previous state: */ memset(&ctx->phase1_alloc, 0, sizeof(ctx->phase1_alloc)); - ctx->sba = true; + ctx->sba = false; ctx->tbf_starting_time_exists = false; ctx->tbf_starting_time = 0; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ibf0c60516c337f4428ff33afbfb65a39a37a3719 Gerrit-Change-Number: 34650 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul_ass_fsm: Fix 'sba' field wrongly reset to true
by fixeria 05 Oct '23

05 Oct '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34650?usp=email ) Change subject: rlcmac: tbf_ul_ass_fsm: Fix 'sba' field wrongly reset to true ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ibf0c60516c337f4428ff33afbfb65a39a37a3719 Gerrit-Change-Number: 34650 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 13:15:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul_ass_fsm: Fix 'sba' field wrongly reset to true
by pespin 05 Oct '23

05 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34650?usp=email ) Change subject: rlcmac: tbf_ul_ass_fsm: Fix 'sba' field wrongly reset to true ...................................................................... rlcmac: tbf_ul_ass_fsm: Fix 'sba' field wrongly reset to true Change-Id: Ibf0c60516c337f4428ff33afbfb65a39a37a3719 --- M src/rlcmac/tbf_ul_ass_fsm.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/50/34650/1 diff --git a/src/rlcmac/tbf_ul_ass_fsm.c b/src/rlcmac/tbf_ul_ass_fsm.c index e577313..1783d5b 100644 --- a/src/rlcmac/tbf_ul_ass_fsm.c +++ b/src/rlcmac/tbf_ul_ass_fsm.c @@ -130,7 +130,7 @@ { /* reset previous state: */ memset(&ctx->phase1_alloc, 0, sizeof(ctx->phase1_alloc)); - ctx->sba = true; + ctx->sba = false; ctx->tbf_starting_time_exists = false; ctx->tbf_starting_time = 0; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ibf0c60516c337f4428ff33afbfb65a39a37a3719 Gerrit-Change-Number: 34650 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0