October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/gerrit-verifications: Add osmo-epdg
by osmith 05 Oct '23

05 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email ) Change subject: jobs/gerrit-verifications: Add osmo-epdg ...................................................................... jobs/gerrit-verifications: Add osmo-epdg Change-Id: I84accfc5065ed2e780c4ecb77885af61bc6fb72f --- M jobs/gerrit-verifications.yml 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 9317720..07f07f4 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -191,6 +191,12 @@ cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' pipeline_binpkgs: "debian:11 debian:12" + - osmo-epdg: + repos_url: '{gerrit_url}/erlang/{repos}' + gerrit_project: 'erlang/{repos}' + cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' + pipeline_binpkgs: "debian:11 debian:12" + - osmo-e1-hardware: a2_name: JOB_TYPE a2: !!python/tuple ["firmware", "gateware", "manuals", "software"] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I84accfc5065ed2e780c4ecb77885af61bc6fb72f Gerrit-Change-Number: 34655 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications: Add osmo-epdg
by osmith 05 Oct '23

05 Oct '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email ) Change subject: jobs/gerrit-verifications: Add osmo-epdg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I84accfc5065ed2e780c4ecb77885af61bc6fb72f Gerrit-Change-Number: 34655 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:26:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications: Add osmo-epdg
by osmith 05 Oct '23

05 Oct '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: jobs/gerrit-verifications: Add osmo-epdg ...................................................................... Patch Set 1: -Code-Review (1 comment) Patchset: PS1: yep, see https://gitea.osmocom.org/osmocom/osmo-ci/src/branch/master/jobs/README.adoc > jenkins-jobs update jobs/coverity.yml as discussed, I'll merge it and deploy it -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I84accfc5065ed2e780c4ecb77885af61bc6fb72f Gerrit-Change-Number: 34655 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:26:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: Add contrib/jenkins.sh
by fixeria 05 Oct '23

05 Oct '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34656?usp=email ) Change subject: Add contrib/jenkins.sh ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34656?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ide4a16bd0b1d788b44c79d6a7268c5eeab0ed272 Gerrit-Change-Number: 34656 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:25:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in ...osmo-epdg[master]: Initial work to have proper app compilation and escript generation
by fixeria 05 Oct '23

05 Oct '23

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email ) Change subject: Initial work to have proper app compilation and escript generation ...................................................................... Patch Set 2: (2 comments) File Makefile: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654/comment/31d8501b_09ef… PS2, Line 14: rm -rf _build/ "No newline at end of right file." (shouldn't the text editor add it automatically?) File src/osmo_epdg.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654/comment/caaaa1d0_2690… PS2, Line 7: timer:sleep(infinity). same here, missing newline (git is complaining) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I83b9117a1d611a1b992ddf052450509f9bd16964 Gerrit-Change-Number: 34654 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:25:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: Fix selection of correct ARFCN at arfcn_from_freq_index()
by jolly 05 Oct '23

05 Oct '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34657?usp=email ) Change subject: Fix selection of correct ARFCN at arfcn_from_freq_index() ...................................................................... Fix selection of correct ARFCN at arfcn_from_freq_index() The selection of ARFCN is described in TS 44.018 §10.5.2.20. The frequencies found in SI5 and SI5bis are counted first, in the following order: ARFCN 1..1023,0. The frequencies found in SI5ter are counted afterwards, in the following order: ARFCN 1..1023,0. Related: OS#5782 Change-Id: I090d84a5550d89743e8f5a886f400df6483f50d7 --- M src/host/layer23/src/common/sysinfo.c 1 file changed, 28 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/57/34657/1 diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index 356f8eb..f541c85 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -1078,30 +1078,25 @@ return 0; } -static int16_t arfcn_from_freq_index(struct gsm48_sysinfo *s, uint16_t index) +/* Get ARFCN from BCCH allocation found in SI5/SI5bis an SI5ter. See TS 44.018 §10.5.2.20. */ +int16_t arfcn_from_freq_index(const struct gsm48_sysinfo *s, uint16_t index) { uint16_t arfcn, i = 0; - /* First, search for the P-GSM ARFCN. */ - for (arfcn = 1; arfcn < 124; arfcn++) { - if (!(s->freq[arfcn].mask & FREQ_TYPE_REP)) + /* Search for ARFCN found in SI5 or SI5bis. (first sub list) */ + for (arfcn = 1; arfcn <= 1024; arfcn++) { + if (!(s->freq[arfcn & 1023].mask & (FREQ_TYPE_REP_5 | FREQ_TYPE_REP_5bis))) continue; if (index == i++) - return arfcn; + return arfcn & 1023; } - /* Second, search for ARFCN 0. */ - if ((s->freq[arfcn].mask & FREQ_TYPE_REP)) { - if (index == i++) - return arfcn; - } - - /* Third, search for all other ARFCN. */ - for (arfcn = 125; arfcn < 1024; arfcn++) { - if (!(s->freq[arfcn].mask & FREQ_TYPE_REP)) + /* Search for ARFCN found in SI5ter. (second sub list) */ + for (arfcn = 1; arfcn <= 1024; arfcn++) { + if (!(s->freq[arfcn & 1023].mask & FREQ_TYPE_REP_5ter)) continue; if (index == i++) - return arfcn; + return arfcn & 1023; } /* If not found, return EOF (-1) as idicator. */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I090d84a5550d89743e8f5a886f400df6483f50d7 Gerrit-Change-Number: 34657 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[M] Change in osmocom-bb[master]: Fix indices of ARFCNs for measurement report
by jolly 05 Oct '23

05 Oct '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34658?usp=email ) Change subject: Fix indices of ARFCNs for measurement report ...................................................................... Fix indices of ARFCNs for measurement report The order of ARFCNs are described in TS 44.018 §10.5.2.20. The function arfcn_from_freq_index() is re-used to get the ARFCNs in correct order for the report. Change-Id: I0674467eb5a38a341cf65f95a25aa5f7232df069 --- M src/host/layer23/include/osmocom/bb/common/sysinfo.h M src/host/layer23/src/mobile/gsm48_rr.c 2 files changed, 32 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/58/34658/1 diff --git a/src/host/layer23/include/osmocom/bb/common/sysinfo.h b/src/host/layer23/include/osmocom/bb/common/sysinfo.h index 89d38ac..9efb248 100644 --- a/src/host/layer23/include/osmocom/bb/common/sysinfo.h +++ b/src/host/layer23/include/osmocom/bb/common/sysinfo.h @@ -219,5 +219,6 @@ int gsm48_decode_mobile_alloc(struct gsm_sysinfo_freq *freq, const uint8_t *ma, uint8_t len, uint16_t *hopping, uint8_t *hopp_len, int si4); +int16_t arfcn_from_freq_index(const struct gsm48_sysinfo *s, uint16_t index); #endif /* _SYSINFO_H */ diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 8dca379..3200412 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -2538,32 +2538,30 @@ && s->si5 && (!s->nb_ext_ind_si5 || s->si5bis)) { struct gsm48_rr_meas *rrmeas = &ms->rrlayer.meas; - int n = 0, i, refer_pcs; + int i, refer_pcs; + int16_t arfcn; LOGP(DRR, LOGL_NOTICE, "Complete set of SI5* for BA(%d)\n", s->nb_ba_ind_si5); rrmeas->nc_num = 0; refer_pcs = gsm_refer_pcs(cs->arfcn, s); - /* collect channels from freq list (1..1023,0) */ - for (i = 1; i <= 1024; i++) { - if ((s->freq[i & 1023].mask & FREQ_TYPE_REP)) { - if (n == 32) { - LOGP(DRR, LOGL_NOTICE, "SI5* report " - "exceeds 32 BCCHs\n"); - break; - } - if (refer_pcs && i >= 512 && i <= 810) - rrmeas->nc_arfcn[n] = i | ARFCN_PCS; - else - rrmeas->nc_arfcn[n] = i & 1023; - rrmeas->nc_rxlev_dbm[n] = -128; - LOGP(DRR, LOGL_NOTICE, "SI5* report arfcn %s\n", - gsm_print_arfcn(rrmeas->nc_arfcn[n])); - n++; - } + /* Collect channels from freq list in correct order. */ + for (i = 1; i < 32; i++) { + arfcn = arfcn_from_freq_index(s, i); + if (arfcn < 0) + break; + if (refer_pcs && arfcn >= 512 && arfcn <= 810) + rrmeas->nc_arfcn[i] = arfcn | ARFCN_PCS; + else + rrmeas->nc_arfcn[i] = arfcn; + rrmeas->nc_rxlev_dbm[i] = -128; + LOGP(DRR, LOGL_NOTICE, "SI5/SI5bis report arfcn %s (index %d)\n", + gsm_print_arfcn(rrmeas->nc_arfcn[i]), i); } - rrmeas->nc_num = n; + rrmeas->nc_num = i; + if (i == 32 && arfcn_from_freq_index(s, i) >= 0) + LOGP(DRR, LOGL_NOTICE, "SI5/SI5bis/SI5ter define more than 32 channels.\n"); } /* send sysinfo event to other layers */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34658?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0674467eb5a38a341cf65f95a25aa5f7232df069 Gerrit-Change-Number: 34658 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications: Add osmo-epdg
by osmith 05 Oct '23

05 Oct '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email ) Change subject: jobs/gerrit-verifications: Add osmo-epdg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I84accfc5065ed2e780c4ecb77885af61bc6fb72f Gerrit-Change-Number: 34655 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:24:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: Add .gitignore
by fixeria 05 Oct '23

05 Oct '23

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34653?usp=email ) Change subject: Add .gitignore ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ia2d93a81d94a34d0a869c6e135d13109cc5e2522 Gerrit-Change-Number: 34653 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:23:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: Add contrib/jenkins.sh
by pespin 05 Oct '23

05 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34656?usp=email ) Change subject: Add contrib/jenkins.sh ...................................................................... Add contrib/jenkins.sh Change-Id: Ide4a16bd0b1d788b44c79d6a7268c5eeab0ed272 --- A contrib/jenkins.sh 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/56/34656/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..87eae34 --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,5 @@ +#!/bin/sh -ex + +rebar3 compile +rebar3 escriptize +rebar3 eunit -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34656?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ide4a16bd0b1d788b44c79d6a7268c5eeab0ed272 Gerrit-Change-Number: 34656 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0