October 2023 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo-epdg[master]: Initial work to have proper app compilation and escript generation
by pespin 05 Oct '23

05 Oct '23

Attention is currently required from: fixeria, lynxis lazus. Hello fixeria, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email to look at the new patch set (#2). Change subject: Initial work to have proper app compilation and escript generation ...................................................................... Initial work to have proper app compilation and escript generation Change-Id: I83b9117a1d611a1b992ddf052450509f9bd16964 --- A Makefile M rebar.config A rebar.lock R src/osmo_epdg.app.src A src/osmo_epdg.erl R src/osmo_epdg_app.erl R src/osmo_epdg_sup.erl 7 files changed, 67 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/54/34654/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I83b9117a1d611a1b992ddf052450509f9bd16964 Gerrit-Change-Number: 34654 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications: Add osmo-epdg
by pespin 05 Oct '23

05 Oct '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email ) Change subject: jobs/gerrit-verifications: Add osmo-epdg ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I need to submit this somehow with jenkins-job-builds right? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I84accfc5065ed2e780c4ecb77885af61bc6fb72f Gerrit-Change-Number: 34655 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:23:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications: Add osmo-epdg
by pespin 05 Oct '23

05 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email ) Change subject: jobs/gerrit-verifications: Add osmo-epdg ...................................................................... jobs/gerrit-verifications: Add osmo-epdg Change-Id: I84accfc5065ed2e780c4ecb77885af61bc6fb72f --- M jobs/gerrit-verifications.yml 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/55/34655/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 9317720..07f07f4 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -191,6 +191,12 @@ cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' pipeline_binpkgs: "debian:11 debian:12" + - osmo-epdg: + repos_url: '{gerrit_url}/erlang/{repos}' + gerrit_project: 'erlang/{repos}' + cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' + pipeline_binpkgs: "debian:11 debian:12" + - osmo-e1-hardware: a2_name: JOB_TYPE a2: !!python/tuple ["firmware", "gateware", "manuals", "software"] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I84accfc5065ed2e780c4ecb77885af61bc6fb72f Gerrit-Change-Number: 34655 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: ASCI: Make neigh_list_get_arfcn() available to other users
by jolly 05 Oct '23

05 Oct '23

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34625?usp=email ) Change subject: ASCI: Make neigh_list_get_arfcn() available to other users ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34625/comment/874d2c21_14bdee99 PS2, Line 946: rc > you're changing the behavior here: […] It was not checked in the original code. I will add a check here and simplify the function. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia8a1dca4837536129d17e7784b892bcb75b9ca4b Gerrit-Change-Number: 34625 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:18:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support
by jolly 05 Oct '23

05 Oct '23

Attention is currently required from: fixeria, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email ) Change subject: ASCI: Add System Information 10 support ...................................................................... Patch Set 3: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/42690333_1940fbb5 PS2, Line 13: For each BTS, an SI 10 is gerated with all other neighbor BTS. > generated Done Patchset: PS2: > SI10 is actually not needed for the call establishment, it's needed for quicker cell change. […] The idea was to wait 3 seconds, which allows the MS to receive the SI5* messages before adding the SI10 (which relates to SI5*). There is not much benefit when sending SI10 earlier. Then I thought that it would be enough time for all the channels to be established in that BSC. There is no way to know at the BSC, if the channels requested from the MSC are complete. I could add an update to the SI10 for every channel that is established after the timer has expired. What do you think? File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/4bc38c72_0183a6f2 PS2, Line 1420: struct gsm_subscriber_connection *conn > should be `const` Done https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/f600693d_fad587ca PS2, Line 1424: *n_bts, *l_bts > cosmetic: better declare these two separately, so they're not hidden behind the `s_bts` assignment. […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/cd6e512e_cf268bb5 PS2, Line 1447: 32 > where this limit is coming from? […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/7352572d_8f0c439c PS2, Line 1459: if (c->lchan->ts->trx->bts->c0->arfcn != arfcn) > can we maybe have a "i_bts = c->lchan->ts->trx->bts;" var here to avoid dereferencing crazy amounts […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3 Gerrit-Change-Number: 34626 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:18:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support
by jolly 05 Oct '23

05 Oct '23

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ASCI: Add System Information 10 support ...................................................................... ASCI: Add System Information 10 support A timer is used to wait some seconds before sending SI 10 to all BTS. This ensures that all channels are established by the MSC, before sending a complete list of VGCS/VBS neighbor cells for a call. For each BTS, an SI 10 is generated with all other neighbor BTS. The SI 10 will only define neighbor cells within the same BSC, because it does not know about neighbor cells within other BSCs. Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3 --- M include/osmocom/bsc/gsm_data.h M include/osmocom/bsc/system_information.h M src/osmo-bsc/system_information.c M src/osmo-bsc/vgcs_fsm.c 4 files changed, 316 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/26/34626/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3 Gerrit-Change-Number: 34626 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: ASCI: Make neigh_list_get_arfcn() available to other users
by jolly 05 Oct '23

05 Oct '23

Attention is currently required from: fixeria, jolly, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/34625?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review-1 by fixeria, Verified+1 by Jenkins Builder Change subject: ASCI: Make neigh_list_get_arfcn() available to other users ...................................................................... ASCI: Make neigh_list_get_arfcn() available to other users The error logging message within this function is moved to the user neigh_list_get_arfcn(). Change-Id: Ia8a1dca4837536129d17e7784b892bcb75b9ca4b --- M include/osmocom/bsc/gsm_04_08_rr.h M src/osmo-bsc/gsm_04_08_rr.c 2 files changed, 46 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/25/34625/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia8a1dca4837536129d17e7784b892bcb75b9ca4b Gerrit-Change-Number: 34625 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in ...osmo-epdg[master]: Add .gitignore
by pespin 05 Oct '23

05 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34653?usp=email ) Change subject: Add .gitignore ...................................................................... Add .gitignore Change-Id: Ia2d93a81d94a34d0a869c6e135d13109cc5e2522 --- A .gitignore 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/53/34653/1 diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..08ae348 --- /dev/null +++ b/.gitignore @@ -0,0 +1,10 @@ +_build/ +include/ +log/ + +*.beam +erl_crash.dump + +src/diameter_3gpp* +src/diameter_rfc* +src/diameter_etsi* -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ia2d93a81d94a34d0a869c6e135d13109cc5e2522 Gerrit-Change-Number: 34653 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in ...osmo-epdg[master]: Initial work to have proper app compilation and escript generation
by pespin 05 Oct '23

05 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email ) Change subject: Initial work to have proper app compilation and escript generation ...................................................................... Initial work to have proper app compilation and escript generation Change-Id: I83b9117a1d611a1b992ddf052450509f9bd16964 --- A Makefile M rebar.config A rebar.lock R src/osmo_epdg.app.src A src/osmo_epdg.erl R src/osmo_epdg_app.erl R src/osmo_epdg_sup.erl 7 files changed, 64 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/54/34654/1 diff --git a/Makefile b/Makefile new file mode 100644 index 0000000..b3cd090 --- /dev/null +++ b/Makefile @@ -0,0 +1,11 @@ +all: build + +build: + rebar3 compile + rebar3 escriptize + +run: build + _build/default/bin/osmo-epdg + +clean: + rm -rf _build/ \ No newline at end of file diff --git a/rebar.config b/rebar.config index d0176c4..51852e4 100644 --- a/rebar.config +++ b/rebar.config @@ -36,7 +36,7 @@ {escript_name, "osmo-epdg"}. {relx, - [{release, {"osmo-epdg", "1.0.0"}, [epdg]}, + [{release, {"osmo-epdg", "1.0.0"}, [osmo_epdg]}, {sys_config, "./config/sys.config"}, {vm_args, "./config/vm.args"}, {dev_mode, true}, diff --git a/rebar.lock b/rebar.lock new file mode 100644 index 0000000..4c53cab --- /dev/null +++ b/rebar.lock @@ -0,0 +1,32 @@ +{"1.2.0", +[{<<"epcap">>, + {git,"https://github.com/msantos/epcap", + {ref,"d5c03caf608c1369e68cfed0a606d3eb82ddfd21"}}, + 1}, + {<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},1}, + {<<"lager">>, + {git,"https://github.com/erlang-lager/lager", + {ref,"459a3b2cdd9eadd29e5a7ce5c43932f5ccd6eb88"}}, + 0}, + {<<"osmo_gsup">>, + {git,"https://gitea.osmocom.org/erlang/osmo_gsup", + {ref,"ee15ee2b44f4a57c57831393d1fed2dc215d36e4"}}, + 0}, + {<<"osmo_ss7">>, + {git,"https://gitea.osmocom.org/erlang/osmo_ss7", + {ref,"3c6cdc5a53c4a5ec1aff417f2cbfaa9449004ee6"}}, + 0}, + {<<"parse_trans">>, + {git,"https://github.com/uwiger/parse_trans", + {ref,"cdb01ba260ba9a00b2aafa17affead0f6fac081c"}}, + 1}, + {<<"pkt">>, + {git,"https://github.com/msantos/pkt", + {ref,"67a4a14f596fded5ad5f2d8f94318faa8ad2c288"}}, + 1}]}. +[ +{pkg_hash,[ + {<<"goldrush">>, <<"F06E5D5F1277DA5C413E84D5A2924174182FB108DABB39D5EC548B27424CD106">>}]}, +{pkg_hash_ext,[ + {<<"goldrush">>, <<"99CB4128CFFCB3227581E5D4D803D5413FA643F4EB96523F77D9E6937D994CEB">>}]} +]. diff --git a/src/epdg.app.src b/src/osmo_epdg.app.src similarity index 89% rename from src/epdg.app.src rename to src/osmo_epdg.app.src index 4a11ef8..b75cf4d 100644 --- a/src/epdg.app.src +++ b/src/osmo_epdg.app.src @@ -1,5 +1,5 @@ %-*- mode: erlang -*- -{application, epdg, +{application, osmo_epdg, [ {description, "ePDG"}, {vsn, "1"}, diff --git a/src/osmo_epdg.erl b/src/osmo_epdg.erl new file mode 100644 index 0000000..26f9845 --- /dev/null +++ b/src/osmo_epdg.erl @@ -0,0 +1,7 @@ +-module(osmo_epdg). + +-export([main/1]). + +main(_Args) -> + application:ensure_all_started(?MODULE), + timer:sleep(infinity). \ No newline at end of file diff --git a/src/epdg_app.erl b/src/osmo_epdg_app.erl similarity index 67% rename from src/epdg_app.erl rename to src/osmo_epdg_app.erl index 8bf2279..197fb97 100644 --- a/src/epdg_app.erl +++ b/src/osmo_epdg_app.erl @@ -1,12 +1,11 @@ --module(epdg_app). - +-module(osmo_epdg_app). -behaviour(application). -export([start/2, stop/1]). start(_StartType, _StartArgs) -> - epdg_sup:start_link(). + osmo_epdg_sup:start_link(). stop(_State) -> ok. diff --git a/src/epdg_sup.erl b/src/osmo_epdg_sup.erl similarity index 94% rename from src/epdg_sup.erl rename to src/osmo_epdg_sup.erl index 836fa9c..231d27f 100644 --- a/src/epdg_sup.erl +++ b/src/osmo_epdg_sup.erl @@ -1,4 +1,4 @@ --module(epdg_sup). +-module(osmo_epdg_sup). -behaviour(supervisor). -export([start_link/0]). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I83b9117a1d611a1b992ddf052450509f9bd16964 Gerrit-Change-Number: 34654 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: pcu_l1_if: signal BTS model via PCUIF
by fixeria 05 Oct '23

05 Oct '23

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: This is something that needs to be done carefully: you're adding a new field, but the PCUIF version remains unchanged. Old osmo-{bts,bsc} speaking the same PCUIF version will not include this field, so the INFO.ind message will get dropped in `pcu_rx()`, see `CHECK_IF_MSG_SIZE`. I know PCUIF sucks when it comes to adding new fields, I wish at least the INFO.ind would employ TLV encoding rather than static structure... -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047 Gerrit-Change-Number: 34647 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 13:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0