October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/master: use same url scheme as gerrit jobs
by osmith 05 Oct '23

05 Oct '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34660?usp=email ) Change subject: jobs/master: use same url scheme as gerrit jobs ...................................................................... jobs/master: use same url scheme as gerrit jobs Make it easier to copy entries from gerrit-verifications.yml to master-builds.yml by using the same url schema in both. Change-Id: Ibe992dd8027a8b8df8623abc57a590972443449f --- M jobs/master-builds.yml 1 file changed, 30 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/60/34660/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 52ed298..dcf40ef 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -70,7 +70,9 @@ cmd: '{docker_run_ccache} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh' trigger: email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org - git_base_url: https://gerrit.osmocom.org + gerrit_url: 'https://gerrit.osmocom.org' + gitea_url: 'https://gitea.osmocom.org' + repos_url: '{gerrit_url}/{repos}' branches: - master ssh: @@ -103,7 +105,7 @@ master-libosmo-netif, master-osmo-bts - libosmo-dsp: - git_base_url: https://gitea.osmocom.org/sdr + repos_url: '{gitea_url}/sdr/{repos}' cmd: | {docker_run_ccache} \ {docker_img} {timeout_cmd} sh -ex -c \ @@ -287,14 +289,14 @@ - binaries_ftp.osmocom.org - docs_ftp.osmocom.org - ice40-usbtrace: - git_base_url: https://gitea.osmocom.org/electronics + repos_url: '{gitea_url}/electronics/{repos}' docker_img: 'registry.osmocom.org/$USER/fpga-build' cmd: 'docker pull {docker_img} && {docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' ssh: - binaries_ftp.osmocom.org - docs_ftp.osmocom.org - no2bootloader: - git_base_url: https://github.com/no2fpga + repos_url: 'https://github.com/no2fpga/{repos}' docker_img: 'registry.osmocom.org/$USER/fpga-build' cmd: 'docker pull {docker_img} && {docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de 246tnt(a)gmail.com @@ -303,7 +305,8 @@ - docs_ftp.osmocom.org - osmo-fl2k: - git_base_url: https://gitea.osmocom.org/sdr + repos_url: '{gitea_url}/sdr/{repos}' + - osmo-ggsn: a1_name: GTP a1: !!python/tuple [--enable-gtp-linux,--disable-gtp-linux] @@ -322,7 +325,7 @@ - osmo-upf - osmo-gmr: - git_base_url: https://gitea.osmocom.org/satellite + repos_url: '{gitea_url}/satellite/{repos}' email: jenkins-notifications(a)lists.osmocom.org 246tnt(a)gmail.com - osmo-gsm-manuals @@ -344,7 +347,7 @@ master-osmo-hnbgw - osmo-ir77: - git_base_url: https://gitea.osmocom.org/satellite + repos_url: '{gitea_url}/satellite/{repos}' email: jenkins-notifications(a)lists.osmocom.org 246tnt(a)gmail.com - osmo-mgw: @@ -396,7 +399,7 @@ "$DOCKER_IMG" {timeout_cmd} /build/contrib/jenkins.sh - osmo-python-tests: - git_base_url: https://gerrit.osmocom.org/python + repos_url: '{gerrit_url}/python/{repos}' - osmo-sgsn: a1_name: IU @@ -455,7 +458,7 @@ - binaries_ftp.osmocom.org - docs_ftp.osmocom.org - simtrace: - git_base_url: https://gitea.osmocom.org/sim-card + repos_url: '{gitea_url}/sim-card/{repos}' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de - simtrace2: cmd: '{docker_run_ccache} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' @@ -464,7 +467,7 @@ - binaries_ftp.osmocom.org - docs_ftp.osmocom.org - osmo-opencm3-projects: - git_base_url: https://gitea.osmocom.org/electronics + repos_url: '{gitea_url}/electronics/{repos}' cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de ssh: @@ -496,7 +499,7 @@ {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - rtl-sdr: - git_base_url: https://gitea.osmocom.org/sdr + repos_url: '{gitea_url}/sdr/{repos}' email: laforge(a)gnumonks.org steve(a)steve-m.de - pysim: @@ -525,12 +528,12 @@ concurrent: false cmd: cd ./tests; {timeout_cmd} ./run-tests slave_axis: !!python/tuple [simtester] - git_base_url: https://gitea.sysmocom.de/sysmocom + repos_url: 'https://gitea.sysmocom.de/sysmocom/{repos}' - dahdi-tools - xgoldmon: - git_base_url: https://github.com/2b-as + repos_url: 'https://github.com/2b-as/{repos}' cmd: | rm -rf osmo-ci git clone --depth=1 https://gerrit.osmocom.org/osmo-ci -b master @@ -551,7 +554,7 @@ num-to-keep: 120 description: | Automatic jenkins test job of - <a href="{git_base_url}/{repos}">{repos}</a> + <a href="{repos_url}">{repos}</a> <br/><br/> <b>Auto-generated using Jenkins Job Builder. DO NOT EDIT MANUALLY!</b> @@ -583,7 +586,7 @@ scm: - git: - url: "{git_base_url}/{repos}" + url: '{obj:repos_url}' branches: '{obj:branches}' refspec: name: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34660?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibe992dd8027a8b8df8623abc57a590972443449f Gerrit-Change-Number: 34660 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: Fix typo in libosmocore.map
by Hoernchen 05 Oct '23

05 Oct '23

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34659?usp=email ) Change subject: Fix typo in libosmocore.map ...................................................................... Fix typo in libosmocore.map Fixes: 64ba9edf173cc16f9d94c94a423a8b7a5904efaf Change-Id: I0fb13fb4ef8160f3ac2cb1cb4dd6ea57fd04b5be --- M src/core/libosmocore.map 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 105a80a..6c02cd3 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -432,7 +432,7 @@ osmo_sock_mcast_subscribe; osmo_sock_mcast_ttl_set; osmo_sock_multiaddr_add_local_addr; -çosmo_sock_multiaddr_del_local_addr; +osmo_sock_multiaddr_del_local_addr; osmo_sock_set_dscp; osmo_sock_set_priority; osmo_sock_unix_init; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34659?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fb13fb4ef8160f3ac2cb1cb4dd6ea57fd04b5be Gerrit-Change-Number: 34659 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in ...osmo-epdg[master]: Initial work to have proper app compilation and escript generation
by fixeria 05 Oct '23

05 Oct '23

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email ) Change subject: Initial work to have proper app compilation and escript generation ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File Makefile: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654/comment/ad9c0871_529b… PS2, Line 14: rm -rf _build/ > "No newline at end of right file." […] Done File src/osmo_epdg.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654/comment/7e7f596e_4874… PS2, Line 7: timer:sleep(infinity). > same here, missing newline (git is complaining) Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I83b9117a1d611a1b992ddf052450509f9bd16964 Gerrit-Change-Number: 34654 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:56:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: Fix typo in libosmocore.map
by osmith 05 Oct '23

05 Oct '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34659?usp=email ) Change subject: Fix typo in libosmocore.map ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34659?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fb13fb4ef8160f3ac2cb1cb4dd6ea57fd04b5be Gerrit-Change-Number: 34659 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:51:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: Fix typo in libosmocore.map
by pespin 05 Oct '23

05 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34659?usp=email ) Change subject: Fix typo in libosmocore.map ...................................................................... Fix typo in libosmocore.map Fixes: 64ba9edf173cc16f9d94c94a423a8b7a5904efaf Change-Id: I0fb13fb4ef8160f3ac2cb1cb4dd6ea57fd04b5be --- M src/core/libosmocore.map 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/59/34659/1 diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 105a80a..6c02cd3 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -432,7 +432,7 @@ osmo_sock_mcast_subscribe; osmo_sock_mcast_ttl_set; osmo_sock_multiaddr_add_local_addr; -çosmo_sock_multiaddr_del_local_addr; +osmo_sock_multiaddr_del_local_addr; osmo_sock_set_dscp; osmo_sock_set_priority; osmo_sock_unix_init; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34659?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fb13fb4ef8160f3ac2cb1cb4dd6ea57fd04b5be Gerrit-Change-Number: 34659 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support
by fixeria 05 Oct '23

05 Oct '23

Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email ) Change subject: ASCI: Add System Information 10 support ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/a2b5c191_3a6660f1 PS2, Line 1447: 32 > Done Thanks for adding the comment. I still see a possible problem though. By doing `< 32` you're actually limiting number the neighbors you check here in this function, not the number of frequencies the SI10 can fit. Imagine having more than 32 neighbors in the list (weird, but still possible, right?). The current logic would not take those neighbors with `i >= 32` into account, despite they could be involved in group calls and could fit. Does that make sense? If yes, just limit to `nbv->data_len * 8` and rely on your overflow detection logic below. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3 Gerrit-Change-Number: 34626 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:46:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in ...osmo-epdg[master]: Initial work to have proper app compilation and escript generation
by pespin 05 Oct '23

05 Oct '23

Attention is currently required from: lynxis lazus, pespin. Hello fixeria, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email to look at the new patch set (#3). Change subject: Initial work to have proper app compilation and escript generation ...................................................................... Initial work to have proper app compilation and escript generation Change-Id: I83b9117a1d611a1b992ddf052450509f9bd16964 --- A Makefile M rebar.config A rebar.lock R src/osmo_epdg.app.src A src/osmo_epdg.erl R src/osmo_epdg_app.erl R src/osmo_epdg_sup.erl 7 files changed, 67 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/54/34654/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I83b9117a1d611a1b992ddf052450509f9bd16964 Gerrit-Change-Number: 34654 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmocom-bb[master]: Fix indices of ARFCNs for measurement report
by pespin 05 Oct '23

05 Oct '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34658?usp=email ) Change subject: Fix indices of ARFCNs for measurement report ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34658?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0674467eb5a38a341cf65f95a25aa5f7232df069 Gerrit-Change-Number: 34658 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:30:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: Fix selection of correct ARFCN at arfcn_from_freq_index()
by pespin 05 Oct '23

05 Oct '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34657?usp=email ) Change subject: Fix selection of correct ARFCN at arfcn_from_freq_index() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I090d84a5550d89743e8f5a886f400df6483f50d7 Gerrit-Change-Number: 34657 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:29:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: ASCI: Make neigh_list_get_arfcn() available to other users
by fixeria 05 Oct '23

05 Oct '23

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34625?usp=email ) Change subject: ASCI: Make neigh_list_get_arfcn() available to other users ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia8a1dca4837536129d17e7784b892bcb75b9ca4b Gerrit-Change-Number: 34625 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:29:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0