October 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: Drop use of deprectated vty callback is_config_node
by osmith 05 Oct '23

05 Oct '23

Attention is currently required from: dexter, fixeria, neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34620?usp=email ) Change subject: Drop use of deprectated vty callback is_config_node ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I54c5aa5911611b181f80e76556b150f25dd5b60c Gerrit-Change-Number: 34620 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 07:40:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: ASCI: Add VTY command to display group call neighbor cells
by laforge 05 Oct '23

05 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34615?usp=email ) Change subject: ASCI: Add VTY command to display group call neighbor cells ...................................................................... ASCI: Add VTY command to display group call neighbor cells Related: OS#5782 Change-Id: Ie84221507bdf247c1563b829d6cf0adb53ce161f --- M src/host/layer23/include/osmocom/bb/common/sysinfo.h M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/mobile/vty_interface.c 3 files changed, 70 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/layer23/include/osmocom/bb/common/sysinfo.h b/src/host/layer23/include/osmocom/bb/common/sysinfo.h index 7b118ca..89d38ac 100644 --- a/src/host/layer23/include/osmocom/bb/common/sysinfo.h +++ b/src/host/layer23/include/osmocom/bb/common/sysinfo.h @@ -185,6 +185,7 @@ int gsm48_sysinfo_dump(const struct gsm48_sysinfo *s, uint16_t arfcn, void (*print)(void *, const char *, ...), void *priv, uint8_t *freq_map); +int gsm48_si10_dump(const struct gsm48_sysinfo *s, void (*print)(void *, const char *, ...), void *priv); int gsm48_decode_lai(struct gsm48_loc_area_id *lai, uint16_t *mcc, uint16_t *mnc, uint16_t *lac); int gsm48_decode_chan_h0(const struct gsm48_chan_desc *cd, diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index a728eb4..356f8eb 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -311,6 +311,48 @@ return 0; } +int gsm48_si10_dump(const struct gsm48_sysinfo *s, void (*print)(void *, const char *, ...), void *priv) +{ + const struct si10_cell_info *c; + int i; + + if (!s || !s->si10) { + print(priv, "No group channel neighbor information available.\n"); + return 0; + } + + if (!s->si10_cell_num) { + print(priv, "No group channel neighbors exist.\n"); + return 0; + } + + /* Group call neighbor cells. */ + print(priv, "Group channel neighbor cells (current or last call):\n"); + for (i = 0; i < s->si10_cell_num; i++) { + c = &s->si10_cell[i]; + print(priv, " index = %d", c->index); + if (c->arfcn >= 0) + print(priv, " ARFCN = %d", c->arfcn); + else + print(priv, " ARFCN = not in SI5*"); + print(priv, " BSIC = %d,%d", c->bsic >> 3, c->bsic & 0x7); + if (c->barred) { + print(priv, " barred"); + continue; + } + if (c->la_different) + print(priv, " CRH = %d", c->cell_resel_hyst_db); + print(priv, " MS_TXPWR_MAX_CCCH = %d\n", c->ms_txpwr_max_cch); + print(priv, " RXLEV_MIN = %d", c->rxlev_acc_min_db); + print(priv, " CRO = %d", c->cell_resel_offset); + print(priv, " TEMP_OFFSET = %d", c->temp_offset); + print(priv, " PENALTY_TIME = %d", c->penalty_time); + } + print(priv, "\n"); + + return 0; +} + /* * decoding */ diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index a4b97bc..2a09608 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -373,10 +373,10 @@ return CMD_SUCCESS; } -#define ASCI_STR SHOW_STR "Display information about ASCI items\nName of MS (see \"show ms\")\n" +#define SHOW_ASCI_STR SHOW_STR "Display information about ASCI items\nName of MS (see \"show ms\")\n" DEFUN(show_asci_calls, show_asci_calls_cmd, "show asci MS_NAME calls", - ASCI_STR "Display ongoing ASCI calls") + SHOW_ASCI_STR "Display ongoing ASCI calls") { struct osmocom_ms *ms; @@ -389,6 +389,20 @@ return CMD_SUCCESS; } +DEFUN(show_asci_neighbors, show_asci_neighbors_cmd, "show asci MS_NAME neighbors", + SHOW_ASCI_STR "Display neigbor cells of ongoing or last ASCI call") +{ + struct osmocom_ms *ms; + + ms = l23_vty_get_ms(argv[0], vty); + if (!ms) + return CMD_WARNING; + + gsm48_si10_dump(ms->cellsel.si, l23_vty_printf, vty); + + return CMD_SUCCESS; +} + DEFUN(monitor_network, monitor_network_cmd, "monitor network MS_NAME", "Monitor...\nMonitor network information\nName of MS (see \"show ms\")") { @@ -2484,6 +2498,7 @@ install_element_ve(&show_forb_la_cmd); install_element_ve(&show_forb_plmn_cmd); install_element_ve(&show_asci_calls_cmd); + install_element_ve(&show_asci_neighbors_cmd); install_element_ve(&monitor_network_cmd); install_element_ve(&no_monitor_network_cmd); install_element(ENABLE_NODE, &off_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie84221507bdf247c1563b829d6cf0adb53ce161f Gerrit-Change-Number: 34615 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: Fix settings for VGCS/VBS
by laforge 05 Oct '23

05 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email ) Change subject: Fix settings for VGCS/VBS ...................................................................... Fix settings for VGCS/VBS The "support" flags must be copied to the settings, because they are enabled by default and may be omitted in the VTY config. Related: OS#5364 Change-Id: I81575dd3f2ade70101df32935a1c3d5469327577 --- M src/host/layer23/src/common/settings.c 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/host/layer23/src/common/settings.c b/src/host/layer23/src/common/settings.c index 288b03e..395d239 100644 --- a/src/host/layer23/src/common/settings.c +++ b/src/host/layer23/src/common/settings.c @@ -100,6 +100,8 @@ set->ch_cap = sup->ch_cap; set->min_rxlev_dbm = sup->min_rxlev_dbm; set->dsc_max = sup->dsc_max; + set->vgcs = sup->vgcs; + set->vbs = sup->vbs; if (sup->half_v1 || sup->half_v3) set->half = 1; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I81575dd3f2ade70101df32935a1c3d5469327577 Gerrit-Change-Number: 34644 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmocom-bb[master]: Cleaning gsm48_mm_data_ind()
by laforge 05 Oct '23

05 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34603?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Cleaning gsm48_mm_data_ind() ...................................................................... Cleaning gsm48_mm_data_ind() Get rid of goto and double switch/case by putting connection handling code into a separate function. Change-Id: I12454cab06c105ccd9e2495e3a6f0640f2884885 --- M src/host/layer23/src/mobile/gsm48_mm.c 1 file changed, 59 insertions(+), 55 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_mm.c b/src/host/layer23/src/mobile/gsm48_mm.c index 092a984..cec798b 100644 --- a/src/host/layer23/src/mobile/gsm48_mm.c +++ b/src/host/layer23/src/mobile/gsm48_mm.c @@ -4628,61 +4628,16 @@ #define MMDATASLLEN \ (sizeof(mmdatastatelist) / sizeof(struct mmdatastate)) -static int gsm48_mm_data_ind(struct osmocom_ms *ms, struct msgb *msg) +static int create_conn_and_push_mm_hdr(struct gsm48_mmlayer *mm, struct msgb *msg, int rr_est, int rr_prim) { - struct gsm48_mmlayer *mm = &ms->mmlayer; struct gsm48_rr_hdr *rrh = (struct gsm48_rr_hdr *)msg->data; uint8_t sapi = rrh->sapi; struct gsm48_hdr *gh = msgb_l3(msg); uint8_t pdisc = gh->proto_discr & 0x0f; - uint8_t msg_type = gh->msg_type & 0xbf; uint8_t transaction_id; uint32_t callref; struct gsm48_mm_conn *conn; struct gsm48_mmxx_hdr *mmh; - int msg_supported = 0; /* determine, if message is supported at all */ - int rr_prim, rr_est = -1; /* no prim set */ - uint8_t skip_ind; - int i, rc; - - /* 9.2.19 */ - if (msg_type == GSM48_MT_MM_NULL) { - msgb_free(msg); - return 0; - } - - if (mm->state == GSM48_MM_ST_IMSI_DETACH_INIT) { - LOGP(DMM, LOGL_NOTICE, "DATA IND ignored during IMSI " - "detach.\n"); - msgb_free(msg); - return 0; - } - /* pull the RR header */ - msgb_pull(msg, sizeof(struct gsm48_rr_hdr)); - - /* create transaction (if not exists) and push message */ - switch (pdisc) { - case GSM48_PDISC_CC: - rr_prim = GSM48_MMCC_DATA_IND; - rr_est = GSM48_MMCC_EST_IND; - break; - case GSM48_PDISC_NC_SS: - rr_prim = GSM48_MMSS_DATA_IND; - rr_est = GSM48_MMSS_EST_IND; - break; - case GSM48_PDISC_SMS: - rr_prim = GSM48_MMSMS_DATA_IND; - rr_est = GSM48_MMSMS_EST_IND; - break; - case GSM48_PDISC_GROUP_CC: - rr_prim = GSM48_MMGCC_DATA_IND; - break; - case GSM48_PDISC_BCAST_CC: - rr_prim = GSM48_MMBCC_DATA_IND; - break; - default: - goto forward_msg; - } transaction_id = ((gh->proto_discr & 0xf0) ^ 0x80) >> 4; /* flip */ @@ -4699,16 +4654,13 @@ if (rr_est == -1) { LOGP(DMM, LOGL_ERROR, "No MO connection for pdisc=%d, transaction_id=%d\n", pdisc, transaction_id); - msgb_free(msg); return -EINVAL; } conn = mm_conn_new(mm, pdisc, transaction_id, sapi, mm_conn_new_ref++); rr_prim = rr_est; } - if (!conn) { - msgb_free(msg); + if (!conn) return -ENOMEM; - } callref = conn->ref; } @@ -4732,8 +4684,35 @@ new_mm_state(mm, GSM48_MM_ST_MM_CONN_ACTIVE, 0); } + return 0; +} + +static int gsm48_mm_data_ind(struct osmocom_ms *ms, struct msgb *msg) +{ + struct gsm48_mmlayer *mm = &ms->mmlayer; + struct gsm48_hdr *gh = msgb_l3(msg); + uint8_t pdisc = gh->proto_discr & 0x0f; + uint8_t msg_type = gh->msg_type & 0xbf; + int msg_supported = 0; /* determine, if message is supported at all */ + uint8_t skip_ind; + int i, rc; + + /* 9.2.19 */ + if (msg_type == GSM48_MT_MM_NULL) { + msgb_free(msg); + return 0; + } + + if (mm->state == GSM48_MM_ST_IMSI_DETACH_INIT) { + LOGP(DMM, LOGL_NOTICE, "DATA IND ignored during IMSI " + "detach.\n"); + msgb_free(msg); + return 0; + } + /* pull the RR header */ + msgb_pull(msg, sizeof(struct gsm48_rr_hdr)); + /* forward message */ -forward_msg: switch (pdisc) { case GSM48_PDISC_MM: skip_ind = (gh->proto_discr & 0xf0) >> 4; @@ -4746,23 +4725,36 @@ break; /* follow the selection procedure below */ case GSM48_PDISC_CC: - rc = gsm48_rcv_cc(ms, msg); + rc = create_conn_and_push_mm_hdr(mm, msg, GSM48_MMCC_EST_IND, GSM48_MMCC_DATA_IND); + if (rc == 0) + rc = gsm48_rcv_cc(ms, msg); msgb_free(msg); return rc; case GSM48_PDISC_NC_SS: - rc = gsm480_rcv_ss(ms, msg); + rc = create_conn_and_push_mm_hdr(mm, msg, GSM48_MMSS_EST_IND, GSM48_MMSS_DATA_IND); + if (rc == 0) + rc = gsm480_rcv_ss(ms, msg); msgb_free(msg); return rc; case GSM48_PDISC_SMS: - rc = gsm411_rcv_sms(ms, msg); + rc = create_conn_and_push_mm_hdr(mm, msg, GSM48_MMSMS_EST_IND, GSM48_MMSMS_DATA_IND); + if (rc == 0) + rc = gsm411_rcv_sms(ms, msg); msgb_free(msg); return rc; case GSM48_PDISC_GROUP_CC: + rc = create_conn_and_push_mm_hdr(mm, msg, -1, GSM48_MMGCC_DATA_IND); + if (rc == 0) + rc = gsm44068_rcv_gcc_bcc(ms, msg); + msgb_free(msg); + return rc; case GSM48_PDISC_BCAST_CC: - rc = gsm44068_rcv_gcc_bcc(ms, msg); + rc = create_conn_and_push_mm_hdr(mm, msg, -1, GSM48_MMBCC_DATA_IND); + if (rc == 0) + rc = gsm44068_rcv_gcc_bcc(ms, msg); msgb_free(msg); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I12454cab06c105ccd9e2495e3a6f0640f2884885 Gerrit-Change-Number: 34603 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[L] Change in osmocom-bb[master]: ASCI: Add VTY commands to control voice group/broadcast calls
by laforge 05 Oct '23

05 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email ) Change subject: ASCI: Add VTY commands to control voice group/broadcast calls ...................................................................... ASCI: Add VTY commands to control voice group/broadcast calls Related: OS#5364 Change-Id: Id32253b4e10b8df48e819d8a92bbcda332dd11e6 --- M src/host/layer23/include/osmocom/bb/mobile/vty.h M src/host/layer23/src/mobile/vty_interface.c 2 files changed, 249 insertions(+), 8 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/host/layer23/include/osmocom/bb/mobile/vty.h b/src/host/layer23/include/osmocom/bb/mobile/vty.h index 4ac084e..511348b 100644 --- a/src/host/layer23/include/osmocom/bb/mobile/vty.h +++ b/src/host/layer23/include/osmocom/bb/mobile/vty.h @@ -11,6 +11,8 @@ enum ms_vty_node { SUPPORT_NODE = _LAST_L23VTY_NODE + 1, AUDIO_NODE, + VGCS_NODE, + VBS_NODE, }; int ms_vty_init(void); diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index feb5f84..5e5fa6d 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -39,6 +39,7 @@ #include <osmocom/bb/mobile/app_mobile.h> #include <osmocom/bb/mobile/gsm480_ss.h> #include <osmocom/bb/mobile/gsm411_sms.h> +#include <osmocom/bb/mobile/gsm44068_gcc_bcc.h> #include <osmocom/vty/telnet_interface.h> #include <osmocom/vty/misc.h> @@ -54,6 +55,18 @@ 1 }; +struct cmd_node vgcs_node = { + VGCS_NODE, + "%s(group-call)# ", + 1 +}; + +struct cmd_node vbs_node = { + VBS_NODE, + "%s(broadcast-call)# ", + 1 +}; + int vty_check_number(struct vty *vty, const char *number) { int i; @@ -79,6 +92,32 @@ return 0; } +int vty_check_callref(struct vty *vty, const char *number) +{ + int i, ii = strlen(number); + + /* First check digits, so that a false command result the following error message. */ + for (i = 0; i < ii; i++) { + if (!(number[i] >= '0' && number[i] <= '9')) { + vty_out(vty, "Invalid digit '%c' in callref!%s", + number[i], VTY_NEWLINE); + return -EINVAL; + } + } + + if (ii < 1) { + vty_out(vty, "Given callref has no digits!%s", VTY_NEWLINE); + return -EINVAL; + } + + if (ii > 8) { + vty_out(vty, "Given callref is too long!%s", VTY_NEWLINE); + return -EINVAL; + } + + return 0; +} + static void vty_restart(struct vty *vty, struct osmocom_ms *ms) { if (l23_vty_reading) @@ -334,6 +373,22 @@ return CMD_SUCCESS; } +#define ASCI_STR SHOW_STR "Display information about ASCI items\nName of MS (see \"show ms\")\n" + +DEFUN(show_asci_calls, show_asci_calls_cmd, "show asci MS_NAME calls", + ASCI_STR "Display ongoing ASCI calls") +{ + struct osmocom_ms *ms; + + ms = l23_vty_get_ms(argv[0], vty); + if (!ms) + return CMD_WARNING; + + gsm44068_dump_calls(ms, l23_vty_printf, vty); + + return CMD_SUCCESS; +} + DEFUN(monitor_network, monitor_network_cmd, "monitor network MS_NAME", "Monitor...\nMonitor network information\nName of MS (see \"show ms\")") { @@ -583,6 +638,146 @@ return CMD_SUCCESS; } +#define VGCS_STR "Make a voice group call\nName of MS (see \"show ms\")\n" +#define VGCS_CMDS "(CALLREF|hangup|leave|talk|listen)" +#define VGCS_CMDS_TXT \ + "Voice group to call or join\nHangup voice group call\nLeave voice group call\nBecome talker\nBecome listener" + +/* This command enters VGCS call node with given MS. */ +DEFUN(vgcs_enter, vgcs_enter_cmd, "group-call MS_NAME", + VGCS_STR) +{ + struct osmocom_ms *ms; + + ms = l23_vty_get_ms(argv[0], vty); + if (!ms) + return CMD_WARNING; + + vty->index = ms; + vty->node = VGCS_NODE; + + return CMD_SUCCESS; +} + +/* These commands perform VGCS on VGCS node. */ +DEFUN(vgcs, vgcs_cmd, VGCS_CMDS, + VGCS_CMDS_TXT) +{ + struct osmocom_ms *ms = vty->index; + struct gsm_settings *set; + const char *command; + + set = &ms->settings; + + if (!set->vgcs) { + vty_out(vty, "VGCS not supported by this mobile, please enable VGCS support%s", VTY_NEWLINE); + return CMD_WARNING; + } + + if (set->ch_cap == GSM_CAP_SDCCH) { + vty_out(vty, "ASCI call is not supported for SDCCH only mobile%s", VTY_NEWLINE); + return CMD_WARNING; + } + + command = (char *)argv[0]; + if (!strcmp(command, "hangup")) + gcc_bcc_hangup(ms); + else if (!strcmp(command, "leave")) + gcc_leave(ms); + else if (!strcmp(command, "talk")) + gcc_talk(ms); + else if (!strcmp(command, "listen")) + gcc_listen(ms); + else { + if (vty_check_callref(vty, command)) + return CMD_WARNING; + gcc_bcc_call(ms, GSM48_PDISC_GROUP_CC, command); + } + + return CMD_SUCCESS; +} + +/* These commands perform VGCS on given MS without entering the VGCS node. */ +DEFUN(vgcs_direct, vgcs_direct_cmd, "group-call MS_NAME " VGCS_CMDS, + VGCS_STR VGCS_CMDS_TXT) +{ + struct osmocom_ms *ms; + + ms = l23_vty_get_ms(argv[0], vty); + if (!ms) + return CMD_WARNING; + + vty->index = ms; + return vgcs(self, vty, argc - 1, argv + 1); +} + +#define VBS_STR "Make a voice broadcast call\nName of MS (see \"show ms\")\n" +#define VBS_CMDS "(CALLREF|hangup)" +#define VBS_CMDS_TXT \ + "Voice broadcast to call or join\nHangup voice broadcast call" + +/* This command enters VBS call node with given MS. */ +DEFUN(vbs_enter, vbs_enter_cmd, "broadcast-call MS_NAME", + VBS_STR) +{ + struct osmocom_ms *ms; + + ms = l23_vty_get_ms(argv[0], vty); + if (!ms) + return CMD_WARNING; + + vty->index = ms; + vty->node = VBS_NODE; + + return CMD_SUCCESS; +} + +/* These commands perform VBS on VBS node. */ +DEFUN(vbs, vbs_cmd, VBS_CMDS, + VBS_CMDS_TXT) +{ + struct osmocom_ms *ms = vty->index; + struct gsm_settings *set; + const char *command; + + set = &ms->settings; + + if (!set->vbs) { + vty_out(vty, "VBS not supported by this mobile, please enable VBS support%s", VTY_NEWLINE); + return CMD_WARNING; + } + + if (set->ch_cap == GSM_CAP_SDCCH) { + vty_out(vty, "ASCI call is not supported for SDCCH only mobile%s", VTY_NEWLINE); + return CMD_WARNING; + } + + command = (char *)argv[0]; + if (!strcmp(command, "hangup")) + gcc_bcc_hangup(ms); + else { + if (vty_check_callref(vty, command)) + return CMD_WARNING; + gcc_bcc_call(ms, GSM48_PDISC_BCAST_CC, command); + } + + return CMD_SUCCESS; +} + +/* These commands perform VBS on given MS without entering the VBS node. */ +DEFUN(vbs_direct, vbs_direct_cmd, "broadcast-call MS_NAME " VBS_CMDS, + VBS_STR VBS_CMDS_TXT) +{ + struct osmocom_ms *ms; + + ms = l23_vty_get_ms(argv[0], vty); + if (!ms) + return CMD_WARNING; + + vty->index = ms; + return vbs(self, vty, argc - 1, argv + 1); +} + #define TEST_CMD_DESC "Special commands for testing\n" DEFUN(test_reselection, test_reselection_cmd, "test re-selection NAME", @@ -1072,11 +1267,14 @@ if (!l23_vty_hide_default || set->skip_max_per_band) vty_out(vty, " %sskip-max-per-band%s", (set->skip_max_per_band) ? "" : "no ", VTY_NEWLINE); + SUP_WRITE(vgcs, "vgcs"); + SUP_WRITE(vbs, "vbs"); if (!l23_vty_hide_default || set->any_timeout != MOB_C7_DEFLT_ANY_TIMEOUT) vty_out(vty, " c7-any-timeout %d%s", set->any_timeout, VTY_NEWLINE); - SUP_WRITE(vgcs, "vgcs"); - SUP_WRITE(vbs, "vbs"); + if (!l23_vty_hide_default || !set->uplink_release_local) + vty_out(vty, " %suplink-release-local%s", + (set->uplink_release_local) ? "no " : "", VTY_NEWLINE); vty_out(vty, " audio%s", VTY_NEWLINE); vty_out(vty, " io-handler %s%s", @@ -1727,6 +1925,26 @@ return CMD_SUCCESS; } +DEFUN(cfg_ms_no_uplink_release_local, cfg_ms_no_uplink_release_local_cmd, "no uplink-release-local", + NO_STR "Release L2 on uplink of VGCS channel normally. Release locally when UPLINK FREE is received.") +{ + struct osmocom_ms *ms = vty->index; + struct gsm_settings *set = &ms->settings; + + set->uplink_release_local = false; + return CMD_SUCCESS; +} + +DEFUN(cfg_ms_uplink_release_local, cfg_ms_uplink_release_local_cmd, "uplink-release-local", + "Release L2 on uplink of VGCS channel locally after receiving UPLINK FREE.") +{ + struct osmocom_ms *ms = vty->index; + struct gsm_settings *set = &ms->settings; + + set->uplink_release_local = true; + return CMD_SUCCESS; +} + static int config_write_dummy(struct vty *vty) { return CMD_SUCCESS; @@ -2054,14 +2272,14 @@ return CMD_SUCCESS; } -SUP_EN(cfg_ms_sup_vbs, cfg_ms_sup_vbs_cmd, vbs, "vbs", - "Voice Broadcast Service (VBS)", 0); -SUP_DI(cfg_ms_sup_no_vbs, cfg_ms_sup_no_vbs_cmd, vbs, - "vbs", "Voice Broadcast Service (VBS)", 0); SUP_EN(cfg_ms_sup_vgcs, cfg_ms_sup_vgcs_cmd, vgcs, "vgcs", "Voice Group Call Service (VGCS)", 0); SUP_DI(cfg_ms_sup_no_vgcs, cfg_ms_sup_no_vgcs_cmd, vgcs, "vgcs", "Voice Group Call Service (VBS)", 0); +SUP_EN(cfg_ms_sup_vbs, cfg_ms_sup_vbs_cmd, vbs, "vbs", + "Voice Broadcast Service (VBS)", 0); +SUP_DI(cfg_ms_sup_no_vbs, cfg_ms_sup_no_vbs_cmd, vbs, + "vbs", "Voice Broadcast Service (VBS)", 0); /* per audio config */ DEFUN(cfg_ms_audio, cfg_ms_audio_cmd, "audio", @@ -2265,6 +2483,7 @@ install_element_ve(&show_ba_cmd); install_element_ve(&show_forb_la_cmd); install_element_ve(&show_forb_plmn_cmd); + install_element_ve(&show_asci_calls_cmd); install_element_ve(&monitor_network_cmd); install_element_ve(&no_monitor_network_cmd); install_element(ENABLE_NODE, &off_cmd); @@ -2277,6 +2496,14 @@ install_element(ENABLE_NODE, &call_dtmf_cmd); install_element(ENABLE_NODE, &sms_cmd); install_element(ENABLE_NODE, &service_cmd); + install_element(ENABLE_NODE, &vgcs_enter_cmd); + install_element(ENABLE_NODE, &vgcs_direct_cmd); + install_node(&vgcs_node, config_write_dummy); + install_element(VGCS_NODE, &vgcs_cmd); + install_element(ENABLE_NODE, &vbs_enter_cmd); + install_element(ENABLE_NODE, &vbs_direct_cmd); + install_node(&vbs_node, config_write_dummy); + install_element(VBS_NODE, &vbs_cmd); install_element(ENABLE_NODE, &test_reselection_cmd); install_element(ENABLE_NODE, &delete_forbidden_plmn_cmd); @@ -2335,6 +2562,8 @@ install_element(MS_NODE, &cfg_ms_any_timeout_cmd); install_element(MS_NODE, &cfg_ms_sms_store_cmd); install_element(MS_NODE, &cfg_ms_no_sms_store_cmd); + install_element(MS_NODE, &cfg_ms_uplink_release_local_cmd); + install_element(MS_NODE, &cfg_ms_no_uplink_release_local_cmd); install_element(MS_NODE, &cfg_ms_support_cmd); install_node(&support_node, config_write_dummy); install_element(SUPPORT_NODE, &cfg_ms_sup_dtmf_cmd); @@ -2391,10 +2620,10 @@ install_element(SUPPORT_NODE, &cfg_ms_sup_dsc_max_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_skip_max_per_band_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_no_skip_max_per_band_cmd); - install_element(SUPPORT_NODE, &cfg_ms_sup_vbs_cmd); - install_element(SUPPORT_NODE, &cfg_ms_sup_no_vbs_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_vgcs_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_no_vgcs_cmd); + install_element(SUPPORT_NODE, &cfg_ms_sup_vbs_cmd); + install_element(SUPPORT_NODE, &cfg_ms_sup_no_vbs_cmd); install_element(MS_NODE, &cfg_ms_script_load_run_cmd); install_element(MS_NODE, &cfg_ms_no_script_load_run_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id32253b4e10b8df48e819d8a92bbcda332dd11e6 Gerrit-Change-Number: 34495 Gerrit-PatchSet: 16 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information
by laforge 05 Oct '23

05 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email ) ( 9 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ASCI: Show NCH position in VTY together with system information ...................................................................... ASCI: Show NCH position in VTY together with system information Related: OS#5364 Change-Id: I5e0a9d469eb70608502dca881808621fa153b666 --- M src/host/layer23/src/common/sysinfo.c 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index 700accd..7af1d93 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -23,6 +23,7 @@ #include <osmocom/core/utils.h> #include <osmocom/core/bitvec.h> #include <osmocom/gsm/gsm48.h> +#include <osmocom/gsm/gsm48_rest_octets.h> #include <osmocom/gprs/rlcmac/csn1_defs.h> @@ -72,6 +73,7 @@ char buffer[82]; int i, j, k, index; int refer_pcs = gsm_refer_pcs(arfcn, s); + int rc; /* available sysinfos */ print(priv, "ARFCN = %s channels 512+ refer to %s\n", @@ -282,6 +284,16 @@ print(priv, " BS-PA-MFMS = %d Attachment = %s\n", s->pag_mf_periods, (s->att_allowed) ? "allowed" : "denied"); print(priv, "BS-AG_BLKS_RES = %d ", s->bs_ag_blks_res); + if (!s->nch) + print(priv, "NCH not available "); + else { + uint8_t num_blocks, first_block; + rc = osmo_gsm48_si1ro_nch_pos_decode(s->nch_position, &num_blocks, &first_block); + if (rc < 0) + print(priv, "NCH Position invalid "); + else + print(priv, "NCH Position %u / %u blocks ", first_block, num_blocks); + } if (s->t3212) print(priv, "T3212 = %d sec.\n", s->t3212); else -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666 Gerrit-Change-Number: 34496 Gerrit-PatchSet: 16 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: Correctly extract bits from SI2*/SI5*
by laforge 05 Oct '23

05 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34604?usp=email ) Change subject: Correctly extract bits from SI2*/SI5* ...................................................................... Correctly extract bits from SI2*/SI5* These bits are: * EXT-IND * BA-IND * Multiband reporting Change-Id: Ie5349464fed0a4276955235c7c87b5bcb299f20d --- M src/host/layer23/src/common/sysinfo.c 1 file changed, 26 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index 7af1d93..66b87eb 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -636,8 +636,8 @@ memcpy(s->si2_msg, si, OSMO_MIN(len, sizeof(s->si2_msg))); /* Neighbor Cell Description */ - s->nb_ext_ind_si2 = (si->bcch_frequency_list[0] >> 6) & 1; - s->nb_ba_ind_si2 = (si->bcch_frequency_list[0] >> 5) & 1; + s->nb_ext_ind_si2 = (si->bcch_frequency_list[0] >> 5) & 1; + s->nb_ba_ind_si2 = (si->bcch_frequency_list[0] >> 4) & 1; decode_freq_list(s->freq, si->bcch_frequency_list, sizeof(si->bcch_frequency_list), 0xce, FREQ_TYPE_NCELL_2); @@ -657,8 +657,8 @@ memcpy(s->si2b_msg, si, OSMO_MIN(len, sizeof(s->si2b_msg))); /* Neighbor Cell Description */ - s->nb_ext_ind_si2bis = (si->bcch_frequency_list[0] >> 6) & 1; - s->nb_ba_ind_si2bis = (si->bcch_frequency_list[0] >> 5) & 1; + s->nb_ext_ind_si2bis = (si->bcch_frequency_list[0] >> 5) & 1; + s->nb_ba_ind_si2bis = (si->bcch_frequency_list[0] >> 4) & 1; decode_freq_list(s->freq, si->bcch_frequency_list, sizeof(si->bcch_frequency_list), 0xce, FREQ_TYPE_NCELL_2bis); /* RACH Control Parameter */ @@ -675,8 +675,8 @@ memcpy(s->si2t_msg, si, OSMO_MIN(len, sizeof(s->si2t_msg))); /* Neighbor Cell Description 2 */ - s->nb_multi_rep_si2ter = (si->ext_bcch_frequency_list[0] >> 6) & 3; - s->nb_ba_ind_si2ter = (si->ext_bcch_frequency_list[0] >> 5) & 1; + s->nb_multi_rep_si2ter = (si->ext_bcch_frequency_list[0] >> 5) & 3; + s->nb_ba_ind_si2ter = (si->ext_bcch_frequency_list[0] >> 4) & 1; decode_freq_list(s->freq, si->ext_bcch_frequency_list, sizeof(si->ext_bcch_frequency_list), 0x8e, FREQ_TYPE_NCELL_2ter); @@ -780,8 +780,8 @@ memcpy(s->si5_msg, si, OSMO_MIN(len, sizeof(s->si5_msg))); /* Neighbor Cell Description */ - s->nb_ext_ind_si5 = (si->bcch_frequency_list[0] >> 6) & 1; - s->nb_ba_ind_si5 = (si->bcch_frequency_list[0] >> 5) & 1; + s->nb_ext_ind_si5 = (si->bcch_frequency_list[0] >> 5) & 1; + s->nb_ba_ind_si5 = (si->bcch_frequency_list[0] >> 4) & 1; decode_freq_list(s->freq, si->bcch_frequency_list, sizeof(si->bcch_frequency_list), 0xce, FREQ_TYPE_REP_5); @@ -797,8 +797,8 @@ memcpy(s->si5b_msg, si, OSMO_MIN(len, sizeof(s->si5b_msg))); /* Neighbor Cell Description */ - s->nb_ext_ind_si5bis = (si->bcch_frequency_list[0] >> 6) & 1; - s->nb_ba_ind_si5bis = (si->bcch_frequency_list[0] >> 5) & 1; + s->nb_ext_ind_si5bis = (si->bcch_frequency_list[0] >> 5) & 1; + s->nb_ba_ind_si5bis = (si->bcch_frequency_list[0] >> 4) & 1; decode_freq_list(s->freq, si->bcch_frequency_list, sizeof(si->bcch_frequency_list), 0xce, FREQ_TYPE_REP_5bis); @@ -814,8 +814,8 @@ memcpy(s->si5t_msg, si, OSMO_MIN(len, sizeof(s->si5t_msg))); /* Neighbor Cell Description */ - s->nb_multi_rep_si5ter = (si->bcch_frequency_list[0] >> 6) & 3; - s->nb_ba_ind_si5ter = (si->bcch_frequency_list[0] >> 5) & 1; + s->nb_multi_rep_si5ter = (si->bcch_frequency_list[0] >> 5) & 3; + s->nb_ba_ind_si5ter = (si->bcch_frequency_list[0] >> 4) & 1; decode_freq_list(s->freq, si->bcch_frequency_list, sizeof(si->bcch_frequency_list), 0x8e, FREQ_TYPE_REP_5ter); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie5349464fed0a4276955235c7c87b5bcb299f20d Gerrit-Change-Number: 34604 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: Correctly use SUP_WRITE() macro for GSM 850
by laforge 05 Oct '23

05 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34606?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Correctly use SUP_WRITE() macro for GSM 850 ...................................................................... Correctly use SUP_WRITE() macro for GSM 850 Change-Id: I52c99c63e38934fb26c26dba5bf2551ea311228b --- M src/host/layer23/src/mobile/vty_interface.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index 5e5fa6d..a4b97bc 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -1213,7 +1213,7 @@ SUP_WRITE(p_gsm, "p-gsm"); SUP_WRITE(e_gsm, "e-gsm"); SUP_WRITE(r_gsm, "r-gsm"); - SUP_WRITE(pcs, "gsm-850"); + SUP_WRITE(gsm_850, "gsm-850"); SUP_WRITE(gsm_480, "gsm-480"); SUP_WRITE(gsm_450, "gsm-450"); SUP_WRITE(dcs, "dcs"); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34606?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I52c99c63e38934fb26c26dba5bf2551ea311228b Gerrit-Change-Number: 34606 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: Fix typo in sysinfo.c
by laforge 05 Oct '23

05 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34605?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Fix typo in sysinfo.c ...................................................................... Fix typo in sysinfo.c Change-Id: I12405bef9f7910a354d9ac5153f4adc55095d747 --- M src/host/layer23/src/common/sysinfo.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index 66b87eb..12780c2 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -255,7 +255,7 @@ print(priv, "\n"); /* cell selection */ - print(priv, "MX_TXPWR_MAX_CCCH = %d CRH = %d RXLEV_MIN = %d " + print(priv, "MS_TXPWR_MAX_CCCH = %d CRH = %d RXLEV_MIN = %d " "NECI = %d ACS = %d\n", s->ms_txpwr_max_cch, s->cell_resel_hyst_db, s->rxlev_acc_min_db, s->neci, s->acs); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I12405bef9f7910a354d9ac5153f4adc55095d747 Gerrit-Change-Number: 34605 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmocom-bb[master]: Fix potential NULL pointer dereferences, discovered by Coverity Scan
by laforge 05 Oct '23

05 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34608?usp=email ) Change subject: Fix potential NULL pointer dereferences, discovered by Coverity Scan ...................................................................... Fix potential NULL pointer dereferences, discovered by Coverity Scan See: CID 323362 + CID 323363 Change-Id: I47aa506014d8bddb8c8ce9b506c1c5c7b8056d30 --- M src/host/layer23/src/mobile/gsm48_mm.c 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_mm.c b/src/host/layer23/src/mobile/gsm48_mm.c index cec798b..810dfa7 100644 --- a/src/host/layer23/src/mobile/gsm48_mm.c +++ b/src/host/layer23/src/mobile/gsm48_mm.c @@ -3190,6 +3190,8 @@ (msg_type & GSM48_MMXX_MASK), mmh->ref, mmh->transaction_id, sapi); + if (!nmsg) + return -ENOMEM; nmmh = (struct gsm48_mmxx_hdr *)nmsg->data; nmmh->cause = cause; gsm48_mmxx_upmsg(ms, nmsg); @@ -3410,6 +3412,8 @@ (msg_type & GSM48_MMXX_MASK), mmh->ref, mmh->transaction_id, sapi); + if (!nmsg) + return -ENOMEM; nmmh = (struct gsm48_mmxx_hdr *)nmsg->data; nmmh->cause = 17; gsm48_mmxx_upmsg(ms, nmsg); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I47aa506014d8bddb8c8ce9b506c1c5c7b8056d30 Gerrit-Change-Number: 34608 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0