January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 ) Change subject: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts ...................................................................... Patch Set 1: (2 comments) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997/comment/9e17055f_23cb… PS1, Line 9335: not > are forbidden? not part of this patch, but still I'll submit a follow up patch. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997/comment/9a27017f_0bca… PS1, Line 9342: differnet > different Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d342e5938f6293ae45ee399796417651768af5d Gerrit-Change-Number: 30997 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:21:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: gpsr_ns2_udp: Use osmo_io_fd instead of osmo_fd

by pespin

Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30936 ) Change subject: gpsr_ns2_udp: Use osmo_io_fd instead of osmo_fd ...................................................................... Patch Set 3: (3 comments) File src/gb/gprs_ns2_udp.c: https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/04398edc_0d98005d PS3, Line 50: struct > might be worth renaming the struct member from fd to iofd or io_fd to make the code more obvious iofd sounds good. We already use "ofd" for osmo_fd. https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/828a6ab7_9b301c71 PS3, Line 72: if (priv->fd) yeah this definetly needs to be named priv->iofd. https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/b1b1011f_563f17e0 PS3, Line 153: rc = > you can do away with the rc variable as there are no local users here anymore. […] Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id776d2d9f35c304620f3d5b94492148dd987f5a0 Gerrit-Change-Number: 30936 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:15:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: Add osmo_io with initial poll backend

by pespin

Attention is currently required from: osmith, Hoernchen, neels, laforge, fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30934 ) Change subject: Add osmo_io with initial poll backend ...................................................................... Patch Set 3: (26 comments) File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/8d04803d_26ccd6a7 PS3, Line 49: void osmo_iofd_read_enable(struct osmo_io_fd *iofd); duplicated declaration? one probably should be "disable" https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/a893cd75_7d281ec1 PS3, Line 55: unsigned int osmo_iofd_get_priv(struct osmo_io_fd *iofd); const iofd https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/9779c049_4723f660 PS3, Line 56: int osmo_iofd_get_fd(struct osmo_io_fd *iofd); const iofd File src/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/4eb23142_d4708c38 PS3, Line 44: extern struct iofd_backend_ops iofd_poll_ops; we have an internal header, maybe move this there? https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/b45183be_4c0b39cd PS3, Line 47: static enum osmo_io_backend g_backend; g_io_backend? https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/325f6a28_d6e94902 PS3, Line 50: struct iofd_backend_ops g_iofd_ops; then better name it with an osmo_ prefix. https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/5f694a6e_7c527ff6 PS3, Line 111: talloc_free(msghdr); the ownserhip of msghdr->msg is not really clear here. If a msg ptr is passed in iofd_msghdr_alloc, is it expected to pass ownsership of msg to msghdr? If so, either: - call talloc_steal in iofd_msghdr_alloc - explicitly talloc_free msghdr->msg here. https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/c5f10141_edbf357f PS3, Line 203: e > no doxygen docs, but function is exported Ack https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/3989be04_0f4f8bb4 PS3, Line 225: msg_pending = iofd_msgb_alloc(iofd); I wonder why do we need to allocate + copy to a new msgb here. https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/d9474b17_ea77ad96 PS3, Line 228: iofd->pending = msg_pending; iofd->pending may already be set here? in that case may leak the previous iofd->pending? https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/9cf86edf_f55914c5 PS3, Line 299: int osmo_iofd_sendto_msgb(struct osmo_io_fd *iofd, struct msgb *msg, const struct osmo_sockaddr *dest) we may be missing "int flags" here? https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/8d0ed2a8_3583faa5 PS3, Line 367: iofd->name = talloc_strdup(iofd, name); This can be split into a separate func osmo_iofd_set_name(), simplifying the current osmo_iofd_setup param list. Some apps may not even care nor want to spend cycles allocating memory and setting names. https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/9dd628e7_0023c4fa PS3, Line 389: g_backend == OSMO_IO_BACKEND_POLL ? "poll" : "uring" > there might be more in the future, it might be worth having a separate value_string for that rather […] Ack https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/f517d93a_a320919a PS3, Line 408: if (iofd->pending) no need for this if, must probably (free function) https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/5e7e43dd_5e60bd63 PS3, Line 414: talloc_free(iofd); you still want to free the memory if close somehow fails, otherwise you'll leak it? https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/7decfc04_2f211349 PS3, Line 430: osmo_iofd_get_priv > please rename to osmo_iofd_get_priv_nr(). […] Ack File src/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/f501f63f_e7dff15c PS3, Line 72: struct { : bool read_enabled; : bool read_pending; : bool write_pending; : bool write_enabled; : /* TODO: index into array of registered fd's? */ : } uring; > should this maybe introduced only in the actual io_oring patch? Ack https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/7ff40994_73fcb0ba PS3, Line 87: // TODO: SCTP_* I'd say this needs to be added before merging the patch? or not needed? File src/osmo_io_poll.c: https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/c4b0bb76_56537732 PS3, Line 63: if (iofd->closing) { Remove {} https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/4f2e3acc_e61c1809 PS3, Line 71: rc = write(ofd->fd, msgb_data(msg), msgb_length(msg)); this should be send() in order to pass iofd->flags to it. Actually, you should have aseparate read_flags and write_flags fields most probably. https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/ef75ef5d_767d6bba PS3, Line 72: if (rc < msgb_length(msg)) { if write returns error (rc<0), you'll be doing pretty weird stuff here. https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/2c843641_2b92acf7 PS3, Line 104: socklen_t addrlen = sizeof(struct sockaddr); This is wrong afaict. It should be struct sockaddr_strorage. No need for sa, You can simply do: socklen_t addrlen = sizeof(saddr.u.ss); rc = recvfrom(ofd->fd, msgb_data(msg), msgb_tailroom(msg), 0, &saddr.u.sa, &addrlen); https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/0b2e6e3a_49d7b8f0 PS3, Line 114: > extraneous empty line Ack https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/4b1467a4_feb2bfb2 PS3, Line 117: { > coding style Ack https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/f6938d24_856ee183 PS3, Line 124: struct osmo_sockaddr *dest = &msghdr->sa; Usually we use "osa" to name an osmo_sockaddr, to differentiate it from "sa" (sockaddr). Please update the field name in msghdr. https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/fa350aec_7561a9b7 PS3, Line 128: &dest->u.sa, sizeof(*dest)); not sure if sizeof(sockaddr_storage) is good here, you may have to pass dest.u.sin or dest.u.sin6 depending on the dest.u.sa.sa_family? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I50d73cf550d6ce8154bf827bf47408131cf5b0a0 Gerrit-Change-Number: 30934 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:12:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: jenkins-common: replace subnet in scm files too

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30998 ) Change subject: jenkins-common: replace subnet in scm files too ...................................................................... jenkins-common: replace subnet in scm files too Replace the subnet in *.scm configs of nplab-sua-test and nplab-m3ua-test too. Related: OS#5802 Change-Id: Ia734df3721a4ae3408a17d33c835282b79174132 --- M jenkins-common.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/98/30998/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index c7c282c..484e513 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -270,6 +270,7 @@ "$VOL_BASE_DIR" \ -name '*.cfg' -o \ -name '*.conf' -o \ + -name '*.scm' -o \ -name '*.sh' -o \ -name '*.txt' -o \ -name '*.yaml' \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia734df3721a4ae3408a17d33c835282b79174132 Gerrit-Change-Number: 30998 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: hosts: replace invalid char minus ("-") in host group names

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30918 ) Change subject: ansible: hosts: replace invalid char minus ("-") in host group names ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0c13ce4edb7f57c7ff77141b5511080bba639ec0 Gerrit-Change-Number: 30918 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:41:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: install-coverity: add missing tag coverity

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30916 ) Change subject: ansible: install-coverity: add missing tag coverity ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I86be4c72ad3bce070ddf7f8270492b6cf8ea826e Gerrit-Change-Number: 30916 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:40:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: install-poky-sdk: add tag poky to the apt install task

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30915 ) Change subject: ansible: install-poky-sdk: add tag poky to the apt install task ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id8e433a789aff8df241687f1f109a161e725a29a Gerrit-Change-Number: 30915 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:40:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 ) Change subject: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts ...................................................................... Patch Set 1: (2 comments) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997/comment/60e570bd_6b50… PS1, Line 9335: not are forbidden? not part of this patch, but still https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997/comment/9f9ba11b_23ae… PS1, Line 9342: differnet different -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d342e5938f6293ae45ee399796417651768af5d Gerrit-Change-Number: 30997 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:40:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: .gitignore: make poky regex more specific

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30914 ) Change subject: ansible: .gitignore: make poky regex more specific ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3ac9a6129323f27ba387b44d8293d7b134716af8 Gerrit-Change-Number: 30914 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:40:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: install-poky-sdk: ensure it's not installed twice

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30913 ) Change subject: ansible: install-poky-sdk: ensure it's not installed twice ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8ff8e72a5974378327d4692341b0a371c667b741 Gerrit-Change-Number: 30913 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:40:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023