Change in libosmocore[master]: gpsr_ns2_udp: Use osmo_io_fd instead of osmo_fd
Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30936 ) Change subject: gpsr_ns2_udp: Use osmo_io_fd instead of osmo_fd ...................................................................... Patch Set 3: (3 comments) File src/gb/gprs_ns2_udp.c: https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/04398edc_0d98005d PS3, Line 50: struct
might be worth renaming the struct member from fd to iofd or io_fd to make the code more obvious iofd sounds good. We already use "ofd" for osmo_fd.
https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/828a6ab7_9b301c71 PS3, Line 72: if (priv->fd) yeah this definetly needs to be named priv->iofd. https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/b1b1011f_563f17e0 PS3, Line 153: rc =
you can do away with the rc variable as there are no local users here anymore. […] Ack
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id776d2d9f35c304620f3d5b94492148dd987f5a0 Gerrit-Change-Number: 30936 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:15:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment
participants (1)
-
pespin