Attention is currently required from: laforge, daniel.

View Change

3 comments:

• File src/gb/gprs_ns2_udp.c:

  • Patch Set #3, Line 50: struct

    might be worth renaming the struct member from fd to iofd or io_fd to make the code more obvious

    iofd sounds good. We already use "ofd" for osmo_fd.

  • Patch Set #3, Line 72: if (priv->fd)

    yeah this definetly needs to be named priv->iofd.

  • Patch Set #3, Line 153: rc =

    you can do away with the rc variable as there are no local users here anymore. […]

    Ack

To view, visit change 30936. To unsubscribe, or for help writing mail filters, visit settings.