January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: layer23: Introduce APN VTY node

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 ) Change subject: layer23: Introduce APN VTY node ...................................................................... Patch Set 3: (3 comments) File src/host/layer23/include/osmocom/bb/common/apn.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/658b8428_5835d2b0 PS3, Line 49: shut-down > this spelling looks weird, "shutdown" or "shut down"? https://en.wikipedia.org/wiki/Shutdown […] Ack https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/02ee4398_4aca2cdb PS3, Line 51: sequeence > sequence Ack File src/host/layer23/src/common/apn.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/88cbdce7_fd738219 PS3, Line 47: { > should it remove itself from ms->gprs.apn_list here? […] It's doing exactly that in the line below (48). -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e Gerrit-Change-Number: 30992 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 13:13:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce APN VTY node

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 ) Change subject: layer23: Introduce APN VTY node ...................................................................... Patch Set 3: (3 comments) File src/host/layer23/include/osmocom/bb/common/apn.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/19cdf139_02da3fe3 PS3, Line 49: shut-down this spelling looks weird, "shutdown" or "shut down"? https://en.wikipedia.org/wiki/Shutdown (but also not that important) https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/24f2ad6e_480f566e PS3, Line 51: sequeence sequence File src/host/layer23/src/common/apn.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/4176a35b_6387c65b PS3, Line 47: { should it remove itself from ms->gprs.apn_list here? otherwise it looks like with "no apn ..." vty cmd, it will still be in apn_list -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e Gerrit-Change-Number: 30992 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 13:05:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Initial integration of tun device

by pespin

Attention is currently required from: pespin. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30996 ) Change subject: layer23: Initial integration of tun device ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I86cac406843157aa2e51727cf8ccac9804d7961d Gerrit-Change-Number: 30996 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:59:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 ) Change subject: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts ...................................................................... bsc: Fix regression in TC_assignment_emerg_setup_deny_bts A recent commit introduced a regression which made TC_assignment_emerg_setup_deny_bts fail. The problematic commit (see hash below) set "pars.ra := f_rnd_ra_emerg()" in the helper function, which made the BSC early reject the CHAN RQD with ImmAssRej in the case the BTS policy forbids emergency calls. In that scenario, rejection can be done early because there's no need to wait to find out which MSC it is aimed at. This scenario, however, is already being validated by test TC_chan_rqd_emerg_deny. The scenario TC_assignment_emerg_setup_deny_bts was testing is actually one where CHAN RQD doesn't contain reason="emergency call", which means BTS doesn't early reject it, but only knows about it being an emergency call when a CC Emergency Setup is sent to it, time at which it releases the call. Hence, this commit sets back pars.ra = f_rnd_ra_emerg() only on the ..._deny_msc testcase, since it's the only test really needing it. Fixes: 14076d3b721030c5f0610403cbc7e75a6eed5351 Related: OS#5849 Change-Id: I8d342e5938f6293ae45ee399796417651768af5d --- M bsc/BSC_Tests.ttcn 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index a9d7c9d..6902744 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -9249,10 +9249,6 @@ var PDU_BSSAP emerg_setup_data_ind_bssap; timer T := 3.0; - /* Make sure the CHAN RQD indicates an emergency call (0b101xxxxx). The difference is that osmo-bsc directly - * assigns a TCH lchan and establishing voice for the emergency call will use Mode Modify, not reassignment to - * another lchan. */ - g_pars.ra := f_rnd_ra_emerg(); f_assignment_emerg_setup(); T.start; @@ -9316,12 +9312,19 @@ f_vty_allow_emerg_msc(false); f_vty_allow_emerg_bts(true, 0); + /* Make sure the CHAN RQD indicates an emergency call (0b101xxxxx): */ + pars.ra := f_rnd_ra_emerg(); vc_conn := f_start_handler(refers(f_TC_assignment_emerg_setup_deny), pars); vc_conn.done; f_shutdown_helper(); } -/* EMERGENCY CALL situation #3, allowed globally but forbidden by BTS */ +/* EMERGENCY CALL situation #3, allowed globally but forbidden by BTS. + * The RACH req (and hence CHAN RQD) indicate other than emergency call. + * Hence BSC only learns about it being an emergency call later during call setup. + * If interested in the ra="emergency call" + deny bts policy case, + * see TC_chan_rqd_emerg_deny. + */ testcase TC_assignment_emerg_setup_deny_bts() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); var MSC_ConnHdlr vc_conn; @@ -9329,13 +9332,14 @@ /* Note: This simulates a spec violation by the MS, correct MS * implementations would not try to establish an emergency call because * the system information tells in advance that emergency calls are - * not forbidden */ + * not allowed */ f_init(1, true); f_sleep(1.0); f_vty_allow_emerg_msc(true); f_vty_allow_emerg_bts(false, 0); + /* Note: Here we implicitly leave default g_pars.ra which is different than "emergency call" */ vc_conn := f_start_handler(refers(f_TC_assignment_emerg_setup_deny), pars); vc_conn.done; f_shutdown_helper(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d342e5938f6293ae45ee399796417651768af5d Gerrit-Change-Number: 30997 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 ) Change subject: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d342e5938f6293ae45ee399796417651768af5d Gerrit-Change-Number: 30997 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:55:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: network_create: set NET_NAME after next SUBNET

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31000 ) Change subject: network_create: set NET_NAME after next SUBNET ...................................................................... network_create: set NET_NAME after next SUBNET Put the current SUBNET into NET_NAME, not the previous one. Without this patch it works too, but this makes more sense. Related: OS#5802 Change-Id: I6c90505fd6c0ba62244ff67709b0bf31bf44b449 --- M jenkins-common.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/jenkins-common.sh b/jenkins-common.sh index 484e513..2eb9aad 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -200,8 +200,8 @@ network_create() { SUBNET="$PPID" for i in $(seq 1 30); do - NET_NAME="$SUITE_NAME-$SUBNET" SUBNET="$(echo "($SUBNET + 1) % 256" | bc)" + NET_NAME="$SUITE_NAME-$SUBNET" SUB4="172.18.$SUBNET.0/24" SUB6="fd02:db8:$SUBNET::/64" set +x -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6c90505fd6c0ba62244ff67709b0bf31bf44b449 Gerrit-Change-Number: 31000 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Move '(no) shutdown' VTY code to common/vty.c

by osmith

Attention is currently required from: neels, pespin, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30972 ) Change subject: layer23: Move '(no) shutdown' VTY code to common/vty.c ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib5c9b6f3efa255d67980945db9f98dd8a112af0e Gerrit-Change-Number: 30972 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:46:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Move layer2-socket VTY command to common/

by osmith

Attention is currently required from: neels, pespin, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30978 ) Change subject: layer23: Move layer2-socket VTY command to common/ ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/6f9cfc48_a9ccd9dd PS3, Line 55: l23_vty_restart > I'll submit renaming since this seem to be creating trouble. ah, didn't realize this was discussed before in the patch. the new name is better, thanks! -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If7419f8fc54a54eed68a076968d93dba5ac977b7 Gerrit-Change-Number: 30978 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:45:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 ) Change subject: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d342e5938f6293ae45ee399796417651768af5d Gerrit-Change-Number: 30997 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:44:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: network_create: set NET_NAME after next SUBNET

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31000 ) Change subject: network_create: set NET_NAME after next SUBNET ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6c90505fd6c0ba62244ff67709b0bf31bf44b449 Gerrit-Change-Number: 31000 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:43:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023