January 2023 - gerrit-log - lists.osmocom.org

Change in pysim[master]: cards: also program EF.AD under ADF.USIM

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31004 ) Change subject: cards: also program EF.AD under ADF.USIM ...................................................................... cards: also program EF.AD under ADF.USIM DF.GSM and ADF.USIM have an EF.AD with nearly the same contents. Usually there is one file physically present and the other is just a link. Apparantly this is not always the case for sysmo-ismi-sja2 cards, so lets program EF.AD in both locations. Change-Id: Ic9dd4acc8d9a72acbb7376ddf3e2128125d4a8f5 Related: OS#5830 --- M pySim/cards.py 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/04/31004/1 diff --git a/pySim/cards.py b/pySim/cards.py index b8a37d4..d222d6a 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -178,7 +178,7 @@ data, sw = self._scc.update_record(EF['SMSP'], 1, rpad(smsp, 84)) return sw - def update_ad(self, mnc=None, opmode=None, ofm=None): + def update_ad(self, mnc=None, opmode=None, ofm=None, path=EF['AD']): """ Update Administrative Data (AD) @@ -191,6 +191,7 @@ mnc (str): MNC of IMSI opmode (Hex-str, 1 Byte): MS Operation Mode ofm (Hex-str, 1 Byte): Operational Feature Monitor (OFM) aka Ciphering Indicator + path (optional list with file path e.g. ['3f00', '7f20', '6fad']) Returns: str: Return code of write operation @@ -200,7 +201,7 @@ # read from card raw_hex_data, sw = self._scc.read_binary( - EF['AD'], length=None, offset=0) + path, length=None, offset=0) abstract_data = ad.decode_hex(raw_hex_data) # perform updates @@ -223,7 +224,7 @@ # write to card raw_hex_data = ad.encode_hex(abstract_data) - data, sw = self._scc.update_binary(EF['AD'], raw_hex_data) + data, sw = self._scc.update_binary(path, raw_hex_data) return sw def read_spn(self): @@ -1576,6 +1577,17 @@ data, sw = self.select_adf_by_aid(adf="usim") if sw == '9000': + # EF.AD in ADF.USIM + if (p.get('mcc') and p.get('mnc')) or p.get('opmode'): + if p.get('mcc') and p.get('mnc'): + mnc = p['mnc'] + else: + mnc = None + sw = self.update_ad(mnc=mnc, opmode=p.get('opmode'), + path=EF_USIM_ADF_map['AD']) + if sw != '9000': + print("Programming AD failed with code %s" % sw) + # update EF-USIM_AUTH_KEY in ADF.USIM if p.get('ki'): self._scc.update_binary('af20', p['ki'], 1) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic9dd4acc8d9a72acbb7376ddf3e2128125d4a8f5 Gerrit-Change-Number: 31004 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: sndcp: Fix missing dep link against libmath

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31003 ) Change subject: sndcp: Fix missing dep link against libmath ...................................................................... sndcp: Fix missing dep link against libmath It is already present in libosmo-gprs-sndcp.pc.in Libs.private, but it was forgotten at compile time. That makes it fail under some systems when linking against it (like jenkins): /build/deps/install/stow/libosmo-gprs/lib/libosmo-gprs-sndcp.so: undefined reference to `ceil' Change-Id: Iba9629b323b50b28cc4c54cf35b2e39ee89bc192 --- M src/sndcp/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/03/31003/1 diff --git a/src/sndcp/Makefile.am b/src/sndcp/Makefile.am index 0395ef1..26ca24f 100644 --- a/src/sndcp/Makefile.am +++ b/src/sndcp/Makefile.am @@ -44,4 +44,5 @@ libosmo_gprs_sndcp_la_LIBADD = \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ + -lm \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iba9629b323b50b28cc4c54cf35b2e39ee89bc192 Gerrit-Change-Number: 31003 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce APN VTY node

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 ) Change subject: layer23: Introduce APN VTY node ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e Gerrit-Change-Number: 30992 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 13:27:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Initial integration of tun device

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30996 ) Change subject: layer23: Initial integration of tun device ...................................................................... Patch Set 3: (2 comments) File src/host/layer23/src/common/apn.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30996/comment/0d350cbd_4c768368 PS3, Line 88: /* TODO: prepare & transmit SNDCP UNITDATA.req */ > unresolved TODO on purpose? Yes, this will be a follow-up step (actually another set of patches perhaps). https://gerrit.osmocom.org/c/osmocom-bb/+/30996/comment/49da02bc_9df1c524 PS3, Line 94: what > use "flags" instead of "what" here, so it's more descriptive? I realize that it's also "what" in lib […] what is fine here imho, otherwise it may be confused with other types of flags, like recv()/send() ones. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I86cac406843157aa2e51727cf8ccac9804d7961d Gerrit-Change-Number: 30996 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 13:26:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: Depend on libosmo-gprs-{llc,sndcp}

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30999 ) Change subject: Depend on libosmo-gprs-{llc,sndcp} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30999 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I80811f73b798151257107bc94aedabe71fee0300 Gerrit-Change-Number: 30999 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 13:26:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Initial integration of tun device

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30996 ) Change subject: layer23: Initial integration of tun device ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/host/layer23/src/common/apn.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30996/comment/eb42a6cc_acf262cb PS3, Line 88: /* TODO: prepare & transmit SNDCP UNITDATA.req */ unresolved TODO on purpose? https://gerrit.osmocom.org/c/osmocom-bb/+/30996/comment/c5c41d2a_dd72c6da PS3, Line 94: what use "flags" instead of "what" here, so it's more descriptive? I realize that it's also "what" in libosmocore, but still -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I86cac406843157aa2e51727cf8ccac9804d7961d Gerrit-Change-Number: 30996 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 13:25:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce tun.{c,h}

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30994 ) Change subject: layer23: Introduce tun.{c,h} ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd Gerrit-Change-Number: 30994 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 13:17:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ggsn[master]: Fix typos in comments and VTY descriptions

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31002 ) Change subject: Fix typos in comments and VTY descriptions ...................................................................... Fix typos in comments and VTY descriptions Change-Id: I359425152dc18d29c57047f1b10942480b7a61e5 --- M ggsn/ggsn.h M ggsn/ggsn_vty.c 2 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/02/31002/1 diff --git a/ggsn/ggsn.h b/ggsn/ggsn.h index 46f8778..1abbc9a 100644 --- a/ggsn/ggsn.h +++ b/ggsn/ggsn.h @@ -66,9 +66,9 @@ uint32_t apn_type_mask; /* GTP-U via TUN device or in Linux kernel */ enum apn_gtpu_mode gtpu_mode; - /* administratively shut-down (true) or not (false) */ + /* administratively shut down (true) or not (false) */ bool shutdown; - /* transmit G-PDU sequeence numbers (true) or not (false) */ + /* transmit G-PDU sequence numbers (true) or not (false) */ bool tx_gpdu_seq; } cfg; @@ -128,7 +128,7 @@ char *state_dir; /* Time between Echo requests on each SGSN */ unsigned int echo_interval; - /* administratively shut-down (true) or not (false) */ + /* administratively shut down (true) or not (false) */ bool shutdown; } cfg; diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c index fb0caa2..2d49a94 100644 --- a/ggsn/ggsn_vty.c +++ b/ggsn/ggsn_vty.c @@ -299,7 +299,7 @@ DEFUN(cfg_ggsn_shutdown, cfg_ggsn_shutdown_cmd, "shutdown ggsn", - "Put the GGSN in administrative shut-down\n" GGSN_STR) + "Put the GGSN in administrative shutdown\n" GGSN_STR) { struct ggsn_ctx *ggsn = (struct ggsn_ctx *) vty->index; @@ -316,7 +316,7 @@ DEFUN(cfg_ggsn_no_shutdown, cfg_ggsn_no_shutdown_cmd, "no shutdown ggsn", - NO_STR GGSN_STR "Remove the GGSN from administrative shut-down\n") + NO_STR GGSN_STR "Remove the GGSN from administrative shutdown\n") { struct ggsn_ctx *ggsn = (struct ggsn_ctx *) vty->index; @@ -344,7 +344,7 @@ DEFUN(cfg_ggsn_show_sgsn, cfg_ggsn_show_sgsn_cmd, "show sgsn", - NO_STR GGSN_STR "Remove the GGSN from administrative shut-down\n") + NO_STR GGSN_STR "Remove the GGSN from administrative shutdown\n") { struct ggsn_ctx *ggsn = (struct ggsn_ctx *) vty->index; struct sgsn_peer *sgsn; @@ -681,7 +681,7 @@ DEFUN(cfg_apn_shutdown, cfg_apn_shutdown_cmd, "shutdown", - "Put the APN in administrative shut-down\n") + "Put the APN in administrative shutdown\n") { struct apn_ctx *apn = (struct apn_ctx *) vty->index; @@ -698,7 +698,7 @@ DEFUN(cfg_apn_no_shutdown, cfg_apn_no_shutdown_cmd, "no shutdown", - NO_STR "Remove the APN from administrative shut-down\n") + NO_STR "Remove the APN from administrative shutdown\n") { struct apn_ctx *apn = (struct apn_ctx *) vty->index; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I359425152dc18d29c57047f1b10942480b7a61e5 Gerrit-Change-Number: 31002 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce netdev.{c,h}

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 13:15:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce APN VTY node

by pespin

Attention is currently required from: osmith, fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992 to look at the new patch set (#4). Change subject: layer23: Introduce APN VTY node ...................................................................... layer23: Introduce APN VTY node Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e --- M doc/examples/modem/modem.cfg M src/host/layer23/include/osmocom/bb/common/Makefile.am A src/host/layer23/include/osmocom/bb/common/apn.h M src/host/layer23/include/osmocom/bb/common/ms.h M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/modem/vty.h M src/host/layer23/src/common/Makefile.am A src/host/layer23/src/common/apn.c M src/host/layer23/src/common/ms.c M src/host/layer23/src/common/settings.c M src/host/layer23/src/modem/app_modem.c M src/host/layer23/src/modem/vty.c 12 files changed, 369 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/92/30992/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e Gerrit-Change-Number: 30992 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023