lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

January 2023

  • 1 participants
  • 2205 discussions
Change in osmocom-bb[master]: layer23: Move layer2-socket VTY command to common/
by pespin 17 Jan '23

17 Jan '23
Attention is currently required from: osmith, neels, msuraev. Hello osmith, Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30978 to look at the new patch set (#4). Change subject: layer23: Move layer2-socket VTY command to common/ ...................................................................... layer23: Move layer2-socket VTY command to common/ This allows configuring layer2-socket for other apps than mobile, like the "modem" one. Change-Id: If7419f8fc54a54eed68a076968d93dba5ac977b7 --- M src/host/layer23/include/osmocom/bb/common/l1l2_interface.h M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/vty.h M src/host/layer23/src/common/main.c M src/host/layer23/src/common/ms.c M src/host/layer23/src/common/settings.c M src/host/layer23/src/common/vty.c M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/vty_interface.c 9 files changed, 51 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/78/30978/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If7419f8fc54a54eed68a076968d93dba5ac977b7 Gerrit-Change-Number: 30978 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
Change in osmocom-bb[master]: Depend on libosmo-gprs-{llc,sndcp}
by pespin 17 Jan '23

17 Jan '23
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30999 ) Change subject: Depend on libosmo-gprs-{llc,sndcp} ...................................................................... Depend on libosmo-gprs-{llc,sndcp} These will be needed for the MS to speak SNDCP and LLC. Change-Id: I80811f73b798151257107bc94aedabe71fee0300 --- M src/host/layer23/configure.ac M src/host/layer23/src/common/Makefile.am M src/host/layer23/src/misc/Makefile.am M src/host/layer23/src/mobile/Makefile.am M src/host/layer23/src/modem/Makefile.am 5 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/99/30999/1 diff --git a/src/host/layer23/configure.ac b/src/host/layer23/configure.ac index 43ed0fb..2c6ffe5 100644 --- a/src/host/layer23/configure.ac +++ b/src/host/layer23/configure.ac @@ -47,6 +47,8 @@ PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm) PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec) PKG_CHECK_MODULES(LIBOSMOGPRSRLCMAC, libosmo-gprs-rlcmac) +PKG_CHECK_MODULES(LIBOSMOGPRSLLC, libosmo-gprs-llc) +PKG_CHECK_MODULES(LIBOSMOGPRSSNDCP, libosmo-gprs-sndcp) AC_CHECK_LIB(gps, gps_waiting, LIBGPS_CFLAGS=" -D_HAVE_GPSD" LIBGPS_LIBS=" -lgps ",,) AC_SUBST([LIBGPS_CFLAGS]) AC_SUBST([LIBGPS_LIBS]) diff --git a/src/host/layer23/src/common/Makefile.am b/src/host/layer23/src/common/Makefile.am index cc6f3f5..b43dbf3 100644 --- a/src/host/layer23/src/common/Makefile.am +++ b/src/host/layer23/src/common/Makefile.am @@ -8,6 +8,8 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOGPRSRLCMAC_CFLAGS) \ + $(LIBOSMOGPRSLLC_CFLAGS) \ + $(LIBOSMOGPRSSNDCP_CFLAGS) \ $(LIBGPS_CFLAGS) \ $(NULL) diff --git a/src/host/layer23/src/misc/Makefile.am b/src/host/layer23/src/misc/Makefile.am index 358be74..05995c3 100644 --- a/src/host/layer23/src/misc/Makefile.am +++ b/src/host/layer23/src/misc/Makefile.am @@ -9,6 +9,8 @@ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOGPRSRLCMAC_CFLAGS) \ + $(LIBOSMOGPRSLLC_CFLAGS) \ + $(LIBOSMOGPRSSNDCP_CFLAGS) \ $(LIBGPS_CFLAGS) \ $(NULL) @@ -19,6 +21,8 @@ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCODEC_LIBS) \ $(LIBOSMOGPRSRLCMAC_LIBS) \ + $(LIBOSMOGPRSLLC_LIBS) \ + $(LIBOSMOGPRSSNDCP_LIBS) \ $(LIBGPS_LIBS) \ $(NULL) diff --git a/src/host/layer23/src/mobile/Makefile.am b/src/host/layer23/src/mobile/Makefile.am index b87063b..55df667 100644 --- a/src/host/layer23/src/mobile/Makefile.am +++ b/src/host/layer23/src/mobile/Makefile.am @@ -9,6 +9,8 @@ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOGPRSRLCMAC_CFLAGS) \ + $(LIBOSMOGPRSLLC_CFLAGS) \ + $(LIBOSMOGPRSSNDCP_CFLAGS) \ $(LIBOSMOCODEC_CFLAGS) \ $(LIBOSMOGAPK_CFLAGS) \ $(LIBGPS_CFLAGS) \ @@ -42,6 +44,8 @@ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOGPRSRLCMAC_LIBS) \ + $(LIBOSMOGPRSLLC_LIBS) \ + $(LIBOSMOGPRSSNDCP_LIBS) \ $(LIBOSMOCODEC_LIBS) \ $(LIBOSMOGAPK_LIBS) \ $(LIBGPS_LIBS) \ diff --git a/src/host/layer23/src/modem/Makefile.am b/src/host/layer23/src/modem/Makefile.am index 3f4c261..4f369ad 100644 --- a/src/host/layer23/src/modem/Makefile.am +++ b/src/host/layer23/src/modem/Makefile.am @@ -9,6 +9,8 @@ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOGPRSRLCMAC_CFLAGS) \ + $(LIBOSMOGPRSLLC_CFLAGS) \ + $(LIBOSMOGPRSSNDCP_CFLAGS) \ $(NULL) bin_PROGRAMS = modem @@ -24,4 +26,6 @@ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOGPRSRLCMAC_LIBS) \ + $(LIBOSMOGPRSLLC_LIBS) \ + $(LIBOSMOGPRSSNDCP_LIBS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30999 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I80811f73b798151257107bc94aedabe71fee0300 Gerrit-Change-Number: 30999 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmocom-bb[master]: layer23: Introduce APN VTY node
by pespin 17 Jan '23

17 Jan '23
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 ) Change subject: layer23: Introduce APN VTY node ...................................................................... Patch Set 2: (3 comments) File doc/examples/modem/modem.cfg: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/8289f4c8_4bba7263 PS2, Line 12: no shutdown > 'no shutdown' again? I understand the idea that the user may want to switch between APNs, or even ac […] I'm just following existing commands (same is used for a long time in osmo-ggsn), which I suppose even comes from old cisco-like VTY namings. File src/host/layer23/include/osmocom/bb/common/apn.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/f450acfb_1d442a36 PS2, Line 62: //struct in6_addr v6_lladdr; > TODO? Yes, I'm focusing on filling holes grain by grain, otherwise it's too many pieces and too much work and patches wouldn't be nice to review. This way also other can use stuff in there earlier while developing their own parts. File src/host/layer23/include/osmocom/bb/common/ms.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/057b9677_209e32f7 PS2, Line 94: gprs_settings > Ideally, all settings should be in struct gsm_settings. I decided to split it into gsm_settings and gprs_settings since other apps may not need the GPRS part. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e Gerrit-Change-Number: 30992 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:38:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmocom-bb[master]: layer23: Move layer2-socket VTY command to common/
by pespin 17 Jan '23

17 Jan '23
Attention is currently required from: osmith, neels, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30978 ) Change subject: layer23: Move layer2-socket VTY command to common/ ...................................................................... Patch Set 3: (1 comment) File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/6209d4f0_c2ecfe7a PS3, Line 55: l23_vty_restart > maybe: l23_vty_restart_msg? […] I'll submit renaming since this seem to be creating trouble. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If7419f8fc54a54eed68a076968d93dba5ac977b7 Gerrit-Change-Number: 30978 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:34:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in docker-playground[master]: jenkins-common: replace subnet in scm files too
by osmith 17 Jan '23

17 Jan '23
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30998 ) Change subject: jenkins-common: replace subnet in scm files too ...................................................................... jenkins-common: replace subnet in scm files too Replace the subnet in *.scm configs of nplab-sua-test and nplab-m3ua-test too. Related: OS#5802 Change-Id: Ia734df3721a4ae3408a17d33c835282b79174132 --- M jenkins-common.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/jenkins-common.sh b/jenkins-common.sh index c7c282c..484e513 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -270,6 +270,7 @@ "$VOL_BASE_DIR" \ -name '*.cfg' -o \ -name '*.conf' -o \ + -name '*.scm' -o \ -name '*.sh' -o \ -name '*.txt' -o \ -name '*.yaml' \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia734df3721a4ae3408a17d33c835282b79174132 Gerrit-Change-Number: 30998 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in osmocom-bb[master]: layer23: Move '(no) shutdown' VTY code to common/vty.c
by pespin 17 Jan '23

17 Jan '23
Attention is currently required from: osmith, neels, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30972 ) Change subject: layer23: Move '(no) shutdown' VTY code to common/vty.c ...................................................................... Patch Set 4: (1 comment) File src/host/layer23/include/osmocom/bb/common/osmocom_data.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/85487353_74955e2b PS2, Line 37: struct osmobb_l23_vty_sig_data { > still unresolved, the union wasn't added yet Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib5c9b6f3efa255d67980945db9f98dd8a112af0e Gerrit-Change-Number: 30972 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:32:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in docker-playground[master]: jenkins-common: replace subnet in scm files too
by pespin 17 Jan '23

17 Jan '23
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30998 ) Change subject: jenkins-common: replace subnet in scm files too ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia734df3721a4ae3408a17d33c835282b79174132 Gerrit-Change-Number: 30998 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:24:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts
by pespin 17 Jan '23

17 Jan '23
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 ) Change subject: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts ...................................................................... Patch Set 3: (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997/comment/0e4e4356_0d73… PS1, Line 9335: not > I'll submit a follow up patch. It's actually only in here the typo, so I submitted together in this patch in the end. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d342e5938f6293ae45ee399796417651768af5d Gerrit-Change-Number: 30997 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:23:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts
by pespin 17 Jan '23

17 Jan '23
Attention is currently required from: osmith. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 to look at the new patch set (#3). Change subject: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts ...................................................................... bsc: Fix regression in TC_assignment_emerg_setup_deny_bts A recent commit introduced a regression which made TC_assignment_emerg_setup_deny_bts fail. The problematic commit (see hash below) set "pars.ra := f_rnd_ra_emerg()" in the helper function, which made the BSC early reject the CHAN RQD with ImmAssRej in the case the BTS policy forbids emergency calls. In that scenario, rejection can be done early because there's no need to wait to find out which MSC it is aimed at. This scenario, however, is already being validated by test TC_chan_rqd_emerg_deny. The scenario TC_assignment_emerg_setup_deny_bts was testing is actually one where CHAN RQD doesn't contain reason="emergency call", which means BTS doesn't early reject it, but only knows about it being an emergency call when a CC Emergency Setup is sent to it, time at which it releases the call. Hence, this commit sets back pars.ra = f_rnd_ra_emerg() only on the ..._deny_msc testcase, since it's the only test really needing it. Fixes: 14076d3b721030c5f0610403cbc7e75a6eed5351 Related: OS#5849 Change-Id: I8d342e5938f6293ae45ee399796417651768af5d --- M bsc/BSC_Tests.ttcn 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/30997/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d342e5938f6293ae45ee399796417651768af5d Gerrit-Change-Number: 30997 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
Change in osmo-ttcn3-hacks[master]: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts
by pespin 17 Jan '23

17 Jan '23
Attention is currently required from: osmith. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 to look at the new patch set (#2). Change subject: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts ...................................................................... bsc: Fix regression in TC_assignment_emerg_setup_deny_bts A recent commit introduced a regression which made TC_assignment_emerg_setup_deny_bts fail. The problematic commit (see hash below) set "pars.ra := f_rnd_ra_emerg()" in the helper function, which made the BSC early reject the CHAN RQD with ImmAssRej in the case the BTS policy forbids emergency calls. In that scenario, rejection can be done early because there's no need to wait to find out which MSC it is aimed at. This scenario, however, is already being validated by test TC_chan_rqd_emerg_deny. The scenario TC_assignment_emerg_setup_deny_bts was testing is actually one where CHAN RQD doesn't contain reason="emergency call", which means BTS doesn't early reject it, but only knows about it being an emergency call when a CC Emergency Setup is sent to it, time at which it releases the call. Hence, this commit sets back pars.ra = f_rnd_ra_emerg() only on the ..._deny_msc testcase, since it's the only test really needing it. Fixes: 14076d3b721030c5f0610403cbc7e75a6eed5351 Related: OS#5849 Change-Id: I8d342e5938f6293ae45ee399796417651768af5d --- M bsc/BSC_Tests.ttcn 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/30997/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d342e5938f6293ae45ee399796417651768af5d Gerrit-Change-Number: 30997 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 95
  • 96
  • 97
  • 98
  • 99
  • 100
  • 101
  • ...
  • 221
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.