January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: ansible: replace deprecated include by import_tasks

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30912 ) Change subject: ansible: replace deprecated include by import_tasks ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I29766c65b9e1601a20aa8f20a438e8368c65f6a8 Gerrit-Change-Number: 30912 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:40:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-hnbgw[master]: drop bogus error log 'no MGW fsm'

by laforge

Attention is currently required from: neels, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/30688 ) Change subject: drop bogus error log 'no MGW fsm' ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/30688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I89dd4fb6913bfb84b6667b159e09968734e2102a Gerrit-Change-Number: 30688 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:39:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in mncc-python[master]: rtpsourcec: Fix compilation on Debian 11 / gcc-10.2.1

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/mncc-python/+/30858 ) Change subject: rtpsourcec: Fix compilation on Debian 11 / gcc-10.2.1 ...................................................................... rtpsourcec: Fix compilation on Debian 11 / gcc-10.2.1 rtpsource.c: In function ‘signal_handler’: rtpsource.c:209:3: error: called object ‘signal’ is not a function or function pointer 209 | signal(SIGABRT, SIG_DFL); | ^~~~~~ rtpsource.c:198:32: note: declared here 198 | static void signal_handler(int signal) | ~~~~^~~~~~ Change-Id: I57d13faa8052b6f15890ce9c6c74efa927d2e2ab --- M rtpsource/rtpsource.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve diff --git a/rtpsource/rtpsource.c b/rtpsource/rtpsource.c index d966a4f..fb108bf 100644 --- a/rtpsource/rtpsource.c +++ b/rtpsource/rtpsource.c @@ -35,6 +35,7 @@ #include <unistd.h> #include <errno.h> #include <getopt.h> +#include <signal.h> #include <sys/signal.h> #include <osmocom/core/linuxlist.h> @@ -194,9 +195,9 @@ struct rtpsource_state *g_rss; static void *g_tall_ctx; -static void signal_handler(int signal) +static void signal_handler(int signum) { - switch (signal) { + switch (signum) { case SIGABRT: /* in case of abort, we want to obtain a talloc report and * then run default SIGABRT handler, who will generate coredump -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/30858 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: I57d13faa8052b6f15890ce9c6c74efa927d2e2ab Gerrit-Change-Number: 30858 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in mncc-python[master]: rtpsourcec: Fix compilation on Debian 11 / gcc-10.2.1

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/mncc-python/+/30858 ) Change subject: rtpsourcec: Fix compilation on Debian 11 / gcc-10.2.1 ...................................................................... Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/30858 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: I57d13faa8052b6f15890ce9c6c74efa927d2e2ab Gerrit-Change-Number: 30858 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:39:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 ) Change subject: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d342e5938f6293ae45ee399796417651768af5d Gerrit-Change-Number: 30997 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:38:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-trx[master]: ms: update submodule to currently known working version

by laforge

Attention is currently required from: Hoernchen, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30967 ) Change subject: ms: update submodule to currently known working version ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I690f508d1f0cee0b623196dd4574c3ee456f07fa Gerrit-Change-Number: 30967 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:37:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-trx[master]: ms: adjust float<->integral type conversion

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30966 ) Change subject: ms: adjust float<->integral type conversion ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I93f077f967daf2ed382d12cc20a54846b3688634 Gerrit-Change-Number: 30966 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:36:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-trx[master]: .clang-format: adjust template formatting

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30970 ) Change subject: .clang-format: adjust template formatting ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9345693982ce33e6bc811be9e98b9d3da2add7a1 Gerrit-Change-Number: 30970 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:35:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 ) Change subject: bsc: Fix regression in TC_assignment_emerg_setup_deny_bts ...................................................................... bsc: Fix regression in TC_assignment_emerg_setup_deny_bts A recent commit introduced a regression which made TC_assignment_emerg_setup_deny_bts fail. The problematic commit (see hash below) set "pars.ra := f_rnd_ra_emerg()" in the helper function, which made the BSC early reject the CHAN RQD with ImmAssRej in the case the BTS policy forbids emergency calls. In that scenario, rejection can be done early because there's no need to wait to find out which MSC it is aimed at. This scenario, however, is already being validated by test TC_chan_rqd_emerg_deny. The scenario TC_assignment_emerg_setup_deny_bts was testing is actually one where CHAN RQD doesn't contain reason="emergency call", which means BTS doesn't early reject it, but only knows about it being an emergency call when a CC Emergency Setup is sent to it, time at which it releases the call. Hence, this commit sets back pars.ra = f_rnd_ra_emerg() only on the ..._deny_msc testcase, since it's the only test really needing it. Fixes: 14076d3b721030c5f0610403cbc7e75a6eed5351 Related: OS#5849 Change-Id: I8d342e5938f6293ae45ee399796417651768af5d --- M bsc/BSC_Tests.ttcn 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/30997/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index a9d7c9d..0325c42 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -9249,10 +9249,6 @@ var PDU_BSSAP emerg_setup_data_ind_bssap; timer T := 3.0; - /* Make sure the CHAN RQD indicates an emergency call (0b101xxxxx). The difference is that osmo-bsc directly - * assigns a TCH lchan and establishing voice for the emergency call will use Mode Modify, not reassignment to - * another lchan. */ - g_pars.ra := f_rnd_ra_emerg(); f_assignment_emerg_setup(); T.start; @@ -9316,12 +9312,19 @@ f_vty_allow_emerg_msc(false); f_vty_allow_emerg_bts(true, 0); + /* Make sure the CHAN RQD indicates an emergency call (0b101xxxxx): */ + pars.ra := f_rnd_ra_emerg(); vc_conn := f_start_handler(refers(f_TC_assignment_emerg_setup_deny), pars); vc_conn.done; f_shutdown_helper(); } -/* EMERGENCY CALL situation #3, allowed globally but forbidden by BTS */ +/* EMERGENCY CALL situation #3, allowed globally but forbidden by BTS. + * The RACH req (and hence CHAN RQD) indicate other than emergency call. + * Hence BSC only learns about it being an emergency call later during call setup. + * If interested in the ra="emergency call" + deny bts policy case, + * see TC_chan_rqd_emerg_deny. + */ testcase TC_assignment_emerg_setup_deny_bts() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); var MSC_ConnHdlr vc_conn; @@ -9336,6 +9339,7 @@ f_vty_allow_emerg_msc(true); f_vty_allow_emerg_bts(false, 0); + /* Note: Here we implicitly leave default g_pars.ra which is differnet than "emergency call" */ vc_conn := f_start_handler(refers(f_TC_assignment_emerg_setup_deny), pars); vc_conn.done; f_shutdown_helper(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d342e5938f6293ae45ee399796417651768af5d Gerrit-Change-Number: 30997 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: gpsr_ns2_udp: Use osmo_io_fd instead of osmo_fd

by laforge

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30936 ) Change subject: gpsr_ns2_udp: Use osmo_io_fd instead of osmo_fd ...................................................................... Patch Set 3: (2 comments) File src/gb/gprs_ns2_udp.c: https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/85f27c3d_58e01baf PS3, Line 50: struct might be worth renaming the struct member from fd to iofd or io_fd to make the code more obvious https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/c5ab51fc_967ec21c PS3, Line 153: rc = you can do away with the rc variable as there are no local users here anymore. just return osmo_iofd_sendto_msgb()? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id776d2d9f35c304620f3d5b94492148dd987f5a0 Gerrit-Change-Number: 30936 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 11:29:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023