January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: layer23: Introduce netdev.{c,h}

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 15:35:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce netdev.{c,h}

by pespin

Attention is currently required from: pespin. pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Use shift operand to define bitmask values

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31005 ) Change subject: layer23: Use shift operand to define bitmask values ...................................................................... layer23: Use shift operand to define bitmask values Change-Id: I22e2f543c077a4df4623c5e3bd44f8f068596baf --- M src/host/layer23/include/osmocom/bb/common/l23_app.h 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/05/31005/1 diff --git a/src/host/layer23/include/osmocom/bb/common/l23_app.h b/src/host/layer23/include/osmocom/bb/common/l23_app.h index 3c07f70..46c3f44 100644 --- a/src/host/layer23/include/osmocom/bb/common/l23_app.h +++ b/src/host/layer23/include/osmocom/bb/common/l23_app.h @@ -6,11 +6,11 @@ /* Options supported by the l23 app */ enum { - L23_OPT_SAP = 1, - L23_OPT_ARFCN = 2, - L23_OPT_TAP = 4, - L23_OPT_VTY = 8, - L23_OPT_DBG = 16, + L23_OPT_SAP = 1 << 0, + L23_OPT_ARFCN = 1 << 1, + L23_OPT_TAP = 1 << 2, + L23_OPT_VTY = 1 << 3, + L23_OPT_DBG = 1 << 4, }; extern void *l23_ctx; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31005 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22e2f543c077a4df4623c5e3bd44f8f068596baf Gerrit-Change-Number: 31005 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce tun.{c,h}

by Jenkins Builder

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30994 ) Change subject: layer23: Introduce tun.{c,h} ...................................................................... Patch Set 4: (19 comments) File src/host/layer23/include/osmocom/bb/common/tun.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/573a4857_bcafdfdb PS4, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/5225cfd9_a47a1ddd PS4, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/8f1647c4_d425c49b PS4, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/e8348cf4_22643c27 PS4, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack, Unnecessary space before function pointer arguments File src/host/layer23/src/common/tun.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/eab543b1_78f877c5 PS4, Line 48: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/07427985_f59ab32e PS4, Line 53: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/9d9bd55f_7b67766c PS4, Line 65: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/0036de06_8388573b PS4, Line 104: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/dd607443_87916a4d PS4, Line 123: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/c79d4e60_5cb27927 PS4, Line 186: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/9ff3c9f1_c40a7665 PS4, Line 214: strcpy(ifr.ifr_name, dev_name); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/640a53ab_1565d70d PS4, Line 221: strncpy((*tun)->devname, ifr.ifr_name, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/425cbba1_0d881df5 PS4, Line 229: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/4f04445e_f959c25d PS4, Line 230: strncpy((*tun)->devname, dev_name, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/fc41a734_01996b9d PS4, Line 243: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/526394a5_0618c4ea PS4, Line 273: strncpy(areq.ifra_name, (*tun)->devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/ccc1421e_c25e5bc6 PS4, Line 283: while (ioctl(fd, SIOCDIFADDR, (void *)&areq) != -1) ; space prohibited before semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/d3216d81_38ed6a84 PS4, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2811): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/3cd0d235_3e7360b6 PS4, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len)) Unnecessary space before function pointer arguments -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd Gerrit-Change-Number: 30994 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 15:28:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce netdev.{c,h}

by Jenkins Builder

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Patch Set 4: (42 comments) File src/host/layer23/include/osmocom/bb/common/netdev.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5cca2146_5d94189b PS4, Line 33: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/67d5c7f1_3cb79a58 PS4, Line 33: { open brace '{' following struct go on the same line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/764ca7aa_d2ab1bd9 PS4, Line 35: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d130cc4b_135ebc9b PS4, Line 36: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a9b2b1ea_84aa9c38 PS4, Line 38: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/26a88708_e0c397b0 PS4, Line 39: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9b09ea95_a9da3a03 PS4, Line 43: u_int8_t tos; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/73d097a0_622d2625 PS4, Line 44: u_int16_t tot_len; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/3881047a_d51ec8b0 PS4, Line 45: u_int16_t id; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e1c51d64_cfcc4c28 PS4, Line 46: u_int16_t frag_off; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/fabb92a8_094086cd PS4, Line 47: u_int8_t ttl; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9b59ca45_b4558bf9 PS4, Line 48: u_int8_t protocol; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/7870de6d_171ecfa9 PS4, Line 49: u_int16_t check; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5a603b79_85756af8 PS4, Line 50: u_int32_t saddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/cc09c3d1_db9dceff PS4, Line 51: u_int32_t daddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8ac51e92_d0eb828d PS4, Line 53: }; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/cca37578_1016c849 PS4, Line 57: struct osmo_sockaddr addr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/21b86069_f2f13e18 PS4, Line 58: uint8_t prefixlen; please, no spaces at the start of a line File src/host/layer23/src/common/netdev.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/579cef39_3f2027bf PS4, Line 45: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/42dbc390_3df65347 PS4, Line 49: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/607eb07d_91e2a74d PS4, Line 61: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/ebf02f71_30e7a96d PS4, Line 97: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/ba91663b_8b4dda98 PS4, Line 125: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1fbf600b_cce22efc PS4, Line 132: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/27518212_fef839c0 PS4, Line 160: if (ioctl(fd, SIOCSIFDSTADDR, (caddr_t) & ifr) < 0) { space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/c749fd0b_0300d07d PS4, Line 172: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/38822558_8243730b PS4, Line 191: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f6e53b95_e121921f PS4, Line 213: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/49441006_af136fea PS4, Line 214: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5854aaf7_c632957c PS4, Line 249: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d1d0cc55_53c5808e PS4, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/88493a8c_2cd643a1 PS4, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/70c22b00_faab758f PS4, Line 387: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/ef48b395_df13c315 PS4, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/643cbb64_8e272c36 PS4, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1324a83a_5dc4df39 PS4, Line 536: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/91bc8e6a_5c9f50a9 PS4, Line 608: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/2b0f29cf_9e38708d PS4, Line 677: strncpy(ifr.ifr_name, gw_iface, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f1d202df_e8c57257 PS4, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/6e600438_8a470da6 PS4, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/06a242fe_22ada977 PS4, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/86014121_8b1e74aa PS4, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 15:28:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Initial integration of tun device

by pespin

Attention is currently required from: osmith. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30996 to look at the new patch set (#4). Change subject: layer23: Initial integration of tun device ...................................................................... layer23: Initial integration of tun device Change-Id: I86cac406843157aa2e51727cf8ccac9804d7961d --- M src/host/layer23/include/osmocom/bb/common/apn.h M src/host/layer23/src/common/apn.c 2 files changed, 94 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/30996/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I86cac406843157aa2e51727cf8ccac9804d7961d Gerrit-Change-Number: 30996 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: sndcp: Fix missing dep link against libmath

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31003 ) Change subject: sndcp: Fix missing dep link against libmath ...................................................................... sndcp: Fix missing dep link against libmath It is already present in libosmo-gprs-sndcp.pc.in Libs.private, but it was forgotten at compile time. That makes it fail under some systems when linking against it (like jenkins): /build/deps/install/stow/libosmo-gprs/lib/libosmo-gprs-sndcp.so: undefined reference to `ceil' Change-Id: Iba9629b323b50b28cc4c54cf35b2e39ee89bc192 --- M src/sndcp/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/sndcp/Makefile.am b/src/sndcp/Makefile.am index 0395ef1..26ca24f 100644 --- a/src/sndcp/Makefile.am +++ b/src/sndcp/Makefile.am @@ -44,4 +44,5 @@ libosmo_gprs_sndcp_la_LIBADD = \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ + -lm \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iba9629b323b50b28cc4c54cf35b2e39ee89bc192 Gerrit-Change-Number: 31003 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: kernel_test_wait_for_vm: increase timeout to 15s

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31001 ) Change subject: kernel_test_wait_for_vm: increase timeout to 15s ...................................................................... kernel_test_wait_for_vm: increase timeout to 15s As we run more testsuites in parallel, the load was higher and so this timeout was reached. Related: OS#5802 Change-Id: I823010106a99a4906e32198ed42b36f9fe662c4e --- M jenkins-common.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jenkins-common.sh b/jenkins-common.sh index 2eb9aad..08d4e4e 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -420,7 +420,7 @@ return fi - for i in $(seq 1 10); do + for i in $(seq 1 15); do sleep 1 if grep -q KERNEL_TEST_VM_IS_READY "$log"; then -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I823010106a99a4906e32198ed42b36f9fe662c4e Gerrit-Change-Number: 31001 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: kernel_test_wait_for_vm: increase timeout to 15s

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31001 ) Change subject: kernel_test_wait_for_vm: increase timeout to 15s ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I823010106a99a4906e32198ed42b36f9fe662c4e Gerrit-Change-Number: 31001 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 14:46:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: sndcp: Fix missing dep link against libmath

by osmith

Attention is currently required from: pespin, fixeria, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31003 ) Change subject: sndcp: Fix missing dep link against libmath ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iba9629b323b50b28cc4c54cf35b2e39ee89bc192 Gerrit-Change-Number: 31003 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 13:41:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023