lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

January 2023

  • 1 participants
  • 2205 discussions
Change in osmo-pcu[master]: llc: Refactor code checking if PDU expired while dequeueing
by fixeria 26 Jan '23

26 Jan '23
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31087 ) Change subject: llc: Refactor code checking if PDU expired while dequeueing ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia0738caa1ccab5f78c2d49db582bdce96f18600a Gerrit-Change-Number: 31087 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:44:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-pcu[master]: llc: Mark llc_is_user_data_frame() as static
by fixeria 26 Jan '23

26 Jan '23
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31086 ) Change subject: llc: Mark llc_is_user_data_frame() as static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8e38a946c87142a09e0b49ea3160df1d5772b587 Gerrit-Change-Number: 31086 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:43:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in libosmocore[master]: SI: add missing header
by fixeria 26 Jan '23

26 Jan '23
Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31080 ) Change subject: SI: add missing header ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/755f2d7a_9aaf1ed9 PS1, Line 12: Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3 Fixes: 600d4eeab71665c0aec0a11a226d231f109534ca File include/osmocom/gsm/gsm48.h: https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/35863964_4e970e33 PS1, Line 38: const char *gsm48_rr_msg_type_short_name(uint8_t msgtype); > I wonder why isn't this named gsm48_rr_msg_short_name() following the existing ones. Ack, I also find the current naming confusing. It may look like the function is returning a short name. I suggest to rename it, before it's too late. How about: gsm48_rr_short_pd_msg_name()? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3 Gerrit-Change-Number: 31080 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:42:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: hnbgw: add HNBAP port to ConnHdlr
by pespin 26 Jan '23

26 Jan '23
Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085 ) Change subject: hnbgw: add HNBAP port to ConnHdlr ...................................................................... Patch Set 1: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085/comment/e40bd8a6_a87f… PS1, Line 414: /* disconnect test_CT HNBAP[i], instead connect ConnHdlr.HNBAP to HNBAP[i] */ > Usually you have the test logic either in the test_CT or in the ConnHdlr. […] because there may be tests currently spawning ConHdlr but still sending HNBAP from the test_CT, that's why I'm asking. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e7ffded5bd9974c444dbb567b6afa643b5b2501 Gerrit-Change-Number: 31085 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:38:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: hnbgw: add HNBGWVTY to ConnHdlr
by pespin 26 Jan '23

26 Jan '23
Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084 ) Change subject: hnbgw: add HNBGWVTY to ConnHdlr ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > AFAIU, to allow accessing the VTY from test logic running on ConnHdlr. […] Yes sure, I'm just asking whether is this needed and how will it be used :) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic325fd5eb5134529012856c08336633c1413284d Gerrit-Change-Number: 31084 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:37:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: hnbgw: add HNBAP port to ConnHdlr
by fixeria 26 Jan '23

26 Jan '23
Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085 ) Change subject: hnbgw: add HNBAP port to ConnHdlr ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085/comment/66df24a6_1f88… PS1, Line 414: /* disconnect test_CT HNBAP[i], instead connect ConnHdlr.HNBAP to HNBAP[i] */ > Isn't this breaking existing tests which used test_CT HNBAP[i] ? Usually you have the test logic either in the test_CT or in the ConnHdlr. Why would this break the test_CT ones? With this patch applied, the ConnHdlr spawned by this function gets exclusive access to one of the HNBAP ports (determined by pars.hnb_idx). Leaving an HNBAP port connected to the test_CT would require all HNBAP.send() operations to use explicit addressing... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e7ffded5bd9974c444dbb567b6afa643b5b2501 Gerrit-Change-Number: 31085 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:31:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: hnbgw: add HNBGWVTY to ConnHdlr
by fixeria 26 Jan '23

26 Jan '23
Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084 ) Change subject: hnbgw: add HNBGWVTY to ConnHdlr ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > Why do we need this? having one VTY instance per test isn't enough? AFAIU, to allow accessing the VTY from test logic running on ConnHdlr. Each ConnHdlr will have it's own TCP/VTY connection, not interfering with the others. We have this in other testsuites too, check e.g. MSC_ConnHdlr in ttcn3-bsc-test. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic325fd5eb5134529012856c08336633c1413284d Gerrit-Change-Number: 31084 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:20:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: hnbgw: drop duplicate import
by fixeria 26 Jan '23

26 Jan '23
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31083 ) Change subject: hnbgw: drop duplicate import ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib24ecca40679fd80be2555ada208121d730c1904 Gerrit-Change-Number: 31083 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:11:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-pcu[master]: llc: Refactor code checking if PDU expired while dequeueing
by pespin 26 Jan '23

26 Jan '23
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31087 ) Change subject: llc: Refactor code checking if PDU expired while dequeueing ...................................................................... llc: Refactor code checking if PDU expired while dequeueing The previous function name was misleading since it was checking already for more stuff than pdu containing user data. Rename the function and move all checks on PDU in there instead of having it half in one place and half in the other. Change-Id: Ia0738caa1ccab5f78c2d49db582bdce96f18600a --- M src/llc.c 1 file changed, 8 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/87/31087/1 diff --git a/src/llc.c b/src/llc.c index c283146..7d39d61 100644 --- a/src/llc.c +++ b/src/llc.c @@ -80,9 +80,12 @@ llc->length += len; } -static bool llc_is_user_data_frame(const uint8_t *data, size_t len) +static bool llc_pdu_can_be_discarded(const uint8_t *data, size_t len) { - if (len < 2) + const unsigned keep_small_thresh = 60; + + /* Is the frame small, perhaps only a TCP ACK? */ + if (len <= keep_small_thresh) return false; if ((data[0] & 0x0f) == 1 /* GPRS_SAPI_GMM */) @@ -271,7 +274,6 @@ struct gprs_rlcmac_bts *bts = q->ms->bts; struct gprs_pcu *pcu = bts->pcu; struct timespec hyst_delta = {0, 0}; - const unsigned keep_small_thresh = 60; enum gprs_llc_queue_prio prio; if (pcu->vty.llc_discard_csec) @@ -306,14 +308,9 @@ /* Hysteresis mode, try to discard LLC messages until * the low water mark has been reached */ - /* Check whether to abort the hysteresis mode */ - - /* Is the frame small, perhaps only a TCP ACK? */ - if (msg->len <= keep_small_thresh) - break; - - /* Is it a GMM message? */ - if (!llc_is_user_data_frame(msg->data, msg->len)) + /* Check whether to abort the hysteresis mode: + * Can the PDU be discarded according to its type? */ + if (!llc_pdu_can_be_discarded(msg->data, msg->len)) break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia0738caa1ccab5f78c2d49db582bdce96f18600a Gerrit-Change-Number: 31087 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-pcu[master]: llc: Mark llc_is_user_data_frame() as static
by pespin 26 Jan '23

26 Jan '23
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31086 ) Change subject: llc: Mark llc_is_user_data_frame() as static ...................................................................... llc: Mark llc_is_user_data_frame() as static It's only used once in the same file. Change-Id: I8e38a946c87142a09e0b49ea3160df1d5772b587 --- M src/llc.c M src/llc.h 2 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/86/31086/1 diff --git a/src/llc.c b/src/llc.c index ddc1e03..c283146 100644 --- a/src/llc.c +++ b/src/llc.c @@ -80,7 +80,7 @@ llc->length += len; } -bool llc_is_user_data_frame(const uint8_t *data, size_t len) +static bool llc_is_user_data_frame(const uint8_t *data, size_t len) { if (len < 2) return false; diff --git a/src/llc.h b/src/llc.h index fe14c6a..58b169e 100644 --- a/src/llc.h +++ b/src/llc.h @@ -58,7 +58,6 @@ uint16_t index; /* current write/read position of frame */ uint16_t length; /* len of current DL LLC_frame, 0 == no frame */ }; -bool llc_is_user_data_frame(const uint8_t *data, size_t len); void llc_init(struct gprs_llc *llc); void llc_reset(struct gprs_llc *llc); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8e38a946c87142a09e0b49ea3160df1d5772b587 Gerrit-Change-Number: 31086 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 31
  • 32
  • 33
  • 34
  • 35
  • 36
  • 37
  • ...
  • 221
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.