January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: llc: Mark llc_is_user_data_frame() as static

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31086 ) Change subject: llc: Mark llc_is_user_data_frame() as static ...................................................................... llc: Mark llc_is_user_data_frame() as static It's only used once in the same file. Change-Id: I8e38a946c87142a09e0b49ea3160df1d5772b587 --- M src/llc.c M src/llc.h 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/llc.c b/src/llc.c index ddc1e03..c283146 100644 --- a/src/llc.c +++ b/src/llc.c @@ -80,7 +80,7 @@ llc->length += len; } -bool llc_is_user_data_frame(const uint8_t *data, size_t len) +static bool llc_is_user_data_frame(const uint8_t *data, size_t len) { if (len < 2) return false; diff --git a/src/llc.h b/src/llc.h index fe14c6a..58b169e 100644 --- a/src/llc.h +++ b/src/llc.h @@ -58,7 +58,6 @@ uint16_t index; /* current write/read position of frame */ uint16_t length; /* len of current DL LLC_frame, 0 == no frame */ }; -bool llc_is_user_data_frame(const uint8_t *data, size_t len); void llc_init(struct gprs_llc *llc); void llc_reset(struct gprs_llc *llc); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8e38a946c87142a09e0b49ea3160df1d5772b587 Gerrit-Change-Number: 31086 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmocom-bb[master]: modem: Initial integration of libosmo-gprs-rlcmac

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31077 ) Change subject: modem: Initial integration of libosmo-gprs-rlcmac ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File src/host/layer23/src/modem/llc.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/faaecc38_94ba6757 PS4, Line 145: osmo_static_assert I believe this assertion should be done in libosmo-gprs.git instead (in the unit tests maybe), because both structs belong there? Not critical though. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0e628d9ddaa5ad6a205f07746d4176d1b8df7eb0 Gerrit-Change-Number: 31077 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 15:28:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in pysim[master]: ts_51_011: Improve decoding of SELECT response for classic SIM

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31070 ) Change subject: ts_51_011: Improve decoding of SELECT response for classic SIM ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia8e890bda74e3b4dacca0673d6e5ed8692dabd87 Gerrit-Change-Number: 31070 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Jan 2023 15:23:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in pysim[master]: ts_51_011: Support EF.LND

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31068 ) Change subject: ts_51_011: Support EF.LND ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3b7d6c7e7504b7cc8a1b62f13e8c0ae83a91d0f0 Gerrit-Change-Number: 31068 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Jan 2023 15:20:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in pysim[master]: ts_51_011: Implement Extended BCD Coding

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31066 ) Change subject: ts_51_011: Implement Extended BCD Coding ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/31066/comment/7c605ca1_69d6a9f0 PS2, Line 366: 'dialing_nr'/ExtendedBcdAdapter(BcdAdapter(Rpad(Bytes(10)))), > yes, the ExtendedBcdAdapter is written in a way that it just translates the */# characters, and in o […] But then it's not really a BcdAdapter, if it simply translates the */# characters? I don't want to block your work, but currently it looks cumbersome and confusing. Here is my proposal: class ExtendedBcdAdapter(BcdAdapter): """convert a bytes() type to a string of BCD nibbles, replacing a/b with */# """ def _decode(self, obj, context, path): obj = obj.lower().replace("a","*").replace("b","#") return super()._decode(obj, context, path) def _encode(self, obj, context, path): obj = obj.replace("*","a").replace("#","b") return super()._encode(obj, context, path) With this implementation it can be used directly. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifcec13e9b296dba7bec34b7872192b7ce185c23c Gerrit-Change-Number: 31066 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 15:18:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in pysim[master]: ts_51_011: Support EF.SDN

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31065 ) Change subject: ts_51_011: Support EF.SDN ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If91332b10138096d465a9dccf90744de2c14b2be Gerrit-Change-Number: 31065 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Jan 2023 15:01:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in pysim[master]: ts_51_011: Fix bit-order in EF.VGCSS and EF.VBSS

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31064 ) Change subject: ts_51_011: Fix bit-order in EF.VGCSS and EF.VBSS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I77674c23823aae71c9504b1a85cd75266edadc6f Gerrit-Change-Number: 31064 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:58:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in pysim[master]: gsm_r: Fix byte/nibble ordering of predefined_value1

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31057 ) Change subject: gsm_r: Fix byte/nibble ordering of predefined_value1 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31057 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia0dd8994556548a17a0a3101225c23e804511717 Gerrit-Change-Number: 31057 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:55:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in pysim[master]: gsm_r: EF_Predefined: Decode first record different from others

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31056 ) Change subject: gsm_r: EF_Predefined: Decode first record different from others ...................................................................... Patch Set 2: (5 comments) File pySim/gsm_r.py: https://gerrit.osmocom.org/c/pysim/+/31056/comment/cb605dbb_1c7d5ed6 PS2, Line 252: EF_Predefined self https://gerrit.osmocom.org/c/pysim/+/31056/comment/e388e3ba_367cee2c PS2, Line 254: EF_Predefined self https://gerrit.osmocom.org/c/pysim/+/31056/comment/1404d823_06fcb869 PS2, Line 257: r = None this line can be safely removed https://gerrit.osmocom.org/c/pysim/+/31056/comment/412ad605_4decbc94 PS2, Line 259: EF_Predefined self https://gerrit.osmocom.org/c/pysim/+/31056/comment/429c68e4_2da49f0b PS2, Line 261: EF_Predefined self -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib526f6c3c2ac9a945b8242e2e54536628376efc0 Gerrit-Change-Number: 31056 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:55:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in pysim[master]: ts_51_011, ts_31_102: point to proper EF_EXTn file

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31067 ) Change subject: ts_51_011, ts_31_102: point to proper EF_EXTn file ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5301d41225266d35c05e41588811502e5595520d Gerrit-Change-Number: 31067 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 14:49:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023