January 2023 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: libosmocore: Transition to use of 'telnet_init_default'

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31093 ) Change subject: libosmocore: Transition to use of 'telnet_init_default' ...................................................................... libosmocore: Transition to use of 'telnet_init_default' Replace remaining calls of telnet_init_dynif() by telnet_init_default() Related: OS#5809 Change-Id: Ie762d0c642021db1a6ef95333cd771351de86845 --- M tests/logging/logging_vty_test.c M tests/stats/stats_vty_test.c M tests/tdef/tdef_vty_config_root_test.c M tests/tdef/tdef_vty_config_subnode_test.c M tests/tdef/tdef_vty_dynamic_test.c M tests/vty/vty_transcript_test.c M utils/osmo-ns-dummy.c 7 files changed, 7 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/93/31093/1 diff --git a/tests/logging/logging_vty_test.c b/tests/logging/logging_vty_test.c index 96b316d..15f7fc2 100644 --- a/tests/logging/logging_vty_test.c +++ b/tests/logging/logging_vty_test.c @@ -261,7 +261,7 @@ } } - rc = telnet_init_dynif(root_ctx, NULL, vty_get_bind_addr(), 42042); + rc = telnet_init_default(root_ctx, NULL, 42042); if (rc < 0) return 2; diff --git a/tests/stats/stats_vty_test.c b/tests/stats/stats_vty_test.c index 09b125a..29cbf5e 100644 --- a/tests/stats/stats_vty_test.c +++ b/tests/stats/stats_vty_test.c @@ -70,7 +70,7 @@ osmo_stats_vty_add_cmds(); - rc = telnet_init_dynif(root_ctx, NULL, vty_get_bind_addr(), 42042); + rc = telnet_init_default(root_ctx, NULL, 42042); if (rc < 0) return 2; diff --git a/tests/tdef/tdef_vty_config_root_test.c b/tests/tdef/tdef_vty_config_root_test.c index e2dbcb4..8c46d95 100644 --- a/tests/tdef/tdef_vty_config_root_test.c +++ b/tests/tdef/tdef_vty_config_root_test.c @@ -260,7 +260,7 @@ } } - rc = telnet_init_dynif(root_ctx, NULL, vty_get_bind_addr(), 42042); + rc = telnet_init_default(root_ctx, NULL, 42042); if (rc < 0) return 2; diff --git a/tests/tdef/tdef_vty_config_subnode_test.c b/tests/tdef/tdef_vty_config_subnode_test.c index d4abe09..e3e165d 100644 --- a/tests/tdef/tdef_vty_config_subnode_test.c +++ b/tests/tdef/tdef_vty_config_subnode_test.c @@ -253,7 +253,7 @@ } } - rc = telnet_init_dynif(root_ctx, NULL, vty_get_bind_addr(), 42042); + rc = telnet_init_default(root_ctx, NULL, 42042); if (rc < 0) return 2; diff --git a/tests/tdef/tdef_vty_dynamic_test.c b/tests/tdef/tdef_vty_dynamic_test.c index 715fa60..b646c54 100644 --- a/tests/tdef/tdef_vty_dynamic_test.c +++ b/tests/tdef/tdef_vty_dynamic_test.c @@ -327,7 +327,7 @@ } } - rc = telnet_init_dynif(root_ctx, NULL, vty_get_bind_addr(), 42042); + rc = telnet_init_default(root_ctx, NULL, 42042); if (rc < 0) return 2; diff --git a/tests/vty/vty_transcript_test.c b/tests/vty/vty_transcript_test.c index 0f18f7e..1754b67 100644 --- a/tests/vty/vty_transcript_test.c +++ b/tests/vty/vty_transcript_test.c @@ -361,7 +361,7 @@ } } - rc = telnet_init_dynif(root_ctx, NULL, vty_get_bind_addr(), 42042); + rc = telnet_init_default(root_ctx, NULL, 42042); if (rc < 0) return 2; diff --git a/utils/osmo-ns-dummy.c b/utils/osmo-ns-dummy.c index e2662a2..890444c 100644 --- a/utils/osmo-ns-dummy.c +++ b/utils/osmo-ns-dummy.c @@ -272,8 +272,7 @@ fprintf(stderr, "No config file: '%s' Using default config.\n", config_file); - rc = telnet_init_dynif(ctx, NULL, vty_get_bind_addr(), - vty_port); + rc = telnet_init_default(ctx, NULL, vty_port); if (rc < 0) { fprintf(stderr, "Error initializing telnet\n"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie762d0c642021db1a6ef95333cd771351de86845 Gerrit-Change-Number: 31093 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: osmo-pcu: Transition to use of 'telnet_init_default'

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31092 ) Change subject: osmo-pcu: Transition to use of 'telnet_init_default' ...................................................................... osmo-pcu: Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: I9559486ce64a9ccf348b4ee0e1d09141dbc1ae8f --- M src/pcu_main.cpp 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/92/31092/1 diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp index 60c8c79..901ee6c 100644 --- a/src/pcu_main.cpp +++ b/src/pcu_main.cpp @@ -300,8 +300,7 @@ gsmtap_source_add_sink(pcu->gsmtap); } - rc = telnet_init_dynif(tall_pcu_ctx, NULL, vty_get_bind_addr(), - OSMO_VTY_PORT_PCU); + rc = telnet_init_default(tall_pcu_ctx, NULL, OSMO_VTY_PORT_PCU); if (rc < 0) { fprintf(stderr, "Error initializing telnet\n"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9559486ce64a9ccf348b4ee0e1d09141dbc1ae8f Gerrit-Change-Number: 31092 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc: Fix 'apply-config-file' CTRL command

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31029 ) Change subject: osmo-bsc: Fix 'apply-config-file' CTRL command ...................................................................... osmo-bsc: Fix 'apply-config-file' CTRL command Make 'apply-config-file' check the neighbor config, just as is done after config parsing on startup Related: OS#5866 Change-Id: I24ae8cd7e5e0d15eab9fd04b1858072bf0bad36a --- M src/osmo-bsc/bsc_ctrl.c 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_ctrl.c b/src/osmo-bsc/bsc_ctrl.c index ca246e7..8eb7caf 100644 --- a/src/osmo-bsc/bsc_ctrl.c +++ b/src/osmo-bsc/bsc_ctrl.c @@ -43,6 +43,7 @@ #include <osmocom/bsc/a_reset.h> #include <osmocom/bsc/ctrl.h> #include <osmocom/bsc/handover_ctrl.h> +#include <osmocom/bsc/neighbor_ident.h> static int verify_net_apply_config_file(struct ctrl_cmd *cmd, const char *value, void *_data) { @@ -83,6 +84,14 @@ goto close_ret; } + rc = neighbors_check_cfg(); + if (rc) { + cmd->reply = talloc_asprintf(cmd, "Errors in neighbor configuration"); + if (!cmd->reply) + cmd->reply = "OOM"; + goto close_ret; + } + cmd->reply = "OK"; cmd_ret = CTRL_CMD_REPLY; close_ret: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I24ae8cd7e5e0d15eab9fd04b1858072bf0bad36a Gerrit-Change-Number: 31029 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: SI13: drop meaningless error check

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31091 ) Change subject: SI13: drop meaningless error check ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib1aeaa57ad0929fd2e1296737969d89485f0ac7b Gerrit-Change-Number: 31091 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 26 Jan 2023 20:11:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-e1d[master]: Increasing max FIFO size for feature request 5875, adapting tests

by laforge

Attention is currently required from: cquirin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/31088 ) Change subject: Increasing max FIFO size for feature request 5875, adapting tests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/31088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iae76d87cf436c80c005a2f8fce5a30f74f7e4545 Gerrit-Change-Number: 31088 Gerrit-PatchSet: 1 Gerrit-Owner: cquirin <christoph.lauter(a)christoph-lauter.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: cquirin <christoph.lauter(a)christoph-lauter.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: cquirin <christoph.lauter(a)christoph-lauter.org> Gerrit-Comment-Date: Thu, 26 Jan 2023 19:51:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: Add SI10 support

by msuraev

Attention is currently required from: msuraev. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31036 ) Change subject: Add SI10 support ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a5da543f083f31e873c67b5ec1b5a439187d8f3 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 18:44:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: SI: add missing header

by msuraev

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31080 ) Change subject: SI: add missing header ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3 Gerrit-Change-Number: 31080 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 18:39:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: tun: Fix potential unpaired call to osmo_netns_switch_exit()

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31081 ) Change subject: tun: Fix potential unpaired call to osmo_netns_switch_exit() ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/31081/comment/082193d3_c500cc27 PS1, Line 7: potential unpaired called > potentially unpaired call? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadfc9eb48c6342433eee8da3e4d00ee496df3c75 Gerrit-Change-Number: 31081 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 17:41:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: tun: Fix potential unpaired call to osmo_netns_switch_exit()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31081 ) Change subject: tun: Fix potential unpaired call to osmo_netns_switch_exit() ...................................................................... tun: Fix potential unpaired call to osmo_netns_switch_exit() Fixes: Coverity CID#307429 Change-Id: Iadfc9eb48c6342433eee8da3e4d00ee496df3c75 --- M src/core/tun.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/core/tun.c b/src/core/tun.c index 7f61183..4c9dec1 100644 --- a/src/core/tun.c +++ b/src/core/tun.c @@ -407,7 +407,8 @@ close(tundev->wqueue.bfd.fd); tundev->wqueue.bfd.fd = -1; err_restore_ns: - osmo_netns_switch_exit(&switch_state); + if (tundev->netns_name) + osmo_netns_switch_exit(&switch_state); err_close_netns_fd: if (netns_fd >= 0) close(netns_fd); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadfc9eb48c6342433eee8da3e4d00ee496df3c75 Gerrit-Change-Number: 31081 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: tun: Fix potential unpaired call to osmo_netns_switch_exit()

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31081 ) Change subject: tun: Fix potential unpaired call to osmo_netns_switch_exit() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadfc9eb48c6342433eee8da3e4d00ee496df3c75 Gerrit-Change-Number: 31081 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Jan 2023 17:41:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023