Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/31080
to look at the new patch set (#2).
Change subject: SI: add missing header
......................................................................
SI: add missing header
Previous SI10 patch added function without exposing it via public header.
Let's fix this.
Fixes: 600d4eeab71665c0aec0a11a226d231f109534ca
Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
---
M include/osmocom/gsm/gsm48.h
M src/gsm/gsm48.c
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/31080/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31080
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
Gerrit-Change-Number: 31080
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria, pespin.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31080 )
Change subject: SI: add missing header
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/01bd2acb_f0fdc14a
PS1, Line 12: Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
> Fixes: 600d4eeab71665c0aec0a11a226d231f109534ca
Done
File include/osmocom/gsm/gsm48.h:
https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/4b885ba5_421867fb
PS1, Line 38: const char *gsm48_rr_msg_type_short_name(uint8_t msgtype);
> Ack, I also find the current naming confusing. […]
It's never too late to rename smth - we have API versioning in place.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31080
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
Gerrit-Change-Number: 31080
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 17:19:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31089 )
Change subject: HO: use defined constant instead of magic number
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31089
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iabedc3a704ccc766f4490e3e621e7be83995a9c6
Gerrit-Change-Number: 31089
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 26 Jan 2023 17:07:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
cquirin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/31088 )
Change subject: Increasing max FIFO size for feature request 5875, adapting tests
......................................................................
Removed Code-Review+2 by cquirin <christoph.lauter(a)christoph-lauter.org>
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/31088
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Iae76d87cf436c80c005a2f8fce5a30f74f7e4545
Gerrit-Change-Number: 31088
Gerrit-PatchSet: 1
Gerrit-Owner: cquirin <christoph.lauter(a)christoph-lauter.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: cquirin <christoph.lauter(a)christoph-lauter.org>
Gerrit-MessageType: deleteVote
cquirin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/31073 )
Change subject: Increased the size of the FIFO/RIFO to 1600 frames (instead of 800) and changed the RIFO tests in such a manner that they do not hardcode the FIFO/RIFO size.
......................................................................
Abandoned
Newbie to the process: code not linted correctly, Change-IDs messed up
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/31073
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Iebfe10aaf5244901c6ac0f4f84ac75e7947b57b8
Gerrit-Change-Number: 31073
Gerrit-PatchSet: 1
Gerrit-Owner: cquirin <christoph.lauter(a)christoph-lauter.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: abandon
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31077 )
Change subject: modem: Initial integration of libosmo-gprs-rlcmac
......................................................................
Patch Set 4:
(1 comment)
File src/host/layer23/src/modem/llc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/0162fc54_674868e4
PS4, Line 145: osmo_static_assert
> I believe this assertion should be done in libosmo-gprs. […]
It cannot be done in the lib code because they don't depend on one another. It could be done in a unit test on top of here, but having the comment in the header of the libs is enough for now imho.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I0e628d9ddaa5ad6a205f07746d4176d1b8df7eb0
Gerrit-Change-Number: 31077
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 15:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment