January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: modem: Initial integration of libosmo-gprs-rlcmac

by pespin

Attention is currently required from: osmith, fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/31077 to look at the new patch set (#2). Change subject: modem: Initial integration of libosmo-gprs-rlcmac ...................................................................... modem: Initial integration of libosmo-gprs-rlcmac This commit places code to forward unitdata LLC<->RLCMAC. Depends: libosmo-gprs.git Change-Id I1870fa6a264612c5a669bfb832e6e8c0a892cb74 Related: OS#5500 Change-Id: I0e628d9ddaa5ad6a205f07746d4176d1b8df7eb0 --- M src/host/layer23/include/osmocom/bb/common/logging.h M src/host/layer23/include/osmocom/bb/modem/Makefile.am A src/host/layer23/include/osmocom/bb/modem/rlcmac.h M src/host/layer23/src/common/logging.c M src/host/layer23/src/modem/Makefile.am M src/host/layer23/src/modem/llc.c A src/host/layer23/src/modem/rlcmac.c 7 files changed, 167 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/77/31077/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0e628d9ddaa5ad6a205f07746d4176d1b8df7eb0 Gerrit-Change-Number: 31077 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: Initial integration of libosmo-gprs-{llc,sndcp}

by pespin

Attention is currently required from: osmith, fixeria. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/31007 to look at the new patch set (#6). Change subject: modem: Initial integration of libosmo-gprs-{llc,sndcp} ...................................................................... modem: Initial integration of libosmo-gprs-{llc,sndcp} Change-Id: I820328009ccdd1f8112aeb163efa064ec1465d2a --- M src/host/layer23/include/osmocom/bb/common/logging.h M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/modem/Makefile.am A src/host/layer23/include/osmocom/bb/modem/llc.h A src/host/layer23/include/osmocom/bb/modem/sndcp.h M src/host/layer23/src/common/logging.c M src/host/layer23/src/modem/Makefile.am M src/host/layer23/src/modem/app_modem.c A src/host/layer23/src/modem/llc.c A src/host/layer23/src/modem/sndcp.c 10 files changed, 436 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/07/31007/6 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I820328009ccdd1f8112aeb163efa064ec1465d2a Gerrit-Change-Number: 31007 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: Initial integration of libosmo-gprs-rlcmac

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31077 ) Change subject: modem: Initial integration of libosmo-gprs-rlcmac ...................................................................... Patch Set 1: (3 comments) File src/host/layer23/src/modem/llc.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/41f1ba74_48e175f9 PS1, Line 149: owneserip > ownership Ack https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/e7cecd22_c7df4de3 PS1, Line 151: RLCMAC-GRR-UNITDATA-IND, we just need to adapt the header. > will this always be the case in the future? maybe it makes sense to use osmo_static_assert on the si […] comments are already there. osmo_static_assert: I'll try that thanks. File src/host/layer23/src/modem/rlcmac.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/ce19c296_e94ba21f PS1, Line 78: LL > RLCMAC GMMRR Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0e628d9ddaa5ad6a205f07746d4176d1b8df7eb0 Gerrit-Change-Number: 31077 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 11:45:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: Initial integration of libosmo-gprs-{llc,sndcp}

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31007 ) Change subject: modem: Initial integration of libosmo-gprs-{llc,sndcp} ...................................................................... Patch Set 5: (3 comments) File src/host/layer23/src/modem/app_modem.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31007/comment/8a2fc24c_b6ca829e PS5, Line 556: DLGLOBAL > DLLC? Ack https://gerrit.osmocom.org/c/osmocom-bb/+/31007/comment/8d283926_ceefc137 PS5, Line 561: DLGLOBAL > DSNDCP? Ack File src/host/layer23/src/modem/llc.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31007/comment/45d3f1f5_ea55a487 PS5, Line 68: //TODO: free msg? > intentionally keeping these? […] This is expected, all the message ownership stuff in the APIs will be looked at once everything is in place, to see how we can optimize msgb allocation buffer copying. This app has still a lot of stuff missing so it's notr eady for normal use yet. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I820328009ccdd1f8112aeb163efa064ec1465d2a Gerrit-Change-Number: 31007 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 11:44:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: SI: add missing header

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31080 ) Change subject: SI: add missing header ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3 Gerrit-Change-Number: 31080 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 26 Jan 2023 11:43:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: Fixup .gitignore

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31079 ) Change subject: Fixup .gitignore ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I33b62047ff5bca7f5834df0961f3637cb319c80d Gerrit-Change-Number: 31079 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 11:43:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: d/control: libosmocore-dev: depend on libmnl-dev

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31078 ) Change subject: d/control: libosmocore-dev: depend on libmnl-dev ...................................................................... d/control: libosmocore-dev: depend on libmnl-dev Let libosmocore-dev depend on libmnl-dev, as we build the debian package without --disable-libmnl and so libosmocore.pc lists libmnl in requires. This patch should fix the following error when trying to build any debien package depending on libosmocore-dev: Package 'libmnl', required by 'libosmocore', not found A similar change in the rpm spec is not be needed, as rpm adds depends from pc files automatically. Fixes: 4eb89afa ("configure --enable-libmnl: Add libmnl to libosmocore.pc.in Requires") Change-Id: I7fd578fcc22c0ea6ac04bdc26dc1741e4e26767c --- M debian/control 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/control b/debian/control index 2b8504a..bbf9244 100644 --- a/debian/control +++ b/debian/control @@ -357,6 +357,7 @@ libtalloc-dev (>= 2.1.0), libsctp-dev, libusb-1.0-0-dev, + libmnl-dev, ${misc:Depends} Description: Development headers for Open Source MObile COMmunications CORE library The header files provided by this package may be used to develop -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7fd578fcc22c0ea6ac04bdc26dc1741e4e26767c Gerrit-Change-Number: 31078 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: d/control: libosmocore-dev: depend on libmnl-dev

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31078 ) Change subject: d/control: libosmocore-dev: depend on libmnl-dev ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7fd578fcc22c0ea6ac04bdc26dc1741e4e26767c Gerrit-Change-Number: 31078 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 09:41:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: d/control: libosmocore-dev: depend on libmnl-dev

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31078 ) Change subject: d/control: libosmocore-dev: depend on libmnl-dev ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7fd578fcc22c0ea6ac04bdc26dc1741e4e26767c Gerrit-Change-Number: 31078 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 09:07:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: Initial integration of libosmo-gprs-rlcmac

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31077 ) Change subject: modem: Initial integration of libosmo-gprs-rlcmac ...................................................................... Patch Set 1: (3 comments) File src/host/layer23/src/modem/llc.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/ab09ecb5_4bddf7fe PS1, Line 149: owneserip ownership https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/8bd592d3_0f0a4b44 PS1, Line 151: RLCMAC-GRR-UNITDATA-IND, we just need to adapt the header. will this always be the case in the future? maybe it makes sense to use osmo_static_assert on the size and/or add comments in rlcmac_prim.h / llc_prim.h that this assumption is made? same in modem_rlcmac_handle_grr File src/host/layer23/src/modem/rlcmac.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31077/comment/d2f25c87_b2daaf65 PS1, Line 78: LL RLCMAC GMMRR -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0e628d9ddaa5ad6a205f07746d4176d1b8df7eb0 Gerrit-Change-Number: 31077 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Jan 2023 08:57:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023