April 2022 - gerrit-log - lists.osmocom.org

Change in ...osmo_dia2gsup[master]: server_cb: Fix issue with Erlang/OTP 24

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 ) Change subject: server_cb: Fix issue with Erlang/OTP 24 ...................................................................... server_cb: Fix issue with Erlang/OTP 24 Erlang/OTP 24 dropped crypto:hmac, so use crpyto:mac(hmac, ...) instead. See https://github.com/riverrun/one_time_pass_ecto/issues/9 Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a --- M src/server_cb.erl 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/server_cb.erl b/src/server_cb.erl index c7b0ed1..dc7fe59 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -85,7 +85,13 @@ Autn6 = binary_part(Autn, 0, 6), K = <<Ck:16/binary, Ik:16/binary>>, S = <<16, VplmnId:3/binary, 0, 3, Autn6:6/binary, 0, 6>>, - crypto:hmac(sha256, K, S, 32). + Release = erlang:system_info(otp_release), + if + Release >= "24" -> + crypto:macN(hmac, sha256, K, S, 32); + true -> + crypto:hmac(sha256, K, S, 32) + end. -spec req_num_of_vec([tuple()]) -> int_or_false(). req_num_of_vec([#'Requested-EUTRAN-Authentication-Info'{'Number-Of-Requested-Vectors'=[]}]) -> false; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a Gerrit-Change-Number: 27896 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: server_cb: Fix issue with Erlang/OTP 24

by fixeria

Attention is currently required from: laforge, pespin, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 ) Change subject: server_cb: Fix issue with Erlang/OTP 24 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/server_cb.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896/comment/8456bdaa_… PS3, Line 84: compute_kasme Would be nice to have some unit test coverage for this function, but LGTM! -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a Gerrit-Change-Number: 27896 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 13:02:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: Move struct gsm_bts_paging_state to paging.h

by laforge

Attention is currently required from: neels, pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27866 ) Change subject: Move struct gsm_bts_paging_state to paging.h ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8c058d308fc816828b5e6a86e7c5a1f629a2d7c4 Gerrit-Change-Number: 27866 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 12:59:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_500req

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27890 ) Change subject: bsc: Introduce test TC_paging_500req ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4f7185939c20804deef92f476ed19248ba885f29 Gerrit-Change-Number: 27890 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 12:58:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: rsl_rx_ccch_load: add explicit cast -1 to unsigned

by laforge

Attention is currently required from: pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27879 ) Change subject: rsl_rx_ccch_load: add explicit cast -1 to unsigned ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: > Why not use UINT16_MAX instead? was suggested by fixeria in the first comment, see above. I would go for UINT16_MAX or even the more readable 0xffff -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 Gerrit-Change-Number: 27879 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 12:57:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: paging: Submit up to 20 paging requests in a single work iteration

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27885 ) Change subject: paging: Submit up to 20 paging requests in a single work iteration ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: aside from fixeria's comments: I'd appreciate some kind of illustration why 20 was chosen. If there's some computation/rationale behind it, mightbe useful to have that explained in the code. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I609fa67834b426456f48f6fb2acb601c5905f178 Gerrit-Change-Number: 27885 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 12:56:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: server_cb: Fix issue with Erlang/OTP 24

by laforge

Attention is currently required from: laforge, pespin, fixeria. laforge has uploaded a new patch set (#3) to the change originally created by daniel. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 ) Change subject: server_cb: Fix issue with Erlang/OTP 24 ...................................................................... server_cb: Fix issue with Erlang/OTP 24 Erlang/OTP 24 dropped crypto:hmac, so use crpyto:mac(hmac, ...) instead. See https://github.com/riverrun/one_time_pass_ecto/issues/9 Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a --- M src/server_cb.erl 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/96/27896/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a Gerrit-Change-Number: 27896 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: paging: Submit up to 20 paging requests in a single work iteration

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27885 ) Change subject: paging: Submit up to 20 paging requests in a single work iteration ...................................................................... Patch Set 3: (3 comments) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27885/comment/e1e95e5a_b764d33f PS3, Line 210: struct gsm_paging_request, entry); Alignment needs to be fixed. https://gerrit.osmocom.org/c/osmo-bsc/+/27885/comment/09ba706d_27343fe7 PS3, Line 243: } while (request != initial_request && num_paged < MAX_PAGE_REQ_PER_ITER); I am trying to understand how this is supposed to work if you have less than 20 penging requests awaiting in the queue. If we have just one request, then 'request == initial_request' is true, and we break the loop - so far so good. But if we have two? I may be missing something, but AFAIU the loop will schedule 20 paging messages for just 2 requests, 10 times each. Is this the case? https://gerrit.osmocom.org/c/osmo-bsc/+/27885/comment/4e860eea_2f2b9bd9 PS3, Line 246: sched_next_paging This label name is confusing: when I saw the 'goto' above I thought you're somehow scheduling/sending paging in the absence of the OML link. The old name was cleaner IMO, so I would keep it. Or maybe 'sched_next_iter'? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I609fa67834b426456f48f6fb2acb601c5905f178 Gerrit-Change-Number: 27885 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 11:49:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-e1d[master]: e1oip: fix line counter descriptions

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27898 ) Change subject: e1oip: fix line counter descriptions ...................................................................... e1oip: fix line counter descriptions The direction is wrong in two counter descriptions Change-Id: Ia294af4b30eec1b32c4b15892751d360608c8333 --- M src/octoi/e1oip.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/98/27898/1 diff --git a/src/octoi/e1oip.c b/src/octoi/e1oip.c index 87457db..cd07178 100644 --- a/src/octoi/e1oip.c +++ b/src/octoi/e1oip.c @@ -46,8 +46,8 @@ static const struct rate_ctr_desc iline_ctr_description[] = { [LINE_CTR_E1oIP_UNDERRUN] = { "e1oip:underrun", "Frames underrun / slipped in IP->E1 direction"}, [LINE_CTR_E1oIP_SUBSTITUTED] = { "e1oip:substituted", "Frames substituted in E1->IP direction"}, - [LINE_CTR_E1oIP_E1T_OVERFLOW] = { "e1oip:e1t_overflow", "Frames overflowing the RIFO in E1->IP direction"}, - [LINE_CTR_E1oIP_E1O_OVERFLOW] = { "e1oip:e1o_overflow", "Frames overflowed in IP->E1 direction"}, + [LINE_CTR_E1oIP_E1T_OVERFLOW] = { "e1oip:e1t_overflow", "Frames overflowing the RIFO in IP->E1 direction"}, + [LINE_CTR_E1oIP_E1O_OVERFLOW] = { "e1oip:e1o_overflow", "Frames overflowed in E1->IP direction"}, [LINE_CTR_E1oIP_RX_OUT_OF_ORDER] = { "e1oip:rx:pkt_out_of_order", "Packets out-of-order in IP->E1 direction"}, [LINE_CTR_E1oIP_RX_OUT_OF_WIN] = { "e1oip:rx:pkt_out_of_win", "Packets out-of-rx-window in IP->E1 direction"}, [LINE_CTR_E1oIP_CONNECT_ACCEPT] = { "e1oip:connect_accepted", "OCTOI connections entering accepted state" }, -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ia294af4b30eec1b32c4b15892751d360608c8333 Gerrit-Change-Number: 27898 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: server_cb: Fix issue with Erlang/OTP 24

by daniel

Attention is currently required from: laforge, pespin, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 ) Change subject: server_cb: Fix issue with Erlang/OTP 24 ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS1: > What about supporting both? […] The file you linked seems to be from elixir (.ex), not pure erlang. I couldn't find an analogous example for erlang (function_exported mentioned in https://github.com/elixir-lang/elixir/issues/11524) also seems to exist only in elixir) and I don't know the language that well.. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a Gerrit-Change-Number: 27896 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 03:23:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022