pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853 )
Change subject: pgw: Initial Gy support
......................................................................
Patch Set 3:
(1 comment)
File pgw/PGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853/comment/0ca3fb66_a77d…
PS2, Line 320: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
> Well, I generally don't like that f_shutdown() is overloaded with setting a verdict. […]
You may have the opinion that f_shutdown() is overloaded by setting the veredict (and I disagree), but that's totally unrelated to what the patch is doing: just using an available function with its available parameters.
This patch is not adding or touching that function. Feel free to send a patch dropping the verdict stuff from Misc_Helpers.f_shutdown() and everywhere using it if you want, and let others give their opinion.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I04cf78cb4bc73de59f803c01208a7ef9056cb14f
Gerrit-Change-Number: 27853
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Apr 2022 12:37:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853 )
Change subject: pgw: Initial Gy support
......................................................................
Patch Set 3:
(1 comment)
File pgw/PGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853/comment/a09ec15e_8808…
PS2, Line 320: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
> I see no point in doing so. I think it's actually perfect to do it this way.
Well, I generally don't like that f_shutdown() is overloaded with setting a verdict. IMO this function should do what its name suggests: shutdown everything. There is already a language construct for setting a verdict (which btw supports argument concatenation), so we should stick to a single approach.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I04cf78cb4bc73de59f803c01208a7ef9056cb14f
Gerrit-Change-Number: 27853
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Apr 2022 11:36:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment