April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27893 ) Change subject: icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry ...................................................................... icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ife69f9ce4c6f3eb6d40b05ce8f862ff68180357f --- M firmware/ice40-riscv/icE1usb/gpsdo.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/93/27893/1 diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index 7e3682f..c94a5ed 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -145,6 +145,11 @@ static void _gpsdo_coarse_start(void) { + /* Debug */ +#ifdef GPSDO_DEBUG + printf("[+] GPSDO Coarse Start: tune=%d:%d\n", g_gpsdo.tune.coarse, g_gpsdo.tune.fine); +#endif + /* Set the state */ g_gpsdo.state = STATE_TUNE_COARSE; @@ -165,6 +170,10 @@ static void _gpsdo_fine_start(void) { +#ifdef GPSDO_DEBUG + printf("[+] GPSDO Fine Start\n"); +#endif + /* Set the state */ g_gpsdo.state = STATE_TUNE_FINE; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ife69f9ce4c6f3eb6d40b05ce8f862ff68180357f Gerrit-Change-Number: 27893 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Never use invalid measurements to feed loop

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27892 ) Change subject: icE1usb fw/gpsdo: Never use invalid measurements to feed loop ...................................................................... icE1usb fw/gpsdo: Never use invalid measurements to feed loop Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I9c7b81c6e2e600ed49ac766fa33df23747dd339e --- M firmware/ice40-riscv/icE1usb/gpsdo.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/92/27892/1 diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index cd9866c..7e3682f 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -286,10 +286,11 @@ } else { /* Count invalid measurements and if too many of * them, we go back to hold-over */ - if (++g_gpsdo.meas.invalid >= MAX_INVALID) { + if (++g_gpsdo.meas.invalid >= MAX_INVALID) g_gpsdo.state = STATE_HOLD_OVER; - return; - } + + /* In all cases, invalid measurements are not used */ + return; } g_gpsdo.meas.invalid = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I9c7b81c6e2e600ed49ac766fa33df23747dd339e Gerrit-Change-Number: 27892 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Fix typo in the condition to exit TUNE_FINE

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27891 ) Change subject: icE1usb fw/gpsdo: Fix typo in the condition to exit TUNE_FINE ...................................................................... icE1usb fw/gpsdo: Fix typo in the condition to exit TUNE_FINE Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I6106f07f7bff1c298ac3f86164e155d4bfb1b7ac --- M firmware/ice40-riscv/icE1usb/gpsdo.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/91/27891/1 diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index 8e32627..cd9866c 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -204,7 +204,7 @@ uint16_t tune; /* Did we deviate too much ? */ - if ((freq_diff < -2*MAX_DEV_FINE) && (freq_diff > 2*MAX_DEV_FINE)) { + if ((freq_diff < -2*MAX_DEV_FINE) || (freq_diff > 2*MAX_DEV_FINE)) { _gpsdo_coarse_start(); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I6106f07f7bff1c298ac3f86164e155d4bfb1b7ac Gerrit-Change-Number: 27891 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: rsl_rx_ccch_load: add explicit cast -1 to unsigned

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27879 ) Change subject: rsl_rx_ccch_load: add explicit cast -1 to unsigned ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 Gerrit-Change-Number: 27879 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Apr 2022 08:18:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: msc tests: fix test so they don't depend on previous test runs

by fixeria

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27603 ) Change subject: msc tests: fix test so they don't depend on previous test runs ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27603/comment/0315d597_4f2c… PS3, Line 9: The test currently implicitly check the vlr state left by preceding tests. Empty line missing. Footer should be separated from the commit message body. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebaecd28a426b15baf4729f40b46dd33da79cbae Gerrit-Change-Number: 27603 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 22:44:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Add TC_gy_charging_cc_time

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854 ) Change subject: pgw: Add TC_gy_charging_cc_time ...................................................................... Patch Set 1: (2 comments) File pgw/PGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854/comment/59603b2f_c6b6… PS1, Line 688: /* create a session, then execute a ping command on the user plane */ This test is not only about creating session and running ping, right? This comment needs to be clarified a bit. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854/comment/49d6de41_69de… PS1, Line 715: control { Is it intentional that you don't add TC_gy_charging_cc_time to the control section? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4e567f62bbbdba276e6b3221111c8d9f82cde14 Gerrit-Change-Number: 27854 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 22:40:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Initial Gy support

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853 ) Change subject: pgw: Initial Gy support ...................................................................... Patch Set 2: (2 comments) File pgw/PGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853/comment/4893f33e_5b2d… PS2, Line 320: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, Let's keep setverdict() separate from f_shutdown(), so that there is no need to use log2str(). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853/comment/67a668ed_2f64… PS2, Line 348: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, Let's keep setverdict() separate from f_shutdown(), so that there is no need to use log2str(). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04cf78cb4bc73de59f803c01208a7ef9056cb14f Gerrit-Change-Number: 27853 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 22:36:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Support having several DIAMETER_ConnHdlr per PGW_Session_CT

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27852 ) Change subject: pgw: Support having several DIAMETER_ConnHdlr per PGW_Session_CT ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27852 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I28f1ac0a013e479058f28a6feff6901b33f6c247 Gerrit-Change-Number: 27852 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 22:30:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: ttcn3-pgw: Configure Gy interface

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27889 ) Change subject: ttcn3-pgw: Configure Gy interface ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaeed2086aa058e1079295cb1911ad80e9613f8fa Gerrit-Change-Number: 27889 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 22:28:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: paging: Log skip paging due to not enough free channels

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27884 ) Change subject: paging: Log skip paging due to not enough free channels ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27884 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I311f90be99c4561b45f99ce98533aab5909301d0 Gerrit-Change-Number: 27884 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 16:10:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022