April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Attempt to recover from bad tuning

by tnt

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27894 ) Change subject: icE1usb fw/gpsdo: Attempt to recover from bad tuning ...................................................................... icE1usb fw/gpsdo: Attempt to recover from bad tuning If we're in hold over mode and getting a bunch of invalid frequency measurement despite a good fix, then we most likely ended up on a bad tuning value and we need to recover by starting from scratch. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: If8503a3eaf695e02a0ef0a3b6536de985d247c20 --- M firmware/ice40-riscv/icE1usb/gpsdo.c 1 file changed, 17 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved tnt: Looks good to me, approved diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index c94a5ed..057490f 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -280,6 +280,7 @@ if (!gps_has_valid_fix()) { /* No GPS fix, go to hold-over */ g_gpsdo.state = STATE_HOLD_OVER; + g_gpsdo.meas.invalid = 0; return; } @@ -293,10 +294,22 @@ return; } } else { - /* Count invalid measurements and if too many of - * them, we go back to hold-over */ - if (++g_gpsdo.meas.invalid >= MAX_INVALID) - g_gpsdo.state = STATE_HOLD_OVER; + /* Count invalid measurements */ + if (++g_gpsdo.meas.invalid >= MAX_INVALID) { + if (g_gpsdo.state != STATE_HOLD_OVER) { + /* We go back to hold-over */ + g_gpsdo.state = STATE_HOLD_OVER; + g_gpsdo.meas.invalid = 0; + } else { + /* We're in hold-over, with valid fix, and + * still get a bunch of invalid. Reset tuning */ + g_gpsdo.tune.coarse = 2048; + g_gpsdo.tune.fine = 2048; + + pdm_set(PDM_CLK_HI, true, g_gpsdo.tune.coarse, false); + pdm_set(PDM_CLK_LO, true, g_gpsdo.tune.fine, false); + } + } /* In all cases, invalid measurements are not used */ return; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: If8503a3eaf695e02a0ef0a3b6536de985d247c20 Gerrit-Change-Number: 27894 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Attempt to recover from bad tuning

by tnt

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27894 ) Change subject: icE1usb fw/gpsdo: Attempt to recover from bad tuning ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: If8503a3eaf695e02a0ef0a3b6536de985d247c20 Gerrit-Change-Number: 27894 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:35:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry

by tnt

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27893 ) Change subject: icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry ...................................................................... icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ife69f9ce4c6f3eb6d40b05ce8f862ff68180357f --- M firmware/ice40-riscv/icE1usb/gpsdo.c 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved tnt: Looks good to me, approved diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index 7e3682f..c94a5ed 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -145,6 +145,11 @@ static void _gpsdo_coarse_start(void) { + /* Debug */ +#ifdef GPSDO_DEBUG + printf("[+] GPSDO Coarse Start: tune=%d:%d\n", g_gpsdo.tune.coarse, g_gpsdo.tune.fine); +#endif + /* Set the state */ g_gpsdo.state = STATE_TUNE_COARSE; @@ -165,6 +170,10 @@ static void _gpsdo_fine_start(void) { +#ifdef GPSDO_DEBUG + printf("[+] GPSDO Fine Start\n"); +#endif + /* Set the state */ g_gpsdo.state = STATE_TUNE_FINE; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ife69f9ce4c6f3eb6d40b05ce8f862ff68180357f Gerrit-Change-Number: 27893 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry

by tnt

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27893 ) Change subject: icE1usb fw/gpsdo: Add debug prints for coarse/fine tune entry ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ife69f9ce4c6f3eb6d40b05ce8f862ff68180357f Gerrit-Change-Number: 27893 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:34:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Never use invalid measurements to feed loop

by tnt

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27892 ) Change subject: icE1usb fw/gpsdo: Never use invalid measurements to feed loop ...................................................................... icE1usb fw/gpsdo: Never use invalid measurements to feed loop Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I9c7b81c6e2e600ed49ac766fa33df23747dd339e --- M firmware/ice40-riscv/icE1usb/gpsdo.c 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index cd9866c..7e3682f 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -286,10 +286,11 @@ } else { /* Count invalid measurements and if too many of * them, we go back to hold-over */ - if (++g_gpsdo.meas.invalid >= MAX_INVALID) { + if (++g_gpsdo.meas.invalid >= MAX_INVALID) g_gpsdo.state = STATE_HOLD_OVER; - return; - } + + /* In all cases, invalid measurements are not used */ + return; } g_gpsdo.meas.invalid = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I9c7b81c6e2e600ed49ac766fa33df23747dd339e Gerrit-Change-Number: 27892 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Fix typo in the condition to exit TUNE_FINE

by tnt

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27891 ) Change subject: icE1usb fw/gpsdo: Fix typo in the condition to exit TUNE_FINE ...................................................................... icE1usb fw/gpsdo: Fix typo in the condition to exit TUNE_FINE Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I6106f07f7bff1c298ac3f86164e155d4bfb1b7ac --- M firmware/ice40-riscv/icE1usb/gpsdo.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index 8e32627..cd9866c 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -204,7 +204,7 @@ uint16_t tune; /* Did we deviate too much ? */ - if ((freq_diff < -2*MAX_DEV_FINE) && (freq_diff > 2*MAX_DEV_FINE)) { + if ((freq_diff < -2*MAX_DEV_FINE) || (freq_diff > 2*MAX_DEV_FINE)) { _gpsdo_coarse_start(); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I6106f07f7bff1c298ac3f86164e155d4bfb1b7ac Gerrit-Change-Number: 27891 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: server_cb: Fix issue with Erlang/OTP 24

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 ) Change subject: server_cb: Fix issue with Erlang/OTP 24 ...................................................................... server_cb: Fix issue with Erlang/OTP 24 Erlang/OTP 24 dropped crypto:hmac, so use crpyto:mac(hmac, ...) instead. See https://github.com/riverrun/one_time_pass_ecto/issues/9 Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a --- M src/server_cb.erl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/96/27896/1 diff --git a/src/server_cb.erl b/src/server_cb.erl index c7b0ed1..e09a91e 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -85,7 +85,7 @@ Autn6 = binary_part(Autn, 0, 6), K = <<Ck:16/binary, Ik:16/binary>>, S = <<16, VplmnId:3/binary, 0, 3, Autn6:6/binary, 0, 6>>, - crypto:hmac(sha256, K, S, 32). + crypto:mac(hmac, sha256, K, S, 32). -spec req_num_of_vec([tuple()]) -> int_or_false(). req_num_of_vec([#'Requested-EUTRAN-Authentication-Info'{'Number-Of-Requested-Vectors'=[]}]) -> false; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a Gerrit-Change-Number: 27896 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: Move struct gsm_bts_paging_state to paging.h

by osmith

Attention is currently required from: neels, laforge, pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27866 ) Change subject: Move struct gsm_bts_paging_state to paging.h ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8c058d308fc816828b5e6a86e7c5a1f629a2d7c4 Gerrit-Change-Number: 27866 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Apr 2022 13:44:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: paging: Submit up to 20 paging requests in a single work iteration

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27885 ) Change subject: paging: Submit up to 20 paging requests in a single work iteration ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I609fa67834b426456f48f6fb2acb601c5905f178 Gerrit-Change-Number: 27885 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 22 Apr 2022 13:39:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Limit the fine tuning range

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27895 ) Change subject: icE1usb fw/gpsdo: Limit the fine tuning range ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I2d9d348f5466f581b3d6d36c98847c47e2452f98 Gerrit-Change-Number: 27895 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Fri, 22 Apr 2022 12:56:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022