April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: rsl_rx_ccch_load: add explicit cast -1 to unsigned

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27879 ) Change subject: rsl_rx_ccch_load: add explicit cast -1 to unsigned ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Why not use UINT16_MAX instead? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 Gerrit-Change-Number: 27879 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 03:04:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_500req

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27890 ) Change subject: bsc: Introduce test TC_paging_500req ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4f7185939c20804deef92f476ed19248ba885f29 Gerrit-Change-Number: 27890 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Apr 2022 22:19:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_500req

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27890 ) Change subject: bsc: Introduce test TC_paging_500req ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: This tests validates that after applying https://gerrit.osmocom.org/c/osmo-bsc/+/27885, osmo-bsc can server many more paging requests per unit of time, without timing out. Without this patch, it will only serve 29 until T3113 times out for most of them, being dropped. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4f7185939c20804deef92f476ed19248ba885f29 Gerrit-Change-Number: 27890 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 22 Apr 2022 15:58:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: RFC: Prioritize paging requests for new subsribers over retransmitions

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27897 ) Change subject: RFC: Prioritize paging requests for new subsribers over retransmitions ...................................................................... RFC: Prioritize paging requests for new subsribers over retransmitions Currently, the Tx paging_req queue at the BSC always has new paging requests adding at the end (as long as the subsriver is not already in the queue). That means, if the queue is full of retransmitions, it will take a long time until the first paging_req is sent towards that subscriber. The rationale here is that it makes sense to attempt the first paging ASAP, and give lower prio to paging_req retransmitions, since it may well be that those other subsribers are not available/reachable and won't answer. Related: SYS#5922 Change-Id: I1ae6d97152c458247bc538233b97c2d245196359 --- M src/osmo-bsc/paging.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/27897/1 diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index c290848..a3d9bd4 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -352,6 +352,13 @@ rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_PAGING_ALREADY)); return -EEXIST; } + /* TODO: add new paging request (if not existing already) before first + paging request which ->attempts>0. This way we give better priority + to new subscribers rather than those which didn't answer at first. + This can be done in O(n) since we anyway need to traverse the entire + list to see if the subscriber is already being paged. During + traversal, store the last req with attempts==0. If none found, + add_tail(). */ LOG_PAGING_BTS(params, bts, DPAG, LOGL_DEBUG, "Start paging\n"); params->bsub->active_paging_requests++; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1ae6d97152c458247bc538233b97c2d245196359 Gerrit-Change-Number: 27897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_500req

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27890 ) Change subject: bsc: Introduce test TC_paging_500req ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4f7185939c20804deef92f476ed19248ba885f29 Gerrit-Change-Number: 27890 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 22 Apr 2022 15:43:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: server_cb: Fix issue with Erlang/OTP 24

by pespin

Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 ) Change subject: server_cb: Fix issue with Erlang/OTP 24 ...................................................................... Patch Set 1: (1 comment) This change is ready for review. Patchset: PS1: What about supporting both? https://github.com/riverrun/one_time_pass_ecto/pull/10/commits/822f0c8bffab… -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a Gerrit-Change-Number: 27896 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:45:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: server_cb: Fix issue with Erlang/OTP 24

by fixeria

Attention is currently required from: laforge, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 ) Change subject: server_cb: Fix issue with Erlang/OTP 24 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a Gerrit-Change-Number: 27896 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:43:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: server_cb: Fix issue with Erlang/OTP 24

by daniel

Attention is currently required from: laforge, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 ) Change subject: server_cb: Fix issue with Erlang/OTP 24 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7d916eb1f1435b3ac3fc362bb2f4daa7bbb8bb1a Gerrit-Change-Number: 27896 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:39:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Limit the fine tuning range

by tnt

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27895 ) Change subject: icE1usb fw/gpsdo: Limit the fine tuning range ...................................................................... icE1usb fw/gpsdo: Limit the fine tuning range Fine tuning has a limited tuning range. If at some point we hit the limits, we need to bit the bullet and try to 'transfer' some of that to the coarse range as best as we can. Hopefully we get it close enough to limit disruption. Note that this should really never happen because although it's limited, the tuning range should be good enough to absorb any reasonable temperature / aging variation once we have coarse tuned. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I2d9d348f5466f581b3d6d36c98847c47e2452f98 --- M firmware/ice40-riscv/icE1usb/gpsdo.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve tnt: Looks good to me, approved Jenkins Builder: Verified diff --git a/firmware/ice40-riscv/icE1usb/gpsdo.c b/firmware/ice40-riscv/icE1usb/gpsdo.c index 057490f..c1df4b0 100644 --- a/firmware/ice40-riscv/icE1usb/gpsdo.c +++ b/firmware/ice40-riscv/icE1usb/gpsdo.c @@ -240,8 +240,23 @@ g_gpsdo.fine.div = 0; } - /* Apply value with a bias from long term accumulator */ + /* Compute value with a bias from long term accumulator */ tune = g_gpsdo.tune.fine - (g_gpsdo.fine.acc / 2); + + /* If fine tune is getting close to boundary, do our + * best to transfer part of it to coarse tuning */ + if ((g_gpsdo.tune.fine < 512) || (g_gpsdo.tune.fine > 3584)) + { + int coarse_adj = ((int)g_gpsdo.tune.fine - 2048) >> 6; + + g_gpsdo.tune.coarse += coarse_adj; + g_gpsdo.tune.fine -= coarse_adj << 6; + tune -= coarse_adj << 6; + + pdm_set(PDM_CLK_HI, true, g_gpsdo.tune.coarse, false); + } + + /* Apply fine */ pdm_set(PDM_CLK_LO, true, tune, false); /* Debug */ -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I2d9d348f5466f581b3d6d36c98847c47e2452f98 Gerrit-Change-Number: 27895 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw/gpsdo: Limit the fine tuning range

by tnt

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27895 ) Change subject: icE1usb fw/gpsdo: Limit the fine tuning range ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I2d9d348f5466f581b3d6d36c98847c47e2452f98 Gerrit-Change-Number: 27895 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Fri, 22 Apr 2022 14:36:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022