April 2022 - gerrit-log - lists.osmocom.org

Change in dahdi-linux[master]: wcte13xp: Fix missing break statement when setting J1 line mode

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27909 ) Change subject: wcte13xp: Fix missing break statement when setting J1 line mode ...................................................................... wcte13xp: Fix missing break statement when setting J1 line mode Change-Id: I776812d9fc4d8cb1140555e70a3480bdaf0aaaaf --- M drivers/dahdi/wcte13xp-base.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/09/27909/1 diff --git a/drivers/dahdi/wcte13xp-base.c b/drivers/dahdi/wcte13xp-base.c index 69f7099..cfbdd4a 100644 --- a/drivers/dahdi/wcte13xp-base.c +++ b/drivers/dahdi/wcte13xp-base.c @@ -1874,6 +1874,7 @@ "Changing from %s to E1 line mode.\n", dahdi_spantype2str(wc->span.spantype)); res = t13x_software_init(wc, J1); + break; default: dev_err(&wc->xb.pdev->dev, "Got invalid linemode '%s' from dahdi\n", -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27909 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I776812d9fc4d8cb1140555e70a3480bdaf0aaaaf Gerrit-Change-Number: 27909 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ci[master]: dahdi: use buster, not stretch

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27908 ) Change subject: dahdi: use buster, not stretch ...................................................................... dahdi: use buster, not stretch stretch has too old gcc which doesn't support -Wno-format-truncation which is used in dahdi-linux since 2018. Change-Id: I4fca722e67b2c649dea4f9799d277cd568bcc493 --- M jobs/gerrit-verifications-dahdi.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/08/27908/1 diff --git a/jobs/gerrit-verifications-dahdi.yml b/jobs/gerrit-verifications-dahdi.yml index 30c223e..bb0263f 100644 --- a/jobs/gerrit-verifications-dahdi.yml +++ b/jobs/gerrit-verifications-dahdi.yml @@ -86,7 +86,7 @@ -e "KSRC=/linux" \ -v "$PWD/dahdi-linux:/build" \ -v "$PWD/linux:/linux" \ - "$USER/debian-stretch-jenkins" \ + "$USER/debian-buster-jenkins" \ timeout 10m su build -c /build/contrib/jenkins.sh publishers: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4fca722e67b2c649dea4f9799d277cd568bcc493 Gerrit-Change-Number: 27908 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: install libelf-dev

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27907 ) Change subject: debian-buster-jenkins: install libelf-dev ...................................................................... debian-buster-jenkins: install libelf-dev Add libelf-dev to be able to build kernel modules with defconfig_x86_64. This is an update to commit d6c5c7a0341c966ddef235a5d6e00a536c1a857c, which should have not just modified the stretch but also the buster Docker image Change-Id: I4c442d86688278ff634a286b98637189eef88bfb Related: OS#5407 --- M debian-buster-jenkins/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 0ea81fe..6bbd389 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -56,6 +56,7 @@ libcsv-dev \ libdbd-sqlite3 \ libdbi-dev \ + libelf-dev \ libffi-dev \ libfftw3-dev \ libgmp-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4c442d86688278ff634a286b98637189eef88bfb Gerrit-Change-Number: 27907 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: install libelf-dev

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27907 ) Change subject: debian-buster-jenkins: install libelf-dev ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4c442d86688278ff634a286b98637189eef88bfb Gerrit-Change-Number: 27907 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 24 Apr 2022 16:17:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: install libelf-dev

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/27907 ) Change subject: debian-buster-jenkins: install libelf-dev ...................................................................... debian-buster-jenkins: install libelf-dev Add libelf-dev to be able to build kernel modules with defconfig_x86_64. This is an update to commit d6c5c7a0341c966ddef235a5d6e00a536c1a857c, which should have not just modified the stretch but also the buster Docker image Change-Id: I4c442d86688278ff634a286b98637189eef88bfb Related: OS#5407 --- M debian-buster-jenkins/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/07/27907/1 diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 0ea81fe..6bbd389 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -56,6 +56,7 @@ libcsv-dev \ libdbd-sqlite3 \ libdbi-dev \ + libelf-dev \ libffi-dev \ libfftw3-dev \ libgmp-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4c442d86688278ff634a286b98637189eef88bfb Gerrit-Change-Number: 27907 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: TC_emerg_premption: test RR rel cause

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27906 ) Change subject: bsc: TC_emerg_premption: test RR rel cause ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I47e919edc25a8427f49d654f97f05e46a89da16d Gerrit-Change-Number: 27906 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Apr 2022 00:10:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: TC_emerg_premption: cosmetic

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27905 ) Change subject: bsc: TC_emerg_premption: cosmetic ...................................................................... Patch Set 1: (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27905/comment/46a42d1e_a733… PS1, Line 8976: if (first_tch != rx_rsl.ies[0].body.chan_nr) { This goes beyond the scope of a 'cosmetic' change. You're basically adding more checks. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c540d76eedfd4115b410921bf5a0b6c2d00b5c2 Gerrit-Change-Number: 27905 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Apr 2022 00:09:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call deny: log on LOGL_ERROR

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27904 ) Change subject: emerg call deny: log on LOGL_ERROR ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: A spec. violation from the MS side does not look like an error condition to me... I would keep it on NOTICE. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id6ea25484479bfc1728124df8fe8e2e03bcee3ec Gerrit-Change-Number: 27904 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 23:59:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call deny: do not dispatch dtap

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27903 ) Change subject: emerg call deny: do not dispatch dtap ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27903/comment/9ddbe8b4_dbdb0ba1 PS1, Line 1077: /* fall through */ I see no change here: 'break' generally moves the execution flow out of the switch statement (unless it's part of an inner switch statement or a loop). Neither I see inner switch statements here, nor any loops. So if we break, we don't fall through. Am I missing something? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I065953f0380e142824ba30a842c86f9c598f89fe Gerrit-Change-Number: 27903 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 23:56:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call deny: fix RR release cause

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27902 ) Change subject: emerg call deny: fix RR release cause ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia195621165cb7bbe33e6c2e915abc42ab16a2a4f Gerrit-Change-Number: 27902 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Apr 2022 23:47:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022