April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: emerg call deny: log on LOGL_ERROR

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27904 ) Change subject: emerg call deny: log on LOGL_ERROR ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > A spec. violation from the MS side does not look like an error condition to me... […] not even if an *EMERGENCY* is not being answered? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id6ea25484479bfc1728124df8fe8e2e03bcee3ec Gerrit-Change-Number: 27904 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Apr 2022 20:12:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call deny: do not dispatch dtap

by neels

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27903 ) Change subject: emerg call deny: do not dispatch dtap ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I065953f0380e142824ba30a842c86f9c598f89fe Gerrit-Change-Number: 27903 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: abandon

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call deny: do not dispatch dtap

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27903 ) Change subject: emerg call deny: do not dispatch dtap ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27903/comment/c11014df_dd347862 PS1, Line 1077: /* fall through */ > I see no change here: 'break' generally moves the execution flow out of the switch statement (unless […] no, i didn't pay attention apparently -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I065953f0380e142824ba30a842c86f9c598f89fe Gerrit-Change-Number: 27903 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Apr 2022 20:11:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call: tweak log, comments

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27901 to look at the new patch set (#2). Change subject: emerg call: tweak log, comments ...................................................................... emerg call: tweak log, comments Change-Id: I01e457ae6a9a951a2525c2159cb5979a0cb8bd95 --- M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/gsm_04_08_rr.c 2 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/27901/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I01e457ae6a9a951a2525c2159cb5979a0cb8bd95 Gerrit-Change-Number: 27901 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call deny: fix RR release cause

by neels

Attention is currently required from: neels. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27902 to look at the new patch set (#2). Change subject: emerg call deny: fix RR release cause ...................................................................... emerg call deny: fix RR release cause So far the we indicated pre-emption in the release cause of denying an emergency setup, instead indicate protocol error. When emergency calls are disallowed, it is not pre-emption (making room for an emergency call) but a protocol error (MS asks for emergency call when the network does not allow it). Related: OS#5534 Change-Id: Ia195621165cb7bbe33e6c2e915abc42ab16a2a4f --- M src/osmo-bsc/gsm_04_08_rr.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/02/27902/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia195621165cb7bbe33e6c2e915abc42ab16a2a4f Gerrit-Change-Number: 27902 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call deny: log on LOGL_ERROR

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27904 to look at the new patch set (#2). Change subject: emerg call deny: log on LOGL_ERROR ...................................................................... emerg call deny: log on LOGL_ERROR Change-Id: Id6ea25484479bfc1728124df8fe8e2e03bcee3ec --- M src/osmo-bsc/gsm_04_08_rr.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/04/27904/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id6ea25484479bfc1728124df8fe8e2e03bcee3ec Gerrit-Change-Number: 27904 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-ci[master]: dahdi-linux: Add gerrit build verification against master

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27913 ) Change subject: dahdi-linux: Add gerrit build verification against master ...................................................................... dahdi-linux: Add gerrit build verification against master Now that master-dahdi-linux-master is passing, we should verify any future patches also against master. Change-Id: I86cfd7e868dcaeeb6c6dbc6f08046a70b4582cc7 --- M jobs/gerrit-verifications-dahdi.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/13/27913/1 diff --git a/jobs/gerrit-verifications-dahdi.yml b/jobs/gerrit-verifications-dahdi.yml index bb0263f..51bfb04 100644 --- a/jobs/gerrit-verifications-dahdi.yml +++ b/jobs/gerrit-verifications-dahdi.yml @@ -4,6 +4,7 @@ linux-ver: - "v4.19" - "v5.10" + - "master" jobs: - 'gerrit-dahdi-linux-{linux-ver}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I86cfd7e868dcaeeb6c6dbc6f08046a70b4582cc7 Gerrit-Change-Number: 27913 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ci[master]: dahdi: use buster, not stretch

by laforge

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/27908 to look at the new patch set (#2). Change subject: dahdi: use buster, not stretch ...................................................................... dahdi: use buster, not stretch stretch has too old gcc which doesn't support -Wno-format-truncation which is used in dahdi-linux since 2018. Related: OS#5407 Change-Id: I4fca722e67b2c649dea4f9799d277cd568bcc493 --- M jobs/gerrit-verifications-dahdi.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/08/27908/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4fca722e67b2c649dea4f9799d277cd568bcc493 Gerrit-Change-Number: 27908 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in dahdi-linux[master]: wctc4xxp: Use __dev_addr_set() on kernels >= 5.15

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27911 ) Change subject: wctc4xxp: Use __dev_addr_set() on kernels >= 5.15 ...................................................................... wctc4xxp: Use __dev_addr_set() on kernels >= 5.15 The address list has been converted to a tree, so netdev->dev_addr is now const and must not be written directly. The __dev_addr_set helper can be used for this. Change-Id: Id7b71164dfe7772b68e86cb12ac0e0974fec1498 --- M drivers/dahdi/wctc4xxp/base.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/drivers/dahdi/wctc4xxp/base.c b/drivers/dahdi/wctc4xxp/base.c index 7ff3456..223bbbd 100644 --- a/drivers/dahdi/wctc4xxp/base.c +++ b/drivers/dahdi/wctc4xxp/base.c @@ -637,7 +637,11 @@ return -ENOMEM; priv = netdev_priv(netdev); priv->wc = wc; +#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 15, 0) + __dev_addr_set(netdev, our_mac, sizeof(our_mac)); +#else memcpy(netdev->dev_addr, our_mac, sizeof(our_mac)); +#endif # ifdef HAVE_NET_DEVICE_OPS netdev->netdev_ops = &wctc4xxp_netdev_ops; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Id7b71164dfe7772b68e86cb12ac0e0974fec1498 Gerrit-Change-Number: 27911 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in dahdi-linux[master]: dahdi-sysfs-chan: Fix potential NULL pointer deref

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27912 ) Change subject: dahdi-sysfs-chan: Fix potential NULL pointer deref ...................................................................... dahdi-sysfs-chan: Fix potential NULL pointer deref Sometimes it is useful to look at compiler warnings: dahdi-sysfs-chan.c:384:17: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] And indeed, we could have de-referenced a NULL pointer here. Change-Id: I4274e7a92ca6ee7e92c6adb713fb89ffe31b4c72 --- M drivers/dahdi/dahdi-sysfs-chan.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/drivers/dahdi/dahdi-sysfs-chan.c b/drivers/dahdi/dahdi-sysfs-chan.c index a91e6ed..8682ea3 100644 --- a/drivers/dahdi/dahdi-sysfs-chan.c +++ b/drivers/dahdi/dahdi-sysfs-chan.c @@ -381,10 +381,11 @@ return; for (i = 0; i < ARRAY_SIZE(fixed_minors); i++) { void *d = fixed_minors[i].dev; - if (d && !IS_ERR(d)) + if (d && !IS_ERR(d)) { dahdi_dbg(DEVICES, "Removing fixed device file %s\n", fixed_minors[i].name); DEL_DAHDI_DEV(fixed_minors[i].minor); + } } } -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I4274e7a92ca6ee7e92c6adb713fb89ffe31b4c72 Gerrit-Change-Number: 27912 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022