Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854 )
Change subject: pgw: Add TC_gy_charging_cc_time
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Patchset:
PS2:
> ping
Huh, the two comments I left were not marked as Resolved, so I thought they're not addressed.
File pgw/PGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854/comment/0b81d6cd_5ec5…
PS1, Line 688: /* create a session, then execute a ping command on the user plane */
> This test is not only about creating session and running ping, right? This comment needs to be clari […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854/comment/0000a7f1_f969…
PS1, Line 715: control {
> Is it intentional that you don't add TC_gy_charging_cc_time to the control section?
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie4e567f62bbbdba276e6b3221111c8d9f82cde14
Gerrit-Change-Number: 27854
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Apr 2022 09:15:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/27916 )
Change subject: CM Serv Rej: do not crash on use count mismatch
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
does it make sense to send a CM Serv Rej despite no CM Serv Request was sent in first place? Probably not?
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/27916
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I2009df42d1f27ec0d011e22bfc46dbc17afe7239
Gerrit-Change-Number: 27916
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Apr 2022 08:55:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27917 )
Change subject: contrib/jenkins.sh: disable CONFIG_WERROR
......................................................................
contrib/jenkins.sh: disable CONFIG_WERROR
As requested by Harald, do not build with -Werror in jenkins. It had
been made the default in Linux 5.15.
Related: OS#5407
Change-Id: I0ba2e4bfc4b9920796197539f9823a18f446c9cb
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/17/27917/1
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index eeb3fbc..837a7ee 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -17,6 +17,7 @@
if ! [ -e ".config" ]; then
make "$DEFCONFIG"
+ sed -i 's/CONFIG_WERROR=y/# CONFIG_WERROR is not set/' .config
fi
if [ "arch/x86/configs/$DEFCONFIG" -nt ".config" ]; then
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27917
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I0ba2e4bfc4b9920796197539f9823a18f446c9cb
Gerrit-Change-Number: 27917
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange