April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: paging: Submit up to 20 paging requests in a single work iteration

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27885 ) Change subject: paging: Submit up to 20 paging requests in a single work iteration ...................................................................... Patch Set 4: (2 comments) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27885/comment/75bb8b1c_48af21b7 PS3, Line 243: } while (request != initial_request && num_paged < MAX_PAGE_REQ_PER_ITER); > I am trying to understand how this is supposed to work if you have less than 20 penging requests awa […] If we have two: [A, B] initial_request = A request = A do { ... llist_del + llist_add_tail: [B, A] request = B while (request != initial_request) -> B != A, we do next iteration with B: do { ... llist_del + llist_add_tail: [A, B] request = A while (request != initial_request) -> A != A, not true, we break. https://gerrit.osmocom.org/c/osmo-bsc/+/27885/comment/154d1e57_0fc418b6 PS3, Line 246: sched_next_paging > This label name is confusing: when I saw the 'goto' above I thought you're somehow scheduling/sendin […] ok I'll change it to sched_next_iter. "skip_paging" didn't look good to me, since sometimes it's not really skipping, but actually re-scheduling. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I609fa67834b426456f48f6fb2acb601c5905f178 Gerrit-Change-Number: 27885 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 09:58:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: paging: Log skip paging due to not enough free channels

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27884 ) Change subject: paging: Log skip paging due to not enough free channels ...................................................................... paging: Log skip paging due to not enough free channels Change-Id: I311f90be99c4561b45f99ce98533aab5909301d0 --- M src/osmo-bsc/paging.c 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index bf2629d..898fa95 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -208,9 +208,12 @@ struct gsm_paging_request, entry); /* we need to determine the number of free channels */ - if (paging_bts->free_chans_need != -1) { - if (can_send_pag_req(request->bts, request->chan_type) != 0) - goto skip_paging; + if (paging_bts->free_chans_need != -1 && + can_send_pag_req(request->bts, request->chan_type) != 0) { + LOG_PAGING_BTS(request, request->bts, DPAG, LOGL_INFO, + "Paging delayed: not enough free channels (<%d)\n", + paging_bts->free_chans_need); + goto skip_paging; } /* Skip paging if the bts is down. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27884 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I311f90be99c4561b45f99ce98533aab5909301d0 Gerrit-Change-Number: 27884 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: paging: Avoid setting up credit_timer every time

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27880 ) Change subject: paging: Avoid setting up credit_timer every time ...................................................................... paging: Avoid setting up credit_timer every time Change-Id: Id4da0ab094ffe939cad9ff5708721e25b5a1a984 --- M src/osmo-bsc/paging.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, approved diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 73c1175..ed435f4 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -200,8 +200,6 @@ * to zero and we do not get any messages. */ if (paging_bts->available_slots == 0) { - osmo_timer_setup(&paging_bts->credit_timer, paging_give_credit, - paging_bts); osmo_timer_schedule(&paging_bts->credit_timer, 5, 0); return; } @@ -248,6 +246,7 @@ bts->paging.available_slots = 20; INIT_LLIST_HEAD(&bts->paging.pending_requests); osmo_timer_setup(&bts->paging.work_timer, paging_worker, &bts->paging); + osmo_timer_setup(&bts->paging.credit_timer, paging_give_credit, &bts->paging); } /*! do we have any pending paging requests for given subscriber? */ 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27880 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id4da0ab094ffe939cad9ff5708721e25b5a1a984 Gerrit-Change-Number: 27880 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: paging: Use llist_first_entry() macro

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27883 ) Change subject: paging: Use llist_first_entry() macro ...................................................................... paging: Use llist_first_entry() macro Change-Id: I83e88de6f48cc8aad18ed80ab981b0b438e72b1a --- M src/osmo-bsc/paging.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index ed435f4..bf2629d 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -204,8 +204,8 @@ return; } - request = llist_entry(paging_bts->pending_requests.next, - struct gsm_paging_request, entry); + request = llist_first_entry(&paging_bts->pending_requests, + struct gsm_paging_request, entry); /* we need to determine the number of free channels */ if (paging_bts->free_chans_need != -1) { 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27883 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I83e88de6f48cc8aad18ed80ab981b0b438e72b1a Gerrit-Change-Number: 27883 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: rsl_rx_ccch_load: Use UINT16_MAX instead of -1

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27879 ) Change subject: rsl_rx_ccch_load: Use UINT16_MAX instead of -1 ...................................................................... rsl_rx_ccch_load: Use UINT16_MAX instead of -1 The variables are unsigned, so -1 gets actually translated to UNIT16_MAX when the value is casted to uint16_t. Let's do that explicitly so that readers don't think those are signed variables. Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 0ede339..b5375e0 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2328,14 +2328,14 @@ struct ccch_signal_data sd; sd.bts = sign_link->trx->bts; - sd.rach_slot_count = -1; - sd.rach_busy_count = -1; - sd.rach_access_count = -1; + sd.rach_slot_count = UINT16_MAX; + sd.rach_busy_count = UINT16_MAX; + sd.rach_access_count = UINT16_MAX; switch (rslh->data[0]) { case RSL_IE_PAGING_LOAD: sd.pg_buf_space = rslh->data[1] << 8 | rslh->data[2]; - if (is_ipaccess_bts(sign_link->trx->bts) && sd.pg_buf_space == 0xffff) { + if (is_ipaccess_bts(sign_link->trx->bts) && sd.pg_buf_space == UINT16_MAX) { /* paging load below configured threshold, use 50 as default */ sd.pg_buf_space = 50; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 Gerrit-Change-Number: 27879 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: paging: Log skip paging due to not enough free channels

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27884 ) Change subject: paging: Log skip paging due to not enough free channels ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27884 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I311f90be99c4561b45f99ce98533aab5909301d0 Gerrit-Change-Number: 27884 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 09:45:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: rsl_rx_ccch_load: Use UINT16_MAX instead of -1

by osmith

Attention is currently required from: pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27879 ) Change subject: rsl_rx_ccch_load: Use UINT16_MAX instead of -1 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 Gerrit-Change-Number: 27879 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 09:37:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: rsl_rx_ccch_load: Use UINT16_MAX instead of -1

by fixeria

Attention is currently required from: osmith, pespin, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27879 ) Change subject: rsl_rx_ccch_load: Use UINT16_MAX instead of -1 ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/27879/comment/200e9f47_eda0d5f2 PS1, Line 10: isgned > signed Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 Gerrit-Change-Number: 27879 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 09:33:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: rsl_rx_ccch_load: Use UINT16_MAX instead of -1

by pespin

Attention is currently required from: daniel. Hello osmith, Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27879 to look at the new patch set (#3). Change subject: rsl_rx_ccch_load: Use UINT16_MAX instead of -1 ...................................................................... rsl_rx_ccch_load: Use UINT16_MAX instead of -1 The variables are unsigned, so -1 gets actually translated to UNIT16_MAX when the value is casted to uint16_t. Let's do that explicitly so that readers don't think those are signed variables. Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/79/27879/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 Gerrit-Change-Number: 27879 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pgw: Add TC_gy_charging_cc_time

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854 ) Change subject: pgw: Add TC_gy_charging_cc_time ...................................................................... pgw: Add TC_gy_charging_cc_time Related: SYS#5276 Change-Id: Ie4e567f62bbbdba276e6b3221111c8d9f82cde14 --- M pgw/PGW_Tests.ttcn 1 file changed, 25 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 02c28cc..1a02c4d 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -685,8 +685,32 @@ vc_conn.done; } +/* Test charging over Gy interface. */ +private function f_TC_gy_charging_cc_time() runs on PGW_Session_CT { + var default d; + f_create_session(); + /* We should receive an update even if no traffic is sent: */ + as_DIA_Gy_CCR(UPDATE_REQUEST); + + d := activate(as_DIA_Gy_CCR(UPDATE_REQUEST)); + f_ping4(mp_ping_hostname); + /* Let the CCA reach the GGSN */ + f_sleep(0.5); + deactivate(d); + + f_delete_session(omit, g_teic, '10'O); + setverdict(pass); +} +testcase TC_gy_charging_cc_time() runs on PGW_Test_CT { + var PGW_Session_CT vc_conn; + var SessionPars pars := valueof(t_SessionPars('001010123456789'H, "tun23")); + pars.gy_validity_time := 3; /* Grant access for 3 seconds, needs to be re-validated afterwards */ + f_init(); + vc_conn := f_start_handler(refers(f_TC_gy_charging_cc_time), pars); + vc_conn.done; +} control { execute( TC_tx_echo() ); @@ -695,6 +719,7 @@ execute( TC_createSession_ping4_256() ); execute( TC_createSession_deleteSession() ); execute( TC_deleteSession_unknown() ); + execute( TC_gy_charging_cc_time() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4e567f62bbbdba276e6b3221111c8d9f82cde14 Gerrit-Change-Number: 27854 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022