Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29725 )
Change subject: osmux: Clean up mgcp_config osmux fields
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
I'd add indentation for the struct, otherwise LGTM
File include/osmocom/mgcp/mgcp.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/29725/comment/c7e4eeb7_d25ad70b
PS1, Line 162: enum osmux_usage usage;
no indentation for contents of the struct?
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29725
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icc1c1ce3ab3a8beb941cda7c112485a0db882a90
Gerrit-Change-Number: 29725
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Oct 2022 08:42:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29702 )
Change subject: jenkins-gerrit: tweak notify setting
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> That may be a bit problematic. […]
I'm pretty sure that only having the owner of the patch notified is the behavior we already had before introducing the recent changes: whoever submits the patch is the owner of the patch and gets the notification if one of the CI checks fails.
So I guess there was a misunderstanding here, owner meaning the person who submitted the patch and not an administrator or something. Does that resolve it?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29702
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I7c6c183b98624eb75d5dccd9766ee3ff5568b06e
Gerrit-Change-Number: 29702
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Oct 2022 08:23:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment