October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: jobs/gerrit-verifications: add approvals comment

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29687 ) Change subject: jobs/gerrit-verifications: add approvals comment ...................................................................... jobs/gerrit-verifications: add approvals comment Related: OS#2385 Change-Id: I4dfc0f84ffe584523bbff4c41295968a07ba097d --- M jobs/gerrit-verifications.yml 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 0e64ff3..8331096 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -17,6 +17,11 @@ # By default the matrix results in only one job, however for some projects we # use the matrix to build for multiple CPU architectures (x86_64, arm) or use # it to build multiple configurations of the same project (see osmo-bts). +# +# NOTE: after updating the job with Jenkins Job Builder as usual, check if a +# new pipeline script was generated and approve it here: +# https://jenkins.osmocom.org/jenkins/scriptApproval/ +# This happens when changing the pipeline script, when adding new projects etc. - project: name: gerrit @@ -364,6 +369,11 @@ name: PIPELINE_BINPKGS description: Enable the binpkgs job (build deb/rpm packages) default: '{obj:pipeline_binpkgs}' + # NOTE: jenkins pipelines don't run unless the dsl-script was approved. + # Sadly this doesn't happen automatically when updating the job with + # Jenkins Job Builder. So if you change the pipeline script, update the job + # as usually with JJB and then approve the scripts here: + # https://jenkins.osmocom.org/jenkins/scriptApproval/ dsl: | pipeline {{ agent {{ label "osmocom-gerrit" }} -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4dfc0f84ffe584523bbff4c41295968a07ba097d Gerrit-Change-Number: 29687 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-verifications: set pipeline concurrent

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29706 ) Change subject: jobs/gerrit-verifications: set pipeline concurrent ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/29706/comment/c55b6f74_ac8e2b8a PS4, Line 12: Note that the concurrent setting of the build jobs are not changed. Some > settings? I mean the "concurrent" setting / argument / option in in the related build jobs. e.g. https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bsc-nat-build/configure "Execute concurrent builds if necessary" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29706 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie2a19013e73d96a937e8f83c815c6a82cfe0768d Gerrit-Change-Number: 29706 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:08:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in simtrace2[master]: contrib/jenkins.sh: set USE_CLANG=1

by pespin

Attention is currently required from: osmith, Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/29730 ) Change subject: contrib/jenkins.sh: set USE_CLANG=1 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/29730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I2aa2e20e75e334560dbe1f6db9fd1491873ff91f Gerrit-Change-Number: 29730 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:07:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-verifications: add osmo-ci

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29689 ) Change subject: jobs/gerrit-verifications: add osmo-ci ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie6d8a99647846fb4008953b444bba642cbcf3b1e Gerrit-Change-Number: 29689 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:06:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-verifications*: drop unsupported args

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29688 ) Change subject: jobs/gerrit-verifications*: drop unsupported args ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6a0057738955bc2507cb5d8c4d48edf652c3529f Gerrit-Change-Number: 29688 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:06:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jenkins-gerrit: tweak notify setting

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29702 ) Change subject: jenkins-gerrit: tweak notify setting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7c6c183b98624eb75d5dccd9766ee3ff5568b06e Gerrit-Change-Number: 29702 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:06:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-gsm-manuals[master]: osmux: Improve NAT related documentation

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29723 ) Change subject: osmux: Improve NAT related documentation ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File common/chapters/osmux/osmux.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29723/comment/cd86bc07_1bb4… PS1, Line 57: charachtersitic > characteristic Done https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29723/comment/e34d2cf4_86d8… PS1, Line 69: insance > instance Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5ed7aa834bfd0d5ef84ff69ece6d1d5e5b920d4e Gerrit-Change-Number: 29723 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:05:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Clean up mgcp_config osmux fields

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29725 ) Change subject: osmux: Clean up mgcp_config osmux fields ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File include/osmocom/mgcp/mgcp.h: https://gerrit.osmocom.org/c/osmo-mgw/+/29725/comment/ed91d87c_04cf4d55 PS1, Line 162: enum osmux_usage usage; > no indentation for contents of the struct? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icc1c1ce3ab3a8beb941cda7c112485a0db882a90 Gerrit-Change-Number: 29725 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:05:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in simtrace2[master]: contrib/jenkins.sh: set USE_CLANG=1

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/29730 ) Change subject: contrib/jenkins.sh: set USE_CLANG=1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > why do we need clang? ah I forgot to reference the issue in the commit message. updated. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/29730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I2aa2e20e75e334560dbe1f6db9fd1491873ff91f Gerrit-Change-Number: 29730 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:04:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in simtrace2[master]: contrib/jenkins.sh: set USE_CLANG=1

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/29730 to look at the new patch set (#2). Change subject: contrib/jenkins.sh: set USE_CLANG=1 ...................................................................... contrib/jenkins.sh: set USE_CLANG=1 As the bootloader goes beyond partition size in modern gcc, use clang instead. Depends: docker-playground Ib82a53fa7edc62d21e772efbb9b2c049d1b50c4d Related: OS#5260 Change-Id: I2aa2e20e75e334560dbe1f6db9fd1491873ff91f --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/30/29730/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/29730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I2aa2e20e75e334560dbe1f6db9fd1491873ff91f Gerrit-Change-Number: 29730 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022