October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-e1d[master]: octoi: Prevent segfault on 'show octoi-clients if a client has no line

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29726 ) Change subject: octoi: Prevent segfault on 'show octoi-clients if a client has no line ...................................................................... octoi: Prevent segfault on 'show octoi-clients if a client has no line This can happen if the specified device in the config isn't plugged in for instance, no line is created ... Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I594463591f2945a04ccd708f16788034cc1dfc57 --- M src/octoi/octoi_fsm.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/octoi/octoi_fsm.c b/src/octoi/octoi_fsm.c index 39790fa..06d2105 100644 --- a/src/octoi/octoi_fsm.c +++ b/src/octoi/octoi_fsm.c @@ -240,7 +240,9 @@ vty_out(vty, " Peer '%s', Remote "OSMO_SOCKADDR_STR_FMT", State %s%s", peer->name, OSMO_SOCKADDR_STR_FMT_ARGS(&peer->cfg.remote), osmo_fsm_inst_state_name(peer->priv), VTY_NEWLINE); - vty_out_rate_ctr_group(vty, " ", peer->iline->ctrs); - vty_out_stat_item_group(vty, " ", peer->iline->stats); + if (peer->iline) { + vty_out_rate_ctr_group(vty, " ", peer->iline->ctrs); + vty_out_stat_item_group(vty, " ", peer->iline->stats); + } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I594463591f2945a04ccd708f16788034cc1dfc57 Gerrit-Change-Number: 29726 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-e1d[master]: octoi: Prevent segfault on 'show octoi-clients if a client has no line

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29726 ) Change subject: octoi: Prevent segfault on 'show octoi-clients if a client has no line ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I594463591f2945a04ccd708f16788034cc1dfc57 Gerrit-Change-Number: 29726 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:45:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: cosmetic: Fix whitespace indentation

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29732 ) Change subject: cosmetic: Fix whitespace indentation ...................................................................... cosmetic: Fix whitespace indentation Change-Id: I7d713872220e665e126dee670cdd77f7eb44eba4 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/29732/1 diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 61a1559..fd5382f 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -3455,7 +3455,7 @@ install_element(GSMNET_NODE, &cfg_net_nri_null_del_cmd); bts_vty_init(); - mgcp_client_pool_vty_init(GSMNET_NODE, MGW_NODE, " ", vty_global_gsm_network->mgw.mgw_pool); + mgcp_client_pool_vty_init(GSMNET_NODE, MGW_NODE, " ", vty_global_gsm_network->mgw.mgw_pool); install_element(ENABLE_NODE, &drop_bts_cmd); install_element(ENABLE_NODE, &restart_bts_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7d713872220e665e126dee670cdd77f7eb44eba4 Gerrit-Change-Number: 29732 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: cosmetic: Fix typo in comment

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29731 ) Change subject: cosmetic: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b0fcd7ee13e0e712d47741258f83a6f98503e27 Gerrit-Change-Number: 29731 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:23:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: ansible/ttcn3-slave: fix adding apt key

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29708 ) Change subject: ansible/ttcn3-slave: fix adding apt key ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > That's very weird OBS requirement. yep -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idb23231d629ba8a75510deace0d1f130e889d535 Gerrit-Change-Number: 29708 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:20:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: ansible/hosts: add build2-deb11build-ansible

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29707 ) Change subject: ansible/hosts: add build2-deb11build-ansible ...................................................................... ansible/hosts: add build2-deb11build-ansible Add it to the config. I've used this to enable ipv6 in docker, so libosmocore builds don't fail in the socket test when building rpm/deb packages on that host in docker. Related: OS#2385 Change-Id: Ibe8e2a638fcbc7c0a69c211385a870b1a82b6fef --- M ansible/hosts 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved msuraev: Looks good to me, but someone else must approve diff --git a/ansible/hosts b/ansible/hosts index c6164a3..1c1ed4d 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -11,6 +11,7 @@ admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300 osmocom_jenkins_slave_fstrim=True build2-deb9build-ansible ansible_host=2a01:4f8:10b:2ad9::1:6 osmocom_jenkins_slave_fstrim=True build2-deb10build-ansible ansible_host=2a01:4f8:10b:2ad9::1:10 osmocom_jenkins_slave_fstrim=True +build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 osmocom_jenkins_slave_fstrim=True host2-deb9build-ansible ansible_host=2a01:4f8:120:8470::1:3 osmocom_jenkins_slave_fstrim=True gtp0-deb9build ansible_host=10.34.2.102 osmocom_jenkins_slave_fstrim=True gtp0-deb10build ansible_host=10.34.2.101 osmocom_jenkins_slave_fstrim=True -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibe8e2a638fcbc7c0a69c211385a870b1a82b6fef Gerrit-Change-Number: 29707 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: ansible/ttcn3-slave: fix adding apt key

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29708 ) Change subject: ansible/ttcn3-slave: fix adding apt key ...................................................................... ansible/ttcn3-slave: fix adding apt key Downloading the apt key from obs.osmocom.org returns a 404 error unless an Accept HTTP header is sent. (Yes, really.) Also using apt-key is deprecated, so change it to download the key with get_url as shown in the ansible docs example. Fix for: Failed to download key at https://obs.osmocom.org/projects/osmocom/public_key: HTTP Error 404: Not Found Related: https://github.com/ansible/ansible/issues/50436#issuecomment-451205256 Related: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/apt_key… Change-Id: Idb23231d629ba8a75510deace0d1f130e889d535 --- M ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved msuraev: Looks good to me, but someone else must approve diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml b/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml index 1e61fe5..67717fc 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml @@ -15,12 +15,17 @@ dest: "/home/{{ jenkins_user }}/jenkins/docker-playground" - name: add apt.key - apt_key: + get_url: url: https://obs.osmocom.org/projects/osmocom/public_key + dest: /etc/apt/trusted.gpg.d/obs.osmocom.org.asc + # OBS webserver needs this header, returns 404 otherwise + # https://github.com/ansible/ansible/issues/50436#issuecomment-451205256 + headers: + Accept: '*/*' - name: add apt repository apt_repository: - repo: "deb https://downloads.osmocom.org/packages/osmocom:/latest/{{ obs_distro }}/ ./" + repo: "deb [signed-by=/etc/apt/trusted.gpg.d/obs.osmocom.org.asc] https://downloads.osmocom.org/packages/osmocom:/latest/{{ obs_distro }}/ ./" filename: obs_osmocom update_cache: yes -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idb23231d629ba8a75510deace0d1f130e889d535 Gerrit-Change-Number: 29708 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: cosmetic: Fix typo in comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29731 ) Change subject: cosmetic: Fix typo in comment ...................................................................... cosmetic: Fix typo in comment Change-Id: I6b0fcd7ee13e0e712d47741258f83a6f98503e27 --- M src/libosmo-mgcp-client/mgcp_client_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/31/29731/1 diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c b/src/libosmo-mgcp-client/mgcp_client_vty.c index 4bf6cd0..88b056b 100644 --- a/src/libosmo-mgcp-client/mgcp_client_vty.c +++ b/src/libosmo-mgcp-client/mgcp_client_vty.c @@ -35,7 +35,7 @@ #define MGW_STR MGCP_CLIENT_MGW_STR -/* Only common (non-pooled) VTY connands will use this talloc context. All +/* Only common (non-pooled) VTY commands will use this talloc context. All * pooled VTY commands will use the pool (global_mgcp_client_pool) as * talloc context. */ static void *global_mgcp_client_ctx = NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b0fcd7ee13e0e712d47741258f83a6f98503e27 Gerrit-Change-Number: 29731 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: ansible/ttcn3-slave: fix adding apt key

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29708 ) Change subject: ansible/ttcn3-slave: fix adding apt key ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idb23231d629ba8a75510deace0d1f130e889d535 Gerrit-Change-Number: 29708 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:20:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: ansible/hosts: add build2-deb11build-ansible

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29707 ) Change subject: ansible/hosts: add build2-deb11build-ansible ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibe8e2a638fcbc7c0a69c211385a870b1a82b6fef Gerrit-Change-Number: 29707 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 11:20:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022