October 2022 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: debian-buster-jenkins: order pkgs alphabetically

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29738 ) Change subject: debian-buster-jenkins: order pkgs alphabetically ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I32dffc65239f1ad650b9e8d6ed6e4fe48878b916 Gerrit-Change-Number: 29738 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 12:52:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: add LLVMEmbeddedToolchainForArm

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29739 ) Change subject: debian-buster-jenkins: add LLVMEmbeddedToolchainForArm ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4f3fd7f7a40e5fa00bbfc713c1365f573febfe41 Gerrit-Change-Number: 29739 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 12:52:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: Revert "debian-buster-build: add LLVMEmbeddedToolchainForArm"

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29737 ) Change subject: Revert "debian-buster-build: add LLVMEmbeddedToolchainForArm" ...................................................................... Revert "debian-buster-build: add LLVMEmbeddedToolchainForArm" Wrong docker container, debian-buster-jenkins is used for the build, not debian-buster-build. The next patches will adjust the right one. This reverts commit 1ce91ecfb027134c035d81756e47f27ba86e2be6. Change-Id: Idff1d5a263181070133743c781615b1102311efb --- M debian-buster-build/Dockerfile 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/37/29737/1 diff --git a/debian-buster-build/Dockerfile b/debian-buster-build/Dockerfile index a22a3bf..0d2b5b7 100644 --- a/debian-buster-build/Dockerfile +++ b/debian-buster-build/Dockerfile @@ -6,9 +6,6 @@ ARG OSMOCOM_REPO_PATH="packages/osmocom:" ARG OSMOCOM_REPO="$OSMOCOM_REPO_MIRROR/${OSMOCOM_REPO_PATH}/nightly/Debian_10/" -# LLVM-embedded-toolchain-for-Arm version -ARG LLVM_VERSION="14.0.0" - RUN apt-get update && \ apt-get upgrade -y && \ apt-get install -y --no-install-recommends \ @@ -53,7 +50,6 @@ libsqlite3-dev \ libssl-dev \ libtalloc-dev \ - libtinfo5 \ libtool \ libusb-1.0-0-dev \ libusb-dev \ @@ -65,14 +61,6 @@ wget && \ apt-get clean -RUN set -x && \ - wget -q https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm/releases/do… && \ - tar -xf LLVMEmbeddedToolchainForArm-${LLVM_VERSION}-linux.tar.gz && \ - rm LLVMEmbeddedToolchainForArm-${LLVM_VERSION}-linux.tar.gz && \ - mv LLVMEmbeddedToolchainForArm-${LLVM_VERSION} /opt/llvm-arm && \ - /opt/llvm-arm/bin/clang --version && \ - /opt/llvm-arm/bin/clang --print-targets - # Make respawn.sh part of this image, so it can be used by other images based on it COPY .common/respawn.sh /usr/local/bin/respawn.sh -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Idff1d5a263181070133743c781615b1102311efb Gerrit-Change-Number: 29737 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: order pkgs alphabetically

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29738 ) Change subject: debian-buster-jenkins: order pkgs alphabetically ...................................................................... debian-buster-jenkins: order pkgs alphabetically Change-Id: I32dffc65239f1ad650b9e8d6ed6e4fe48878b916 --- M debian-buster-jenkins/Dockerfile 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/38/29738/1 diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 5229373..269aa83 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -97,6 +97,10 @@ osc \ patchelf \ pkg-config \ + python-pip \ + python-setuptools \ + python-yaml \ + python2.7 \ python3 \ python3-gi \ python3-mako \ @@ -106,14 +110,10 @@ python3-setuptools \ python3-usb \ python3-yaml \ - python2.7 \ - python-pip \ - python-setuptools \ - python-yaml \ rsync \ sdcc \ - sqlite3 \ source-highlight \ + sqlite3 \ stow \ sudo \ systemd \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I32dffc65239f1ad650b9e8d6ed6e4fe48878b916 Gerrit-Change-Number: 29738 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: add LLVMEmbeddedToolchainForArm

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29739 ) Change subject: debian-buster-jenkins: add LLVMEmbeddedToolchainForArm ...................................................................... debian-buster-jenkins: add LLVMEmbeddedToolchainForArm This is needed for simtrace2. As the bootloader goes beyond partition size in modern gcc, we'll use clang instead. Related: OS#5260 Related: simtrace2 I2aa2e20e75e334560dbe1f6db9fd1491873ff91f Change-Id: I4f3fd7f7a40e5fa00bbfc713c1365f573febfe41 --- M debian-buster-jenkins/Dockerfile 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/39/29739/1 diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 269aa83..1439065 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -12,6 +12,9 @@ # https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-fr… ARG DEBIAN_VERSION +# LLVM-embedded-toolchain-for-Arm version +ARG LLVM_VERSION="14.0.0" + # Install apt dependencies (keep in alphabetic order) RUN \ [ "$(arch)" = "x86_64" ] && dpkg --add-architecture i386; \ @@ -83,6 +86,7 @@ libsqlite3-dev \ libssl-dev \ libtalloc-dev \ + libtinfo5 \ libtool \ libusb-1.0-0-dev \ libusb-dev \ @@ -123,6 +127,14 @@ wget \ xsltproc +RUN set -x && \ + wget -q https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm/releases/do… && \ + tar -xf LLVMEmbeddedToolchainForArm-${LLVM_VERSION}-linux.tar.gz && \ + rm LLVMEmbeddedToolchainForArm-${LLVM_VERSION}-linux.tar.gz && \ + mv LLVMEmbeddedToolchainForArm-${LLVM_VERSION} /opt/llvm-arm && \ + /opt/llvm-arm/bin/clang --version && \ + /opt/llvm-arm/bin/clang --print-targets + # Install pip dependencies (keep in alphabetic order) RUN pip3 install \ git+https://github.com/podshumok/python-smpplib.git \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4f3fd7f7a40e5fa00bbfc713c1365f573febfe41 Gerrit-Change-Number: 29739 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: Replace apt-get with apt

by osmith

Attention is currently required from: msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29735 ) Change subject: Replace apt-get with apt ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think we should go the other way and use apt-get instead everywhere, otherwise the following warning gets printed: WARNING: apt does not have a stable CLI interface. Use with caution in scripts. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29735 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1f759fd9dcb7b72161b837e4799cff3efad441af Gerrit-Change-Number: 29735 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 12:46:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Fix typo in internal function name

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29736 ) Change subject: mgcp-client: Fix typo in internal function name ...................................................................... mgcp-client: Fix typo in internal function name Change-Id: I073038f1d6c68bc8546763a2c8c791fb5a021630 --- M src/libosmo-mgcp-client/mgcp_client_vty.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/36/29736/1 diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c b/src/libosmo-mgcp-client/mgcp_client_vty.c index 88b056b..44cff2e 100644 --- a/src/libosmo-mgcp-client/mgcp_client_vty.c +++ b/src/libosmo-mgcp-client/mgcp_client_vty.c @@ -493,7 +493,7 @@ return CMD_SUCCESS; } -DEFUN(mgw_show, mgw_snow_cmd, "show mgw-pool", SHOW_STR "Display information about the MGW-Pool\n") +DEFUN(mgw_show, mgw_show_cmd, "show mgw-pool", SHOW_STR "Display information about the MGW-Pool\n") { vty_out(vty, "%% MGW-Pool:%s", VTY_NEWLINE); struct mgcp_client_pool_member *pool_member; @@ -551,7 +551,7 @@ install_lib_element(ENABLE_NODE, &mgw_block_cmd); install_lib_element(ENABLE_NODE, &mgw_unblock_cmd); - install_lib_element_ve(&mgw_snow_cmd); + install_lib_element_ve(&mgw_show_cmd); global_mgcp_client_pool = pool; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29736 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I073038f1d6c68bc8546763a2c8c791fb5a021630 Gerrit-Change-Number: 29736 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: Replace apt-get with apt

by msuraev

Attention is currently required from: osmith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29735 ) Change subject: Replace apt-get with apt ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29735 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1f759fd9dcb7b72161b837e4799cff3efad441af Gerrit-Change-Number: 29735 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 12:38:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Avoid double iteration picking client from pool

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29734 ) Change subject: mgcp-client: Avoid double iteration picking client from pool ...................................................................... mgcp-client: Avoid double iteration picking client from pool Change-Id: I99e8be878452c5d8e2183239fbdd499dcf507e90 --- M src/libosmo-mgcp-client/mgcp_client_pool.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/34/29734/1 diff --git a/src/libosmo-mgcp-client/mgcp_client_pool.c b/src/libosmo-mgcp-client/mgcp_client_pool.c index 0531953..f3ed392 100644 --- a/src/libosmo-mgcp-client/mgcp_client_pool.c +++ b/src/libosmo-mgcp-client/mgcp_client_pool.c @@ -124,17 +124,18 @@ { struct mgcp_client_pool_member *pool_member; struct mgcp_client_pool_member *pool_member_picked = NULL; - unsigned int n_pool_members = llist_count(&pool->pool); + unsigned int n_pool_members = 0; llist_for_each_entry(pool_member, &pool->pool, list) { + n_pool_members++; if (pool_member->blocked == false && pool_member->client) { if (!pool_member_picked) pool_member_picked = pool_member; else if (pool_member_picked->refcount > pool_member->refcount) pool_member_picked = pool_member; } else { - LOGPPMGW(pool_member, LOGL_DEBUG, "MGW pool has %u members -- MGW %u is unusable\n", n_pool_members, - pool_member->nr); + LOGPPMGW(pool_member, LOGL_DEBUG, "%s -- MGW %u is unusable (blocked=%u, cli=%u)\n", + __func__, pool_member->nr, pool_member->blocked, !!pool_member->client); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I99e8be878452c5d8e2183239fbdd499dcf507e90 Gerrit-Change-Number: 29734 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_client: pool: Improve documentation of some internal fields

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29733 ) Change subject: mgcp_client: pool: Improve documentation of some internal fields ...................................................................... mgcp_client: pool: Improve documentation of some internal fields Change-Id: Ic9823ab0a3f101549452a7c7a0b1b5b21aaa837c --- M include/osmocom/mgcp_client/mgcp_client_pool_internal.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/33/29733/1 diff --git a/include/osmocom/mgcp_client/mgcp_client_pool_internal.h b/include/osmocom/mgcp_client/mgcp_client_pool_internal.h index 95f5525..588ba04 100644 --- a/include/osmocom/mgcp_client/mgcp_client_pool_internal.h +++ b/include/osmocom/mgcp_client/mgcp_client_pool_internal.h @@ -2,6 +2,7 @@ /* Struct to handle a member of a pool of MGWs. */ struct mgcp_client_pool_member { + /* Entry in llist mgcp_client_pool->pool. */ struct llist_head list; /* Reference number assinged by VTY. This number is used to manage the pool from the VTY and to identify it in @@ -31,7 +32,7 @@ * mgcp_client_vty_init() and actively registered by the API user using mgcp_client_pool_register_single() */ struct mgcp_client *mgcp_client_single; - /* A list that manages the pool members (see above) */ + /* A list that manages the pool members (see mgcp_client_pool_member->list above) */ struct llist_head pool; /* String to use for indentation when writing the configuration file to the VTY. This field is populated by -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic9823ab0a3f101549452a7c7a0b1b5b21aaa837c Gerrit-Change-Number: 29733 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022