Attention is currently required from: daniel.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29741 )
Change subject: Drop forward declaration of gbprox_relay2peer()
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29741
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Id8bce05ef347df93202a77b817a10903acaa9d97
Gerrit-Change-Number: 29741
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Oct 2022 14:28:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: daniel, lynxis lazus.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 )
Change subject: gbproxy_vty: Add commands to list Cell/BVC of an NSE
......................................................................
Patch Set 2:
(2 comments)
File src/gb_proxy_vty.c:
https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/f6597731_416b9183
PS2, Line 543: int i;
Would be better to use "unsigned" or "size_t" for i: it's iterated from 0 and used as array index inside hash_for_each() so it should never have negative value.
https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/5d9bf4eb_2fd0c4e3
PS2, Line 587: int i;
Same as above.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I10c6d3f59681ec6dc98f1a3b023af446cc2a1c12
Gerrit-Change-Number: 29714
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 13 Oct 2022 14:27:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29736 )
Change subject: mgcp-client: Fix typo in internal function name
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29736
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I073038f1d6c68bc8546763a2c8c791fb5a021630
Gerrit-Change-Number: 29736
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Oct 2022 14:19:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin, keith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29649 )
Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/osmo-bts-trx/trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/29649/comment/9953a328_bee1b9bd
PS4, Line 397: DEFUN
> I don't see anything changing in the vty help, but here it is anyway. […]
You will when you do 'list with-flags'. There should be '!' sign on the left indicating that the command applies immediately. Once merged, you'll also see 'This command applies immediately' in the osmobts-trx-vty-reference.pdf.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 6
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-Comment-Date: Thu, 13 Oct 2022 13:59:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: keith <keith(a)rhizomatica.org>
Gerrit-MessageType: comment
msuraev has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29735 )
Change subject: Replace apt-get with apt
......................................................................
Abandoned
Based on feedback
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29735
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1f759fd9dcb7b72161b837e4799cff3efad441af
Gerrit-Change-Number: 29735
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: abandon
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29740 )
Change subject: ansible/setup-simtest: pre-install pysim depends
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Marking as draft, couldn't test whether this works yet due to lacking permissions
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29740
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1e9ddb93f05108146a219bd28cf1e9332764bf8e
Gerrit-Change-Number: 29740
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Oct 2022 12:54:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment