Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/29730 )
Change subject: contrib/jenkins.sh: set USE_CLANG=1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
why do we need clang?
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/29730
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I2aa2e20e75e334560dbe1f6db9fd1491873ff91f
Gerrit-Change-Number: 29730
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Oct 2022 10:45:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29706 )
Change subject: jobs/gerrit-verifications: set pipeline concurrent
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ci/+/29706/comment/e3896503_02100688
PS4, Line 12: Note that the concurrent setting of the build jobs are not changed. Some
settings?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29706
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ie2a19013e73d96a937e8f83c815c6a82cfe0768d
Gerrit-Change-Number: 29706
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Oct 2022 10:42:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29702 )
Change subject: jenkins-gerrit: tweak notify setting
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I'm pretty sure that only having the owner of the patch notified is the behavior we already had befo […]
I already understood the owner was the person submitting the patch.
Maybe I was/am receiving all messages already anyway due to some config on my side to receive all notification on gerrit not sure.
Feel free to merge then.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29702
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I7c6c183b98624eb75d5dccd9766ee3ff5568b06e
Gerrit-Change-Number: 29702
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Oct 2022 10:41:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29723
to look at the new patch set (#2).
Change subject: osmux: Improve NAT related documentation
......................................................................
osmux: Improve NAT related documentation
Related: SYS#5987
Change-Id: I5ed7aa834bfd0d5ef84ff69ece6d1d5e5b920d4e
---
M common/chapters/osmux/osmux.adoc
1 file changed, 25 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/23/29723/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29723
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I5ed7aa834bfd0d5ef84ff69ece6d1d5e5b920d4e
Gerrit-Change-Number: 29723
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-mgw/+/29725
to look at the new patch set (#2).
Change subject: osmux: Clean up mgcp_config osmux fields
......................................................................
osmux: Clean up mgcp_config osmux fields
* Move all of them to an anonymous "osmux" substruct to have them all
together.
* Rename some fields to clarify its meanings, similar to what
was already done in osmo-bts.
* Move the port VTY config next to the ip address ones.
Change-Id: Icc1c1ce3ab3a8beb941cda7c112485a0db882a90
---
M include/osmocom/mgcp/mgcp.h
M src/libosmo-mgcp/mgcp_network.c
M src/libosmo-mgcp/mgcp_osmux.c
M src/libosmo-mgcp/mgcp_protocol.c
M src/libosmo-mgcp/mgcp_sdp.c
M src/libosmo-mgcp/mgcp_stat.c
M src/libosmo-mgcp/mgcp_vty.c
7 files changed, 81 insertions(+), 79 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/25/29725/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29725
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icc1c1ce3ab3a8beb941cda7c112485a0db882a90
Gerrit-Change-Number: 29725
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria, keith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29649 )
Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 6
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-Comment-Date: Thu, 13 Oct 2022 10:35:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment