Attention is currently required from: msuraev.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28906 )
Change subject: jobs/osmocom-obs-nightly-asan.yml: new file
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Is there need to push -asan packages to both OBS?
This patch is only pushing it to obs.osmocom.org.
The commit message explains that I put it in an extra file for this reason. However I could also put it in osmocom-obs.yml and add an exclude rule as I learned later, as done in https://gerrit.osmocom.org/c/osmo-ci/+/29595
In any case, this patch is blocked by discussions noted here: https://osmocom.org/issues/5301?next_issue_id=5300&prev_issue_id=5304#note-…
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28906
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1c8c65bd1829baa29864ad186f3c43e79979d141
Gerrit-Change-Number: 28906
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Oct 2022 08:18:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, fixeria.
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29649 )
Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
......................................................................
Patch Set 6:
(1 comment)
File src/osmo-bts-trx/trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/29649/comment/1717bd96_779fe99c
PS5, Line 398: "osmotrx tx-attenuation (oml|<0-50>)",
> You need to adjust the indentation after applying the changes.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 6
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Oct 2022 03:18:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, keith.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/29649
to look at the new patch set (#6).
Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
......................................................................
osmo-bts-trx: respond to tx-attenuation config in real time.
Some osmo-bts varieties have a method to make an immediate change to
TX power from the vty. In osmo-bts-trx there does not seem to be any
way, so lets start the power ramp loop when the parameter
osmotrx tx-attenution is changed on a running TRX.
Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 10 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/49/29649/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 6
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, tnt.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29726 )
Change subject: octoi: Prevent segfault on 'show octoi-clients if a client has no line
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29726
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I594463591f2945a04ccd708f16788034cc1dfc57
Gerrit-Change-Number: 29726
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt(a)246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Wed, 12 Oct 2022 21:50:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria, keith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29649 )
Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
......................................................................
Patch Set 5:
(1 comment)
File src/osmo-bts-trx/trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/29649/comment/b8247c31_fe73ece3
PS5, Line 398: "osmotrx tx-attenuation (oml|<0-50>)",
You need to adjust the indentation after applying the changes.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 5
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-Comment-Date: Wed, 12 Oct 2022 21:48:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29727 )
Change subject: usb: Claim and set interface alt-setting only for used lines
......................................................................
usb: Claim and set interface alt-setting only for used lines
If a line is not auto-created, there is no point on claiming the
matching interface and even less point setting the alt setting that
will try to use USB isoc bandwith.
With this you can no use only line 1 and not line 0 of a ice1usb
for instance. While previously it would still "enable" line 0 and
then line 1 would fail because on BW issues most of the case.
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
Change-Id: Iea5d72272f11875e7a32c78b60c188590deda831
---
M src/usb.c
1 file changed, 16 insertions(+), 15 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/27/29727/1
diff --git a/src/usb.c b/src/usb.c
index 47fff14..c8ad97f 100644
--- a/src/usb.c
+++ b/src/usb.c
@@ -904,21 +904,6 @@
}
}
- /* Get interface and set it up */
- ret = libusb_claim_interface(devh, id->bInterfaceNumber);
- if (ret) {
- LOGP(DE1D, LOGL_ERROR, "Failed to claim interface %d:%s\n", id->bInterfaceNumber,
- libusb_strerror(ret));
- goto next_interface;
- }
-
- ret = libusb_set_interface_alt_setting(devh, id->bInterfaceNumber, 1);
- if (ret) {
- LOGP(DE1D, LOGL_ERROR, "Failed to set interface %d altsetting:%s\n", id->bInterfaceNumber,
- libusb_strerror(ret));
- goto next_interface;
- }
-
/* Setup driver data and find endpoints */
line_data = talloc_zero(e1d->ctx, struct e1_usb_line_data);
@@ -965,6 +950,22 @@
line->drv_data = line_data;
}
+ /* Get interface and set it up */
+ ret = libusb_claim_interface(devh, id->bInterfaceNumber);
+ if (ret) {
+ LOGP(DE1D, LOGL_ERROR, "Failed to claim interface %d:%s\n", id->bInterfaceNumber,
+ libusb_strerror(ret));
+ goto next_interface;
+ }
+
+ ret = libusb_set_interface_alt_setting(devh, id->bInterfaceNumber, 1);
+ if (ret) {
+ LOGP(DE1D, LOGL_ERROR, "Failed to set interface %d altsetting:%s\n", id->bInterfaceNumber,
+ libusb_strerror(ret));
+ goto next_interface;
+ }
+
+ /* Create data flows and start the line */
line_data->flow_in = e1uf_create(line, e1_usb_xfer_in, line_data->ep_in, 4, line_data->pkt_size, 4);
line_data->flow_out = e1uf_create(line, e1_usb_xfer_out, line_data->ep_out, 4, line_data->pkt_size, 4);
line_data->flow_fb = e1uf_create(line, e1_usb_xfer_fb, line_data->ep_fb, 2, 3, 1);
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29727
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Iea5d72272f11875e7a32c78b60c188590deda831
Gerrit-Change-Number: 29727
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: newchange
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29726 )
Change subject: octoi: Prevent segfault on 'show octoi-clients if a client has no line
......................................................................
octoi: Prevent segfault on 'show octoi-clients if a client has no line
This can happen if the specified device in the config isn't plugged
in for instance, no line is created ...
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
Change-Id: I594463591f2945a04ccd708f16788034cc1dfc57
---
M src/octoi/octoi_fsm.c
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/26/29726/1
diff --git a/src/octoi/octoi_fsm.c b/src/octoi/octoi_fsm.c
index 39790fa..06d2105 100644
--- a/src/octoi/octoi_fsm.c
+++ b/src/octoi/octoi_fsm.c
@@ -240,7 +240,9 @@
vty_out(vty, " Peer '%s', Remote "OSMO_SOCKADDR_STR_FMT", State %s%s",
peer->name, OSMO_SOCKADDR_STR_FMT_ARGS(&peer->cfg.remote),
osmo_fsm_inst_state_name(peer->priv), VTY_NEWLINE);
- vty_out_rate_ctr_group(vty, " ", peer->iline->ctrs);
- vty_out_stat_item_group(vty, " ", peer->iline->stats);
+ if (peer->iline) {
+ vty_out_rate_ctr_group(vty, " ", peer->iline->ctrs);
+ vty_out_stat_item_group(vty, " ", peer->iline->stats);
+ }
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29726
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I594463591f2945a04ccd708f16788034cc1dfc57
Gerrit-Change-Number: 29726
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: newchange