October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-gbproxy[master]: gbproxy_vty: Add commands to list Cell/BVC of an NSE

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 ) Change subject: gbproxy_vty: Add commands to list Cell/BVC of an NSE ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I10c6d3f59681ec6dc98f1a3b023af446cc2a1c12 Gerrit-Change-Number: 29714 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 15:15:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: show full request reference in log

by fixeria

Attention is currently required from: pespin, lynxis lazus, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29703 ) Change subject: abis_rsl: show full request reference in log ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29703/comment/4b834292_99366257 PS1, Line 1915: LOG_BTS(bts, DRSL, LOGL_INFO, "CHAN RQD: reason: %s (ra=0x%02x, t1=%d, t3=%d, t2=%d, neci=0x%02x, chreq_reason=0x%02x)\n", > is there some reason to have t1 t2 t3 not in order? Ack. LOGL1S macro in osmo-bts.git prints t1, t2, and then t3. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I78499b49ae176b736e384e193fadc0bdd669dffa Gerrit-Change-Number: 29703 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 15:13:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-gbproxy[master]: Fix obsolete documentation of function

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29719 ) Change subject: Fix obsolete documentation of function ...................................................................... Fix obsolete documentation of function Change-Id: I9588b237f1ee2979fe4ac7c802f1ff6300573e0a --- M src/gb_proxy_peer.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/19/29719/1 diff --git a/src/gb_proxy_peer.c b/src/gb_proxy_peer.c index 1e300ad..e4cb49f 100644 --- a/src/gb_proxy_peer.c +++ b/src/gb_proxy_peer.c @@ -137,8 +137,7 @@ } /*! remove BVCs on NSE specified by NSEI. - * \param[in] cfg proxy in which we operate - * \param[in] nsei NS entity in which we should clean up + * \param[in] nse NS entity in which we should clean up * \param[in] bvci if 0: remove all PTP BVCs; if != 0: BVCI of the single BVC to clean up */ int gbproxy_cleanup_bvcs(struct gbproxy_nse *nse, uint16_t bvci) { -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I9588b237f1ee2979fe4ac7c802f1ff6300573e0a Gerrit-Change-Number: 29719 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy_vty: Add commands to list Cell/BVC of an NSE

by daniel

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 to look at the new patch set (#2). Change subject: gbproxy_vty: Add commands to list Cell/BVC of an NSE ...................................................................... gbproxy_vty: Add commands to list Cell/BVC of an NSE Change-Id: I10c6d3f59681ec6dc98f1a3b023af446cc2a1c12 --- M src/gb_proxy_vty.c 1 file changed, 53 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/14/29714/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I10c6d3f59681ec6dc98f1a3b023af446cc2a1c12 Gerrit-Change-Number: 29714 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy_vty: Add commands to list Cell/BVC of an NSE

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 ) Change subject: gbproxy_vty: Add commands to list Cell/BVC of an NSE ...................................................................... Patch Set 2: (4 comments) File src/gb_proxy_vty.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/70caa7bd_6f637b89 PS1, Line 549: if (!strcmp(argv[0], "bss")) { > you could simply store g_cfg->bss_nses or g_cfg->sgsn_nses in a pointer and use shared code below. I don't think that works with hashtable. DECLARE_HASHTABLE makes those: struct hlist_head X_nses[256]; hash_for_hash() uses ARRAY_SIZE, so it doesn't work on a struct hlist_head *nses: gb_proxy_vty.c: In function ‘show_gbproxy_bvc’: /home/daniel/local/osmo-master/include/osmocom/core/utils.h:19:34: warning: division ‘sizeof (struct hlist_head *) / sizeof (struct hlist_head)’ does not compute the number of array elements [-Wsizeof-pointer-div] 19 | #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) | ^ /home/daniel/local/osmo-master/include/osmocom/core/hashtable.h:19:26: note: in expansion of macro ‘ARRAY_SIZE’ 19 | #define HASH_SIZE(name) (ARRAY_SIZE(name)) | ^~~~~~~~~~ /home/daniel/local/osmo-master/include/osmocom/core/hashtable.h:101:60: note: in expansion of macro ‘HASH_SIZE’ 101 | for ((bkt) = 0, obj = NULL; obj == NULL && (bkt) < HASH_SIZE(name);\ | ^~~~~~~~~ gb_proxy_vty.c:529:9: note: in expansion of macro ‘hash_for_each’ 529 | hash_for_each(nses, i, nse, list) { | ^~~~~~~~~~~~~ gb_proxy_vty.c:516:28: note: first ‘sizeof’ operand was declared here 516 | struct hlist_head *nses; | ^~~~ https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/1e601b2b_a1301eca PS1, Line 550: hash_for_each(g_cfg->bss_nses, i, nse, list) > please add {} around hash_for_each Done https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/c2e5e3b8_be7b69e5 PS1, Line 554: hash_for_each(g_cfg->sgsn_nses, i, nse, list) > please add {} around hash_for_each Done https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/542920dc_a67ec229 PS1, Line 588: hash_for_each(g_cfg->cells, i, cell, list) > please add {} around hash_for_each Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I10c6d3f59681ec6dc98f1a3b023af446cc2a1c12 Gerrit-Change-Number: 29714 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 15:12:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-gbproxy[master]: Improve log levels

by daniel

Attention is currently required from: pespin, lynxis lazus. Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715 to look at the new patch set (#2). Change subject: Improve log levels ...................................................................... Improve log levels * Set log levels to LOGL_NOTICE by default * Set log message about pooling being disabled to debug Change-Id: Ieddf20a5eafaa9738d5d1e9a9aae320e48aa2efc --- M src/gb_proxy.c M src/gb_proxy_main.c 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/15/29715/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ieddf20a5eafaa9738d5d1e9a9aae320e48aa2efc Gerrit-Change-Number: 29715 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-gbproxy[master]: Improve log levels

by daniel

Attention is currently required from: pespin, lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715 ) Change subject: Improve log levels ...................................................................... Patch Set 2: (1 comment) File src/gb_proxy_main.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715/comment/4827acec_b05fce21 PS1, Line 241: .loglevel = LOGL_INFO, > we usually set NOTICE as default. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ieddf20a5eafaa9738d5d1e9a9aae320e48aa2efc Gerrit-Change-Number: 29715 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 12 Oct 2022 15:12:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: msc_a,vlr: add ciphering_required (accurately named)

by msuraev

Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29695 ) Change subject: msc_a,vlr: add ciphering_required (accurately named) ...................................................................... Patch Set 1: (1 comment) File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/29695/comment/704a92da_59e410d0 PS1, Line 1479: bool try_ciphering, Comment explaining the difference between try_ciphering and ciphering_required would be helpful: it's not obvious that it's explained in the commit message for one of those flags. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I52090c5f5db997030da7c2ed9beca9c51f55f4cf Gerrit-Change-Number: 29695 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 15:08:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: delete CHAN RQD from que when rach ind was sent

by msuraev

Attention is currently required from: fixeria, lynxis lazus, dexter. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29705 ) Change subject: abis_rsl: delete CHAN RQD from que when rach ind was sent ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/29705/comment/600c2b0b_1fda1941 PS1, Line 7: abis_rsl: delete CHAN RQD from que when rach ind was sent Did you mean queue? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia4abc55fc6fcb1c00991cc84d09529131d014910 Gerrit-Change-Number: 29705 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 15:01:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: Fix typo in log message

by msuraev

Attention is currently required from: pespin, keith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29718 ) Change subject: Fix typo in log message ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I29a290d1e8b6e237a74ac8fab8dd5e5e5db71796 Gerrit-Change-Number: 29718 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Wed, 12 Oct 2022 14:55:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022