October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: Fix typo in log message

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29718 ) Change subject: Fix typo in log message ...................................................................... Fix typo in log message Related: OS#5700 Change-Id: I29a290d1e8b6e237a74ac8fab8dd5e5e5db71796 --- M src/bts.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/18/29718/1 diff --git a/src/bts.cpp b/src/bts.cpp index 06948d8..e3a4349 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -694,7 +694,7 @@ dl_tbf = ms_dl_tbf(ms); if (!dl_tbf) { LOGP(DRLCMAC, LOGL_ERROR, "Got IMM.ASS confirm, but TLLI=%08x " - "does not exit\n", tlli); + "does not exist\n", tlli); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I29a290d1e8b6e237a74ac8fab8dd5e5e5db71796 Gerrit-Change-Number: 29718 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-gbproxy[master]: Improve log levels, documentation

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715 ) Change subject: Improve log levels, documentation ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: The documentation part can really go into another patch. File src/gb_proxy_main.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715/comment/d4ee9f1d_ccabeb9c PS1, Line 241: .loglevel = LOGL_INFO, we usually set NOTICE as default. -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ieddf20a5eafaa9738d5d1e9a9aae320e48aa2efc Gerrit-Change-Number: 29715 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 14:33:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy_vty: Add commands to list Cell/BVC of an NSE

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 ) Change subject: gbproxy_vty: Add commands to list Cell/BVC of an NSE ...................................................................... Patch Set 1: Code-Review+1 (4 comments) File src/gb_proxy_vty.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/dba53766_6faa1d2d PS1, Line 549: if (!strcmp(argv[0], "bss")) { you could simply store g_cfg->bss_nses or g_cfg->sgsn_nses in a pointer and use shared code below. https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/f51e1b09_b0cfd9ac PS1, Line 550: hash_for_each(g_cfg->bss_nses, i, nse, list) please add {} around hash_for_each https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/663ccfa6_f829ac7e PS1, Line 554: hash_for_each(g_cfg->sgsn_nses, i, nse, list) please add {} around hash_for_each https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/52c9319d_1e5bc1ab PS1, Line 588: hash_for_each(g_cfg->cells, i, cell, list) please add {} around hash_for_each -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I10c6d3f59681ec6dc98f1a3b023af446cc2a1c12 Gerrit-Change-Number: 29714 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 14:31:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy_vty: Add commands to list Cell/BVC of an NSE

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 ) Change subject: gbproxy_vty: Add commands to list Cell/BVC of an NSE ...................................................................... gbproxy_vty: Add commands to list Cell/BVC of an NSE Change-Id: I10c6d3f59681ec6dc98f1a3b023af446cc2a1c12 --- M src/gb_proxy_vty.c 1 file changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/14/29714/1 diff --git a/src/gb_proxy_vty.c b/src/gb_proxy_vty.c index 906beff..311401e 100644 --- a/src/gb_proxy_vty.c +++ b/src/gb_proxy_vty.c @@ -529,6 +529,35 @@ return CMD_SUCCESS; } +DEFUN(show_gbproxy_bvc_nsei, show_gbproxy_bvc_nsei_cmd, "show gbproxy bvc (bss|sgsn) nsei <0-65535> [stats]", + SHOW_STR GBPROXY_STR + "Show BSSGP Virtual Connections\n" + "Display BSS-side BVCs\n" + "Display SGSN-side BVCs\n" + "Limit display to cells from an NSE\n" + "NSEI to use\n" + "Show statistics\n") +{ + struct gbproxy_nse *nse; + bool show_stats = argc >= 3; + int i; + uint16_t nsei = atoi(argv[1]); + + if (show_stats) + vty_out_rate_ctr_group(vty, "", g_cfg->ctrg); + + if (!strcmp(argv[0], "bss")) { + hash_for_each(g_cfg->bss_nses, i, nse, list) + if (nse->nsei == nsei) + gbproxy_vty_print_nse(vty, nse, show_stats); + } else { + hash_for_each(g_cfg->sgsn_nses, i, nse, list) + if (nse->nsei == nsei) + gbproxy_vty_print_nse(vty, nse, show_stats); + } + return CMD_SUCCESS; +} + DEFUN(show_gbproxy_cell, show_gbproxy_cell_cmd, "show gbproxy cell [stats]", SHOW_STR GBPROXY_STR "Show GPRS Cell Information\n" @@ -544,6 +573,25 @@ return CMD_SUCCESS; } +DEFUN(show_gbproxy_cell_nsei, show_gbproxy_cell_nsei_cmd, "show gbproxy cell nsei <0-65535> [stats]", + SHOW_STR GBPROXY_STR + "Show GPRS Cell Information\n" + "Limit display to cells from an NSE\n" + "NSEI to use\n" + "Show statistics\n") +{ + struct gbproxy_cell *cell; + bool show_stats = argc >= 2; + int i; + uint16_t nsei = atoi(argv[0]); + + hash_for_each(g_cfg->cells, i, cell, list) + if (cell->bss_bvc->nse->nsei == nsei) + gbproxy_vty_print_cell(vty, cell, show_stats); + + return CMD_SUCCESS; +} + DEFUN(show_gbproxy_tlli_cache, show_gbproxy_tlli_cache_cmd, "show gbproxy tlli-cache", SHOW_STR GBPROXY_STR "Show TLLI cache entries\n") @@ -722,7 +770,9 @@ int gbproxy_vty_init(void) { install_element_ve(&show_gbproxy_bvc_cmd); + install_element_ve(&show_gbproxy_bvc_nsei_cmd); install_element_ve(&show_gbproxy_cell_cmd); + install_element_ve(&show_gbproxy_cell_nsei_cmd); install_element_ve(&show_gbproxy_tlli_cache_cmd); install_element_ve(&show_gbproxy_imsi_cache_cmd); install_element_ve(&show_nri_all_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I10c6d3f59681ec6dc98f1a3b023af446cc2a1c12 Gerrit-Change-Number: 29714 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-gbproxy[master]: Improve log levels, documentation

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715 ) Change subject: Improve log levels, documentation ...................................................................... Improve log levels, documentation * DGPRS should not set level to debug by default * Remove log message about pooling being disabled * Fix documentation of gbproxy_cleanup_bvcs() parameters Change-Id: Ieddf20a5eafaa9738d5d1e9a9aae320e48aa2efc --- M src/gb_proxy.c M src/gb_proxy_main.c M src/gb_proxy_peer.c 3 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/15/29715/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 488ef91..aa8ad8a 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -281,7 +281,7 @@ return NULL; } - LOGPSGSN(sgsn, LOGL_INFO, "Pooling disabled, using first available SGSN\n"); + LOGPSGSN(sgsn, LOGL_DEBUG, "Pooling disabled, using first available SGSN\n"); } else { /* Pooling is enabled, try to use the NRI for routing to an SGSN * See 3GPP TS 23.236 Ch. 5.3.2 */ diff --git a/src/gb_proxy_main.c b/src/gb_proxy_main.c index 1a4e951..80d6908 100644 --- a/src/gb_proxy_main.c +++ b/src/gb_proxy_main.c @@ -237,12 +237,14 @@ [DGPRS] = { .name = "DGPRS", .description = "GPRS Packet Service", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, + .loglevel = LOGL_INFO, }, [DOBJ] = { .name = "DOBJ", .description = "GbProxy object allocation/release", .enabled = 1, + .loglevel = LOGL_INFO, .color = "\033[38;5;121m" }, }; diff --git a/src/gb_proxy_peer.c b/src/gb_proxy_peer.c index 1e300ad..e4cb49f 100644 --- a/src/gb_proxy_peer.c +++ b/src/gb_proxy_peer.c @@ -137,8 +137,7 @@ } /*! remove BVCs on NSE specified by NSEI. - * \param[in] cfg proxy in which we operate - * \param[in] nsei NS entity in which we should clean up + * \param[in] nse NS entity in which we should clean up * \param[in] bvci if 0: remove all PTP BVCs; if != 0: BVCI of the single BVC to clean up */ int gbproxy_cleanup_bvcs(struct gbproxy_nse *nse, uint16_t bvci) { -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ieddf20a5eafaa9738d5d1e9a9aae320e48aa2efc Gerrit-Change-Number: 29715 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-verifications: add osmo-ci

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29689 ) Change subject: jobs/gerrit-verifications: add osmo-ci ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie6d8a99647846fb4008953b444bba642cbcf3b1e Gerrit-Change-Number: 29689 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 14:17:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: msc: test auth options, and fall-back to no-auth

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29692 ) Change subject: msc: test auth options, and fall-back to no-auth ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29692/comment/47afbf1d_91a4… PS2, Line 6875: kc_support := '01'O, did you think about using a template here to spare some lines? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8e3b02ca83e56ef5349d85f08407509e19fa353c Gerrit-Change-Number: 29692 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 14:14:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jenkins-gerrit: tweak notify setting

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29702 ) Change subject: jenkins-gerrit: tweak notify setting ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: That may be a bit problematic. For instance sometimes linter may fail and that's fine since we are simply moving code around, or importing code from somewhere else. If that's the case, I wouldn't receive an email as a non-owner so I'm not going to ever review it unless somebody pings me personally afaiu. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7c6c183b98624eb75d5dccd9766ee3ff5568b06e Gerrit-Change-Number: 29702 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 14:11:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: delete CHAN RQD from que when rach ind was sent

by pespin

Attention is currently required from: lynxis lazus, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29705 ) Change subject: abis_rsl: delete CHAN RQD from que when rach ind was sent ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia4abc55fc6fcb1c00991cc84d09529131d014910 Gerrit-Change-Number: 29705 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 14:09:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: when doing packet access, log t1,t3,t2 and fn

by pespin

Attention is currently required from: lynxis lazus, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29704 ) Change subject: abis_rsl: when doing packet access, log t1,t3,t2 and fn ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29704/comment/7c42911b_56a3598e PS1, Line 1822: LOG_BTS(rqd->bts, DRSL, LOGL_INFO, "CHAN RQD: fn(t1=%u,t3=%u,t2=%u) = %u\n", t1, t2, t3, fn); same, why not t1 t2 t3 in order? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I83d20ba9e0ce6488d458ccf4a85c8445c30e3a89 Gerrit-Change-Number: 29704 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 14:05:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022