October 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: msgb: introduce extended copy functions

by laforge

Attention is currently required from: pespin, fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29761 ) Change subject: msgb: introduce extended copy functions ...................................................................... Patch Set 3: (1 comment) File include/osmocom/core/msgb.h: https://gerrit.osmocom.org/c/libosmocore/+/29761/comment/616862f8_ba3a811c PS3, Line 73: extern struct msgb *msgb_copy_ext(const struct msgb *msg, uint16_t new_len, const char *name); > what about msgb_copy_resize()? looks more descriptive. agreeing with pespin. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I36d4c16241d19f0f73c325be4d0e0bdef6813615 Gerrit-Change-Number: 29761 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:11:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: msgb: expand copy test

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29760 ) Change subject: msgb: expand copy test ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I695c40e9350f608049111e81907fa6a5f48bb199 Gerrit-Change-Number: 29760 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:11:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29769 ) Change subject: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ieebc6e623874b4770ec7cd8b934244ffecaa089d Gerrit-Change-Number: 29769 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:10:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: stream: Introduce APIs osmo_stream_{cli,srv}_clear_tx_queue()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29776 ) Change subject: stream: Introduce APIs osmo_stream_{cli,srv}_clear_tx_queue() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iecb0a4bc281647673d2930d1f1586a2df231af52 Gerrit-Change-Number: 29776 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:10:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29769 ) Change subject: stream: Improve logging of SCTP_PEER_ADDR_CHANGE notification ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ieebc6e623874b4770ec7cd8b934244ffecaa089d Gerrit-Change-Number: 29769 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:10:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: cosmetic: stream: Fix parameter name

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29775 ) Change subject: cosmetic: stream: Fix parameter name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7e1e9902a39655e57e28d38a222bca850dd7de0e Gerrit-Change-Number: 29775 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:10:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libsmpp34[master]: cosmetic: make linter happy

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29770 ) Change subject: cosmetic: make linter happy ...................................................................... cosmetic: make linter happy * drop trailing space * remove FSF postal address from license header Change-Id: I772e6d7db38d830dfbee651bcd6e8ed24f07ca0b --- M src/smpp34.h 1 file changed, 37 insertions(+), 38 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/smpp34.h b/src/smpp34.h index b66d47f..29f3e01 100644 --- a/src/smpp34.h +++ b/src/smpp34.h @@ -1,23 +1,22 @@ -/* +/* * Copyright (C) 2006 Raul Tremsal * File : smpp34.h * Author: Raul Tremsal <ultraismo(a)yahoo.com> * * This file is part of libsmpp34 (c-open-smpp3.4 library). * - * The libsmpp34 library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation; either version 2.1 of the + * The libsmpp34 library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public License as + * published by the Free Software Foundation; either version 2.1 of the * License, or (at your option) any later version. * - * This library is distributed in the hope that it will be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY - * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public + * This library is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY + * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public * License for more details. * - * You should have received a copy of the GNU Lesser General Public License - * along with this library; if not, write to the Free Software Foundation, - * Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * You should have received a copy of the GNU Lesser General Public License + * along with this library; if not, see <http://www.gnu.org/licenses/>. * */ #ifndef _SMPP_H_ @@ -26,41 +25,41 @@ /* SMPP Version ***************************************************************/ #define SMPP_VERSION 0x34 /* Command Id *****************************************************************/ -#define GENERIC_NACK 0x80000000 -#define BIND_RECEIVER 0x00000001 -#define BIND_RECEIVER_RESP 0x80000001 -#define BIND_TRANSMITTER 0x00000002 -#define BIND_TRANSMITTER_RESP 0x80000002 -#define QUERY_SM 0x00000003 -#define QUERY_SM_RESP 0x80000003 -#define SUBMIT_SM 0x00000004 -#define SUBMIT_SM_RESP 0x80000004 -#define DELIVER_SM 0x00000005 -#define DELIVER_SM_RESP 0x80000005 -#define UNBIND 0x00000006 -#define UNBIND_RESP 0x80000006 -#define REPLACE_SM 0x00000007 -#define REPLACE_SM_RESP 0x80000007 -#define CANCEL_SM 0x00000008 -#define CANCEL_SM_RESP 0x80000008 -#define BIND_TRANSCEIVER 0x00000009 -#define BIND_TRANSCEIVER_RESP 0x80000009 +#define GENERIC_NACK 0x80000000 +#define BIND_RECEIVER 0x00000001 +#define BIND_RECEIVER_RESP 0x80000001 +#define BIND_TRANSMITTER 0x00000002 +#define BIND_TRANSMITTER_RESP 0x80000002 +#define QUERY_SM 0x00000003 +#define QUERY_SM_RESP 0x80000003 +#define SUBMIT_SM 0x00000004 +#define SUBMIT_SM_RESP 0x80000004 +#define DELIVER_SM 0x00000005 +#define DELIVER_SM_RESP 0x80000005 +#define UNBIND 0x00000006 +#define UNBIND_RESP 0x80000006 +#define REPLACE_SM 0x00000007 +#define REPLACE_SM_RESP 0x80000007 +#define CANCEL_SM 0x00000008 +#define CANCEL_SM_RESP 0x80000008 +#define BIND_TRANSCEIVER 0x00000009 +#define BIND_TRANSCEIVER_RESP 0x80000009 /* Reserved 0x0000000A 0x8000000A */ -#define OUTBIND 0x0000000B +#define OUTBIND 0x0000000B /* Reserved 0x0000000C - 0x00000014 0x8000000B - 0x80000014 */ -#define ENQUIRE_LINK 0x00000015 -#define ENQUIRE_LINK_RESP 0x80000015 +#define ENQUIRE_LINK 0x00000015 +#define ENQUIRE_LINK_RESP 0x80000015 /* Reserved 0x00000016 - 0x00000020 0x80000016 - 0x80000020*/ -#define SUBMIT_MULTI 0x00000021 -#define SUBMIT_MULTI_RESP 0x80000021 +#define SUBMIT_MULTI 0x00000021 +#define SUBMIT_MULTI_RESP 0x80000021 /* Reserved 0x00000022 - 0x000000FF 0x80000022 - 0x800000FF */ /* Reserved 0x00000100 */ -#define Reserved 0x80000100 +#define Reserved 0x80000100 /* Reserved 0x00000101 0x80000101 */ -#define ALERT_NOTIFICATION 0x00000102 +#define ALERT_NOTIFICATION 0x00000102 /* Reserved 0x80000102 */ -#define DATA_SM 0x00000103 -#define DATA_SM_RESP 0x80000103 +#define DATA_SM 0x00000103 +#define DATA_SM_RESP 0x80000103 /* Reserved for SMPP extension 0x00000104 - 0x0000FFFF 0x80000104 - 0x8000FFFF */ /* Reserved 0x00010000 - 0x000101FF 0x80010000 - 0x800101FF */ /* Reserved for SMSC Vendor 0x00010200 - 0x000102FF 0x80010200 - 0x800102FF */ -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I772e6d7db38d830dfbee651bcd6e8ed24f07ca0b Gerrit-Change-Number: 29770 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in libsmpp34[master]: Add #define for default SMPP port 2775

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29771 ) Change subject: Add #define for default SMPP port 2775 ...................................................................... Add #define for default SMPP port 2775 Change-Id: I2fcc15ac60b7b6501c9cb1afd0fe6d66d4b76f5f --- M src/smpp34.h 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/smpp34.h b/src/smpp34.h index 29f3e01..d8ab18b 100644 --- a/src/smpp34.h +++ b/src/smpp34.h @@ -24,6 +24,7 @@ /* SMPP Version ***************************************************************/ #define SMPP_VERSION 0x34 +#define SMPP_PORT 2775 /* Command Id *****************************************************************/ #define GENERIC_NACK 0x80000000 #define BIND_RECEIVER 0x00000001 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29771 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I2fcc15ac60b7b6501c9cb1afd0fe6d66d4b76f5f Gerrit-Change-Number: 29771 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in libsmpp34[master]: Add #define for default SMPP port 2775

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29771 ) Change subject: Add #define for default SMPP port 2775 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29771 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I2fcc15ac60b7b6501c9cb1afd0fe6d66d4b76f5f Gerrit-Change-Number: 29771 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:09:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libsmpp34[master]: cosmetic: make linter happy

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29770 ) Change subject: cosmetic: make linter happy ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I772e6d7db38d830dfbee651bcd6e8ed24f07ca0b Gerrit-Change-Number: 29770 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Oct 2022 12:09:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022